[issue3066] FD leak in urllib2

2008-08-29 Thread James Antill
James Antill <[EMAIL PROTECTED]> added the comment: So if I add a: class _WrapForRecv: def __init__(self, obj): self.__obj = obj def __getattr__(self, name): if name == "recv": name = "read" return getattr(self.__obj, name) ...and th

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2007-12-19 Thread James Antill
James Antill added the comment: I've applied the last patch I posted to recent RHEL and Fedora releases, and it doesn't seem to break anything ... and from what I could see it fixed the problem. __ Tracker <[EMAIL PROTECTED]> <http://bugs.p

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2007-10-22 Thread James Antill
James Antill added the comment: Not sure who Neal is, and this probably isn't a final upstream fix ... but it's what I've applied to Fedora's python. It's basically the same patch as before, but it keeps the original * tests instead of just replacing them with / te

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2007-09-19 Thread James Antill
James Antill added the comment: Guido: It's true that that len can be slightly bigger than x*y, the big thing is that it can't be smaller so we can malloc(len) and use upto x*y (which was my main focus). I first looked at any of this code today, but I didn't see any reason tha

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2007-09-19 Thread James Antill
James Antill added the comment: And now the obvious typo fix, *sigh*. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1179> __diff -rup Python-2.5-orig/Modules/imageop.c Python-2.5/Modules/imageop.c --- Pyt

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2007-09-19 Thread James Antill
Changes by James Antill: __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1179> __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mai

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

2007-09-19 Thread James Antill
James Antill added the comment: So I think this is all the places integer overflow checking is needed in imageop.c and rbgimgmodule.c. There might be checks here which can't be exploited anyway, and I haven't checked any other files yet. Feel free to comment. Ps. This is against