[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

2021-05-25 Thread George-Cristian Bîrzan
George-Cristian Bîrzan added the comment: I think the only thing I'd improve would be to mention that this issue is the one that introduced the bug, otherwise it looks a bit weird. -- ___ Python tracker <https://bugs.python.org/is

[issue36384] [security] CVE-2021-29921: ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

2021-05-25 Thread George-Cristian Bîrzan
George-Cristian Bîrzan added the comment: The timeline there is wrong. This issue's creation time isn't the disclosure time, it's when the bug was introduced. The disclosure was on 30th of May, when I emailed secur...@python.org and Christian Heimes commented here and made htt

[issue36384] ipaddress Should not reject IPv4 addresses with leading zeroes as ambiguously octal

2021-03-31 Thread George-Cristian Bîrzan
Change by George-Cristian Bîrzan : -- nosy: +gc2 ___ Python tracker <https://bugs.python.org/issue36384> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13922] argparse handling multiple "--" in args improperly

2012-08-21 Thread George-Cristian Bîrzan
George-Cristian Bîrzan added the comment: This patch introduced a regression. Before, parse_args would take a tuple as an argument, and in _get_values it was converted to a list via list comprehension, which meant it was working with tuples too. In the current version, that raises an

[issue12029] Catching virtual subclasses in except clauses

2012-05-12 Thread George-Cristian Bîrzan
George-Cristian Bîrzan added the comment: As promissed the patch. It doesn't break any tests, and it passes the ones I added. I have a pybench one as well, which even though trivial, does point to the fact that there is a degradation in performance, but not sure it's worth po

[issue12029] Catching virtual subclasses in except clauses

2012-05-11 Thread George-Cristian Bîrzan
George-Cristian Bîrzan added the comment: I have a patch, with tests, but no Internet on my computer so going out, will post it when I get back/my Internet comes back -- ___ Python tracker <http://bugs.python.org/issue12

[issue12029] Catching virtual subclasses in except clauses

2012-05-11 Thread George-Cristian Bîrzan
George-Cristian Bîrzan added the comment: I posted on python dev that this would slow exception checking considerably so that is a concern. As for possible bugs, this has been working in the 2 branch for a while now, so I don't think that is the biggest issue. As for possible use