[issue11513] chained exception/incorrect exception from tarfile.open on a non-existent file

2011-03-18 Thread Evan Dandrea
Changes by Evan Dandrea : Removed file: http://bugs.python.org/file21223/tarfile-fix-multiple-exception-on-enoent.patch ___ Python tracker <http://bugs.python.org/issue11

[issue11513] chained exception/incorrect exception from tarfile.open on a non-existent file

2011-03-18 Thread Evan Dandrea
Evan Dandrea added the comment: David, Thanks for the pointers. I've updated the patch hopefully adequately addressing your concerns. -- components: +Interpreter Core -Library (Lib) type: behavior -> Added file: http://bugs.python.org/file21277/tarfile-fix-multiple-exce

[issue11560] Expand test coverage in shutil

2011-03-15 Thread Evan Dandrea
New submission from Evan Dandrea : The attached patch increases the coverage in shutil. It makes the following changes: - Tests the code paths for file and directory copies across filesystems by mocking out rename. - Adds a test for shutil.copy. - Adds a test for shutil.copy2. - Tests

[issue11548] Passing format= to unpack_archive fails

2011-03-15 Thread Evan Dandrea
Changes by Evan Dandrea : Removed file: http://bugs.python.org/file21196/fix_unpack_with_format.patch ___ Python tracker <http://bugs.python.org/issue11548> ___ ___ Pytho

[issue11548] Passing format= to unpack_archive fails

2011-03-15 Thread Evan Dandrea
Changes by Evan Dandrea : Added file: http://bugs.python.org/file21228/fix_unpack_with_format.patch ___ Python tracker <http://bugs.python.org/issue11548> ___ ___ Pytho

[issue11513] Infinite recursion around raising an exception in tarfile

2011-03-15 Thread Evan Dandrea
Changes by Evan Dandrea : Removed file: http://bugs.python.org/file21222/tarfile-fix-multiple-exception-on-enoent.patch ___ Python tracker <http://bugs.python.org/issue11

[issue11513] Infinite recursion around raising an exception in tarfile

2011-03-15 Thread Evan Dandrea
Changes by Evan Dandrea : Added file: http://bugs.python.org/file21223/tarfile-fix-multiple-exception-on-enoent.patch ___ Python tracker <http://bugs.python.org/issue11

[issue11513] Infinite recursion around raising an exception in tarfile

2011-03-15 Thread Evan Dandrea
Evan Dandrea added the comment: *facepalm* Indeed, thanks for pointing that out and nice catch on the race condition. Attached is a patch to fix the issue as you've suggested, and adds a test case for it. -- keywords: +patch Added file: http://bugs.python.org/file21222/tarfil

[issue11503] Expand test coverage in posixpath

2011-03-15 Thread Evan Dandrea
Evan Dandrea added the comment: I haven't used addCleanup here, but have noted it for the future. In this case, using it would require adding another function to handle the reassignment, which I think is a bit more messy than the extra bit of indent

[issue11503] Expand test coverage in posixpath

2011-03-15 Thread Evan Dandrea
Evan Dandrea added the comment: I've looked at the sameopenfile code, and can see no reason why it would not work on Windows. I've asked Brian to verify this. -- ___ Python tracker <http://bugs.python.o

[issue11503] Expand test coverage in posixpath

2011-03-15 Thread Evan Dandrea
Evan Dandrea added the comment: Updated the patch to address Michael's concerns. -- Added file: http://bugs.python.org/file21221/test_posixpath_with_same_device.patch ___ Python tracker <http://bugs.python.org/is

[issue11548] Passing format= to unpack_archive fails

2011-03-14 Thread Evan Dandrea
New submission from Evan Dandrea : Passing the format keyword parameter to shutil.unpack_archive triggers an exception: Traceback (most recent call last): File "Lib/test/test_shutil.py", line 650, in test_unpack_archive unpack_archive(filename, tmpdir2, format=format) File &

[issue11513] Infinite recursion around raising an exception in tarfile

2011-03-14 Thread Evan Dandrea
New submission from Evan Dandrea : Using Python tip from Sunday, I noticed that tarfile does not elegantly handle ENOENT by raising a single exception: >>> tarfile.TarFile.gzopen('fdsfd', 'r') Traceback (most recent call last): File "/home/evan/hg/cpyt

[issue11503] Expand test coverage in posixpath

2011-03-14 Thread Evan Dandrea
Evan Dandrea added the comment: It's probably best to give the fake stats inode numbers, so if the code does fail to check the st_dev fields, it will fail the test. I've updated the patch with this. -- Added file: http://bugs.python.org

[issue11503] Expand test coverage in posixpath

2011-03-14 Thread Evan Dandrea
Evan Dandrea added the comment: Added an updated patch that includes testing whether ismount would succeed by faking path being on a different device from its parent. -- Added file: http://bugs.python.org/file21125/test_posixpath_with_same_device.patch

[issue11503] Expand test coverage in posixpath

2011-03-14 Thread Evan Dandrea
Evan Dandrea added the comment: Fixed a typo in the previous patch. -- Added file: http://bugs.python.org/file21124/test_posixpath.patch ___ Python tracker <http://bugs.python.org/issue11

[issue11503] Expand test coverage in posixpath

2011-03-14 Thread Evan Dandrea
Changes by Evan Dandrea : -- nosy: +michael.foord ___ Python tracker <http://bugs.python.org/issue11503> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11503] Expand test coverage in posixpath

2011-03-14 Thread Evan Dandrea
New submission from Evan Dandrea : I've expanded the coverage of the posixpath test. The following scenarios have been added: - lexists with a non-existent file. - ismount with binary data. - ismount with a directory that is not a mountpoint. - ismount with a non-existent file. - is