[issue1757072] Zipfile robustness

2008-02-04 Thread Chris Mellon
Chris Mellon added the comment: I agree that the zipfile is out of spec. Here are my arguments in favor of making the change anyway: Existing zip tools like 7zip, pkzip, and winzip handle these files "as expected" As far as I know, it won't break any valid zipfiles. Because th

[issue1518] Fast globals/builtins access (patch)

2007-11-29 Thread Chris Mellon
Chris Mellon added the comment: I may have had some old code in the build or something - I did a clean rebuild to look at some of the slowdowns and the fastglobals_test benchmarks are now even better than Neils. Pybench is still overall slower but it's mostly in float operations, which seem

[issue1518] Fast globals/builtins access (patch)

2007-11-29 Thread Chris Mellon
Chris Mellon added the comment: In funcobject.c:PyFunction_New, the declarations of op and __name__ need to be moved to the top of the function to compile in MSVC, and if accepted the fastglobals.c file needs to be added to PCBuild. In the test script, the use of import * generates syntax

[issue1502] itertools should grow chunkify

2007-11-26 Thread Chris Mellon
New submission from Chris Mellon: One of the most common requests in c.l.p and #python is a way to break an iterable up into some particular size chunks. For example, "abcdef" -> "ab", "cd", "ef". It's pretty easy to write one, but there are a f