Chris Calloway added the comment:
Format the martix of test reports.
--
Added file: http://bugs.python.org/file32964/reports.html
___
Python tracker
<http://bugs.python.org/issue15
Chris Calloway added the comment:
Formatted test directory layout.
--
Added file: http://bugs.python.org/file32963/layouts.html
___
Python tracker
<http://bugs.python.org/issue15
Chris Calloway added the comment:
Reformat the filecmp test report matrix.
--
Added file: http://bugs.python.org/file32962/test_filecmp_reports.rst
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29746/test_filecmp_reports.rst
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Pytho
Chris Calloway added the comment:
Reformat the filecmpdata directory layouts diagram.
--
Added file: http://bugs.python.org/file32961/test_filecmp_layouts.rst
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29745/test_filecmp_layouts.rst
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Pytho
Chris Calloway added the comment:
The promised comments have been added to the patch. The refactoring of the
pre-existing tests is not part of this patch. But I'm uploading this now as the
patch does fix the issue.
--
Added file: http://bugs.python.org/file32960/issue-15518-1.
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file30040/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
I'm uploading a new patch which gets rid of the temp_cwd calls as suggested in
the review. The patch is not complete in that the explanatory comments
suggested in the review and revising the pre-existing tests have not been
completed yet. However, I wa
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29758/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
I replaced issue-15518-1.patch. I believe it now addresses all the concerns
expressed thus far. If reviewed favorably, I will extend it to clean-up the
pre-existing tests to address the concerns noted about them, especially since
the filecmpdata directory
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29749/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
Fix calls to BaseReportTestCase methods in subclasses. Not an override so don't
need super().
--
Added file: http://bugs.python.org/file29749/issue-15518-1.patch
___
Python tracker
<http://bugs.py
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29747/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
The attached patch issue-15518-1.patch replaces previous patch proposals for
this issue.
The patch implements the suggestion to factor code common to report TestCase
classes into a common base class BaseReportTestCase. Apologies for not having
that in the
Chris Calloway added the comment:
The attached file test_filecmp_reports.rst documents the reports generated by
filecmp.dircmp test methods if the directory and file layouts in
test_filecmp_layouts.rst are followed to aid in review discussion of patch.
--
Added file: http
Chris Calloway added the comment:
The attached file test_filecmp_layouts.rst documents the directory and file
layouts for complete test coverage of filecmp.dircmp report methods to aid in
review discussion of patch.
--
Added file: http://bugs.python.org/file29745
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29682/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
Replaced patch to fix a few under-informative test messages.
--
Added file: http://bugs.python.org/file29682/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file29681/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Chris Calloway added the comment:
OK, I got to participate in my Python user group hack night this week where I
actually got to work on my projects instead of spending all night helping
newbies on their projects. I used the time to refactor all the previous patches
for this issue on which I
Changes by Chris Calloway :
Removed file: http://bugs.python.org/file26635/issue-15518-1.patch
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bug
Changes by Chris Calloway :
--
nosy: +cbc
___
Python tracker
<http://bugs.python.org/issue15351>
___
___
Python-bugs-list mailing list
Unsubscribe:
Chris Calloway added the comment:
Yes, that's why I opened it. Feel free to submit patches if you think I'm
moving too slowly.
--
___
Python tracker
<http://bugs.python.o
Chris Calloway added the comment:
I have a number of patches for this issue I have worked on during a few local
Python user group hack nights. I have not submitted them yet, however, as they
require some expository material here in order to illustrate how they address
Jerdonek's poin
Chris Calloway added the comment:
Well, really, the reason I'm deferring is to get the patch accepted, because it
seems kind of unacceptable for standard library modules not to have full test
coverage. So far, I don't see evidence that the issue has even been triaged. Of
the three
Chris Calloway added the comment:
> There are at least two ways you could deal with this. You could change the
> working directory to the temp directory in setUp() and change it back in
> tearDown(). This is a common pattern in the tests [...]
> Alternatively, you could s
Chris Calloway added the comment:
> Would it be possible to structure things so that you have tests like
> test_report(), test_report_partial_closure(), etc?
Yes, I would prefer that structure. I was just being consistent, as you said,
with the prevailing style of the existing tests.
Chris Calloway added the comment:
Thank you and the issue to add report method tests is issue 15518.
--
___
Python tracker
<http://bugs.python.org/issue15
Changes by Chris Calloway :
--
nosy: +cjerdonek
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue15518>
___
___
Python-bugs-list mai
New submission from Chris Calloway:
The filecmp module has no tests for the following methods of the dircmp class:
report()
report_partial_closure()
report_full_closure()
The attached patch provides those tests. This issue was suggested in issue
15454. Future plans for these tests are
Chris Calloway added the comment:
At the PyOhio sprints, I noticed this issue and found it interesting for low
hanging fruit. First I went to make tests for this enhancement, only to find
that report(), report_partial_closure(), and report_full_closure did not
already have tests.
In adding
Changes by Chris Calloway :
--
nosy: +cbc
___
Python tracker
<http://bugs.python.org/issue15454>
___
___
Python-bugs-list mailing list
Unsubscribe:
33 matches
Mail list logo
