[issue24790] Idle: improve stack viewer

2015-08-25 Thread Can İbanoğlu
Can İbanoğlu added the comment: First of all, sorry for the late reply. I did try the solution you have proposed which removes the need to click to expand the items under globals/locals but as I understand it, you have something more in mind for the whole stackviewer UI. Should I still submit

[issue24790] Idle: improve stack viewer

2015-08-19 Thread Can İbanoğlu
Can İbanoğlu added the comment: Come to think of it, maybe I should send both the second and third items in one patch? I could just call the GetSubList method if the VariablesTreeItem is being created for locals. Is that a bad approach to take? Sorry for the sheer number of questions

[issue24790] Idle: improve stack viewer

2015-08-19 Thread Can İbanoğlu
Can İbanoğlu added the comment: I have also prepared a patch for the second item but I don't know if I should regenerate the patch after you have committed the first patch so I'm sitting on it now. I also didn't update the ACKS and NEWS files, should I? Here's what I did

[issue24790] Idle: improve stack viewer

2015-08-19 Thread Can İbanoğlu
Can İbanoğlu added the comment: Alright, here goes my first patch. I just did what you have pointed out :) -- keywords: +patch Added file: http://bugs.python.org/file40213/issue24790.1.patch ___ Python tracker <http://bugs.python.org/issue24

[issue24790] Idle: improve stack viewer

2015-08-19 Thread Can İbanoğlu
Can İbanoğlu added the comment: Thank you very much for your thorough input, it is very much appreciated! Actually one of the first things that I tried was to return stack[1:] to remove the target but your suggestion is much better. I did try it and it does work and I will provide a patch as

[issue24790] Idle: improve stack viewer

2015-08-18 Thread Can İbanoğlu
Can İbanoğlu added the comment: Hello again, I have spent some time going over the code and how the PyShell brings all of this together and have formed some loose opinions on how to solve these issues but I wanted to get a much more informed opinion. I will provide a patch for the first one

[issue24790] Idle: improve stack viewer

2015-08-17 Thread Can İbanoğlu
Can İbanoğlu added the comment: It does indeed, thank you very much! I have signed the Contributor Agreement and will start working on this right away. -- ___ Python tracker <http://bugs.python.org/issue24

[issue24790] Idle: improve stack viewer

2015-08-17 Thread Can İbanoğlu
Can İbanoğlu added the comment: Hello, I'm very interested in tackling this issue but this will be my first contribution to Python and I'm quite nervous. I have gone over the developer guide and FAQ but I would appreciate if you could let me know if I should approach this in a c