[issue46376] PyMapping_Check returns 1 for list

Change by Ashley Anderson : -- nosy: +aganders3 ___ Python tracker <https://bugs.python.org/issue46376> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26688] unittest2 referenced in unittest.mock documentation

New submission from Ashley Anderson: I noticed a few references to `unittest2` in the documentation in the `unittest.mock` "getting started" section: https://docs.python.org/3.6/library/unittest.mock-examples.html#patch-decorators I am attaching a patch that just changes these o

[issue12006] strptime should implement %G, %V and %u directives

Changes by Ashley Anderson : Added file: http://bugs.python.org/file40660/issue12006_10_complete.patch ___ Python tracker <http://bugs.python.org/issue12006> ___ ___ Pytho

[issue12006] strptime should implement %G, %V and %u directives

Ashley Anderson added the comment: Thanks Alexander, but I think the latest patch is still mine. It seems strange to review my own patch. I'll do it if that's common, but since this will (hopefully, eventually) be my first accepted patch I would appreciate the feedback from anothe

[issue12006] strptime should implement %G, %V and %u directives

Ashley Anderson added the comment: Another *ping* for a patch review since it's been almost a month since the last one. -- ___ Python tracker <http://bugs.python.org/is

[issue12006] strptime should implement %G, %V and %u directives

Ashley Anderson added the comment: Haha, thanks Erik. It seems you know my tastes enough to not offer a chocolate-based reward. =) I was actually set to "ping" to request a patch review today, as it's been one month since my last submission. Please let me know if I need to up

[issue12006] strptime should implement %G, %V and %u directives

Ashley Anderson added the comment: Thanks for the review and the good suggestions. Hopefully this new patch is an improvement. I didn't know about the context manager for assertRaises - I was just following the format for another ValueError test a few lines above. The frozenset a

[issue12006] strptime should implement %G, %V and %u directives

Ashley Anderson added the comment: Here is an updated patch with implementation as outlined in msg247525. -- Added file: http://bugs.python.org/file40085/issue12006_7_complete.patch ___ Python tracker <http://bugs.python.org/issue12

[issue12006] strptime should implement %G, %V and %u directives

Ashley Anderson added the comment: Wow, I can't believe this issue is so old now! I'm motivated to finally come back and address the remaining issues to get this merged. Sorry for seemingly abandoning this; I'm embarrassed I didn't push to finish it earlier. It sounds like

[issue12006] strptime should implement %V or %u directive from libc

Ashley Anderson added the comment: Attaching a patch for the documentation just in time for the weekend! -- Added file: http://bugs.python.org/file22240/12006_doc.patch ___ Python tracker <http://bugs.python.org/issue12

[issue12006] strptime should implement %V or %u directive from libc

Ashley Anderson added the comment: I disagree, I think %G is necessary in strptime(). Take Monday, December 31, 2001 as an example. The ISO date is 2002 01 1. Now, given only the Gregorian year (2001) for this date, and the ISO week and weekday (01 1), there is an ambiguity with Monday

[issue12006] strptime should implement %V or %u directive from libc

Ashley Anderson added the comment: The example that triggered the issue in testing was January 1, 1905. The ISO date for this day is 1904 52 7. This is reported correctly if you use datetime.isocalendar() or datetime.strftime('%G'), but you get 1905 if you use datetime.strftime(&

[issue12006] strptime should implement %V or %u directive from libc

Ashley Anderson added the comment: When trying to add cases for %V and %u in the tests, I ran into an issue of year ambiguity. The problem comes when the ISO year does not match the Gregorian year for a given date. I think this should be fixed by implementing the %G directive (ISO year

[issue12006] strptime should implement %V or %u directive from libc

Ashley Anderson added the comment: Thanks everyone, please take your time if there are more pressing issues; I'll get to work on tests and documentation in the mean time. I agree that '_calc_julian_from_V' is a bit strange. I was mimicking a similar helper

[issue12006] strptime should implement %V or %u directive from libc

Changes by Ashley Anderson : Removed file: http://bugs.python.org/file22101/12006.patch ___ Python tracker <http://bugs.python.org/issue12006> ___ ___ Python-bugs-list m

[issue12006] strptime should implement %V or %u directive from libc

Ashley Anderson added the comment: OK, here is my second attempt. I think it functions as desired, but a code review may reveal flaws in my implementation. I'm sure there are associated tests and documentation to write, but I have basically no experience with that yet. If this looks lik

[issue12006] strptime should implement %V or %u directive from libc

Ashley Anderson added the comment: Thanks, I think I understand the original post now. Upon reading the docs and code, however, it seems this is possible using the %W and %w directives. Is the issue just to support the different letters (%V and %u) specifically, or that they are not quite

[issue12006] strptime should implement %V or %u directive from libc

Ashley Anderson added the comment: I've recently joined the python-mentors mailing list because I love Python and want to get involved. I found this bug in the list of "Easy issues" and thought I'd try my hand. Anyway, this is my first patch, so please forgive me if I am

[issue12006] strptime should implement %V or %u directive from libc

Changes by Ashley Anderson : -- nosy: +Ashley.Anderson ___ Python tracker <http://bugs.python.org/issue12006> ___ ___ Python-bugs-list mailing list Unsubscribe: