Andrew Vant added the comment:
On 9 Nov 2010 at 18:59, Antoine Pitrou wrote:
> I have committed the patch in r86365, and I've made usenetrc
> False by default in r86366. Thanks for contributing!
Woot. I thank you.
Regarding usenetrc, the NNTP.login and NNTP.starttls documentati
Andrew Vant added the comment:
On 6 Nov 2010 at 17:23, StevenJ wrote:
> As it stands, the nntplib can cause the cached capabilities to be
> refreshed at certain points automatically (as it should), but I think
> it should be possible for the caller of the method to also specify
>
Andrew Vant added the comment:
On 6 Nov 2010 at 11:48, Antoine Pitrou wrote:
> I would rename setreadermode to _setreadermode (there's no reason to
> make it public IMO). Also, I would not explicitly check "STARTTLS" in
> the capabilities. It the server doesn't
Andrew Vant added the comment:
Here's a second version of the previous patch taking into account the errors
Antoine noticed and some odds and ends from the other comments. Specifically:
Comments fixed and tabs (I think...I hope...) all removed.
Added explicit skip to test_nntplib
Andrew Vant added the comment:
On 2 Nov 2010 at 23:22, Antoine Pitrou wrote:
> I'm talking about the code under "if __name__ == '__main__'".
> Specifically the "-c" option for specifying an SSL context.
Now I feel silly. Partly because of the mista
Andrew Vant added the comment:
On 2 Nov 2010 at 17:05, Antoine Pitrou wrote:
> * the command-line option for the SSLContext won't work, since a
> context is a custom object, not a string; I would rework this part
> anyway, since I don't think separate options for the &quo
Andrew Vant added the comment:
Also, Julien: Thanks for mentioning the 563-discouraged thing. I added a note
about it to the new documentation before submitting.
--
___
Python tracker
<http://bugs.python.org/issue1
Andrew Vant added the comment:
At Antoine's suggestion I've written a new patch for this for 3.2, adding
support for both SSL on 563 and STARTTLS on a normal connection. A NNTP_SSL
class supports the former and a NNTP.starttls() method supports the latter. As
a side effect
