[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

Kyle Stanley added the comment: Clarification: "If I'm not mistaken doesn't mean that the `return -1` within ..." Should instead be: "If I'm not mistaken doesn't this mean that the `return -1` within ..." (I am really looking forward to moving issue over to GitHub at some point. It's nice

[issue38181] some trable with max when np.nan is in the first of a list

Karthikeyan Singaravelan added the comment: I think it's more about how np.nan eq is implemented and not a bug in Python. I find this answer to be a good explanation https://stackoverflow.com/a/47788524/2610955 -- nosy: +xtreak ___ Python tracker

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

Kyle Stanley added the comment: Upon further reading of the documentation and some experimentation, it would definitely not make sense to call `PyInterpreterState_Delete` here (since we're only closing the sub-interpreter in the current thread), so that's not the issue. I still have no idea

[issue38181] some trable with max when np.nan is in the first of a list

New submission from 薛定谔的喵 <1147945...@qq.com>: max([5.0,np.nan]) >>> 5.0 max([np.nan,5.0]) >>> nan -- components: Tests messages: 352513 nosy: 1147945...@qq.com priority: normal severity: normal status: open title: some trable with max when np.nan is in the first of a list versions:

[issue38168] Refleaks in setint() of mmapmodule.c

Change by Xiang Zhang : -- pull_requests: +15786 pull_request: https://github.com/python/cpython/pull/16176 ___ Python tracker ___ _

[issue38168] Refleaks in setint() of mmapmodule.c

miss-islington added the comment: New changeset e857fe624d985616f3e1a6e095a5db732e6b3efe by Miss Islington (bot) in branch '3.7': [3.7] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136) (GH-16175) https://github.com/python/cpython/commit/e857fe624d985616f3e1a6e095a5db7

[issue38168] Refleaks in setint() of mmapmodule.c

miss-islington added the comment: New changeset 322309efe658122cac340adf4995ce40fa0c2e74 by Miss Islington (bot) in branch '3.8': [3.8] bpo-38168: Fix a possbile refleak in setint() of mmapmodule.c (GH-16136) (GH-16174) https://github.com/python/cpython/commit/322309efe658122cac340adf4995ce4

[issue38168] Refleaks in setint() of mmapmodule.c

Change by miss-islington : -- pull_requests: +15785 pull_request: https://github.com/python/cpython/pull/16175 ___ Python tracker ___ __

[issue38168] Refleaks in setint() of mmapmodule.c

Change by miss-islington : -- pull_requests: +15784 pull_request: https://github.com/python/cpython/pull/16174 ___ Python tracker ___ __

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

Kyle Stanley added the comment: Clarification: In the above comment when I was referring to the commit made by Eric Snow, I meant to link to https://github.com/python/cpython/commit/7f8bfc9b9a8381ddb768421b5dd5cbd970266190. -- ___ Python tracker

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

Kyle Stanley added the comment: Note that I'm not particularly experienced with the c-api, I'm just trying to take a stab at understanding why the buildbot failure is occuring. -- ___ Python tracker ___

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

Kyle Stanley added the comment: Upon digging through Modules/_xxsubinterpretersmodule.c, I noticed that on line 2059, `PyInterpreterState_Delete(interp);` is commented out (https://github.com/python/cpython/blob/bf169915ecdd42329726104278eb723a7dda2736/Modules/_xxsubinterpretersmodule.c#L2059

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

Ned Deily added the comment: macOS 3.9, 3.8, 3.7 installers updated to 1.1.1d, macOS 2.7 installer updated to 1.0.2t. Leaving open for Windows installers updates. -- nosy: +benjamin.peterson versions: +Python 2.7 ___ Python tracker

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

Ned Deily added the comment: New changeset 8dd358caf0d3f300ee64799812a020fe0de53637 by Ned Deily in branch '2.7': bpo-38117: Updated OpenSSL to 1.0.2t in macOS installer for 2.7.x. (GH-16171) https://github.com/python/cpython/commit/8dd358caf0d3f300ee64799812a020fe0de53637 -- _

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

miss-islington added the comment: New changeset 346b7c928b82d9da8f6654391e9cfe55625dcfac by Miss Islington (bot) in branch '3.8': bpo-38117: Updated OpenSSL to 1.1.1d in macOS installer. (GH-16170) https://github.com/python/cpython/commit/346b7c928b82d9da8f6654391e9cfe55625dcfac --

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

miss-islington added the comment: New changeset 26c44b5144a51f452dd0693b0278ec69d6a954a1 by Miss Islington (bot) in branch '3.7': bpo-38117: Updated OpenSSL to 1.1.1d in macOS installer. (GH-16170) https://github.com/python/cpython/commit/26c44b5144a51f452dd0693b0278ec69d6a954a1 --

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

Change by miss-islington : -- pull_requests: +15783 pull_request: https://github.com/python/cpython/pull/16173 ___ Python tracker ___ __

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

Ned Deily added the comment: New changeset 24d1597e430498ebe2d3d18fba2cacb3957b494d by Ned Deily in branch 'master': bpo-38117: Updated OpenSSL to 1.1.1d in macOS installer. (GH-16170) https://github.com/python/cpython/commit/24d1597e430498ebe2d3d18fba2cacb3957b494d --

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

Change by miss-islington : -- pull_requests: +15782 pull_request: https://github.com/python/cpython/pull/16172 ___ Python tracker ___ __

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

Change by Ned Deily : -- pull_requests: +15781 pull_request: https://github.com/python/cpython/pull/16171 ___ Python tracker ___ ___

[issue32592] Drop support of Windows Vista and 7 in Python 3.9

Eryk Sun added the comment: Here are a couple more: * WSA_FLAG_NO_HANDLE_INHERIT is supported. Code related to `support_wsa_no_inherit` in Modules/socketmodule.c can be removed. * AddDllDirectory and RemoveDllDirectory are supported. os__add_dll_directory_impl and os__remove_dll_directory_i

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

Change by Ned Deily : -- pull_requests: +15780 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16170 ___ Python tracker ___

[issue20066] PyStructSequence_NewType() not setting proper heap allocation flag?

Joannah Nanjekye added the comment: As commented in issue15729, the Py_TPFLAGS_HEAPTYPE flag is now set in PyType_FromSpecWithBases() which is called by PyStructSequence_NewType(). I think this is no longer an issue. -- nosy: +nanjekyejoannah ___

[issue15729] PyStructSequence_NewType enhancement

Joannah Nanjekye added the comment: All enhancements specified in this issue have since been done. PyStructSequence_NewType() calls PyType_FromSpecWithBases() which sets the needed flags and even the qualname: PyObject * PyType_FromSpecWithBases(PyType_Spec *spec, PyObject *bases) { PyHe

[issue31956] Add start and stop parameters to the array.index()

Anders Lorentsen added the comment: I have actually managed to lost my local branch of this fix, though I assume I can just start another one, manually copy over the changes, somehow mark this current PR as cancelled, aborted, or in my option the best: "replaced/superseeded by: [new PR]". In

[issue37904] Suggested edit to Python Tutorial - Section 4

Change by Diego Barriga : -- keywords: +patch pull_requests: +15779 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16169 ___ Python tracker ___

[issue38180] Test pyexpat fails on Fedora 30

Diego Barriga added the comment: $ cat /etc/os-release NAME=Fedora VERSION="30 (Workstation Edition)" ID=fedora VERSION_ID=30 VERSION_CODENAME="" PLATFORM_ID="platform:f30" PRETTY_NAME="Fedora 30 (Workstation Edition)" ANSI_COLOR="0;34" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedo

[issue38180] Test pyexpat fails on Fedora 30

Change by Diego Barriga : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue38180] Test pyexpat fails on Fedora 30

New submission from Diego Barriga : $ ./python -m test -j8 test_pyexpat Run tests in parallel using 8 child processes 0:00:00 load avg: 0.66 [1/1/1] test_pyexpat failed test test_pyexpat failed -- Traceback (most recent call last): File "/home/umoqnier/develop/python-dev/cpython/Lib/test/test_

[issue38179] Test subprocess fails on Fedora 30: test_group and test_extra_groups

Diego Barriga added the comment: $ cat /etc/os-release NAME=Fedora VERSION="30 (Workstation Edition)" ID=fedora VERSION_ID=30 VERSION_CODENAME="" PLATFORM_ID="platform:f30" PRETTY_NAME="Fedora 30 (Workstation Edition)" ANSI_COLOR="0;34" LOGO=fedora-logo-icon CPE_NAME="cpe:/o:fedoraproject:fed

[issue38179] Test subprocess fails on Fedora 30: test_group and test_extra_groups

New submission from Diego Barriga : == ERROR: test_extra_groups (test.test_subprocess.POSIXProcessTestCase) -- Traceback (most recent call last): File "/home/

[issue38117] Update to OpenSSL 1.1.1d, 1.1.0l, 1.0.2t

Ned Deily added the comment: The Windows and macOS installers also need to by updated to the new versions. -- components: +Windows, macOS nosy: +lukasz.langa, ned.deily, paul.moore, ronaldoussoren, steve.dower, tim.golden, zach.ware priority: normal -> release blocker resolution: fixe

[issue38100] Spelling error in unittest.mock code

Change by Marco Antonio Ramirez Valdes : -- pull_requests: +15778 pull_request: https://github.com/python/cpython/pull/16168 ___ Python tracker ___

[issue38080] 2to3 urllib fixer: missing fix for urllib.getproxies

Change by Roberto Meza : -- keywords: +patch nosy: +robertpro nosy_count: 1.0 -> 2.0 pull_requests: +15776 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16167 ___ Python tracker ___

[issue37828] Fix default mock_name in unittest.mock.assert_called error message

Change by Abraham : -- keywords: +patch pull_requests: +15775 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16166 ___ Python tracker ___

[issue37904] Suggested edit to Python Tutorial - Section 4

Diego Barriga added the comment: I'm interest on this for my first contribution :D -- ___ Python tracker ___ ___ Python-bugs-list m

[issue35638] Introduce fixed point locale aware format type for floating point numbers

Raymond Hettinger added the comment: I had thought that use a locales were deemed an anti-pattern (not easy-to-use, not thread-safe, etc). -- nosy: +rhettinger ___ Python tracker ___

[issue35638] Introduce fixed point locale aware format type for floating point numbers

Change by Raymond Hettinger : -- versions: +Python 3.9 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue38100] Spelling error in unittest.mock code

Change by Maritza Esparza : -- pull_requests: +15774 pull_request: https://github.com/python/cpython/pull/16165 ___ Python tracker ___ _

[issue38100] Spelling error in unittest.mock code

Change by Roundup Robot : -- keywords: +patch pull_requests: +15773 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16164 ___ Python tracker ___ __

[issue37904] Suggested edit to Python Tutorial - Section 4

Change by Diego Barriga : -- nosy: +umoqnier ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Andrew Svetlov added the comment: Raymond, sorry if I was so quick in applying. The patch is very trivial and obvious. I am pretty sure that Yuri and Victor approve it. The PR doesn't fix a mistake, the code is still valid. But we all changed our mind what is the loop role, should it be explic

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

Andrew Svetlov added the comment: This fix cannot land on 3.6, the version is in security-fix only mode. -- versions: -Python 3.6 ___ Python tracker ___ _

[issue38019] asyncio subprocess AttributeError: 'NoneType' object has no attribute '_add_reader' / '_remove_reader'

Andrew Svetlov added the comment: Thanks. The correct fix is 'do nothing if stream._transport is None'. We have only two weeks before 3.8rc, thus I'll prepare a fix myself for the sake of fast merging. -- assignee: -> asvetlov ___ Python tracker

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Hrvoje Nikšić added the comment: Raymond, no problem; I guess I assumed that the authors are following the bug tracker (or have possibly moved on and are inactive). I also had reason to believe the change to be non-controversial, since it is in line with Yury's own recommendations, e.g. from

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Andrew Svetlov added the comment: Thanks Hrvoje! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue38013] AsyncGenerator breaks when not iterated fully with RuntimeError("can't send non-None value to a just-started coroutine")

Andrew Svetlov added the comment: I have a PR for the fix. Yuri preliminary agrees with the patch but he requested more time for careful review. I've added 'release blocker' priority to don't miss this bugfix for the next release. -- nosy: +lukasz.langa, ned.deily priority: normal -

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

miss-islington added the comment: New changeset 1cd6e926d30552056457820a682c1c361ee0f3ff by Miss Islington (bot) in branch '3.8': bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. (GH-16159) https://github.com/python/cpython/commit/1cd6e926d30552056457820a682c1c361ee0f3ff -

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Raymond Hettinger added the comment: Hrvoje, thanks for fixing this. Next time, please involve the people who originally wrote the code. They are both still active. If they made mistakes, it helps them to know about it. If they had a specific intent for the code example, it allows them to

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

miss-islington added the comment: New changeset 701c4886bb0e19ad5ed8c8f556f65ab8597841e7 by Miss Islington (bot) in branch '3.7': bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. (GH-16159) https://github.com/python/cpython/commit/701c4886bb0e19ad5ed8c8f556f65ab8597841e7 -

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Change by miss-islington : -- pull_requests: +15772 pull_request: https://github.com/python/cpython/pull/16162 ___ Python tracker ___ __

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Change by miss-islington : -- pull_requests: +15771 pull_request: https://github.com/python/cpython/pull/16161 ___ Python tracker ___ __

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

miss-islington added the comment: New changeset c717c73fa33a2f3591442059eaf6e7a673e2c725 by Miss Islington (bot) (Hrvoje Nikšić) in branch 'master': bpo-38178: Don't explicitly pass "loop" to EchoClientProtocol. (GH-16159) https://github.com/python/cpython/commit/c717c73fa33a2f3591442059eaf6e7

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset d6fdfc82dd307161caae938b7a6c85215bc1 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-37798: Prevent undefined behavior in direct calls to the C helper function. (GH-16149) (GH-16160) https://github.com/python/cpython/com

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Raymond Hettinger added the comment: The was added originally by Victor and Yuri in c7edff3 and 7c7605ff113 -- nosy: +rhettinger, vstinner ___ Python tracker ___ _

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Change by miss-islington : -- pull_requests: +15770 pull_request: https://github.com/python/cpython/pull/16160 ___ Python tracker ___ __

[issue37798] Add C fastpath for statistics.NormalDist.inv_cdf()

Raymond Hettinger added the comment: New changeset 6e27a0d77520bf2c4412e367496212510f81b983 by Raymond Hettinger in branch 'master': bpo-37798: Prevent undefined behavior in direct calls to the C helper function. (#16149) https://github.com/python/cpython/commit/6e27a0d77520bf2c4412e36749621

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

Change by Hrvoje Nikšić : -- keywords: +patch pull_requests: +15769 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16159 ___ Python tracker ___ ___

[issue38178] Remove explicit "loop" argument from EchoClientProtocol example

New submission from Hrvoje Nikšić : The EchoClientProtocol example receives a "loop" argument, which is not used at all in the TCP example, and is used to create a future in the UDP example. In modern asyncio code the explicit loop arguments are no longer used since the loop can always be obta

[issue27071] unittest.TestCase.assertCountEqual is a very misleading name

Thomas Grainger added the comment: I think assertPermutation (without the "is") would be the best name -- ___ Python tracker ___ __

[issue38176] test_threading leaked [1, 1, 1] references: test_threads_join

Change by Dino Viehland : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38176] test_threading leaked [1, 1, 1] references: test_threads_join

Change by Dino Viehland : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue38176] test_threading leaked [1, 1, 1] references: test_threads_join

Change by Dino Viehland : -- keywords: +patch pull_requests: +15768 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16158 ___ Python tracker ___ __

[issue38176] test_threading leaked [1, 1, 1] references: test_threads_join

Change by Dino Viehland : -- assignee: -> dino.viehland nosy: +dino.viehland ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue32592] Drop support of Windows Vista and 7 in Python 3.9

Eryk Sun added the comment: 3.9 can drop support for console pseudohandles in set_inheritable in Python/fileutils.c and Popen._filter_handle_list in Lib/subprocess.py. Also, _Py_write_impl in Python/fileutils.c can remove the 32767 byte limit for console files (and other character devices s

[issue27218] improve tracing performance with f_trace set to Py_None

Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15767 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16157 ___ Python tracker

[issue37635] Using constant for whence arg in seek()

Antoine Pitrou added the comment: > What do you think of the followup PR to make use of the SEEK_* constants > listed in the documentation? I think it would be useful to at least mention > them in the tutorial, or even make use of them directly in the examples. Yes, I think it would be good

[issue36274] http.client cannot send non-ASCII request lines

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue38177] test_tools: test.test_tools.test_unparse.UnparseTestCase: test_tools leaked [36, 36, 36] references

STINNER Victor added the comment: Oh, test_unparse.UnparseTestCase.test_nonlocal has been fixed. Maybe by: commit 0247e80f3c529900689425676342cb70ea31a13d Author: Eddie Elizondo Date: Sat Sep 14 09:38:17 2019 -0400 Fix leaks in Python-ast.c (#16127) But there are more leaks. vstinner

[issue38177] test_tools: test.test_tools.test_unparse.UnparseTestCase: test_tools leaked [36, 36, 36] references

New submission from STINNER Victor : https://buildbot.python.org/all/#/builders/189/builds/153 $ ./python -m test -R 3:3 test_tools -m test.test_tools.test_unparse.UnparseTestCase.test_nonlocal Run tests sequentially 0:00:00 load avg: 1.48 [1/1] test_tools beginning 6 repetitions 123456 ..

[issue38075] Make random module PEP-384 compatible

STINNER Victor added the comment: > bpo-38075: Port _randommodule.c to PEP-384 (GH-15798) It seems like this change introduced a reference leak: bpo-38176. -- nosy: +vstinner ___ Python tracker

[issue38176] test_threading leaked [1, 1, 1] references: test_threads_join

STINNER Victor added the comment: The regression seems to be introduced by: commit 04f0bbfbedf8d2bb69b012f853de6648b1a9f27f (HEAD, refs/bisect/bad) Author: Dino Viehland Date: Fri Sep 13 11:12:27 2019 +0100 bpo-38075: Port _randommodule.c to PEP-384 (GH-15798) - Migrate `Rando

[issue38176] test_threading leaked [1, 1, 1] references: test_threads_join

New submission from STINNER Victor : vstinner@apu$ ./python -m test -R 3:3 test_threading -m test.test_threading.SubinterpThreadingTests.test_threads_join Run tests sequentially 0:00:00 load avg: 1.11 [1/1] test_threading beginning 6 repetitions 123456 .. test_threading leaked [1, 1, 1] ref

[issue26360] Deadlock in thread.join on Python 2.7/macOS

Kirill Smelkov added the comment: > > Maybe issue38106 related. > > That looks plausible, but unfortunately I'm still able to reproduce the hang > with your PR (commit 9b135c02aa1edab4c99c915c43cd62d988f1f9c1, macOS 10.14.6). Thanks for feedback. Then hereby bug is probably deadlock of anothe

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

Steve Dower added the comment: I added another PR with the additional error codes listed by Eryk Sun. Theoretically we should be able to test most of them, but I haven't written those tests, and I'm not sure they'd prove enough to be worth the extra code. ntpath.realpath is a "best effort" f

[issue38081] Different behavior of os.path.realpath('nul') in 3.7 and 3.8

Change by Steve Dower : -- pull_requests: +15766 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16156 ___ Python tracker ___ __

[issue38166] ast identifies incorrect column for compound attribute lookups

Serhiy Storchaka added the comment: AST for expression a.b.c is Attribute( value=Attribute( value=Name( id='a', ctx=Load(), lineno=1, col_offset=0, end_lineno=1,

[issue35638] Introduce fixed point locale aware format type for floating point numbers

Change by Karl Ove Hufthammer : -- nosy: +huftis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue38166] ast identifies incorrect column for compound attribute lookups

Andrew Briand added the comment: It looks like the test suite (in particular test_ast) specifically checks for the behavior where the col_offset of c in a.b.c.d is 0. This seems strange to me though, does anyone know if this is intended? If not, I can patch it. -- nosy: +andrewbrian

[issue38175] Memory leak in comparison of sqlite.Row objects

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +15765 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16155 ___ Python tracker ___

[issue38175] Memory leak in comparison of sqlite.Row objects

New submission from Serhiy Storchaka : There is a memory leak in comparison of sqlite.Row objects when row descriptors are different. There were not tests for this case. Also, the code compares the result of PyObject_RichCompare() with Py_True and Py_False. It is better to avoid such code, be

[issue38155] Add __all__ to the datetime module

Dong-hee Na added the comment: @ta1hia My idea is that both tests should be added. @p-ganssle's test aims to check the attr is allowed or not. And your test aims to check attribute equalities of pure python module and c module. -- ___ Python track

[issue21023] PyTypeObject tp_name is char* instead of const char*

Serhiy Storchaka added the comment: It should not be an issue in 2014 as it was fixed in 2005. See af68c874a6803b4e90b616077a602c0593719a1d. -- nosy: +serhiy.storchaka resolution: -> out of date stage: -> resolved status: open -> closed ___ Pytho

[issue38158] PyType_Spec docs list non-existant field "doc"

Change by Stefan Behnel : -- keywords: -patch resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue38158] PyType_Spec docs list non-existant field "doc"

Stefan Behnel added the comment: New changeset b65be6cd3d9b6102227d27f4f35385f999a7dd7d by Stefan Behnel (Miss Islington (bot)) in branch '3.8': bpo-38158: Removing nonexistant member "doc" from PyType_Spec documentation (GH-16142) (GH-16154) https://github.com/python/cpython/commit/b65be6cd