[issue31003] IDLE: Add tests for help sources on configdialog general tab

2017-07-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: PR ready for test and review. -- nosy: +csabella, louielu ___ Python tracker ___ ___ Python-bugs-lis

[issue30616] Cannot use functional API to create enum with zero values

2017-07-25 Thread Dong-hee Na
Changes by Dong-hee Na : -- pull_requests: +2940 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue30841] A shadowing variable naming emitted for Python-ast.c

2017-07-25 Thread Yuan Chao Chou
Yuan Chao Chou added the comment: This can be repro by setting -Wshadow-compatible-local when using gcc to compile Python-ast.c. An example on my machine: ➜ cpython git:(69c0db5050) ✗ gcc-7 -Wshadow-compatible-local -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3

[issue31037] Results in section 4.4 break and continue

2017-07-25 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Pyth

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread Dong-hee Na
Changes by Dong-hee Na : -- pull_requests: +2939 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread Dong-hee Na
Changes by Dong-hee Na : -- pull_requests: +2938 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread Ned Deily
Ned Deily added the comment: New changeset a4e774f86224cd8c997deaa4e71312cf1a7b023c by Ned Deily (Dong-hee Na) in branch '3.3': [3.3] bpo-30119: fix ftplib.FTP.putline() to throw an error for a illegal command (#1214) (#2885) https://github.com/python/cpython/commit/a4e774f86224cd8c997deaa4e71

[issue30841] A shadowing variable naming emitted for Python-ast.c

2017-07-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: What actually omits warnings about this? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread Dong-hee Na
Changes by Dong-hee Na : -- pull_requests: +2937 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

2017-07-25 Thread Devin Jeanpierre
Devin Jeanpierre added the comment: I think they misspoke, it's normal with fuzzing to test against master. The current draft of the code runs this git pull before building/launching any tests: git clone --depth 1 https://github.com/python/cpython.git cpython Speaking of which, I forgot t

[issue1732367] Document the constants in the socket module

2017-07-25 Thread Ammar Askar
Ammar Askar added the comment: Gonna take this and its dependencies on, eta 2-4 days. -- nosy: +ammar2 ___ Python tracker ___ ___ Py

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread Dong-hee Na
Dong-hee Na added the comment: Okay, I will send backport today. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread Ned Deily
Ned Deily added the comment: Just FYI, if the backports to 3.5, 3.4, and 3.3 happen *really* fast, we *might* be able to get them into the current round of releases, if Larry approves for 3.5.4 final and 3.4.7 final. If the 3.3 backport doesn't happen soon, 3.3 will reach end of life without

[issue26657] Directory traversal with http.server and SimpleHTTPServer on windows

2017-07-25 Thread Ned Deily
Changes by Ned Deily : -- versions: +Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue26657] Directory traversal with http.server and SimpleHTTPServer on windows

2017-07-25 Thread Ned Deily
Ned Deily added the comment: New changeset 7b92f9fa47df754b50c64aac84cf1c09693571af by Ned Deily (Victor Stinner) in branch '3.3': bpo-26657: Fix Windows directory traversal vulnerability with http.server (#782) (#2860) https://github.com/python/cpython/commit/7b92f9fa47df754b50c64aac84cf1c096

[issue22928] HTTP header injection in urrlib2/urllib/httplib/http.client (CVE-2016-5699)

2017-07-25 Thread Ned Deily
Changes by Ned Deily : -- assignee: georg.brandl -> priority: release blocker -> resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker

[issue31040] mimetypes.add_type should complain when you give it an undotted ext

2017-07-25 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- assignee: -> docs@python components: +Documentation nosy: +docs@python versions: +Python 3.7 ___ Python tracker ___ _

[issue22928] HTTP header injection in urrlib2/urllib/httplib/http.client (CVE-2016-5699)

2017-07-25 Thread Ned Deily
Ned Deily added the comment: New changeset 8e88f6b5e2a35ee458c161aa3f2b7f1f17fb45d1 by Ned Deily (Serhiy Storchaka) in branch '3.3': [3.3] bpo-22928: Disabled HTTP header injections in http.client. (#2817) https://github.com/python/cpython/commit/8e88f6b5e2a35ee458c161aa3f2b7f1f17fb45d1 -

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2935 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset e42339d3a08a8fde3349722def85d7a8e49899be by Victor Stinner in branch '3.6': [3.6] bpo-30595: Fix multiprocessing.Queue.get(timeout) (#2027) (#2881) https://github.com/python/cpython/commit/e42339d3a08a8fde3349722def85d7a8e49899be -- ___

[issue28777] Add asyncio.Queue __aiter__, __anext__ methods

2017-07-25 Thread Guido van Rossum
Guido van Rossum added the comment: > > there's no way to end the loop on the producing side. > I might be missing something, but can't something similar be said of > queue.get()? That's my point, actually. If you are wrapping the Queue protocol with __aiter__/__anext__ the caller would expec

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: I closed bpo-29606 as a duplicate of this bug. -- superseder: urllib FTP protocol stream injection -> ___ Python tracker ___ __

[issue29606] urllib FTP protocol stream injection

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: Hum, bpo-30119 is really the same bug. So I closed this one as a duplicate of bpo-30119. -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> (ftplib) A remote attacker could possibly attack by containing

[issue27945] Various segfaults with dict

2017-07-25 Thread Ned Deily
Changes by Ned Deily : -- priority: release blocker -> resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ _

[issue27945] Various segfaults with dict

2017-07-25 Thread Ned Deily
Ned Deily added the comment: New changeset 8fbdab50fc8f2b71f19b54f3a0208cfbf2be7713 by Ned Deily (Serhiy Storchaka) in branch '3.3': [3.3] [3.5] bpo-27945: Fixed various segfaults with dict. (GH-1657) (GH-1678) (#2396) https://github.com/python/cpython/commit/8fbdab50fc8f2b71f19b54f3a0208cfbf2

[issue30845] [3.5] test_first_completed_some_already_completed() of test_concurrent_futures.ProcessPoolWaitTests: time.sleep() fails with "sleep length must be non-negative" in setUp() on x86 Tiger 3.

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset a6f045224a03f9b5f940c80ee142a2a4b4a9c9d8 by Victor Stinner in branch '3.6': bpo-30845: Enhance test_concurrent_futures cleanup (#2564) (#2880) https://github.com/python/cpython/commit/a6f045224a03f9b5f940c80ee142a2a4b4a9c9d8 --

[issue31042] Inconsistency in documentation of operator.index

2017-07-25 Thread Joseph Fox-Rabinovitz
New submission from Joseph Fox-Rabinovitz: The docs for [`operator.index`][1] and `operator.__index__` state that > Return *a* converted to an integer. Equivalent to `a.__index__()`. The first sentence is correct, but the second is not. First of all, we have the data model [docs][2]: > For cu

[issue31042] Inconsistency in documentation of operator.index

2017-07-25 Thread Joseph Fox-Rabinovitz
Changes by Joseph Fox-Rabinovitz : -- type: behavior -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue20657] OpenBSD: Merge patches

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: I'm sorry but there is no more OpenBSD buildbot. I have no more OpenBSD VM. I just close this old issue :-( -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker

[issue25287] test_crypt fails on OpenBSD

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: There is no more OpenBSD buildbot. I have no OpenBSD VM. I just close this old issue. -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker

[issue26642] Replace stdout and stderr with simple standard printers at Python exit

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: I'm not sure that it's correct to replace sys.stdout with a simple object which can use a different encoding. I prefer to just close this old issue (idea). -- resolution: -> out of date stage: -> resolved status: open -> closed __

[issue29972] Skip tests known to fail on AIX

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: The issue title is very generic. I skipped some tests. I may reopen a new issue if I see other tests that can be skipped on AIX. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: Ok, now test_multiprocessing_spawn should not "leak" processes nor threads anymore. I fixed Python 3.6 and master. I close the issue. I don't think that it's worth it to fix tests in 2.7, and 3.5 is entering security-only mode. Note: I will backport bpo-31019

[issue30500] [security] urllib connects to a wrong host

2017-07-25 Thread Ned Deily
Changes by Ned Deily : -- assignee: -> haypo resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2934 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset d0adfb25c5082046133a18fd185375508c1c334f by Victor Stinner in branch '3.6': [3.6] bpo-26762, bpo-31019: Backport multiprocessing fixes from master to 3.6 (#2879) https://github.com/python/cpython/commit/d0adfb25c5082046133a18fd185375508c1c334f

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset d0adfb25c5082046133a18fd185375508c1c334f by Victor Stinner in branch '3.6': [3.6] bpo-26762, bpo-31019: Backport multiprocessing fixes from master to 3.6 (#2879) https://github.com/python/cpython/commit/d0adfb25c5082046133a18fd185375508c1c334f

[issue30595] test_queue_feeder_donot_stop_onexc() of test_multiprocessing_spawn fails randomly on x86 Windows7 3.x

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2933 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30713] Reject newline character (U+000A) in URLs in urllib.parse

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: https://bugs.python.org/issue29606 was fixed in ftplib. urllib is not the right place to reject invalid inputs. -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker

[issue30500] [security] urllib connects to a wrong host

2017-07-25 Thread Ned Deily
Ned Deily added the comment: New changeset 052f9d6860c48c5abcff8e16212e77cf4249d66c by Ned Deily (Victor Stinner) in branch '3.3': [3.3] bpo-30500: urllib: Simplify splithost by calling into urlparse. (#1849) (#2292) https://github.com/python/cpython/commit/052f9d6860c48c5abcff8e16212e77cf4249

[issue30845] [3.5] test_first_completed_some_already_completed() of test_concurrent_futures.ProcessPoolWaitTests: time.sleep() fails with "sleep length must be non-negative" in setUp() on x86 Tiger 3.

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2932 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue17560] problem using multiprocessing with really big objects?

2017-07-25 Thread Daniel Liu
Daniel Liu added the comment: There's also the other multiprocessing limitation Antoine mentioned early on, where queues/pipes used a 32-bit signed integer to encode object length. Is there a way or plan to get around this limitation? -- nosy: +Daniel Liu _

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: With Python 3.5.4rc1 released (3.5.4 will be the last 3.5 release accepting bug fixes), I'm not sure that it's still worth it to try to backport such changes to Python 3.5. The importlib is very important, any regression can be very important. I'm not sure th

[issue26762] test_multiprocessing_spawn leaves processes running in background

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2930 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2931 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

2017-07-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: As I read 583, they are planning to fuzz 3.6. Why not branch master? I think it more likely that we accidentally add a vulnerability to master then that we accidentally close one. -- ___ Python tracker

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: What about rejecting also NUL byte? -- status: pending -> open ___ Python tracker ___ ___ Python-bug

[issue1732367] Document the constants in the socket module

2017-07-25 Thread Ned Deily
Changes by Ned Deily : -- assignee: georg.brandl -> versions: +Python 3.7 -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list m

[issue23404] 'make touch' does not work with git clones of the source repository

2017-07-25 Thread Ned Deily
Ned Deily added the comment: There still might be time to get this into 3.5.4 final, if Larry agrees. -- ___ Python tracker ___ ___ Py

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread Ned Deily
Changes by Ned Deily : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue30119] (ftplib) A remote attacker could possibly attack by containing the newline characters

2017-07-25 Thread Ned Deily
Changes by Ned Deily : -- nosy: +haypo status: pending -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31041] test_handle_called_with_mp_queue() of test_logging: threading_cleanup() failed to cleanup, on AMD64 FreeBSD 10.x Shared 3.x

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- title: test_handle_called_with_mp_queue() of test_logging: threading_cleanup() failed to cleanup -> test_handle_called_with_mp_queue() of test_logging: threading_cleanup() failed to cleanup, on AMD64 FreeBSD 10.x Shared 3.x __

[issue31041] test_handle_called_with_mp_queue() of test_logging: threading_cleanup() failed to cleanup

2017-07-25 Thread STINNER Victor
New submission from STINNER Victor: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/625/steps/test/logs/stdio (...) test_output (test.test_logging.UnixSocketHandlerTest) ... ok test_output (test.test_logging.UnixDatagramHandlerTest) ... ok test_output (test.t

[issue31034] test_subprocess_send_signal() of test_asyncio hangs if SIGHUP is ignored

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: Ok, I fixed Python 3.6 and master (future 3.7). Python 3.5 is slowly entering security-only fixes. I don't think that this corner case is improtant enough to justify a backport. -- ___ Python tracker

[issue31034] test_subprocess_send_signal() of test_asyncio hangs if SIGHUP is ignored

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs

[issue31034] test_subprocess_send_signal() of test_asyncio hangs if SIGHUP is ignored

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset efe9fcbd2ca85ba9d6af6d95cc530a9c332f37c5 by Victor Stinner in branch '3.6': bpo-31034: Reliable signal handler for test_asyncio (#2867) (#2876) https://github.com/python/cpython/commit/efe9fcbd2ca85ba9d6af6d95cc530a9c332f37c5 -- ___

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset 2db64823c20538a6cfc6033661fab5711d2d4585 by Victor Stinner in branch 'master': bpo-31019: Fix multiprocessing.Process.is_alive() (#2875) https://github.com/python/cpython/commit/2db64823c20538a6cfc6033661fab5711d2d4585 -- __

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

2017-07-25 Thread Devin Jeanpierre
Changes by Devin Jeanpierre : -- pull_requests: +2929 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30778] test_bsddb3 crash on x86 Windows XP 2.7

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2928 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30778] test_bsddb3 crash on x86 Windows XP 2.7

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: I opened a thread on python-dev and it was decided to skip test_bsddb3 on Windows XP: https://mail.python.org/pipermail/python-dev/2017-July/148745.html -- ___ Python tracker

[issue30885] test_subprocess hangs on AMD64 Windows8.1 Refleaks 3.x

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: test_subprocess passed on the last builds 56 (Jul 20) and 57 (Jul 25). -- ___ Python tracker ___ ___

[issue30908] test_os.TestSendfile.test_keywords() leaks dangling threads

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 ___ Python tracker ___ _

[issue26732] multiprocessing sentinel resource leak

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: Antoine: Do you want to backport your change 896145d9d266ee2758cfcd7691238cbc1f9e1ab8 to Python 3.6? If yes, don't forget to include my fix 302bbbe9ba5c72559913e2ea006c921f698a729d for Windows (bpo-31009). If you prefer, I can handle the backport. --

[issue31009] test_multiprocessing_spawn hangs randomly on AMD64 Windows10 3.x and AMD64 Windows8 3.x

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: Windows buildbots are green again, I close the issue. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31034] test_subprocess_send_signal() of test_asyncio hangs if SIGHUP is ignored

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: Patch to test manually the fix: diff --git a/Lib/test/test_asyncio/__init__.py b/Lib/test/test_asyncio/__init__.py index 80a9eea..1418952 100644 --- a/Lib/test/test_asyncio/__init__.py +++ b/Lib/test/test_asyncio/__init__.py @@ -1,3 +1,4 @@ +import signal; sign

[issue31034] test_subprocess_send_signal() of test_asyncio hangs if SIGHUP is ignored

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2927 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30985] Set closing variable in asyncore at close

2017-07-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: I would probably feel safer to use "__closed" for all python versions and adopt the same naming convention for any attribute we may want to add in the future. Kinda weird, but asyncore is probably the only case of deprecated module with bad API design which

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: Hum, I don't think that https://github.com/python/cpython/pull/2849 fixes the root issue. The root issue is that calling Process.is_alive() doesn't update the _children list if the process completes. I wrote a fix for that: https://github.com/python/cpython/pu

[issue31019] multiprocessing.Pool should join "dead" processes

2017-07-25 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +2926 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Larry Hastings
Larry Hastings added the comment: What you're missing is that Misc/NEWS.d is removed from tarballs. We ship Misc/NEWS in tarballs but *not* Misc/NEWS.d. If you start with a CPython tarball (e.g. 3.5.4rc1), and then apply vendor-specific patches on top of that, and those patches include news e

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Ned Deily
Ned Deily added the comment: > I expect that in a tarball, Misc/NEWS and Misc/NEWS.d contain exactly the > same entries. They don't. See for yourself :) https://www.python.org/ftp/python/3.5.4/Python-3.5.4rc1.tgz -- ___ Python tracker

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: If we provide a prebuilt Misc/NEWS in tarball, if Makefile doesn't need blurb if Misc/NEWS already exists, doko's issue is fixed: Debian package builder will not need blurb anymore (PR 2874). > If the upstream patches are extracted from GitHub PRs, then they'

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Ned Deily
Ned Deily added the comment: I just pushed PR 2874 (for 3.5) for review. I think it will solve the tarball problem. Review comments welcome. I'm still thinking about how to make blurb more easily "discoverable". That would be a separate PR. -- _

[issue30985] Set closing variable in asyncore at close

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: It seems like the closing attribute is not *required* to fix bpo-30931, asyncore race condition: http://bugs.python.org/issue30931#msg299162 Another approach doesn't rely on close() "implementation", but more on close() "expected behaviour" (remove the dispatc

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Ned Deily
Changes by Ned Deily : -- pull_requests: +2925 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: > There's an alternative fix which follows a similar approach to the one you > mention: https://github.com/python/cpython/pull/2707/. Sorry, I'm slow to understand. Now that the bug and expected behaviour is better explained, I can now review correctly your PR

[issue25910] Fixing links in documentation

2017-07-25 Thread Mariatta Wijaya
Changes by Mariatta Wijaya : -- pull_requests: +2924 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Larry Hastings
Larry Hastings added the comment: I guess it depends on what the upstream patches look like. If they're always coded against release tarballs and not against git repos, then they'll assume (correctly) that Misc/NEWS exists. In that case you shouldn't have to do anything. If the upstream pat

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-25 Thread Jaume
Jaume added the comment: There's an alternative fix which follows a similar approach to the one you mention: https://github.com/python/cpython/pull/2707/. I personally don't like too much to reuse again again an old variable as it's true that we don't know how people are using it (although I t

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Ned Deily
Ned Deily added the comment: (Of course the above also applies to installed copies of Misc/NEWS, like Debian's /usr/share/doc/pythonx.x/NEWS.gz. The vanilla main Python Makefile doesn't install NEWS.) -- ___ Python tracker

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Ned Deily
Ned Deily added the comment: The good news is that the released tarballs starting now and going forward will already have a generated Misc/NEWS just like they always have had. So blurb is not needed if you are building docs from such tarballs (like 3.5.4rc1). We did forget about building doc

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Larry Hastings
Larry Hastings added the comment: > Sorry to say, but the assumption that pip should be used to be able to build > core python seems to be the wrong direction. I'm not sure I understand your position. External tools are only permissible if Debian packages exist for them? And, it's not "core

[issue30853] IDLE: configdialog -- factor out Tracer subclass

2017-07-25 Thread Cheryl Sabella
Changes by Cheryl Sabella : -- pull_requests: +2923 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: If I understood correctly, to fix this race condition, there are two main constraints: (A) We must call handlers of dispatcher registered before calling select()/poll(): dispatchers can be closed and their file descriptor can be reused while we execute other

[issue26732] multiprocessing sentinel resource leak

2017-07-25 Thread Kevin Quick
Kevin Quick added the comment: Thank you for the fix, pitrou! Regarding your comment regarding the behavior being expected with the "fork" method, I would suggest a documentation modification in the description of the fork method to add something to the effect of "All resources of the parent a

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: I'm not sure that it's a good idea to compare asyncore and asyncio. While their name are similar, their design are *very* different. I'm only talking about the kernel, the core event loop checking for file descriptors. In asyncio, when you close a transport, t

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Matthias Klose
Matthias Klose added the comment: > so why didn't blurb get installed for doko? it's not packaged, and I'm (and I think any other provider of distro packages) not using network access during the build. Sorry to say, but the assumption that pip should be used to be able to build core python se

[issue30985] Set closing variable in asyncore at close

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: "Giampaolo, people using only 3.7 should probably use asyncio. Fixing asyncore is more important to those that can use only 2.7 (e.g.Centos/RHEL) or have to support both python 3 and 2." IMHO starting to use closing in asyncore *is* a backward incompatible chan

[issue30985] Set closing variable in asyncore at close

2017-07-25 Thread Guido van Rossum
Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue27099] IDLE: turn builting extensions into regular modules

2017-07-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: There is a reason that I said, in msg266221, that I would experiment with moving 1 feature ;-). I knew from past experience that changing anything that affected user configuration would have to consider the effect on previous releases. A total 'clean break' n

[issue30302] Improve .__repr__ implementation for datetime.timedelta

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: Do you think that repr(datetime.timedelta) should be documented in the Porting section of What's New in Python 3.7? https://docs.python.org/dev/whatsnew/3.7.html#porting-to-python-3-7 It was proposed in the middle of the python-dev thread. I have no opinion on

[issue30985] Set closing variable in asyncore at close

2017-07-25 Thread Nir Soffer
Nir Soffer added the comment: Giampaolo, people using only 3.7 should probably use asyncio. Fixing asyncore is more important to those that can use only 2.7 (e.g.Centos/RHEL) or have to support both python 3 and 2. Do you think using _closed is safer for backport? This can also clash with existi

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-25 Thread Nir Soffer
Nir Soffer added the comment: > I use the same trick all over the place in pyftpdlib: > https://github.com/giampaolo/pyftpdlib/blob/1268bb185cd63c657d78bc33309041628e62360a/pyftpdlib/handlers.py#L537 This allow detection of closed sockets, but does not fix the issue of accessing the wrong dispat

[issue30302] Improve .__repr__ implementation for datetime.timedelta

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset cc5a65cd9025280ea67ef4bbc2a8bfe31ced6c30 by Victor Stinner (Utkarsh Upadhyay) in branch 'master': bpo-30302 Make timedelta.__repr__ more informative. (#1493) https://github.com/python/cpython/commit/cc5a65cd9025280ea67ef4bbc2a8bfe31ced6c30 -

[issue30302] Improve .__repr__ implementation for datetime.timedelta

2017-07-25 Thread STINNER Victor
STINNER Victor added the comment: This issue has a long history starting in 2015 with a thread on python-dev. Many messages were written on python-dev and on this issue. I will try to summarize. (I hate doing that, summarizing is a risk of missing important information or misunderstand someone

[issue30985] Set closing variable in asyncore at close

2017-07-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: On the other hand, due to the poor asyncore API, I think it's safer if we land this in 3.7 only. "closing" attribute was never documented so if there's code out there setting it to True that'll crash their app pretty quickly as sockets won't close. ---

[issue30304] TestCase.assertMultiLineEqual only registered for Unicode strings in 2.7

2017-07-25 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30985] Set closing variable in asyncore at close

2017-07-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: I welcome this change as it avoids tricks like this one: https://github.com/giampaolo/pyftpdlib/blob/1268bb185cd63c657d78bc33309041628e62360a/pyftpdlib/handlers.py#L537 Any app using asyncore for anything other than an echo server eventually ends up doing th

[issue30931] Race condition in asyncore may access the wrong dispatcher

2017-07-25 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: > Yes, this is a typical issue in asyncore if you don't protect your > subclass to handle double close. I use the same trick all over the place in pyftpdlib: https://github.com/giampaolo/pyftpdlib/blob/1268bb185cd63c657d78bc33309041628e62360a/pyftpdlib/handle

[issue31036] building the python docs requires the blurb module

2017-07-25 Thread Ned Deily
Ned Deily added the comment: Working on it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

  1   2   3   >