[issue24845] IDLE functional/integration testing

Terry J. Reedy added the comment: I have accepted what I think is the core idea -- testing functional pathways starting with user actions instead or in addition to pure unit tests. For instance, test_configdialog.GeneralTest (newly revised in PR 2612) invokes buttons and inserts entries. Th

[issue29854] Segfault when readline history is more then 2 * history size

Changes by Berker Peksag : -- stage: patch review -> backport needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue29854] Segfault when readline history is more then 2 * history size

Berker Peksag added the comment: New changeset fae8f4a9cb88a68eb14750cbb8ddf8740fd67b8b by Berker Peksag (Nir Soffer) in branch 'master': bpo-29854: Fix segfault in call_readline() (GH-728) https://github.com/python/cpython/commit/fae8f4a9cb88a68eb14750cbb8ddf8740fd67b8b -- nosy: +ber

[issue30694] Update embedded copy of expat to 2.2.1

Ned Deily added the comment: See bpo-30797 for compile warning introduced here. -- assignee: -> haypo ___ Python tracker ___ ___ Pyth

[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

Ned Deily added the comment: Thanks for the report. This warning is currently visible on many/all of the buildbots on all branches. The conflict is caused by the upgrade of the bundled to libexpat to version 2.2.1 (bpo-30694). 2.2.1 introduced a define of _GNU_SOURCE into Modules/expat/xmlpa

[issue30694] Update embedded copy of expat to 2.2.1

Ned Deily added the comment: New changeset 05b72ede95521b2d897cb4c7b034139b5437c592 by Ned Deily in branch '3.6': bpo-30797, bpo-30694: Avoid _GNU_SOURCE redefined warning in xmlparse.c (#2615) https://github.com/python/cpython/commit/05b72ede95521b2d897cb4c7b034139b5437c592 -- _

[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

Ned Deily added the comment: New changeset 05b72ede95521b2d897cb4c7b034139b5437c592 by Ned Deily in branch '3.6': bpo-30797, bpo-30694: Avoid _GNU_SOURCE redefined warning in xmlparse.c (#2615) https://github.com/python/cpython/commit/05b72ede95521b2d897cb4c7b034139b5437c592 -- nosy:

[issue30797] ./pyconfig.h:1438:0: warning: "_GNU_SOURCE" redefined [enabled by default]

Changes by Ned Deily : -- pull_requests: +2680 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30694] Update embedded copy of expat to 2.2.1

Changes by Ned Deily : -- pull_requests: +2681 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30869] regrtest: Add .idlerc to saved_test_environment

Terry J. Reedy added the comment: I would have liked the mistake in #30780 to have been noticed, but I don't think the patch would have caught it. What I failed to restore was an in memory date structure that is part of the config module. The patch seems to be concerned only with the filesy

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: Whoops, we seems to have partly overlapped (and made some of the same changes). I plan to push my PR sometime tomorrow (it also changes configdialog and revised tests) after looking as yours. Then move on to adding config tests, #30780. The tests for config

[issue30869] regrtest: Add .idlerc to saved_test_environment

Changes by Louie Lu : -- pull_requests: +2679 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30869] regrtest: Add .idlerc to saved_test_environment

New submission from Louie Lu: In bpo #30780, there is a mistake of tearDownModule didn't restore the use rCfg. To prevent future mistake, Adding .idlerc to regrtest saved_test_environment, so that `--fail-env-changed` option can detect .idlerc been changed in IDLE test. -- components:

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: New changeset df0f99329843c10701ffaefbd3948ac698c12220 by terryjreedy in branch '3.6': [3.6] bpo-30780: Fix error in idlelib.test_idle.test_configdialog (GH-2606) (#2613) https://github.com/python/cpython/commit/df0f99329843c10701ffaefbd3948ac698c12220 -

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- pull_requests: +2678 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30868] IDLE: Improve configuration tests with mock Save.

New submission from Terry J. Reedy: When writing tests for config and configdialog, I blocked the user configs from hitting the filesystem by passing '' as the file name. This disables the Save function. To know that Save is called, a mock is needed. To know what would have been written to

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: I posted PR 2612 for #30779 and expect to merge it tomorrow after sleep and final review. It includes passing revisions of existing configdialog tests. A PR dependent on 2612 could be posted before I do the merge. Follow the model of using xyzpage names in a

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- pull_requests: +2677 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: New changeset 25a4206c243e3b1fa6f5b1c72a11b409b007694d by terryjreedy in branch 'master': bpo-30780: Fix error in idlelib.test_idle.test_configdialog (#2606) https://github.com/python/cpython/commit/25a4206c243e3b1fa6f5b1c72a11b409b007694d -- ___

[issue30860] Consolidate stateful C globals under a single struct.

Nick Coghlan added the comment: The core motivation driving the original refactoring was to better understand and consolidate our runtime state in order to clarify what the GIL is actually protecting (aside from the reference counts). That then turned out to have surprising performance benefit

[issue30790] Can't use proxy to connect internet on windows

Changes by Wu Zongyong : -- pull_requests: +2676 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: I've made the first pull request for the changes to config.py. I have to apologize because I really couldn't figure out how to do 'save_all' without including 'set_user_value' since 'set_user_value' updates userCfg with the values from ConfigChanges. Also, i

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : -- pull_requests: +2675 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue23644] g++ module compile fails with ‘_Atomic’ does not name a type

STINNER Victor added the comment: I don't think that CPython can be built by g++. If you consider that it should, please open a new issue since it's a different use case. -- ___ Python tracker _

[issue30860] Consolidate stateful C globals under a single struct.

Antoine Pitrou added the comment: After looking at the PR, I'm a bit skeptical about this. Suddenly a lot of things which are implementation details get moved to the public include files, which makes things more confusing from my POV. I also don't know why all globals should be consolidated

[issue23644] g++ module compile fails with ‘_Atomic’ does not name a type

Melroy van den Berg added the comment: Yea I'm building Python 3.6.1 from source, using gcc and --with-cxx-main=correct/location/to/g++ flag. So the warning message appears during ./configure about that it can't find g++. I didn't try to patch it using the attachments of this issue. Since I wa

[issue30861] StreamReader does not return reamaing and ready data buffer before raise the Exeption

Guido van Rossum added the comment: We seem to have a failure to communicate. I'm sure your example code "works", but you're not showing what's in the data it receives that is important for the app to read (your example just prints it). And surely your app should be robust even if the connecti

[issue30183] [HPUX] compilation error in pytime.c with cc compiler

Changes by Robert Boehne : -- pull_requests: +2674 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue30532] email.policy.SMTP.fold() mangles long headers

R. David Murray added the comment: Thanks, Joel! -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed type: -> behavior ___ Python tracker ___

[issue30532] email.policy.SMTP.fold() mangles long headers

R. David Murray added the comment: New changeset 3bbdf990a2c1b0b303b950058e3177a1bd5f697a by R. David Murray (Joel Hillacre) in branch '3.5': bpo-30532: Fix whitespace folding in certain cases (#2592) https://github.com/python/cpython/commit/3bbdf990a2c1b0b303b950058e3177a1bd5f697a --

[issue30532] email.policy.SMTP.fold() mangles long headers

R. David Murray added the comment: New changeset c60d2f5e8609b040ab58c498fde23928fe9dbef5 by R. David Murray (Joel Hillacre) in branch '3.6': bpo-30532: Fix whitespace folding in certain cases (#2591) https://github.com/python/cpython/commit/c60d2f5e8609b040ab58c498fde23928fe9dbef5 --

[issue30861] StreamReader does not return reamaing and ready data buffer before raise the Exeption

pfreixes added the comment: As was said, the assumption here is the data that came to the buffer must be available. For example, the next snippet shows a Redis client that expects the data message plus the RST packet, where the redis-server was configured to accept max N connections, the conn

[issue30819] Linking with 'ld -b' fails with 64-bit using Itanium HP compiler

Changes by Robert Boehne : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue23644] g++ module compile fails with ‘_Atomic’ does not name a type

STINNER Victor added the comment: See the following commit of bpo-25150: commit 6df29ada02d22c43a8d439a70b820cb1ceacca42 Author: Victor Stinner Date: Fri Sep 18 15:06:34 2015 +0200 Issue #25150: Hide the private _Py_atomic_xxx symbols from the public Python.h header to fix a compilat

[issue23644] g++ module compile fails with ‘_Atomic’ does not name a type

STINNER Victor added the comment: > ./Include/pyatomic.h:37:5: error: 'atomic_int' does not name a type I don't understand how you got this error. The line 37 of pyatomic.h is only compiled when you build Python itself. At least, since Python 3.5.1 and Python 3.6.0. Did you try to build Pytho

[issue23644] g++ module compile fails with ‘_Atomic’ does not name a type

STINNER Victor added the comment: Oh, wait, I read your message backward. You said that the fix doesn't work? Hum, how can I reproduce the issue? What is your use case? -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: PR to fix type in moduleTearDown. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- pull_requests: +2673 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: I am working on this now. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26506] [EASY] hex() documentation: mention "%x" % int

Mariatta Wijaya added the comment: New changeset 67ba4fa467825d6a0c0a21cc54ff1df2ed1b by Mariatta (Manvisha Kodali) in branch 'master': bpo-26506: hex() documentation: mention %x % int (GH-2525) https://github.com/python/cpython/commit/67ba4fa467825d6a0c0a21cc54ff1df2ed1b --

[issue27584] New addition of vSockets to the python socket module

Cathy Avery added the comment: So I revised my code based on the reviews and I passed all the checks ... now what? Thanks, Cathy -- ___ Python tracker ___

[issue30862] parent logger should also check the level

Vinay Sajip added the comment: New changeset 0653fba51c03d20fa4381ba0836acd17fd05b04b by Vinay Sajip in branch 'master': bpo-30862: Updated Logger.setLevel documentation. (GH-2604) https://github.com/python/cpython/commit/0653fba51c03d20fa4381ba0836acd17fd05b04b -- __

[issue30862] parent logger should also check the level

Changes by Vinay Sajip : -- pull_requests: +2672 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23644] g++ module compile fails with ‘_Atomic’ does not name a type

Melroy van den Berg added the comment: Ow sorry, I though it was already fixed in the latest stable version of 3.x. Since is issue is from 2015. -- ___ Python tracker ___ __

[issue23644] g++ module compile fails with ‘_Atomic’ does not name a type

STINNER Victor added the comment: > I'm using Python 3.6.1. It's not fixed! Thanks for the confirmation of the fix ;-) -- ___ Python tracker ___

[issue30865] python cannot import module located on a "VOLUME" directory

R. David Murray added the comment: Reading through some of the linked material, it looks like the issue is with how UNC "symlinks" are resolved. -- nosy: +r.david.murray ___ Python tracker

[issue30862] parent logger should also check the level

R. David Murray added the comment: @qingyunha: we are telling you that that would *introduce* a bug. This is working the way it is supposed to. Vinay, what if we rewrote the beginning of that paragraph like this: Sets the threshold for this logger to lvl. Logging messages which are less seve

[issue30860] Consolidate stateful C globals under a single struct.

Changes by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue30866] Add _testcapi.stack_pointer() to measure the C stack consumption

STINNER Victor added the comment: I just published my blog post: "My contributions to CPython during 2017 Q1" https://haypo.github.io/contrib-cpython-2017q1.html See the "Stack consumption" section. -- ___ Python tracker

[issue30858] Keyword can't be an expression?

R. David Murray added the comment: If I saw your message, I would think "what is a 'simple name'?". There's no glossary entry for that, nor is it a concept used elsewhere in the documentation as far as I remember. One could instead use "single identifier", but the problem with both of those

[issue23644] g++ module compile fails with ‘_Atomic’ does not name a type

Melroy van den Berg added the comment: I also got this problem with gcc/g++ version 4.9.3. ./Include/pyatomic.h:37:5: error: 'atomic_int' does not name a type I'm using Python 3.6.1. It's not fixed! -- nosy: +Melroy van den Berg versions: +Python 3.6 -Python 3.5 _

[issue30866] Add _testcapi.stack_pointer() to measure the C stack consumption

STINNER Victor added the comment: > Usually we first merge a patch in master and after that cherry-pick it to > other branches. Right. But in this case, I needed the patch for each branch, to run the test on all branches to write a blog post :-) Here are results (blog post spoiler!): Table sh

[issue30867] Add necessary macro that insure `HAVE_OPENSSL_VERIFY_PARAM` to avoid invalid function declaration

Changes by signal1587 : -- title: Add necessary macro that insure`HAVE_OPENSSL_VERIFY_PARAM` to avoid invalid function declaration -> Add necessary macro that insure `HAVE_OPENSSL_VERIFY_PARAM` to avoid invalid function declaration ___ Python tracke

[issue30867] Add necessary macro that insure`HAVE_OPENSSL_VERIFY_PARAM` to avoid invalid function declaration

Changes by signal1587 : -- title: Add necessary macro `HAVE_OPENSSL_VERIFY_PARAM` to avoid invalid declaration -> Add necessary macro that insure`HAVE_OPENSSL_VERIFY_PARAM` to avoid invalid function declaration ___ Python tracker

[issue30867] Add necessary macro `HAVE_OPENSSL_VERIFY_PARAM` to avoid invalid declaration

New submission from signal1587: Compile Python (2.7.13) on platform which has OpenSSL (<0.9.8) will met error: /opt/Python-2.7.13/Modules/_ssl.c:177: error: syntax error before ‘*’ token Since return type `X509_VERIFY_PARAM` got added to OpenSSL in version 0.9.8. Surround the implementation

[issue30865] python cannot import module located on a "VOLUME" directory

Changes by Serhiy Storchaka : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___

[issue30866] Add _testcapi.stack_pointer() to measure the C stack consumption

Serhiy Storchaka added the comment: Usually we first merge a patch in master and after that cherry-pick it to other branches. -- ___ Python tracker ___ _

[issue30847] asyncio: selector_events: add_urgent() for urgent data to read, 3rd argument of select.select()

STINNER Victor added the comment: Ok, it makes sense. Thanks :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue30866] Add _testcapi.stack_pointer() to measure the C stack consumption

Changes by STINNER Victor : -- pull_requests: +2671 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30866] Add _testcapi.stack_pointer() to measure the C stack consumption

Changes by STINNER Victor : -- pull_requests: +2670 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30866] Add _testcapi.stack_pointer() to measure the C stack consumption

Changes by STINNER Victor : -- pull_requests: +2669 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30866] Add _testcapi.stack_pointer() to measure the C stack consumption

New submission from STINNER Victor: In issues bpo-28870, bpo-29227, bpo-29233 and bpo-29234, I worked on reducing the C stack consumption. I now would to add the _testcapi.stack_pointer() that I used to be able to easily measure the stack consumption. Try for example attached stack_overflow-3.

[issue30866] Add _testcapi.stack_pointer() to measure the C stack consumption

Changes by STINNER Victor : -- pull_requests: +2668 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30847] asyncio: selector_events: add_urgent() for urgent data to read, 3rd argument of select.select()

Pim Klanke added the comment: > "Let's say that we got read event on sockets A and B (in an ordered list from > selectors: A, then B), but B gets urgent data: should we handle B urgent data > before not-urgent A data?" IMO No. The same strategy applies. urgent data events on B have priority ov

[issue30865] python cannot import module located on a "VOLUME" directory

New submission from Adrien Pré: This issue created on python-docker project https://github.com/docker-library/python/issues/210 indicates that python cannot import a module if it is located on a docker-volume. yosifkit's comment suggest there is an issue in the UNC resolution with paths start

[issue30855] [3.5] test_tk: test_use() of test_tkinter.test_widgets randomly fails with "integer value too large to represent" on with AMD64 Windows8 3.5

STINNER Victor added the comment: I backported fixes to 2.7 and 3.5 branches. The test fails randomly, so I close the issue and hope that it doesn't come back. If it comes back on 3.5, we should now get the identifier which caused the failure. I will reopen the issue if the bug occurs again.

[issue30339] test_multiprocessing_main_handling: "RuntimeError: Timed out waiting for results" on x86 Windows7 3.x

STINNER Victor added the comment: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.5/builds/229/steps/test/logs/stdio == FAIL: test_directory (test.test_multiprocessing_main_handling.SpawnCmdLineTest)

[issue30319] Change socket.close() to ignore ECONNRESET

STINNER Victor added the comment: Thanks Martin for the long explanation. To simplify a lot, there is and was never any warranty that a successful sock.send() call delivered data to the peer. Each layer does its best, but the data can be lost at any layer, and the peer is free to close the connec

[issue30864] Compile failure for linux socket CAN support

New submission from Riccardo Magliocchetti: I have an issue related to this while trying to compile statically Python 3.6.1 (but latest master looks the same) against a static musl. The problem is that i have AF_CAN defined because it's defined in linux/socket.h but by not having HAVE_LINUX_CA

[issue30855] [3.5] test_tk: test_use() of test_tkinter.test_widgets randomly fails with "integer value too large to represent" on with AMD64 Windows8 3.5

STINNER Victor added the comment: New changeset f6d6480b93eca6f353784579108957108750c004 by Victor Stinner in branch '2.7': [2.7] bpo-30855: Trying to fix test_use on Windows. (#2586) https://github.com/python/cpython/commit/f6d6480b93eca6f353784579108957108750c004 -- ___

[issue30862] parent logger should also check the level

TaoQingyun added the comment: yes, I understand the effective level. my question is that before call ancestor's handler, should also check `c.isEnabledFor(record.levelno)` ``` def callHandlers(self, record): """ Pass a record to all relevant handlers. Loop through a

[issue30863] Rewrite PyUnicode_AsWideChar() and PyUnicode_AsWideCharString()

Changes by Serhiy Storchaka : -- pull_requests: +2667 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30863] Rewrite PyUnicode_AsWideChar() and PyUnicode_AsWideCharString()

New submission from Serhiy Storchaka: Since Python 3.3 PyUnicode_AsUnicodeAndSize() is deprecated in favour of PyUnicode_AsWideChar() and PyUnicode_AsWideCharString(). But the latter two are implemented using PyUnicode_AsUnicodeAndSize(). This prevents adding the deprecation compiler warning f

[issue27268] Incorrect error message on float('')

Wolfgang Maier added the comment: Could somebody turn this into a PR to move things forward? I guess Nofar mistakenly set resolution to "works for me", but meant "patch works for me"? -- nosy: +wolma ___ Python tracker

[issue30799] Improved test coverage Lib/_osx_support.py 99%

New submission from chexex: I will appreciate any feedback. -- nosy: +ned.deily, ronaldoussoren ___ Python tracker ___ ___ Python-bugs

[issue30862] parent logger should also check the level

Vinay Sajip added the comment: As RDM says, this behaviour is as designed. The logger's setLevel documentation says: "Sets the threshold for this logger to lvl. Logging messages which are less severe than lvl will be ignored. When a logger is created, the level is set to NOTSET (which causes

[issue30847] asyncio: selector_events: add_urgent() for urgent data to read, 3rd argument of select.select()

Pim Klanke added the comment: This is in fact the third catagory of select(), "exceptional conditions", but because some find the term "exceptional" confusing when used in a Python module, we decided to use the term "urgent data", borrowed from the poll(2) man page. (see bpo-30844) An example