[issue28769] Make PyUnicode_AsUTF8 returning "const char *" rather of "char *"

New submission from Serhiy Storchaka: PyUnicode_AsUTF8AndSize() and PyUnicode_AsUTF8() return a reference to cached readonly UTF-8 representation of a string. Changing the content of the UTF-8 representation is an error. Proposed patch makes these functions returning "const char *" rather of "

[issue28766] Remove the semicolon in source code

Raymond Hettinger added the comment: Sorry Yuwei, but this is irrelevant and not appropriate for a Python 2.7 backport at this time. -- nosy: +rhettinger status: open -> closed ___ Python tracker _

[issue28573] Python 3.6.0b4 64-bit has no sys._mercurial info

Steve Dower added the comment: Wasn't fixed as well as I'd like, so I clearly need a better approach here. -- resolution: fixed -> stage: resolved -> status: closed -> open title: Python 3.6.0b3 64-bit has no sys._mercurial info -> Python 3.6.0b4 64-bit has no sys._mercurial info ___

[issue28761] Add the const qualifier to fields name and doc of public structs

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue28761] Add the const qualifier to fields name and doc of public structs

Serhiy Storchaka added the comment: Thanks Nick. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue5830] heapq item comparison problematic with sched's events

Changes by Serhiy Storchaka : -- stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue5830] heapq item comparison problematic with sched's events

Serhiy Storchaka added the comment: Agreed, "seq" is better name. Thanks Raymond. -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue28761] Add the const qualifier to fields name and doc of public structs

Roundup Robot added the comment: New changeset 42b0ba372ec2 by Serhiy Storchaka in branch 'default': Issue #28761: The fields name and doc of structures PyMemberDef, PyGetSetDef, https://hg.python.org/cpython/rev/42b0ba372ec2 -- nosy: +python-dev ___

[issue28766] Remove the semicolon in source code

Yuwei Ba added the comment: I know this is not a functional 'fix', though it's the fact that there should not be a semicolon. It can make user confusing. There might be another user who found this semicolon and create an issue again since there are still lots of Python27 codes running on tons

[issue28635] Update What's New for 3.6

INADA Naoki added the comment: I added ``-VV`` option to python command (issue28532). Which section should I add the entry about it? -- nosy: +inada.naoki ___ Python tracker ___

[issue28763] Use en-dashes for ranges in docs

Martin Panter added the comment: Sure, I was just saying that for whatever reason, 50% of the documentation uses hyphens for number ranges, and 50% uses en dashes. -- ___ Python tracker ___

[issue28763] Use en-dashes for ranges in docs

Serhiy Storchaka added the comment: The rest single hyphens between digits are meaningful hypens in iso-8859-1, ISDNs, sample outputs, etc. -- ___ Python tracker ___ ___

[issue28702] Confusing error message when None used in expressions, eg. "'NoneType' object has no attribute 'foo'"

Greg Ward added the comment: > Is it worth changing about 800 places in CPython code? Not counting > third-party code. Definitely not. My aim is not to fix every possible reference to "instance of 'NoneType'", just the handful of cases that are most frequently encountered, especially if we th

[issue28738] Document SIGBREAK as argument for signal() under Windows.

Changes by Eryk Sun : -- keywords: +easy priority: normal -> low stage: -> patch review versions: +Python 3.6 ___ Python tracker ___

[issue23106] Remove smalltable from set objects

Raymond Hettinger added the comment: Based on the performance hit, I am retracting this. -- resolution: -> rejected status: open -> closed ___ Python tracker ___ ___

[issue27100] Attempting to use class with both __enter__ & __exit__ undefined yields __exit__ attribute error

Raymond Hettinger added the comment: Thanks for the patch Jonathan. Nick, thanks for chiming in. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ _

[issue27100] Attempting to use class with both __enter__ & __exit__ undefined yields __exit__ attribute error

Roundup Robot added the comment: New changeset 3aafb232f2db by Raymond Hettinger in branch '3.6': Issue #27100: With statement reports missing __enter__ before __exit__. (Contributed by Jonathan Ellington.) https://hg.python.org/cpython/rev/3aafb232f2db -- nosy: +python-dev _

[issue28766] Remove the semicolon in source code

Martin Panter added the comment: This was added to 2.7 in r68532 (Issue 4879), but the semicolon never made it to the Python 3 branch that I can see, so I don’t think there is anything to fix there. Your patch is against the 2.7 branch, which is only open for bug fixes now, and I don’t think t

[issue28688] Warning -- warnings.filters was modified by test_warnings

Changes by Martin Panter : -- superseder: Warning -- warnings.filters was modified by test_warnings -> Implement comparison (x==y and x!=y) for _sre.SRE_Pattern ___ Python tracker _

[issue28688] Warning -- warnings.filters was modified by test_warnings

Martin Panter added the comment: As long as we are restricted by backwards compatibility, it will be hard to find a hack-free solution. The ideal solution IMO is to re-create _warnings.filters from scratch when _warnings is reloaded, but such a change would be safer only for 3.7. So I am happ

[issue26163] FAIL: test_hash_effectiveness (test.test_set.TestFrozenSet)

Changes by Raymond Hettinger : -- resolution: -> wont fix status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26163] FAIL: test_hash_effectiveness (test.test_set.TestFrozenSet)

Roundup Robot added the comment: New changeset e0f0211d314d by Raymond Hettinger in branch '3.6': Issue #26163: Disable periodically failing test which was overly demanding of the frozenset hash function effectiveness https://hg.python.org/cpython/rev/e0f0211d314d -- nosy: +python-dev

[issue26163] FAIL: test_hash_effectiveness (test.test_set.TestFrozenSet)

Raymond Hettinger added the comment: Rather than making futile further attempts to scramble the bits in the final hash to hide the effect of weak upstream hash inputs, I'm inclined to disable this particular test which was already a crazily harsh torture test. I suspect that even the tuple ha

[issue28763] Use en-dashes for ranges in docs

Martin Panter added the comment: Personally I prefer en dashes where practical, but I fear the change may conflict with other people’s styles and preferences. I quickly counted 22 single hyphens (obviously I missed a few that your patch caught) and also 22 existing en dashes. --

[issue5830] heapq item comparison problematic with sched's events

Raymond Hettinger added the comment: Thanks Serhiy. FWIW, I changed the variable name from "l" to "seq" for readability. -- status: open -> closed ___ Python tracker ___

[issue5830] heapq item comparison problematic with sched's events

Roundup Robot added the comment: New changeset ecc6f7940e02 by Raymond Hettinger in branch '3.6': Issue #5830: Add test for ee476248a74a. (Contributed by Serhiy Storchaka.) https://hg.python.org/cpython/rev/ecc6f7940e02 -- ___ Python tracker

[issue27825] Make the documentation for statistics' data argument clearer.

Mariatta Wijaya added the comment: Sounds good. Thanks, Raymond :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue28587] list.index documentation missing start and stop arguments

Raymond Hettinger added the comment: Okay, applied. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27825] Make the documentation for statistics' data argument clearer.

Raymond Hettinger added the comment: Thanks Mariatta. As discussed in chat, I dropped the extra fractions examples because they didn't seem to add value. -- nosy: +rhettinger resolution: -> fixed status: open -> closed ___ Python tracker

[issue28587] list.index documentation missing start and stop arguments

Roundup Robot added the comment: New changeset efac7ac53933 by Raymond Hettinger in branch '3.6': Issue #28587: Improve list examples in the tutorial https://hg.python.org/cpython/rev/efac7ac53933 -- ___ Python tracker

[issue27825] Make the documentation for statistics' data argument clearer.

Roundup Robot added the comment: New changeset 71dd21a3b9cc by Raymond Hettinger in branch '3.6': Issue #27825: Improve for statistics data arguments. (Contributed by Mariatta Wijaya.) https://hg.python.org/cpython/rev/71dd21a3b9cc -- nosy: +python-dev _

[issue28743] test_choices_algorithms() in test_random uses lots of memory

Martin Panter added the comment: Thanks Raymond, now the test is noticeably faster and fine with my memory situation :) -- stage: -> resolved ___ Python tracker ___ ___

[issue28587] list.index documentation missing start and stop arguments

Mariatta Wijaya added the comment: Thanks Raymond. The new set of examples is much better than the previous one. +1 -- ___ Python tracker ___

[issue28587] list.index documentation missing start and stop arguments

Raymond Hettinger added the comment: Attaching an improved list example: * Replaced abstract and hard to follow numerical example with fruits * Demonstrate the non-mutating methods first -- Added file: http://bugs.python.org/file45595/new_list_example.diff __

[issue28587] list.index documentation missing start and stop arguments

Raymond Hettinger added the comment: Thanks for noticing. I tested against the original list rather than the subsequently modified version. I'm starting to think that this whole example section is annoyingly hard to follow and uninformative. -- _

[issue28587] list.index documentation missing start and stop arguments

Mariatta Wijaya added the comment: Thanks, Raymond and Martin :) Not sure what the procedure is for fixing this. Do I upload another patch? -- ___ Python tracker ___ ___

[issue28587] list.index documentation missing start and stop arguments

Martin Panter added the comment: The committed change looks wrong in the new example. I think Mariatta’s patch was right; it the index found is 3, not 2: >>> a [66.25, 333, -1, 333, 1, 1234.5, 333] >>> a.index(333) 1 >>> a.index(333, 2) # search for 333 starting at index 2 3 -- nosy:

[issue15851] Lib/robotparser.py doesn't accept setting a user agent string, instead it uses the default.

Changes by Raymond Hettinger : -- assignee: rhettinger -> ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue28743] test_choices_algorithms() in test_random uses lots of memory

Raymond Hettinger added the comment: A smaller value suffices for this test. It was trying to make sure the underlying algorithms are as in-sync as possible without going to extremes. -- resolution: -> fixed status: open -> closed ___ Python tracke

[issue28743] test_choices_algorithms() in test_random uses lots of memory

Roundup Robot added the comment: New changeset 3551fca2c6ae by Raymond Hettinger in branch '3.6': Issue #28743: Reduce memory consumption for random module tests https://hg.python.org/cpython/rev/3551fca2c6ae -- nosy: +python-dev ___ Python tracker

[issue28743] test_choices_algorithms() in test_random uses lots of memory

Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue28743] test_choices_algorithms() in test_random uses lots of memory

Martin Panter added the comment: Gareth, are you sure that fixes the main memory problem? Did you see Serhiy’s cum_weights list? Looking at the code, a list of every number from one to 13 million will use more memory (to hold each unique integer) than the initial list of repeated ones. I thin

[issue28587] list.index documentation missing start and stop arguments

Raymond Hettinger added the comment: Mariatta, thank you for the patch. And Chris, thanks for the observant bug report. -- resolution: -> fixed status: open -> closed ___ Python tracker _

[issue28587] list.index documentation missing start and stop arguments

Roundup Robot added the comment: New changeset 62c16fafa7d4 by Raymond Hettinger in branch '3.6': Issue 28587: list.index documentation missing start and stop arguments. (Contributed by Mariatta Wijaya.) https://hg.python.org/cpython/rev/62c16fafa7d4 -- nosy: +python-dev _

[issue28652] Make loop methods reject socket kinds they do not support.

Roundup Robot added the comment: New changeset 0ee76f3afd70 by Yury Selivanov in branch '3.5': Issue #28652: Partially rollback previous changes https://hg.python.org/cpython/rev/0ee76f3afd70 New changeset a40159071359 by Yury Selivanov in branch '3.6': Merge 3.5 (issue #28652) https://hg.python

[issue28475] Misleading error on random.sample when k < 0

Raymond Hettinger added the comment: Thanks Franscisco. I ended-up not modifying the docs because I think it clutters that clarity with an irrelevant side issue. The more important part was to make sure the error message wasn't misleading and the test that edge case. I didn't backport to

[issue28752] datetime object fails to restore from reduction

Alexander Belopolsky added the comment: It looks like Serhiy has already committed it. Thanks! -- ___ Python tracker ___ ___ Python-b

[issue28752] datetime object fails to restore from reduction

Changes by Alexander Belopolsky : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue28475] Misleading error on random.sample when k < 0

Roundup Robot added the comment: New changeset 89f95c78e0ab by Raymond Hettinger in branch '3.6': Issue 28475: Improve error message for random.sample() with k < 0. (Contributed by Francisco Couzo). https://hg.python.org/cpython/rev/89f95c78e0ab -- nosy: +python-dev __

[issue27414] http.server.BaseHTTPRequestHandler inconsistence with Content-Length value

STINNER Victor added the comment: issue27414.patch is not good: see my review. -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-

[issue28752] datetime object fails to restore from reduction

Roundup Robot added the comment: New changeset 0a2a0061e425 by Serhiy Storchaka in branch '3.6': Issue #28752: Restored the __reduce__() methods of datetime objects. https://hg.python.org/cpython/rev/0a2a0061e425 New changeset 23140bd66d86 by Serhiy Storchaka in branch 'default': Issue #28752: R

[issue28752] datetime object fails to restore from reduction

Alexander Belopolsky added the comment: > If you can push this in the next hour or two ... I'll do it now. -- ___ Python tracker ___

[issue28752] datetime object fails to restore from reduction

Ned Deily added the comment: If you can push this in the next hour or two, it can still make b4. -- ___ Python tracker ___ ___ Python-

[issue28751] Fix comments in code.h

Raymond Hettinger added the comment: Thanks Ned. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bug

[issue28751] Fix comments in code.h

Roundup Robot added the comment: New changeset 0a916174 by Raymond Hettinger in branch '3.6': Issue 28751: Fix comments in code.h. (Contributed by Ned Batchelder). https://hg.python.org/cpython/rev/0a916174 -- nosy: +python-dev ___ Python tra

[issue15851] Lib/robotparser.py doesn't accept setting a user agent string, instead it uses the default.

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28751] Fix comments in code.h

Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue28532] Show sys.version when -V option is supplied twice.

Martin Panter added the comment: The text looks okay. I’m not sure about putting it in the “Porting to Python 3.6” section, but there doesn’t seem to be a more appropriate existing heading. Perhaps we need a new heading, say “Other Improvement”, near “Optimizations” and “Build and C API Change

[issue28689] OpenSSL 1.1.0c test failures

Charalampos Stratakis added the comment: Fixed upstream: https://github.com/openssl/openssl/commit/beacb0f0c1ae7b0542fe053b95307f515b578eb7 -- nosy: +cstratak ___ Python tracker

[issue28747] Expose SSL_CTX_set_cert_verify_callback

Steve Dower added the comment: For the sake of review, I fixed the patch and rebased it on default. -- Added file: http://bugs.python.org/file45594/28747_3.patch ___ Python tracker _

[issue28768] Warning: implicit declaration of function '_setmode'

Changes by Masayuki Yamamoto : Added file: http://bugs.python.org/file45593/2.7-include-io.h.patch ___ Python tracker ___ ___ Python-bugs-list

[issue28768] Warning: implicit declaration of function '_setmode'

New submission from Masayuki Yamamoto: Platform that appeared warning is Vista Cygwin x86. Interpreter execution doesn't crash because _setmode function is supplied from cygwin1.dll that always linked. Warning reason is header io.h [*] doesn't include to source file. Therefore I wrote two patc

[issue28752] datetime object fails to restore from reduction

Changes by Serhiy Storchaka : -- nosy: +ned.deily ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue28752] datetime object fails to restore from reduction

Alexander Belopolsky added the comment: The patch LGTM. I'll commit it tonight unless Serhiy beats me to it. -- nosy: +alexandre.vassalotti, haypo, tim.peters ___ Python tracker ___

[issue28752] datetime object fails to restore from reduction

Changes by Alexander Belopolsky : -- assignee: -> belopolsky stage: patch review -> commit review ___ Python tracker ___ ___ Python-b

[issue4347] Circular dependency causes SystemError when adding new syntax

Brett Cannon added the comment: So what does having the tokenizer not depend on pgen accomplish? Does it break a circular dependency where the tokenizer will get rebuilt with pgen before a full build starts? -- ___ Python tracker

[issue28751] Fix comments in code.h

Brett Cannon added the comment: Patch LGTM. -- stage: -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue28767] Readd __index__ support on ipaddress objects

Serhiy Storchaka added the comment: Why __index__ support is needed? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs

[issue28767] Readd __index__ support on ipaddress objects

New submission from Josh Rosenberg: It looks like, due to #16722, in #15559, __index__ was removed from ipaddress objects. #16722 was fixed a few months later, but the comments asking for it to be readded were put on a closed issue, so no one noticed. Can __index__ support be readded now? Shou

[issue28172] Upper-case all example enum members

Changes by Ethan Furman : -- versions: -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue28172] Upper-case all example enum members

Roundup Robot added the comment: New changeset b9801dab214a by Ethan Furman in branch '3.6': close issue28172: Change all example enum member names to uppercase, per Guido; patch by Chris Angelico. https://hg.python.org/cpython/rev/b9801dab214a New changeset 5ec8d4c51363 by Ethan Furman in bran

[issue28747] Expose SSL_CTX_set_cert_verify_callback

Steve Dower added the comment: Whoops, that's what I get for renaming something. Easily fixed, but I'm happy to aim for 3.7. -- ___ Python tracker ___ __

[issue28764] test_mailbox fails when run as a non-root user on Android API 24

R. David Murray added the comment: LGTM. -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

Serhiy Storchaka added the comment: If make groupindex and indexgroup a dict and a tuple, we could use concrete dict and tuple API instead of generic mapping and sequence APIs. Note that groups, groupindex and indexgroup are not independent. Actually indexgroup is derived from groups and group

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

Roundup Robot added the comment: New changeset 493359386360 by Ethan Furman in branch '3.6': issue28082: actually include NEWS entry https://hg.python.org/cpython/rev/493359386360 -- ___ Python tracker

[issue28766] Remove the semicolon in source code

New submission from Yuwei Ba: As we do not often use semicolons in Python world. I hope this historical semi would be cleaned in a future release. Source: Lib/httplib.py:1117 -- components: Library (Lib) files: mywork.patch hgrepos: 361 keywords: patch messages: 281378 nosy: ibigbug pr

[issue23591] enum: Add Flags and IntFlags

Roundup Robot added the comment: New changeset f404a59d834e by Ethan Furman in branch '3.6': closes issue23591: add NEWS entry https://hg.python.org/cpython/rev/f404a59d834e -- status: open -> closed ___ Python tracker

[issue28082] re: convert re flags to (much friendlier) IntFlag constants

Roundup Robot added the comment: New changeset 176fc21f8430 by Ethan Furman in branch '3.6': closes issue28082: doc update and NEWS entry https://hg.python.org/cpython/rev/176fc21f8430 -- resolution: -> fixed stage: commit review -> resolved status: open -> closed _

[issue28740] Add sys.getandroidapilevel()

Xavier de Gaye added the comment: I agree with Marc-Andre, Windows has sys.getwindowsversion() returning system information for the Windows version, and a platform.win32_ver() returning additional version information from the Registry obtained at run time. So it is consistent to add the sys.ge

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

STINNER Victor added the comment: For stricter checks on _sre.compile() arguments, I created the issue #28765: "_sre.compile(): be more strict on types of indexgroup and groupindex". -- ___ Python tracker

[issue28765] _sre.compile(): be more strict on types of indexgroup and groupindex

New submission from STINNER Victor: Attached patch makes _sre.compile() more strict on types: groupindex must be a dictionary and indexgroup must be a tuple. Currently, indexgroup is passed as a list. I chose to convert it to a tuple to use less memory and to prevent unwanted changes. For unwa

[issue28731] _PyDict_NewPresized() creates too small dict

Roundup Robot added the comment: New changeset b708b3190ecb by INADA Naoki in branch 'default': Issue #28731: Optimize _PyDict_NewPresized() to create correct size dict https://hg.python.org/cpython/rev/b708b3190ecb -- nosy: +python-dev ___ Python tra

[issue28688] Warning -- warnings.filters was modified by test_warnings

STINNER Victor added the comment: I implemented x==y operator for _sre.SRE_Pattern in Python 3.6 and 3.7, it fixed this issue. For Python 3.5, I removed the warnings.filters test, as we discussed. @Martin Panter: immortal-filters.patch works because I'm not super excited by the change. Someho

[issue28731] _PyDict_NewPresized() creates too small dict

INADA Naoki added the comment: Thanks. As @haypo suggests, I'll commit this to default branch first, and backport to 3.6 after 3.6.0 is released. -- ___ Python tracker ___ __

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

STINNER Victor added the comment: Serhiy Storchaka: "pattern_compare-6.patch LGTM." Thank you very much for your very useful reviews! I pushed the change. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue28688] Warning -- warnings.filters was modified by test_warnings

Roundup Robot added the comment: New changeset 75b1091594f8 by Victor Stinner in branch '3.5': Issue #28688: Remove warnings.filters check from regrtest https://hg.python.org/cpython/rev/75b1091594f8 New changeset a2616863de06 by Victor Stinner in branch '3.6': Issue #28688: Null merge 3.5 https

[issue28023] python-gdb.py must be updated for the new Python 3.6 compact dict

Changes by INADA Naoki : Added file: http://bugs.python.org/file45589/dict_gdb2.patch ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue26865] Meta-issue: support of the android platform

Xavier de Gaye added the comment: New issues raised upon testing on the Android API 24 emulator: issue #28683: bind() on a unix socket raises PermissionError on Android for a non-root user issue #28684: [asyncio] bind() on a unix socket raises PermissionError on Android for a non-root user

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

Roundup Robot added the comment: New changeset 5e8ef1493843 by Victor Stinner in branch '3.6': Implement rich comparison for _sre.SRE_Pattern https://hg.python.org/cpython/rev/5e8ef1493843 -- nosy: +python-dev ___ Python tracker

[issue18383] test_warnings modifies warnings.filters when running with "-W default"

Roundup Robot added the comment: New changeset 5e8ef1493843 by Victor Stinner in branch '3.6': Implement rich comparison for _sre.SRE_Pattern https://hg.python.org/cpython/rev/5e8ef1493843 -- ___ Python tracker ___

[issue28764] test_mailbox fails when run as a non-root user on Android API 24

New submission from Xavier de Gaye: The patch fixes the problem that on Android API 24, a non-root user is not allowed to create the hard links used by the mailbox module. Related to issue 28759. -- assignee: xdegaye components: Library (Lib) files: test_mailbox_link.patch keywords: pat

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

Serhiy Storchaka added the comment: pattern_compare-6.patch LGTM. -- assignee: -> haypo stage: patch review -> commit review ___ Python tracker ___ _

[issue28727] Implement comparison (x==y and x!=y) for _sre.SRE_Pattern

STINNER Victor added the comment: Back to basis, patch 6: * revert changes on indexgroup and groupindex types: I will fix this later, once this issue is fixed * pattern_richcompare() and pattern_hash() also uses pattern, but don't use groups, indexgroup nor groupindex anymore I removed the @c

[issue28763] Use en-dashes for ranges in docs

Serhiy Storchaka added the comment: Some of these double hyphens are in code examples. Thus the actual number of en-dashes that can be changed to em-dashes is smaller. -- ___ Python tracker ___

[issue28763] Use en-dashes for ranges in docs

Serhiy Storchaka added the comment: 353 en-dashes with spaces. 479 em-dashes with spaces. 89 em-dashes without spaces. And some number of hyphens with spaces. It is hard to automatically distinguish them from minuses in code examples, but in issue18529 I provided large patches that converted a

[issue28023] python-gdb.py must be updated for the new Python 3.6 compact dict

STINNER Victor added the comment: I reviewed dict_gdb.patch. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28763] Use en-dashes for ranges in docs

Ezio Melotti added the comment: While you are at it, have you checked how many en-dashes have been used instead of em-dashes? "--" is commonly used to indicate em-dashes (e.g. in emails), but in rst it renders to an en-dash. -- nosy: +ezio.melotti

[issue28761] Add the const qualifier to fields name and doc of public structs

Nick Coghlan added the comment: +1 from me. The only thing I noticed in the patch was that the issue number needs filling in now that you've filed it. -- ___ Python tracker ___

[issue28638] Creating namedtuple is too slow to be used in common stdlib (e.g. functools)

Nick Coghlan added the comment: Ah, I had forgotten that Larry had already included Python support in Argument Clinic. With the inline code auto-generated from the pure Python implementation, that addresses the main maintenance concerns I had. I did briefly wonder about the difficulties of bo

[issue28731] _PyDict_NewPresized() creates too small dict

Serhiy Storchaka added the comment: I think function scope constant is good. Similar code in dictresize() should have different bound. The patch LGTM. -- stage: patch review -> commit review ___ Python tracker __

  1   2   >