[issue27343] Incorrect error message for conflicting initializers of ctypes structure

Roundup Robot added the comment: New changeset ed81fc7e285b by Serhiy Storchaka in branch '3.5': Issue #27343: Fixed error message for conflicting initializers of ctypes.Structure. https://hg.python.org/cpython/rev/ed81fc7e285b New changeset 40e3790c2a00 by Serhiy Storchaka in branch 'default':

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

Serhiy Storchaka added the comment: Thank you for your review Xiang. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

Roundup Robot added the comment: New changeset 4fbcd58df1a0 by Serhiy Storchaka in branch 'default': Issue #27333: Simplified testing step on 0. https://hg.python.org/cpython/rev/4fbcd58df1a0 -- nosy: +python-dev ___ Python tracker

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

Serhiy Storchaka added the comment: Agreed. -- assignee: -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

Roundup Robot added the comment: New changeset 52931189d7ee by Serhiy Storchaka in branch 'default': Issue #27342: Replaced some Py_XDECREFs with Py_DECREFs. https://hg.python.org/cpython/rev/52931189d7ee -- nosy: +python-dev ___ Python tracker

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Serhiy Storchaka added the comment: There are different tricks that allow to minimize an overhead. Here is tuned patch. But I still not sure that this special case is worth to be optimized. -- Added file: http://bugs.python.org/file43445/minidom.insertBefore2.patch ___

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue22228] Adapt bash readline operate-and-get-next function

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue7769] SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decorator

Changes by Xiang Zhang : -- nosy: +loewis, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue22636] avoid using a shell in ctypes.util: replace os.popen with subprocess

STINNER Victor added the comment: No problemo. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue27337] 3.6.0a2 tarball has weird paths

Ned Deily added the comment: OK, thanks for the info. I'm going to close this issue as "won't fix" and try real hard not to do it again. -- resolution: -> wont fix stage: -> resolved status: open -> closed ___ Python tracker

[issue22908] ZipExtFile in zipfile can be seekable

Jürgen A. Erhard added the comment: To add to this (without looking at the patch): I just to my astonishment learned that a ZipExtFile doesn't even support tell(). I can understand the seek being nontrivial... but the tell? It's a bytestream, and there is (isn't there?) a clear definition of

[issue25548] Show the address in the repr for class objects

Martin Panter added the comment: There is also Issue 13224 proposing to change __str__() to just return the __name__ or __qualname__ if I remember correctly. -- nosy: +martin.panter ___ Python tracker

[issue27341] mock.patch decorating a generator returns a regular function.

Shoshana Berleant added the comment: I attached a file with 4 tests and the output. nosetests reports that all four tests were executed. In reality, only two tests were executed. -- Added file: http://bugs.python.org/file43443/silentfail.py ___ Pytho

[issue27341] mock.patch decorating a generator returns a regular function.

Shoshana Berleant added the comment: output -- Added file: http://bugs.python.org/file43444/actual.out ___ Python tracker ___ ___ Pyth

[issue25548] Show the address in the repr for class objects

Peter Eisentraut added the comment: I understand the reasoning here, but I want to say booh to this change in 3.6.0a2 because it breaks my tests. It used to be that type(x) returned a predictable string, and that was an easy way to verify the result types of things. Perhaps a __str__ impleme

[issue27258] Exception in BytesGenerator.flatten

Pedro Lacerda added the comment: Seems that ``token.has_fws`` evaluates to True in the following condition if token.has_fws: causing ``token._fold(self)`` where isn't needed and raising the exception. Hope it helps! By the way, why the _header_value_parser.py was removed from the reposito

[issue27341] mock.patch decorating a generator returns a regular function.

Robert Collins added the comment: There are two related things here. Firstly, the generator's body will run without the patch (because the wrapping function has try: return decorated(..) finally: unpwatch() Secondly, the wrapping function is itself not a generator, and anything that i

[issue27341] mock.patch decorating a generator returns a regular function.

Robert Collins added the comment: Once fixed in CPython, we'll put the backport in mock, for folk using older Python's. -- versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker

[issue7164] pickle test failure after test_imp/test_import (_make_stat_result is not the same object as os._make_stat_result)

Peter Williams added the comment: I'm experiencing a variation of this problem on a project where I'm trying to make an application that will work with both 2.7.x and 3.4.x and am mostly successful. The application uses a number of pickle files and I want to make it so that it doesn't matter wh

[issue22636] avoid using a shell in ctypes.util: replace os.popen with subprocess

Martin Panter added the comment: Sorry about impersonating your name as committer Victor. I have been fixing this problem in recent patches, but because I imported your patch a while ago I forgot about it. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue22636] avoid using a shell in ctypes.util: replace os.popen with subprocess

Roundup Robot added the comment: New changeset a09ae70f3489 by Victor Stinner in branch '2.7': Issue #22636: Avoid using a shell in the ctypes.util module https://hg.python.org/cpython/rev/a09ae70f3489 -- ___ Python tracker

[issue27337] 3.6.0a2 tarball has weird paths

Peter Eisentraut added the comment: The affected tar is indeed a BSD-ish tar (OS X). With GNU tar I can proceed. It says "gtar: Removing leading `../' from member names". So with that I agree that it's not worth rerolling this release. -- ___ Pyth

[issue27292] Warn users that os.urandom() can return insecure values

Martin Panter added the comment: Restored “On Linux” for the changed in 3.5.2 notice. I do think it is better to be general and future-proof, but that is a separate, less important issue to the main purpose of the patch. (I don’t know if Solaris’s version can block or not.) -- stage:

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

Roundup Robot added the comment: New changeset 61bd6974405f by Berker Peksag in branch 'default': Issue #27312: Fix TypeError in test_setupapp https://hg.python.org/cpython/rev/61bd6974405f -- ___ Python tracker __

[issue27344] zipfile *does* support utf-8 filenames

Terry J. Reedy added the comment: There is a difference between 'official' and 'supported', and I don't quite know what you mean by the latter. -- nosy: +terry.reedy ___ Python tracker

[issue27341] mock.patch decorator fails silently on generators

Terry J. Reedy added the comment: 3.2 to 3.4 only get security fixes please provide a simple test that fails now and that you think should pass or at least warn. -- nosy: +michael.foord, terry.reedy stage: -> test needed ___ Python tracker

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

Terry J. Reedy added the comment: My suggested mock was for the wrong function. Please let me know what happens next time you pull and run test_idle whether alone or with the suite. -- ___ Python tracker

[issue27312] test_setupapp (idlelib.idle_test.test_macosx.SetupTest) fails on OS X

Roundup Robot added the comment: New changeset 90fd1c17214b by Terry Jan Reedy in branch 'default': Issue #27312: mock out function that fails when called from setupApp during https://hg.python.org/cpython/rev/90fd1c17214b -- nosy: +python-dev ___ Pyt

[issue27309] Visual Styles support to tk/tkinter file and message dialogs

Terry J. Reedy added the comment: tkinter.messagebox is based on tkinter.commondialog, first written in 1997. Since it works as originally designed, it does not seem to have been significantly altered since before themed widgets. Upgrading would be an enhancement for future versions, not a bug

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Martin Panter added the comment: Thanks Berker. In this case the previous tests using the same NNTP connection object were skipped. First run: test_unknown_command (test.test_nntplib.NetworkedNNTPTests) ... ok test_welcome (test.test_nntplib.NetworkedNNTPTests) ... ok test_with_statement (test.

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

Raymond Hettinger added the comment: v2 looks correct. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue26923] asyncio.gather drops cancellation

Guido van Rossum added the comment: Thanks! I had eventually pieced together the same explanation. So yes, I think your fix is right, though I would write it like this: ret = False for child in self._children: ret |= child.cancel() return ret # True if at lea

[issue19756] test_nntplib: sporadic failures, network isses? server down?

Berker Peksag added the comment: I just saw the same test failures at http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.5/builds/998/steps/test/logs/stdio I'm attaching the test logs for future reference. -- nosy: +berker.peksag stage: -> needs patch type: -> behavior

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Robert Haschke added the comment: I don't see how to further minimize the checks - all of them are required. I think, the most common uses cases to create a document are appendChild(), which is not affected, and insertBefore() using the same refChild for a while. In that case, the patch gives

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

James Paget added the comment: The 2.7.12rc1+ build resolves the issue for me. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

Steve Dower added the comment: All looked good to me, and as far as I could see all of Berker's feedback was addressed, so consider it in! -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ P

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

Roundup Robot added the comment: New changeset f8957c755c7a by Steve Dower in branch 'default': Issue #26536: socket.ioctl now supports SIO_LOOPBACK_FAST_PATH. Patch by Daniel Stokes. https://hg.python.org/cpython/rev/f8957c755c7a -- nosy: +python-dev __

[issue27048] distutils._msvccompiler._get_vc_env() fails with UnicodeDecodeError if an env var is not encodable

Eryk Sun added the comment: vcvarsall.bat is mostly `set` and `echo` statements, which print using UTF-16LE with "/u". It also runs reg.exe, but with stdout and stderr redirected to nul, so that's no problem. The final `set` command prints cmd's UTF-16LE environment. Using errors='replace' sho

[issue27344] zipfile *does* support utf-8 filenames

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch versions: +Python 3.5 ___ Python tracker ___ ___ Pytho

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Serhiy Storchaka added the comment: This slow down is not such small -- up to 25% for every insertBefore(). If most calls of insertBefore() are not with the same refChild, the benefit from the optimization of one special case can be dwarfed. Try to minimize the overhead of the optimization. If

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

Steve Dower added the comment: Just made another "release" build from the latest source (with OpenSSL 1.0.2h) and can no longer repro this issue, so I'm closing it. If anyone wants to try with the same build, it will be up at https://ptvs.blob.core.windows.net/temp/python-2.7.12.amd64.msi for

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

Changes by Aaron Meurer : -- nosy: +Aaron.Meurer ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue27048] distutils._msvccompiler._get_vc_env() fails with UnicodeDecodeError if an env var is not encodable

Steve Dower added the comment: Oh, and before anyone asks, I used "errors='replace'" because we get all the env variables but don't use most of them. If we do end up needing one that can't be decoded, this should make it obvious, but there's no point failing early because of a variable that we

[issue27048] distutils._msvccompiler._get_vc_env() fails with UnicodeDecodeError if an env var is not encodable

Steve Dower added the comment: I went ahead and updated the subprocess call just in _msvccompiler to use cmd /u, as I like that fix. Not so keen on doing it for all subprocess(shell=True) calls, since we can't reliably predict whether the output will actually respect the option. -- as

[issue27048] distutils._msvccompiler._get_vc_env() fails with UnicodeDecodeError if an env var is not encodable

Roundup Robot added the comment: New changeset 15900c612ca7 by Steve Dower in branch '3.5': Issue #27048: Prevents distutils failing on Windows when environment variables contain non-ASCII characters https://hg.python.org/cpython/rev/15900c612ca7 New changeset bb22ae1e1bcd by Steve Dower in bra

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Robert Haschke added the comment: Indeed there is a small slow down for insertion at the beginning. However, this is simply due to the extra function _index() and thus linear in the number of insertion operations. My patch essentially boosts insertions before /any fixed/ node. If this reference

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

Steve Dower added the comment: A build issue like that is fairly likely - I don't touch 2.7 apart from releases and so all I did was restart my build VM, pull and hit rebuild. There may be another clean step required when the OpenSSL version changes. We're getting another update before the fin

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

Xiang Zhang added the comment: Thanks for review. Eliminate the wrongs ones. -- Added file: http://bugs.python.org/file43440/cleanup_some_xdecrefs_v2.patch ___ Python tracker ___

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

Xiang Zhang added the comment: This looks fine. But maybe code like this looks more clear: if (step && _PyLong_Sign(step) == 0) { PyErr_SetString(PyExc_ValueError, "range() arg 3 must not be zero"); Py_CLEAR(step); } I think assert(PyLong_Check(step)) can be left out

[issue27344] zipfile *does* support utf-8 filenames

New submission from Daniel Holth: The zipfile documentation says "There is no official file name encoding for ZIP files." However ZIP and zipfile supports utf-8 filenames; this has been true for a long time, at least since Python 2.7. -- assignee: docs@python components: Documentation

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file43439/etree_example.py ___ Python tracker ___ ___ Python-bugs-list mailin

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Serhiy Storchaka added the comment: Thank you for your example Robert. If modify your example for inserting new nodes before the first one, it shows the slowdown with your patch. $ ./python minidom_example2.py old new oldtime for 5000 iterations: 0.189058 newtime for 5000 iterations: 0.254402

[issue18373] let code force str(bytes) to raise an exception

Daniel Holth added the comment: What if we changed it so that Python code could only disable str_bytes() process-wide, editing the original flag? Would that be fatal to debuggers and the repl? -- ___ Python tracker

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

Serhiy Storchaka added the comment: Mostly good except longrangeiter_dealloc(). -- components: +Interpreter Core nosy: +mark.dickinson stage: -> patch review type: -> enhancement versions: +Python 3.6 ___ Python tracker

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

Serhiy Storchaka added the comment: Current code is valid, since neither PY_SSIZE_MAX nor PY_SSIZE_MIN equal to 0. But testing on 0 can be simpler. Following patch simplifies the code. -- nosy: +mark.dickinson stage: -> patch review type: behavior -> enhancement versions: -Python 2.7,

[issue24424] xml.dom.minidom: performance issue with Node.insertBefore()

Robert Haschke added the comment: I uploaded a simple example to illustrate the tremendous performance boost. Obviously, the example exploits the caching improvement as much as possible: The code assembles a XML document by inserting new nodes before the last one... These are the timing results

[issue27298] redundant iteration over digits in _PyLong_AsUnsignedLongMask

Changes by Oren Milman : Added file: http://bugs.python.org/file43435/proposedPatches.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue27298] redundant iteration over digits in _PyLong_AsUnsignedLongMask

Changes by Oren Milman : Added file: http://bugs.python.org/file43434/badMicroBenchProposedPatches.diff ___ Python tracker ___ ___ Python-bugs

[issue27298] redundant iteration over digits in _PyLong_AsUnsignedLongMask

Oren Milman added the comment: I did some micro-benchmarking, and it looks like bad news for my patch. I wrote a simple C extension in order to call PyLong_AsUnsignedLongMask and PyLong_AsUnsignedLongLongMask from Python code (attached). Then I ran the following micro-benchmarks using both the

[issue27213] Rework CALL_FUNCTION* opcodes

Demur Rumed added the comment: I've been working on this, may have the ceval portion mostly worked out but can't test until I finish the compile portion. Haven't had time this week, will have time to focus this weekend -- ___ Python tracker

[issue15243] Misleading documentation for __prepare__

Jaysinh shukla added the comment: Submitting patch according to this (http://bugs.python.org/issue15243#msg268356) message. Thanks! -- keywords: +patch nosy: +jaysinh.shukla Added file: http://bugs.python.org/file43432/issue15243_diff_python3.5_3.6_v1.diff

[issue23360] Content-Type when sending data with urlopen()

Changes by Serhiy Storchaka : -- nosy: +orsenthil, r.david.murray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

Roundup Robot added the comment: New changeset cbe977fd306f by Victor Stinner in branch 'default': Issue #27336: Fix compilation on Windows https://hg.python.org/cpython/rev/cbe977fd306f -- ___ Python tracker _

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

Berker Peksag added the comment: Thanks for the report. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file43431/ctypes_conflictin_initializers_error_message.patch ___ Python tracker ___

[issue27336] --without-threads build fails due to undeclared _PyGILState_check_enabled

Roundup Robot added the comment: New changeset 2baaf7e31b13 by Berker Peksag in branch 'default': Issue #27336: Fix compilation failures --without-threads https://hg.python.org/cpython/rev/2baaf7e31b13 -- nosy: +python-dev ___ Python tracker

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file43430/ctypes_conflictin_initializers_error_message.patch ___ Python tracker ___ __

[issue27307] string.Formatter does not support key/attribute access on unnumbered fields

Changes by Ned Deily : -- nosy: +eric.smith stage: -> patch review versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker ___

[issue12319] [http.client] HTTPConnection.request not support "chunked" Transfer-Encoding to send data

Martin Panter added the comment: FYI instead of changing the helper into a static method, I think you could have just called http.client._get_content_length(). I don’t understand why we need the new encode_chunked=True flag. Can’t urllib.request leave the Transfer-Encoding field up to http.cli

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

Changes by Berker Peksag : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue27273] subprocess.run(cmd, input='text') should pass universal_newlines=True to Popen

Changes by Ned Deily : -- nosy: +gregory.p.smith stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue18751] A manager's server never joins its threads

Changes by Ned Deily : -- nosy: +davin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/

[issue27333] validate_step in rangeobject.c, incorrect code logic but right result

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue27330] Possible leaks in ctypes

Serhiy Storchaka added the comment: Thank you for your review Martin! Committed with your fixes. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue27343] Incorrect error message for conflicting initializers of ctypes structure

New submission from Serhiy Storchaka: >>> from ctypes import * >>> class POINT(Structure): ... _fields_ = [("x", c_int), ("y", c_int)] ... >>> POINT(2, 3, x=4) Traceback (most recent call last): File "", line 1, in TypeError: duplicate values for field '???' The name of conflicting field

[issue27305] Crash with "pip list --outdated" on Windows 10 with Python 2.7.12rc1

Christoph Gohlke added the comment: FWIW, this could be a build issue: 1) `_ssl.OPENSSL_VERSION` for the 2.7.12rc1 amd64 binaries is "OpenSSL 1.0.2d 9 Jul 2015", not OpenSSL 1.0.2g as expected from the changelog at . 2) Rebuilding _s

[issue27342] Clean up some Py_XDECREFs in rangeobject.c and bltinmodule.c

New submission from Xiang Zhang: Some Py_XDECREFs in rangeobject.c and bltinmodule.c are not necessary. Py_DECREF is enough. Clean up them. -- files: cleanup_some_xdecrefs.patch keywords: patch messages: 268711 nosy: xiang.zhang priority: normal severity: normal status: open title: Clea