[issue24620] Segfault with nonsensical random state

2015-07-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue24620] Segfault with nonsensical random state

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0933c00c2765 by Serhiy Storchaka in branch '3.4': Issue #24620: Random.setstate() now validates the value of state last element. https://hg.python.org/cpython/rev/0933c00c2765 New changeset 84070c1225c5 by Serhiy Storchaka in branch '2.7': Issue #24

[issue24302] Dead Code of Handler check in function faulthandler_fatal_error()

2015-07-23 Thread Pankaj Sharma
Changes by Pankaj Sharma : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch makes set_add_entry() inconsistent not only with dict, but with other set methods that use set_lookkey(). I don't know if there is some subtle bug here, but I feel myself slightly uncomfortable with it. Also the new code looks a little less readabl

[issue24659] dict() built-in fails on iterators with a "keys" attribute

2015-07-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- priority: normal -> low stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue24620] Segfault with nonsensical random state

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: This is ready to apply. -- assignee: rhettinger -> serhiy.storchaka ___ Python tracker ___ ___ Py

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Serhiy, do you see anything actually wrong with the patch? If it isn't broken in some clear cut way, I'm going to apply it shortly. The comparison with dict internals is a red herring -- there is no promise need or precedent for making that code exactly t

[issue24300] Code Refactoring in function nis_mapname()

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: It is perfectly reasonable to make refactorings. -- resolution: -> fixed status: open -> closed versions: +Python 3.6 -Python 3.4 ___ Python tracker ___

[issue24703] Resource Leak

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4fc7b803ac00 by Serhiy Storchaka in branch '2.7': Issue #24703: Fixed resource leak on error in bsddb.verify(). https://hg.python.org/cpython/rev/4fc7b803ac00 -- nosy: +python-dev ___ Python tracker

[issue24703] Resource Leak

2015-07-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue24703] Resource Leak

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Otherwise the patch LGTM. -- assignee: -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker ___ __

[issue24703] Resource Leak

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Spaces should be used instead tabs for indenting. -- nosy: +serhiy.storchaka stage: -> patch review type: -> resource usage ___ Python tracker _

[issue24300] Code Refactoring in function nis_mapname()

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch doesn't fix any bug. Usually we avoid changing source code without need. -- nosy: +serhiy.storchaka ___ Python tracker ___

[issue24702] Uninitialised Pointer buf.outobj

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset ba8ab143f4e6 by Serhiy Storchaka in branch '2.7': Initialize buf.outobj in multibyte encoder (closes issue #24702). https://hg.python.org/cpython/rev/ba8ab143f4e6 -- nosy: +python-dev ___ Python tracker

[issue24702] Uninitialised Pointer buf.outobj

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Committed in ba8ab143f4e6. Thank you for your contribution pankaj.s01 (could you please specify your real name?). -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker

[issue24300] Code Refactoring in function nis_mapname()

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3bbd0cbfe836 by Raymond Hettinger in branch 'default': Issue #24300: Minor refactoring. https://hg.python.org/cpython/rev/3bbd0cbfe836 -- nosy: +python-dev ___ Python tracker

[issue24703] Resource Leak

2015-07-23 Thread pankaj.s01
New submission from pankaj.s01: Hi, There is an issue of resource leak of file descriptor "outFile" in Python-2.7.10 ,file :Python-2.7.10/Modules/_bsddb.c:3456. variable "outFile" is going out of scope which leaks the storage.So need to close file before return on error. I have attached the pat

[issue24300] Code Refactoring in function nis_mapname()

2015-07-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24702] Uninitialised Pointer buf.outobj

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Ah, sorry, this is 2.7 only. The patch LGTM for 2.7. -- assignee: -> serhiy.storchaka resolution: not a bug -> stage: resolved -> commit review status: closed -> open type: -> crash ___ Python tracker

[issue24702] Uninitialised Pointer buf.outobj

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The MultibyteDecodeBuffer structure doesn't have the outobj field. -- nosy: +pankaj.s01, serhiy.storchaka resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue24702] Uninitialised Pointer buf.outobj

2015-07-23 Thread pankaj.s01
Changes by pankaj.s01 : -- nosy: +benjamin.peterson -pankaj.s01 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24300] Code Refactoring in function nis_mapname()

2015-07-23 Thread pankaj.s01
Changes by pankaj.s01 : -- nosy: +benjamin.peterson -pankaj.s01 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24485] Function source inspection fails on closures

2015-07-23 Thread Meador Inge
Meador Inge added the comment: Thanks Yury! I have committed my patches to 3.5 and default. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue24485] Function source inspection fails on closures

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5400e21e92a7 by Meador Inge in branch '3.5': Issue #24485: Function source inspection fails on closures. https://hg.python.org/cpython/rev/5400e21e92a7 New changeset 0e7d64595223 by Meador Inge in branch 'default': Issue #24485: Function source insp

[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5400e21e92a7 by Meador Inge in branch '3.5': Issue #24485: Function source inspection fails on closures. https://hg.python.org/cpython/rev/5400e21e92a7 New changeset 0e7d64595223 by Meador Inge in branch 'default': Issue #24485: Function source insp

[issue24702] Uninitialised Pointer buf.outobj

2015-07-23 Thread pankaj.s01
New submission from pankaj.s01: Hi , Reporting an issue of uninitialized pointer "buf.outobj" in python-2.7.x . I have attached patch ,please check and review it. Thanks! -- components: Extension Modules, Library (Lib) files: Python-2.7.10-multibytecodec.patch keywords: patch messages:

[issue9850] obsolete macpath module dangerously broken and should be removed

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: In third-party code the path manipulating functions can be used in unexpected manner than doesn't relate to paths on MacOS. Also "import macpath" can be left even with the use of macpath was eliminated or are dead code. There is a chance to break third-party

[issue24695] Don't print traceback header if traceback is None in TracebackException

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: This patch looks correct, applies cleanly, and passes tests. -- nosy: +rhettinger ___ Python tracker ___

[issue24701] list.pop() removes items from multiple lists

2015-07-23 Thread R. David Murray
R. David Murray added the comment: https://docs.python.org/3/faq/programming.html#why-did-changing-list-y-also-change-list-x -- nosy: +r.david.murray resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker

[issue24701] list.pop() removes items from multiple lists

2015-07-23 Thread annoywife
New submission from annoywife: When executing the following code, I would expect the 3 to be removed from "list_copy" while "list_original" remains unaltered. However, list_copy.pop() removes the 3 from both lists. If an index is specified for pop, this behavior occurs as well. list_origina

[issue24700] array compare is hideously slow

2015-07-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- versions: +Python 3.6 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue22000] cross type comparisons clarification

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Why do we need a dedicated section in Built-in Types about Comparisons? It is nice to have some of that information collected together. I think people learn about comparison logic as a single topic rather than piecemeal type by type. To Jim's point, the

[issue24685] collections.OrderedDict collaborative subclassing

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Eric, I believe you're profoundly misunderstanding my Pycon talk. The posted code is not expected "to work if I swap the order of the classes around" -- MRO's are controlled by the child classes (subject to a number of constraints) and the order classes ar

[issue24700] array compare is hideously slow

2015-07-23 Thread Josh Rosenberg
Josh Rosenberg added the comment: You're correct about what is going on; aside from bypassing a bounds check (when not compiled with asserts enabled), the function it uses to get each index is the same as that used to implement indexing at the Python layer. It looks up the getitem function app

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-07-23 Thread Russell Keith-Magee
Russell Keith-Magee added the comment: What hardware architecture are you compiling for? If it's ARM64, and you're not using a trunk version of libffi, that segfault in test_ctypes is to be expected. -- ___ Python tracker

[issue24700] array compare is hideously slow

2015-07-23 Thread swanson
New submission from swanson: Comparing two array.array objects is much slower than it ought to be. The whole point of array.array is to be efficient: "array — Efficient arrays of numeric values" But comparing them is orders of magnitude less efficient than comparing tuples or lists of numbers

[issue24699] TemporaryDirectory is cleaned up twice

2015-07-23 Thread Ilya Kulakov
New submission from Ilya Kulakov: I'm seeing the issue using python 3.4.3 on Windows 8 In the __init__.py method of my package I define temporary directory at the module level like this: _TempDir = tempfile.TemporaryDirectory(prefix='...')) tempfile.tempdir = _TempDir.name I expect it to be

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-07-23 Thread Cyd Haselton
Cyd Haselton added the comment: Build complete. Unfortunately while some of the tests complete successfully, the run ends in a segfault (see attached log) -- Added file: http://bugs.python.org/file40002/py_test_results.log ___ Python tracker

[issue10708] Misc/porting should be folded into the development FAQ or the devguide

2015-07-23 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue24695] Don't print traceback header if traceback is None in TracebackException

2015-07-23 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch. I was pretty sure that I've already created an issue for this but couldn't find it now. -- keywords: +patch nosy: +berker.peksag stage: needs patch -> patch review Added file: http://bugs.python.org/file40001/issue24695.diff ___

[issue24697] Add CoroutineReturn and CoroutineExit builtin exceptions for coroutines

2015-07-23 Thread Stefan Behnel
Stefan Behnel added the comment: > Hm, I think there's little need for new exceptions... While I agree with Yuri that the names are a bit awkward, I actually second this. The StopIteration is almost an implementation detail of how the return value is passed on to become the (Future) result of

[issue24697] Add CoroutineReturn and CoroutineExit builtin exceptions for coroutines

2015-07-23 Thread Guido van Rossum
Guido van Rossum added the comment: Hm, I think there's little need for new exceptions... -- ___ Python tracker ___ ___ Python-bugs-li

[issue24685] collections.OrderedDict collaborative subclassing

2015-07-23 Thread Eric Frederich
Eric Frederich added the comment: Attached, as inj3.py, is a version I made which seems to work with Python2 but not with Python3's C implementation of OrderedDict. I had to walk the MRO myself to get the unbound method to pass along as dict_setitem. With Python3 it doesn't look like doing th

[issue24697] Add CoroutineReturn and CoroutineExit builtin exceptions for coroutines

2015-07-23 Thread Yury Selivanov
Yury Selivanov added the comment: > What problem does this solve? Only avoiding confusion, because coroutines now have a separate type, lack __iter__, and thus are quite different (on the surface) from generators. The fact that 'coro.send(..)' raises StopIteration (when coroutines aren't iter

[issue24698] get_externals.bat script fails

2015-07-23 Thread Steve Dower
Steve Dower added the comment: Apparently you've installed SVN differently and you're calling svn.bat (or svn.cmd) instead of svn.exe. Adding call there should not cause a problem for people who have svn.exe, but Alex, I suggest you try running "where svn" to make sure you are actually invoki

[issue24698] get_externals.bat script fails

2015-07-23 Thread R. David Murray
R. David Murray added the comment: This script has been working for a long time, and while it was updated recently there was no 'call' previously either. What environment are you experiencing a hang in? -- components: +Windows nosy: +paul.moore, r.david.murray, steve.dower, tim.golden

[issue24685] collections.OrderedDict collaborative subclassing

2015-07-23 Thread Eric Frederich
Changes by Eric Frederich : Added file: http://bugs.python.org/file3/inj2.py ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue24685] collections.OrderedDict collaborative subclassing

2015-07-23 Thread Eric Frederich
Changes by Eric Frederich : Removed file: http://bugs.python.org/file39998/inj2.py ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue24685] collections.OrderedDict collaborative subclassing

2015-07-23 Thread Eric Frederich
Eric Frederich added the comment: Raymond, Thanks for the explanation of your reasoning. Could you please provide an example of how to create a cooperative subclass of OrderedDict? I have attempted to make one. I succeeded to make it work where the previous example failed but in doing made th

[issue24698] get_externals.bat script fails

2015-07-23 Thread Alex Budovski
New submission from Alex Budovski: The svn commands need to be wrapped with "call", otherwise the batch interpreter hangs. Attached simple fix. -- files: externalsfix.diff keywords: patch messages: 247223 nosy: Alex Budovski priority: normal severity: normal status: open title: get_exte

[issue10708] Misc/porting should be folded into the development FAQ or the devguide

2015-07-23 Thread Carol Willing
Carol Willing added the comment: I reviewed the patch for this issue, and it looks ready to commit. If one of the core devs could do the commit review/merge, we can close out this issue :) Thanks Paul for your contribution. The patch looks good. As a tip for the future, it's helpful if you men

[issue24455] IDLE debugger causes crash if not quitted properly before next run

2015-07-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Thank you for testing this. I am hoping that you left the patch applied for testing in routine use. I an now reviewing the code so I can understand it well enough to apply, and to see what non-debug functions might possibly be affected, and need testing with

[issue24695] Don't print traceback header if traceback is None in TracebackException

2015-07-23 Thread Robert Collins
Robert Collins added the comment: Huh,indeed. So clearly we should have a test for that behaviour (and fix it). We're very close to the 3.5 release date, but this is a regression - care to whip up a patch? -- ___ Python tracker

[issue21750] mock_open data is visible only once for the life of the class

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 83e28ee348bf by Robert Collins in branch '3.4': Issue #21750: Further fixup to be styled like other mock APIs. https://hg.python.org/cpython/rev/83e28ee348bf New changeset b30fc1de006c by Robert Collins in branch '3.5': Issue #21750: Further fixup t

[issue24651] Mock.assert* API is in user namespace

2015-07-23 Thread Erik Bray
Changes by Erik Bray : -- nosy: +erik.bray ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue24697] Add CoroutineReturn and CoroutineExit builtin exceptions for coroutines

2015-07-23 Thread Guido van Rossum
Guido van Rossum added the comment: What problem does this solve? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Added comments on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue24697] Add CoroutineReturn and CoroutineExit builtin exceptions for coroutines

2015-07-23 Thread Guido van Rossum
Guido van Rossum added the comment: What problem does this solve? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

2015-07-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue24695] Don't print traceback header if traceback is None in TracebackException

2015-07-23 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +rbcollins ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue2091] file accepts 'rU+' as a mode

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I would add a warning in 3.4- (or 3.5-). The 'U' mode should not work with '+', and it can't work with '+' correctly. This is a bug that we can decide not fix by raising an exception. -- ___ Python tracker

[issue24697] Add CoroutineReturn and CoroutineExit builtin exceptions for coroutines

2015-07-23 Thread Yury Selivanov
New submission from Yury Selivanov: Since native coroutines (see PEP 492) hadn't had a separate type when the PEP was accepted, we didn't discuss that it might be necessary to introduce new exception types specifically for coroutines. To maintain backwards compatibility with 3.5, I think we ca

[issue2091] file accepts 'rU+' as a mode

2015-07-23 Thread Robert Collins
Robert Collins added the comment: @Larry - should this go in 3.5, or would you rather it not? -- nosy: +larry ___ Python tracker ___ __

[issue21750] mock_open data is visible only once for the life of the class

2015-07-23 Thread Robert Collins
Robert Collins added the comment: Discussed with Michael Foord; we're going to go with the -2 patch - the new behaviour. -- ___ Python tracker ___ __

[issue24695] Don't print traceback header if traceback is None in TracebackException

2015-07-23 Thread R. David Murray
Changes by R. David Murray : -- stage: -> needs patch title: Don't print traceback header if traceback is None -> Don't print traceback header if traceback is None in TracebackException versions: +Python 3.6 ___ Python tracker

[issue24694] callables registered in TestCase.addCleanup should be run before tearDown

2015-07-23 Thread Robert Collins
Robert Collins added the comment: So yeah - setup + cleanup is LIFO. setup + teardown *can* be LIFO [depends on where you upcall] setup + teardown + cleanup CANNOT be LIFO in all cases: we have to pick one, and either local-first or local-last. So it is ultimately somewhat arbitrary and trans

[issue24696] Don't use None as sentinel for traceback

2015-07-23 Thread Adam Bartoš
New submission from Adam Bartoš: There is a subtle bug in Python 3.4 implementation of traceback library: >>> import traceback >>> >>> try: ... 1 / 0 ... except Exception as e: ... exc = e ... >>> traceback.print_exception(exc.__class__, exc, exc.__traceback__) Traceback (most recent cal

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

2015-07-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file39996/py36_base32hex.patch ___ Python tracker ___ ___ Python-bugs-list ma

[issue13248] deprecated in 3.2/3.3, should be removed in 3.5 or ???

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 558199e060fd by Yury Selivanov in branch 'default': Issue #13248: Remove inspect.getmoduleinfo() from 3.6 (deprecated in 3.3) https://hg.python.org/cpython/rev/558199e060fd -- ___ Python tracker

[issue24695] Don't print traceback header if traceback is None

2015-07-23 Thread Adam Bartoš
New submission from Adam Bartoš: The documentation of traceback.print_exception says "if traceback is not None, it prints a header Traceback (most recent call last):". That also meant that the header wasn't printed if traceback was None. However, the new Python 3.5 TracebackException object al

[issue13248] deprecated in 3.2/3.3, should be removed in 3.5 or ???

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset a565aad5d6e1 by Yury Selivanov in branch 'default': Issue #13248: Remove inspect.getargspec from 3.6 (deprecated from 3.0) https://hg.python.org/cpython/rev/a565aad5d6e1 -- ___ Python tracker

[issue24689] Add tips for effective online communication to devguide

2015-07-23 Thread Carol Willing
Carol Willing added the comment: Ezio and Stephen, The "content" that you are brainstorming here is very helpful, and I'm learning new resources and detail from it. I've learned something from Ezio's link to Nick's post on python-committers. I'm not a core developer so I'm not subscribed to t

[issue16995] Add Base32 support for RFC4648 "Extended Hex" alphabet (patch attached)

2015-07-23 Thread Matthäus Wander
Matthäus Wander added the comment: *facepalm* Yes, I uploaded the old patch twice. Sorry for that. - Added doc update. - Added test case that includes all 32 characters codes. I'm reusing the existing Base32 table generation logic without changes. It has been changed (in 3.4 or so) since the f

[issue24694] callables registered in TestCase.addCleanup should be run before tearDown

2015-07-23 Thread Charles-François Natali
Charles-François Natali added the comment: I understand the risk of breakeage, but that's still broken, because we break LIFO ordering. I'd been using addCleanup() for years and never bothered looking at the documentation - which is admitedly a mistake - because LIFO ordering is the natural beha

[issue24485] Function source inspection fails on closures

2015-07-23 Thread Yury Selivanov
Yury Selivanov added the comment: Meador, I've reverted changes introduced in #21217 -- I don't want to risk shipping 3.5beta4 with broken backwards compatibility. Feel free to rebase & commit your patch (I decorated test_decorator_with_lambda with @unittest.expectedFailure). --

[issue24485] Function source inspection fails on closures

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4e42a62d5648 by Yury Selivanov in branch '3.5': Issue #24485: Revert backwards compatibility breaking changes of #21217. https://hg.python.org/cpython/rev/4e42a62d5648 New changeset 98a2bbf2cce2 by Yury Selivanov in branch 'default': Merge 3.5 (issu

[issue21217] inspect.getsourcelines finds wrong lines when lambda used argument to decorator

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4e42a62d5648 by Yury Selivanov in branch '3.5': Issue #24485: Revert backwards compatibility breaking changes of #21217. https://hg.python.org/cpython/rev/4e42a62d5648 New changeset 98a2bbf2cce2 by Yury Selivanov in branch 'default': Merge 3.5 (issu

[issue24694] callables registered in TestCase.addCleanup should be run before tearDown

2015-07-23 Thread Yury Selivanov
Yury Selivanov added the comment: > But I guess that ship has sailed... Closing the issue. -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___

[issue24694] callables registered in TestCase.addCleanup should be run before tearDown

2015-07-23 Thread Robert Collins
Robert Collins added the comment: Argh, and my memory had things inverted. Anyhow - the inheritance story was the big thing, and -1 on changing. -- ___ Python tracker ___ __

[issue24694] callables registered in TestCase.addCleanup should be run before tearDown

2015-07-23 Thread Robert Collins
Robert Collins added the comment: The ordering is deliberate to support folk migrating from tearDown to cleanups - its not a bug. I thought we documented it clearly - https://docs.python.org/dev/library/unittest.html#unittest.TestCase.doCleanups - but if you wanted to submit improvements to th

[issue24694] callables registered in TestCase.addCleanup should be run before tearDown

2015-07-23 Thread Yury Selivanov
Yury Selivanov added the comment: This is a documented behaviour, changing it would likely break too much code. Moreover, I don't think that calling addCleanup callbacks before tearDown makes more sense than after. tearDown is a common cleanup method for all tests of testcase, and addCleanup

[issue21750] mock_open data is visible only once for the life of the class

2015-07-23 Thread Robert Collins
Robert Collins added the comment: @Paul So the problem is that its never been a high fidelity thing in that sense In that: 3.3 -> read() is a constant for the thing opened from the mock 3.4 -> read() works once and only once across all opened files from the mock 3.5 today -> read() works on

[issue24694] callables registered in TestCase.addCleanup should be run before tearDown

2015-07-23 Thread Charles-François Natali
New submission from Charles-François Natali: Consider this code: - from __future__ import print_function from pyccp.unittest import SafeTestCase class MyTest(SafeTestCase): def setUp(self): print("setUp") def tearDown(self)

[issue21750] mock_open data is visible only once for the life of the class

2015-07-23 Thread Michael Foord
Michael Foord added the comment: So the problem with the testing-cabal issue 280 is *really* a problem with decorators - the decorator is applied at method creation time and mock_open is only called once rather than once *per call*. Better would be to use mock.patch as a context manager inside

[issue2091] file accepts 'rU+' as a mode

2015-07-23 Thread R. David Murray
R. David Murray added the comment: I agree, a change that emits an error where none was emitted before should only go in the next release. With a what's new entry. It is possible there should be a deprecation or -3 warning in 2.7, but I'm not sure it is worth the effort. -- nosy: +r.

[issue24690] find_executable should expand ~

2015-07-23 Thread R. David Murray
R. David Murray added the comment: Agree with Eric. Use expanduser if you want the ~ expanded. -- nosy: +r.david.murray resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker _

[issue24692] types.coroutines() idempotence documentation

2015-07-23 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue24692] types.coroutines() idempotence documentation

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 636ce05ea8f6 by Yury Selivanov in branch '3.5': Issue #24692: Add more tests for types.coroutine https://hg.python.org/cpython/rev/636ce05ea8f6 New changeset 3f3e398bcd3e by Yury Selivanov in branch 'default': Merge 3.5 (Issue #24692) https://hg.pyt

[issue24686] zipfile is intolerant of extra bytes

2015-07-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Opened issue24693 about exception type. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue24693] zipfile: change RuntimeError to more appropriate exception type

2015-07-23 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: RuntimeError is raised in the zipfile module in many cases where more appropriate exception type is expected. Proposed patch changes a number of RuntimeErrors to one of BadZipFile, NotImplementedError, or ValueError. Only changing to NotImplementedError is

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : Added file: http://bugs.python.org/file39993/move_likely_first.diff ___ Python tracker ___ ___ Python-bugs-list

[issue24619] async/await parser issues

2015-07-23 Thread Yury Selivanov
Changes by Yury Selivanov : -- resolution: -> fixed stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : Removed file: http://bugs.python.org/file39992/move_likely_first.diff ___ Python tracker ___ ___ Python-bugs-li

[issue24619] async/await parser issues

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset d03f86e41066 by Yury Selivanov in branch '3.5': Issue #24619: Simplify async/await tokenization. https://hg.python.org/cpython/rev/d03f86e41066 New changeset 3f8048926690 by Yury Selivanov in branch 'default': Merge 3.5 (Issue #24619) https://hg.pyt

[issue18181] PEP447: Add type.__getdescriptor__

2015-07-23 Thread Ronald Oussoren
Ronald Oussoren added the comment: Updated the title and versions, will work on an updated PEP and patch during and after EP'15. -- title: PEP447: Add type.__locallookup__ -> PEP447: Add type.__getdescriptor__ versions: +Python 3.6 -Python 3.4 ___ Py

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : Added file: http://bugs.python.org/file39992/move_likely_first.diff ___ Python tracker ___ ___ Python-bugs-list

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: serhiy.storchaka -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset bc80c783c4ab by Raymond Hettinger in branch 'default': Issue #24681: Move the store of so->table to the code block where it is used. https://hg.python.org/cpython/rev/bc80c783c4ab -- nosy: +python-dev __

[issue24681] Put most likely test first in set_add_entry()

2015-07-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Sets are under no obligation to keep their code synced with dicts and have over time diverged in a number of ways. -- ___ Python tracker ___

[issue24692] types.coroutines() idempotence documentation

2015-07-23 Thread Antoine Pietri
New submission from Antoine Pietri: In the new types.coroutines() documentation, it is not clearly stated whether this function is idempotent or not: what happens when it is called on a function that is already a native coroutine? -- assignee: docs@python components: Documentation mess

  1   2   >