[issue24275] lookdict_* give up too soon

2015-05-23 Thread Dmitry Kazakov
Changes by Dmitry Kazakov : -- nosy: +vlth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue24275] lookdict_* give up too soon

2015-05-23 Thread Jim Jewett
New submission from Jim Jewett: The specialized lookdict_* variants replace themselves with the generic lookdict as soon as a non-unicode key is looked up. They could reasonably leave the replacement to insertdict (line 819, currently assert rather than a replacement), when a non-unicode key

[issue24274] erroneous comments in dictobject.c

2015-05-23 Thread Jim Jewett
New submission from Jim Jewett: https://hg.python.org/cpython/file/2df7c958974e/Objects/dictobject.c#l451 The comments near lookdict suggest that specialized versions such as lookdict_unicode and lookdict_unicode_nodummy cannot return NULL, as that would indicate an Exception was raised during

[issue14373] C implementation of functools.lru_cache

2015-05-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Unfortunately the patch caused a crash in test_ipaddress. Larry granted special exclusion for adding this feature after feature freeze if it will be fixed before beta 2. -- ___ Python tracker

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Jim Jewett
Jim Jewett added the comment: Should dictobject.h get a bit more changes? In particular, should the following be expanded? #define PyDictKeys_Check(op) (Py_TYPE(op) == &PyDictKeys_Type) #define PyDictItems_Check(op) (Py_TYPE(op) == &PyDictItems_Type) #define PyDictValues_Check(op) (Py_TYPE(op

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Jim Jewett
Jim Jewett added the comment: (Just putting my review summary in the main ticket) I'm going to echo the previous comment that maybe trying to emulate the existing dict implementation too carefully just adds complexity. The split-keys implementation shows that there is at least some flexibility

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Jim Jewett
Jim Jewett added the comment: Eric, unless I'm misreading your debugging info, it is the other way around -- something is in the dict, but not in the list that you iterate over. And since the list that you iterate over looks right, I have to wonder if it was something internal-to-configparse

[issue24273] _scproxy.so causes EXC_BAD_ACCESS (SIGSEGV)

2015-05-23 Thread Ned Deily
Ned Deily added the comment: One workaround should be to disable network proxy lookups by defining the environment variable 'no_proxy' with value '*' in the Python process, for example: env no_proxy='*' python3.4 ... -- ___ Python tracker

[issue14373] C implementation of functools.lru_cache

2015-05-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks Serhiy. I'll work on the next steps after the beta. -- assignee: serhiy.storchaka -> rhettinger ___ Python tracker ___ __

[issue24273] _scproxy.so causes EXC_BAD_ACCESS (SIGSEGV)

2015-05-23 Thread Jacob
New submission from Jacob: This looks very related to: http://bugs.python.org/issue13829 I have very simple test code that looks like this: import requests r = requests.get('http://www.google.com') print('requests.get() succeeded') The above code works fine. However, when:

[issue24254] Make class definition namespace ordered by default

2015-05-23 Thread Eric Snow
Changes by Eric Snow : -- hgrepos: +310 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Eric Snow
Changes by Eric Snow : -- hgrepos: +309 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Eric Snow
Eric Snow added the comment: Good catch. I've fixed odictiter_new in the feature branch. However, I'm not sure there's anything to be fixed in odict_new. It follows the same pattern as dict_new (over in Objects/dictobject.c). -- ___ Python tracke

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Matthew Barnett
Matthew Barnett added the comment: In "odict_new", if "_odict_initialize" fails, will the dict pointed to by "od_inst_dict" be deallocated? In "odictiter_new", there's "Py_INCREF(od);". If "di->di_result == NULL" fails, "od" isn't DECREFed. -- ___

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Steve Dower
Steve Dower added the comment: Confirmed that when we build the module needed by the test, the test works fine :) Unfortunately, I think it missed the branch for b1, so people who install and run the test suite will see failures there. I'll make sure it gets into the 3.5 branch once that open

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 42ec976f627e by Steve Dower in branch 'default': Issue #24268: Adds PCBuild project to build _testmultiphase module. https://hg.python.org/cpython/rev/42ec976f627e -- ___ Python tracker

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Steve Dower
Steve Dower added the comment: Actually, that probably means we're not building a new extension module on Windows, right? -- ___ Python tracker ___ _

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Steve Dower
Steve Dower added the comment: Since you're up, any chance you can help diagnose these test failures: Traceback (most recent call last): File "D:\buildarea\3.x.bolen-windows8\build\lib\test\test_importlib\extension\test_loader.py", line 93, in setUp assert self.spec AssertionError >From

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks for getting the Windows side sorted out folks, and my apologies for the breakage. The overlap between the current import system maintainers and Windows developers is unfortunately the null set :( -- ___ Python tr

[issue21961] Add What's New for Idle.

2015-05-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I just added a generic entry to the 3.4 and 3.5 What's New docs pointing people to idlelib/NEWS.txt. + idlelib and IDLE + + +Since idlelib implements the IDLE shell and editor and is not intended for +import by other programs, it gets improve

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Mark Lawrence
Mark Lawrence added the comment: FTR I've now built everything successfully. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset af167a62e2a3 by Steve Dower in branch 'default': Issue #24268: Adds PyModuleDef_Init and PyModuleDef_Type to python3.def (stable ABI) https://hg.python.org/cpython/rev/af167a62e2a3 -- ___ Python tracker

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Steve Dower
Steve Dower added the comment: It also required updating PC/python3.def to put the new functions into the stable API. This is the reason we should auto-gen that file (+Zach), to make sure that anything people can #include under the limited ABI can actually be used. Just double checking all th

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Steve Dower
Steve Dower added the comment: I think it's missing PyAPI_DATA, as it's probably supposed to be an external reference than a declaration. If it builds fine now, I'll commit that, but whoever made the change should confirm that's what it is supposed to be. -- __

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Mark Lawrence
Mark Lawrence added the comment: error C2079: 'PyModuleDef_Type' uses undefined struct '_typeobject' c:\cpython\include\moduleobject.h is occurring on both 32 and 64 bit release builds on Windows 8.1 VS2015. I don't know what is causing it but figured I'd better flag it up pronto, and as you

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b5f5f8b26a6 by Steve Dower in branch 'default': Issue #24268: Fix import naming when loading extension modules. Patch by Petr Viktorin. https://hg.python.org/cpython/rev/7b5f5f8b26a6 -- ___ Python track

[issue23973] PEP 484 implementation

2015-05-23 Thread Guido van Rossum
Guido van Rossum added the comment: I've opened a separate bug (http://bugs.python.org/issue24272) for docs. -- ___ Python tracker ___ ___

[issue24272] PEP 484 docs

2015-05-23 Thread Guido van Rossum
New submission from Guido van Rossum: Would be nice if there were more docs for the typing module (PEP 484). Looking for volunteers. (There's stuff in the PEP that can serve as a starting point.) Note: support for isinstance() and issubclass() will be withdrawn in beta 2. -- assignee:

[issue24272] PEP 484 docs

2015-05-23 Thread Guido van Rossum
Changes by Guido van Rossum : -- stage: -> needs patch type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23973] PEP 484 implementation

2015-05-23 Thread Guido van Rossum
Guido van Rossum added the comment: This was committed (rev 3e96d7ca3f51). I'm keeping this open because there is more to do (see https://github.com/ambv/typehinting/labels/bug). -- priority: release blocker -> normal ___ Python tracker

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Petr Viktorin
Petr Viktorin added the comment: Steve, could you please merge it? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue2528] Change os.access to check ACLs under Windows

2015-05-23 Thread Paul Moore
Changes by Paul Moore : -- nosy: +paul.moore ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Larry Hastings
Larry Hastings added the comment: If it makes sense, can you guys check it in soon, like in real-time here? I tag 3.5 beta 1 in about an hour, and since this is a "bug-fix" it's legitimate to go in. -- ___ Python tracker

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Steve Dower
Steve Dower added the comment: That patch looks good to me. Totally didn't think to look for copy-paste issues... -- ___ Python tracker ___ _

[issue14373] C implementation of functools.lru_cache

2015-05-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks Raymond. I tried to write an implementation with locking, but it would be too complicated (much more complex than all proposed before patches), because recursive locks are needed. In any case I think that GIL is enough here. Locking in Python impleme

[issue14373] C implementation of functools.lru_cache

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 57776eee74f2 by Serhiy Storchaka in branch 'default': Issue #14373: Added C implementation of functools.lru_cache(). Based on https://hg.python.org/cpython/rev/57776eee74f2 -- nosy: +python-dev ___ Pytho

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Petr Viktorin
Petr Viktorin added the comment: Thank you, Steve. A similar problem is on other platforms as well. This patch should fix it; could someone look at it? -- Added file: http://bugs.python.org/file39477/fix-dynload-init-name.patch ___ Python tracker

[issue23970] Update distutils.msvccompiler for VC14

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 32e6123f9f8c by Steve Dower in branch 'default': Issue #23970: Fixes bdist_wininst not working on non-Windows platform. https://hg.python.org/cpython/rev/32e6123f9f8c -- ___ Python tracker

[issue24209] Allow IPv6 bind in http.server

2015-05-23 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag versions: -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue23970] Update distutils.msvccompiler for VC14

2015-05-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: b2ee6206fa5e broke every non-Windows buildbot. http://buildbot.python.org/all/builders/AMD64%20Snow%20Leop%203.x/builds/3229/steps/test/logs/stdio -- nosy: +benjamin.peterson resolution: fixed -> status: closed -> open _

[issue23509] Speed up Counter operators

2015-05-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The OrderedCounter recipe doesn't support well multiset operations, because the result type is hardcoded to Counter. The order is already scrambled. update() and substract() don't work well with overloaded __missing__(). Proposed implementations of __add__ a

[issue21114] wsgiref.simple_server doesn't handle multi-line headers correctly

2015-05-23 Thread Tom Tanner
Tom Tanner added the comment: The patch is waiting for inclusion in 2.7.10 :/ -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue21718] sqlite3 cursor.description seems to rely on incomplete statement parsing for detection

2015-05-23 Thread Tom Tanner
Tom Tanner added the comment: is this going to be fixed in 2.7.10? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue14373] C implementation of functools.lru_cache

2015-05-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Serhiy, go ahead and apply your patch, lru_cache2.patch. I'll fix-up the make_key() code after the beta1 (like the pure python version, it needs to guarantee that hash is called no more than once per key). -- assignee: rhettinger -> serhiy.storchak

[issue24204] string.strip() documentation is misleading

2015-05-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: docs@python -> rhettinger resolution: -> fixed stage: patch review -> resolved ___ Python tracker ___ ___

[issue24204] string.strip() documentation is misleading

2015-05-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue24204] string.strip() documentation is misleading

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 367e3923532f by Raymond Hettinger in branch 'default': Issue #24204: Elaborate of the str.strip() documentation. https://hg.python.org/cpython/rev/367e3923532f -- nosy: +python-dev ___ Python tracker

[issue24204] string.strip() documentation is misleading

2015-05-23 Thread Carol Willing
Carol Willing added the comment: Updated patch with Terry's suggested changes. Thanks Terry and Raymond for the review of the initial patch. -- Added file: http://bugs.python.org/file39476/iss24204b.patch ___ Python tracker

[issue23970] Update distutils.msvccompiler for VC14

2015-05-23 Thread Steve Dower
Changes by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Py

[issue23970] Update distutils.msvccompiler for VC14

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset b2ee6206fa5e by Steve Dower in branch 'default': Issue #23970: Adds distutils._msvccompiler for new Visual Studio versions. https://hg.python.org/cpython/rev/b2ee6206fa5e -- nosy: +python-dev ___ Python t

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Steve Dower
Steve Dower added the comment: For the sake of getting things running again, I went ahead and fixed the format string in dynload_win.c. Feel free to change it again if that isn't what was intended. -- nosy: +steve.dower ___ Python tracker

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset a811f5561c99 by Steve Dower in branch 'default': Issue #24268: Fixes generation of init import name on Windows. https://hg.python.org/cpython/rev/a811f5561c99 -- ___ Python tracker

[issue24269] Few improvements to the collections documentation

2015-05-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-b

[issue24269] Few improvements to the collections documentation

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4d92ce08de6a by Raymond Hettinger in branch 'default': Issue #24269: Minor doc fixups. https://hg.python.org/cpython/rev/4d92ce08de6a -- nosy: +python-dev ___ Python tracker

[issue24269] Few improvements to the collections documentation

2015-05-23 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks for the patch. I've applied all of it except for the expansion of code in the multiset example where I've keep the style of the itertools recipes. -- ___ Python tracker

[issue22931] cookies with square brackets in value

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 710cdba13323 by Benjamin Peterson in branch '3.2': allow square brackets in cookie values (closes #22931) https://hg.python.org/cpython/rev/710cdba13323 New changeset c7b3a50a2f01 by Benjamin Peterson in branch '3.3': merge 3.2 (#22931) https://hg.p

[issue24271] Python site randomly scrolls up when on mobile.

2015-05-23 Thread Ned Deily
Ned Deily added the comment: Problems with the python.org website are tracked at https://github.com/python/pythondotorg/issues. This is a duplicate of https://github.com/python/pythondotorg/issues/531. -- nosy: +ned.deily resolution: -> third party stage: -> resolved status: open ->

[issue24269] Few improvements to the collections documentation

2015-05-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: docs@python -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list ma

[issue24271] Python site randomly scrolls up when on mobile.

2015-05-23 Thread Ram Rachum
New submission from Ram Rachum: I was trying to read this page: https://www.python.org/dev/peps/pep-0492/#acceptance On my mobile. (Nexus 5, chrome.) But when scrolling down the page, the browser sometimes scrolls up to the top of the page. This makes reading very annoying because I have to f

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Petr Viktorin
Petr Viktorin added the comment: FWIW, the remaining refleak occurs when unloading an extension module object. This is something that wasn't possible before PEP 489 -- extension modules were never deleted. -- ___ Python tracker

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Petr Viktorin
Petr Viktorin added the comment: The array module is good if you *really* drop references: $ ./python -X showrefcount Python 3.5.0a4+ (default, May 23 2015, 16:44:38) [GCC 4.9.2 20150212 (Red Hat 4.9.2-6)] on linux Type "help", "copyright", "credits" or "license" for more information. >>> impor

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: Once we sort these out, any that impact Python 3.4 (like the PyType_FromSpecAndBases one) should be backported to the maintenance branch. I wouldn't assume the one you found in PyType_FromSpecAndBases is the only one, though - I believe the tests for this PEP ar

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: Thanks, that reduces the refleaks shown for "./python -m test -R3:3 test_importlib" from 102 to 50 for me. However, I suspect there may still be a leak in the machinery, as I'm still seeing the total number of objects growing when importing the array module and

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7f2e6f236202 by Nick Coghlan in branch 'default': Issue #24268: Address some PEP 489 refleaks https://hg.python.org/cpython/rev/7f2e6f236202 -- nosy: +python-dev ___ Python tracker

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Petr Viktorin
Petr Viktorin added the comment: Fix some refleaks - one in PyModule_FromDefAndSpec2 - this is my fault - one in PyType_FromSpecWithBases - I guess this is the first time PEP-384 built-in types are GC'd - one in the new PEP 489 tests There's still one more in the new testing module, _testmultip

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Eric Snow
Eric Snow added the comment: Good point, Nick. I'd checked that earlier but did not see any relationship. At this point it's worth checking again. :) -- ___ Python tracker ___

[issue24270] PEP 485 (math.isclose) implementation

2015-05-23 Thread Nick Coghlan
New submission from Nick Coghlan: Tracking issue for the PEP 485 math.isclose() implementation: https://www.python.org/dev/peps/pep-0485/ Chris's implementation review request to python-dev: https://mail.python.org/pipermail/python-dev/2015-May/140031.html Working repo: https://github.com/Pyt

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: Regarding the extraneous whitespace changes in modsupport.h, those are courtesy of running "make patchcheck" as part of preparing the commit. -- ___ Python tracker _

[issue24267] test_venv.EnsurePipTest.test_with_pip triggers version check over network

2015-05-23 Thread Donald Stufft
Donald Stufft added the comment: Yea, I already upgraded pip. I did forget that we'll want to add --disable-pip-version-check to the pip invocation inside of ensurepip. -- ___ Python tracker __

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: Initial implementation checked in at https://hg.python.org/cpython/rev/e729b946cc03 Larry, FYI regarding the refleak in test_importlib I just committed: as described in the commit message, I'm pretty sure it's a real refleak in the current PEP 489 implementatio

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: Attached patch is the one I'm looking to commit, but -R 3:3 shows significant reference leaks in test_importlib, and possible problems in other tests as well. I'm about to revert it to see if there were any pre-existing refleak issues before applying this.

[issue23237] Interrupts are lost during readline PyOS_InputHook processing (reopening)

2015-05-23 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue24269] Few improvements to the collections documentation

2015-05-23 Thread Dmitry Kazakov
New submission from Dmitry Kazakov: collections.Counter: Formatted the code in the "See also" section. collections.deque.remove: "Removed the first occurrence of value." -> "Remove ..." collections.deque.index (a followup from issue23704): Changed [, end] to [, stop] in the signature, bec

[issue24260] TabError behavior doesn't match documentation

2015-05-23 Thread Stefan Krah
Stefan Krah added the comment: Then pep-008 is wrong, too, since the implementation *does* allow Evgeny's example. The current implementation just checks if the same INDENT/DEDENT tokens are generated for tab widths 1 and 8. -- ___ Python tracker

[issue24260] TabError behavior doesn't match documentation

2015-05-23 Thread Mark Lawrence
Mark Lawrence added the comment: >From https://www.python.org/dev/peps/pep-0008/ Tabs or Spaces? Spaces are the preferred indentation method. Tabs should be used solely to remain consistent with code that is already indented with tabs. Python 3 disallows mixing the use of tabs and spaces for

[issue24260] TabError behavior doesn't match documentation

2015-05-23 Thread Stefan Krah
Stefan Krah added the comment: I would go further and forbid tabs after spaces entirely. Tabs used for indentation with spaces following for formatting are okay (though unusual in Python). -- nosy: +skrah ___ Python tracker

[issue23965] test_ssl failure on Fedora 22

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: Digging into the test_options failure suggests Christian is right (although I think it has more to do with https://fedoraproject.org/wiki/Changes/CryptoPolicy than it does with FIPS): >>> ctx = ssl.SSLContext(ssl.PROTOCOL_TLSv1) >>> bin(ctx.options) '0b10110

[issue23509] Speed up Counter operators

2015-05-23 Thread Jörn Hees
Jörn Hees added the comment: > I'm closing this because the OP's original concern about wanting an in-place > operation was already solved Was it? Are you referring to http://bugs.python.org/issue13121 ? My main concern was that += is considerably slower than .update(), kind of catching me of

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: I'd suggest also taking a look into whether or not the PEP 412 keysharing might be causing problems. -- nosy: +ncoghlan ___ Python tracker ___ __

[issue24254] Make class definition namespace ordered by default

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: types.prepare_class() also needs to be updated to use OrderedDict() by default. -- dependencies: +Add OrderedDict written in C ___ Python tracker

[issue23377] HTTPResponse may drop buffer holding next response

2015-05-23 Thread Martin Panter
Martin Panter added the comment: Thanks for the reviewing. Here is http-buffer.v3.patch: * Merged with current code * Better HTTPResponse(sock) compatibility suggested by Demian * New HTTPConnection.request(close=True) feature also suggested by Demian. This sends “Connection: close” in the requ

[issue24267] test_venv.EnsurePipTest.test_with_pip triggers version check over network

2015-05-23 Thread Martin Panter
Martin Panter added the comment: Actually looks like I should have updated before I opened this bug. I just updated and I suspect revision 29b95625a07c (“Merge 3.4 into default, upgrading pip to 7.0.1”, a large binary change) fixed it for me. But I did wonder why removing -unetwork didn’t affe

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: I'll get this merged tonight so we make the beta1 deadline, but I expect the initial docs to be fairly rudimentary and requiring further updates. -- assignee: -> ncoghlan versions: +Python 3.5 ___ Python tracker

[issue24267] test_venv.EnsurePipTest.test_with_pip version conflict

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: There's two issues here: 1. The bundled pip should be upgraded to the recently released 7.0 (I believe we can do that after beta 1, due to the different-from-normal guidelines set up in PEP 453) 2. Neither the tests nor ensurepip itself should be touching the n

[issue2528] Change os.access to check ACLs under Windows

2015-05-23 Thread Tim Golden
Tim Golden added the comment: Thanks for the very thorough review. This isn't going to make it into 3.5, but I'll rework it in the light of your comments and see if people are happy with it in the optional argument variation. -- ___ Python tracker

[issue23968] rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET)

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: +1 from me. -- nosy: +larry, rkuska ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue24056] Better expose closure, generator & coroutine status of functions

2015-05-23 Thread Nick Coghlan
Nick Coghlan added the comment: I've also come to agree with Raymond that the repr may not be the best place for this additional information, and have updated the issue title accordingly. For example, as one possible alternative, we might be able to put something in the inspect module (e.g. "i

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Petr Viktorin
Petr Viktorin added the comment: And here are all changes in a single patch. -- keywords: +patch Added file: http://bugs.python.org/file39471/pep0489.patch ___ Python tracker ___

[issue24268] PEP 489 -- Multi-phase extension module initialization

2015-05-23 Thread Petr Viktorin
New submission from Petr Viktorin: Here is the implementation for the recently accepted PEP 489. Tested on Linux. -- files: pep0489.patches messages: 243893 nosy: encukou, eric.snow, ncoghlan priority: normal severity: normal status: open title: PEP 489 -- Multi-phase extension module i

[issue24195] Add `Executor.filter` to concurrent.futures

2015-05-23 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +docs@python ___ Python tracker ___ __

[issue2528] Change os.access to check ACLs under Windows

2015-05-23 Thread eryksun
eryksun added the comment: In msg243815 you asked me to look over this patch. I hope this helps. For GetFileSecurity you need to also request LABEL_SECURITY_INFORMATION. To test this in Vista+, use a file in the root directory of the system drive. This will inherit a high integrity level w/ no

[issue24195] Add `Executor.filter` to concurrent.futures

2015-05-23 Thread Ram Rachum
Ram Rachum added the comment: Raymond: Thank you. So the discussion is back on adding a recipe to the docs. Brian: When I said "possible issues", I followed that with a couple of issues with the example I uploaded (filter_example.py). -- ___ Python