[issue23378] argparse.add_argument action parameter should allow value extend

2015-03-22 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> needs patch versions: -Python 3.4, Python 3.6 ___ Python tracker ___ __

[issue23744] Speed-up deque.__bool__

2015-03-22 Thread Raymond Hettinger
Changes by Raymond Hettinger : Added file: http://bugs.python.org/file38645/timings_deque_bool.txt ___ Python tracker ___ ___ Python-bugs-list

[issue23744] Speed-up deque.__bool__

2015-03-22 Thread Raymond Hettinger
New submission from Raymond Hettinger: The __bool__ method is a little faster than __len__. Timings attached. -- assignee: rhettinger components: Library (Lib) files: deque_bool1.diff keywords: patch messages: 238983 nosy: rhettinger priority: normal severity: normal status: open title:

[issue20271] urllib.parse.urlparse() accepts wrong URLs

2015-03-22 Thread Martin Panter
Martin Panter added the comment: To me, the only difference between urlsplit() and urlparse() is that urlsplit() does not treat parameters following a semicolon specially. The documentation tends to agree with this view. So whatever exceptions are raised by urlparse() should also be raised by

[issue23743] Python crashes upon exit if importing g++ compiled mod after importing gcc compiled mod

2015-03-22 Thread matham
New submission from matham: I have encountered a situation where python crashes when python exits if one imports a c compiled extension followed by a cpp compiled extension (but not if imported in the reverse order). This is on windows with mingw (current using mingw-get install gcc g++ msys-m

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-03-22 Thread Zbyszek Jędrzejewski-Szmek
Zbyszek Jędrzejewski-Szmek added the comment: Actually they are not classes, so the proposed wording cannot be used. But indeed it sounds better with the "and". v4: - one more "and" -- Added file: http://bugs.python.org/file38643/0001-docs-update-description-of-TemporaryFile-and-tempf

[issue20059] Inconsistent urlparse/urllib.parse handling of invalid port values?

2015-03-22 Thread Martin Panter
Martin Panter added the comment: Patch v2 just changes a test to use “with self.assertRaises()”. The behaviour of urlparse() succeeding and then result.port failing is indeed odd and surprising. Hopefully documenting this behaviour will help with the “surprising” aspect. But changing it would

[issue22977] Unformatted “Windows Error 0x%X” exception message on Wine

2015-03-22 Thread Martin Panter
Martin Panter added the comment: V3 patch with suggested changes to the test case, though still completely untested by me. -- Added file: http://bugs.python.org/file38641/win-error-format-v3.patch ___ Python tracker

[issue23062] test_argparse --version test cases

2015-03-22 Thread Martin Panter
Martin Panter added the comment: Serhiy, there is already a test for that: class TestHelpVersionAction(HelpTestCase): """Test the default help for the version action""" So I still think the test is redundant, unless it is made to exercise help=SUPPRESS, as Berker’s patch does. --

[issue22163] max_wbits set incorrectly to -zlib.MAX_WBITS in tarfile, shouldn't be negative

2015-03-22 Thread Martin Panter
Martin Panter added the comment: Eduardo’s patch causes many tests to fail. Abbreviated test output: $ ./python -bWall -m test -v test_tarfile == ERROR: test_compare_members (test.test_tarfile.GzipStreamReadTest) ERROR: test_emp

[issue5784] raw deflate format and zlib module

2015-03-22 Thread Martin Panter
Martin Panter added the comment: According to , the deflateInit2(windowBits) parameter can be: * +8 to +15 to include a “zlib” header and trailer * −8 to −15 to write a raw Deflate stream with no header nor trailer * 16 + (8 to 15) to include a basic “gzip”

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-03-22 Thread Martin Panter
Martin Panter added the comment: The current proposed text would be rendered something like this: ''' TemporaryFile, NamedTemporaryFile, TemporaryDirectory, SpooledTemporaryFile are high-level interfaces which provide automatic cleanup and can be used as context managers. mkstemp() and mkdtemp

[issue23676] Add support of UnicodeTranslateError in standard error handlers

2015-03-22 Thread Martin Panter
Martin Panter added the comment: I think I saw your patch for Issue 18814 proposes to use UnicodeTranslateError. Is there any other case where it is used, either currently or in the past? All I know of it is the documentation, which says it is raised “during translating”. Experimenting with th

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-03-22 Thread Zbyszek Jędrzejewski-Szmek
Zbyszek Jędrzejewski-Szmek added the comment: > Please start sentences with capital letters, specifically “mkstemp() and > mkdtemp() are lower-level functions . . .”. This would make the sentence more convoluted... I think that with markup it is pretty clear that this is a function name and th

[issue23742] expandvars removes single quotes ( ' )

2015-03-22 Thread R. David Murray
R. David Murray added the comment: It apparently only loses unbalanced single quotes. -- components: +Windows -Library (Lib) nosy: +r.david.murray, steve.dower, tim.golden, zach.ware stage: -> needs patch versions: +Python 3.5 ___ Python tracker

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-03-22 Thread R. David Murray
R. David Murray added the comment: If the first word is a function name that does not start with a capital, the sentence can't start with a capital. Sometimes it is worthwhile to reword the sentence so you can start it with a capitalizable word, but sometimes it isn't. (I haven't reviewed th

[issue23740] http.client request and send method have some datatype issues

2015-03-22 Thread R. David Murray
R. David Murray added the comment: Yeah, if we're going to check the type for iterables to convert strings, we might as well check the type for read() as well. The bit about the len not being set except for str and bytes was me mis-remembering what I read in the code. (The isinstance check is

[issue23742] expandvars removes single quotes ( ' )

2015-03-22 Thread Manuel Vögele
New submission from Manuel Vögele: When executing os.path.expandvars("%SystemDrive%\\Foo'Bar") the function erases the ' returning 'C:\\FooBar' using Python 3.4.3 on Windows 7 -- components: Library (Lib) messages: 238968 nosy: manuel_v, serhiy.storchaka priority: normal severity: no

[issue22468] Tarfile using fstat on GZip file object

2015-03-22 Thread Martin Panter
Martin Panter added the comment: I think a warning in the documentation might be helpful. However a special check in the code doesn’t seem right. Would you check for LZMAFile and BZ2File as well? Some of the other attributes (modification time, owner, etc) may be useful even for a GzipFile, an

[issue16328] win_add2path.py sets wrong user path

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: Presumably we can look at this after the discussions about the installer scheduled for PyCon 2015? -- ___ Python tracker ___ ___

[issue23729] Import ElementTree documentation for namespaces and XPath

2015-03-22 Thread Martin Panter
Martin Panter added the comment: Hi Raymond, perhaps you didn’t see the comments on your second patch on Reitveld. E.g. fromstring() does not have an underscore. -- ___ Python tracker _

[issue23740] http.client request and send method have some datatype issues

2015-03-22 Thread Demian Brecht
Demian Brecht added the comment: FWIW, I've done some additional work to request/send in issue #12319 where I've added support for chunked request encoding. @David > if an iterable is passed in, it must be an iterable of bytes-like objects This specific issue is addressed in the patch in #2335

[issue23350] Content-length is incorrect when request body is a list or tuple

2015-03-22 Thread Demian Brecht
Demian Brecht added the comment: @Serhiy: > Content-Length shouldn't be calculated for lists, tuples, and other > non-bytes-compatible sequences. I'd agree with this if it wasn't relatively trivial to calculate. There's no reason that I can think of to exclude the auto-generated Content-Length

[issue22163] max_wbits set incorrectly to -zlib.MAX_WBITS in tarfile, shouldn't be negative

2015-03-22 Thread Martin Panter
Martin Panter added the comment: I suspect the patch is wrong and the zlib documentation needs fixing instead. See for a possible explanation of the negative sign, although it would make more sense for compress() which would actua

[issue22468] Tarfile using fstat on GZip file object

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: msg227328 states "it's not a really common scenario" but I believe we must still allow for it, what do others think? -- nosy: +BreamoreBoy ___ Python tracker __

[issue23740] http.client request and send method have some datatype issues

2015-03-22 Thread Martin Panter
Martin Panter added the comment: As well as encoding iterables of str(), text files could also be handled more consistently by checking the read() return type. That would eliminate the complication of checking for a "b" mode. -- ___ Python tracker

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-03-22 Thread Martin Panter
Martin Panter added the comment: [Padding] Please start sentences with capital letters, specifically “mkstemp() and mkdtemp() are lower-level functions . . .”. The new sentence at the top about context managers seems out-of-place. Perhaps something like “They can also be used as context manag

[issue21319] WindowsRegistryFinder never added to sys.meta_path

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: Just making sure our Windows people are aware of this issue. -- components: +Windows nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware ___ Python tracker __

[issue21315] email._header_value_parser does not recognise in-line encoding changes

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: Could someone formally review the patch please, it's only three additional lines of code and a new test. -- nosy: +BreamoreBoy ___ Python tracker __

[issue21120] PyArena type is used in headers from the limited API

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: I'm not sure if this should be a compile error or an enhancement request, can someone please advise. -- nosy: +BreamoreBoy ___ Python tracker __

[issue23350] Content-length is incorrect when request body is a list or tuple

2015-03-22 Thread Martin Panter
Martin Panter added the comment: David: Calculating the length of a list or tuple of Latin-1 text strings should actually be straight-forward and reliable, because it is a single-byte encoding. However I am starting to think adding a new special case for lists and tuples is a bad idea. There a

[issue21062] Evalute all import-related modules for best practices

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: Just a gentle reminder as it refers to zipimport and a patch was committed just a few days ago. -- nosy: +BreamoreBoy ___ Python tracker ___ ___

[issue23740] http.client request and send method have some datatype issues

2015-03-22 Thread Martin Panter
Martin Panter added the comment: Summary of the main supported types as I see them, whether documented, undocumented, or only working by accident: * None * Bytes-like sequences, e.g. bytes(), bytearray. I believe Content-Length is actually automatically set for all these types. * Arbitrary byt

[issue23252] Add support of writing to unseekable file in zipfile

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 19f36a2a34ec by Serhiy Storchaka in branch 'default': Issue #23252: Added support for writing ZIP files to unseekable streams. https://hg.python.org/cpython/rev/19f36a2a34ec -- nosy: +python-dev ___ Pyth

[issue21526] Support new booleans in Tkinter

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset e9d86c1de292 by Serhiy Storchaka in branch 'default': Issue #21526: Tkinter now supports new boolean type in Tcl 8.5. https://hg.python.org/cpython/rev/e9d86c1de292 -- nosy: +python-dev ___ Python tracker

[issue23546] Windows, 'Edit withIDLE', and multiple installed versions

2015-03-22 Thread Steve Dower
Steve Dower added the comment: I'll try, but if it's not feasible now I doubt it will become feasible until the next installer revamp. Completely separate items are certainly okay. -- ___ Python tracker __

[issue23729] Import ElementTree documentation for namespaces and XPath

2015-03-22 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue23729] Import ElementTree documentation for namespaces and XPath

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 000814bbc899 by Raymond Hettinger in branch '2.7': Issue 23729: Document ElementTree namespace handling and fix an omission in the XPATH predicate table. https://hg.python.org/cpython/rev/000814bbc899 -- __

[issue23729] Import ElementTree documentation for namespaces and XPath

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 88b9af268cca by Raymond Hettinger in branch '3.4': Issue 23729: Document ElementTree namespace handling and fix an omission in the XPATH predicate table. https://hg.python.org/cpython/rev/88b9af268cca -- nosy: +python-dev

[issue23688] unnecessary copying of memoryview in gzip.GzipFile.write?

2015-03-22 Thread Wolfgang Maier
Wolfgang Maier added the comment: Here is a revised version of my patch addressing Serhiy's review comments. -- Added file: http://bugs.python.org/file38639/write_bytes_like_objects_v2.patch ___ Python tracker

[issue23546] Windows, 'Edit withIDLE', and multiple installed versions

2015-03-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Collapsing multiple 'Edit with Idle x.y' entries into one 'Edit with Idle >' + submenu (or 'Edit with Idle 3 >' + submenu) would be fine once practical to do so. -- ___ Python tracker

[issue18684] Pointers point out of array bound in _sre.c

2015-03-22 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Added file: http://bugs.python.org/file38638/sre_ptr_out_of_bounds_4.patch ___ Python tracker ___ ___ Python-bug

[issue18684] Pointers point out of array bound in _sre.c

2015-03-22 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file38637/sre_ptr_out_of_bounds_4.patch ___ Python tracker ___ ___ Python-b

[issue18684] Pointers point out of array bound in _sre.c

2015-03-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is recent patch. -- versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file38637/sre_ptr_out_of_bounds_4.patch ___ Python tracker _

[issue23741] Small pprint refactoring

2015-03-22 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: This issue is not so ambitious as issue7434. Proposed match only slightly refactor current implementation, so it becomes easier extensible for standard types. No public interface provided, this task left for issue7434. No behavior changed. -- assi

[issue23378] argparse.add_argument action parameter should allow value extend

2015-03-22 Thread Wolfgang Maier
Wolfgang Maier added the comment: > - I haven't seen other requests for it For the record, an Extend custom action class is one of very few such classes I have ever written for argparse for exactly the OP's usecase, i.e., it is useful for any parser that should accept the same option multiple

[issue23546] Windows, 'Edit withIDLE', and multiple installed versions

2015-03-22 Thread Steve Dower
Steve Dower added the comment: > If you want me to take this request to pydev, I will, but it seems > straightforward to me. "I'll go get Dad" seems a fairly immature threat and it's really not necessary. However, (after writing and then deleting a long exposition of the options) the most rel

[issue23298] Add ArgumentParser.add_mutually_dependence_group

2015-03-22 Thread paul j3
paul j3 added the comment: http://bugs.python.org/issue11588 is an earlier request for 'necessarily inclusive' groups. The patches that I proposed there are more general, allowing for other logical combinations of arguments, as well as nesting groups. As such it is more complex than your pat

[issue23647] imaplib.py MAXLINE value is too low for gmail

2015-03-22 Thread R. David Murray
Changes by R. David Murray : -- keywords: -patch stage: commit review -> needs patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue23350] Content-length is incorrect when request body is a list or tuple

2015-03-22 Thread R. David Murray
R. David Murray added the comment: Well, the current reality not counting the bug reported in this issue. So, I documented it as if the fix here is to not set the length when body is an iterator. -- ___ Python tracker

[issue23350] Content-length is incorrect when request body is a list or tuple

2015-03-22 Thread R. David Murray
R. David Murray added the comment: I just updated the docs to what I think is the current reality. See issue 23740 for what I think are problems with the current implementation, aside from any enhancement of computing a length for tuple or list. Since the latter cannot be done reliably unles

[issue23378] argparse.add_argument action parameter should allow value extend

2015-03-22 Thread paul j3
paul j3 added the comment: My opinion is that this is an unnecessary addition. Reasons: - it is easy to add as a custom action class - I haven't seen other requests for it - the append retains information about the argument strings that extend looses - it is easy flatten the appended attribu

[issue23647] imaplib.py MAXLINE value is too low for gmail

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset a56aa567072c by R David Murray in branch '2.7': #23647: Increase imaplib's MAXLINE to accommodate modern mailbox sizes. https://hg.python.org/cpython/rev/a56aa567072c New changeset c1348ada8fc6 by R David Murray in branch '3.4': #23647: Increase ima

[issue23740] http.client request and send method have some datatype issues

2015-03-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: See also issue23350 and issue23360. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-b

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-22 Thread Ryan Gonzalez
Ryan Gonzalez added the comment: Cyd: if you could do that, it would be great! -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23647] imaplib.py MAXLINE value is too low for gmail

2015-03-22 Thread R. David Murray
R. David Murray added the comment: Now that I've had time to look at this, I see that in fact RFC2683 says nothing about what value MAXLINE should have, unless one is reasoning by analogy. It is concerned with *command line* lengths from the client to the server, not about server responses.

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-22 Thread Cyd Haselton
Cyd Haselton added the comment: Ryan, Has anyone taken you up on the non-KBOX testing? Do you need me to test the patches within the KBOX environment? -- ___ Python tracker ___ _

[issue23487] argparse: add_subparsers 'action' broken

2015-03-22 Thread paul j3
paul j3 added the comment: It certainly looks like a documentation issue. `action` doesn't make sense here. `add_subparsers` normally creates an Action of type `_SubParsersAction`. 'action' for normal 'add_argument' command defines the Action type created at that time. Conceivably a user

[issue23539] Content-length not set for HTTP methods expecting body when body is None

2015-03-22 Thread James Rutherford
James Rutherford added the comment: Updated docs look good to me, thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23700] tempfile.NamedTemporaryFile can close too early if used as iterator

2015-03-22 Thread STINNER Victor
STINNER Victor added the comment: Yeah, the new comment is better :-) Thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue23740] http.client request and send method have some datatype issues

2015-03-22 Thread R. David Murray
New submission from R. David Murray: While committing the patch for issue 23539 I decided to rewrite the 'request' docs for clarity. I doing so I found that http.client isn't as consistent as it could be about how it handles bytes and strings. Two points specifically: it will only take the

[issue23539] Content-length not set for HTTP methods expecting body when body is None

2015-03-22 Thread R. David Murray
R. David Murray added the comment: Thanks James and Demien. I decided to rewrite the 'request' docs for Python3 to make them easier to follow (and more accurate). Hopefully I didn't make any mistakes, but you might want to review it just in case. -- resolution: -> fixed stage: commi

[issue23539] Content-length not set for HTTP methods expecting body when body is None

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5c3dc817ffd7 by R David Murray in branch '2.7': #23539: Set Content-Length to 0 for PUT, POST, and PATCH if body is None. https://hg.python.org/cpython/rev/5c3dc817ffd7 New changeset f6f72422df96 by R David Murray in branch '3.4': #23539: Set Conten

[issue2211] Cookie.Morsel interface needs update

2015-03-22 Thread R. David Murray
R. David Murray added the comment: Oh, and the additional what's new text would in this case be pretty much the contents of that multi-line versionchanged entry, as a bullet item in the 'porting' section. That is, they are behavior changes that are closer to API fixes than new features, and s

[issue2211] Cookie.Morsel interface needs update

2015-03-22 Thread R. David Murray
R. David Murray added the comment: Demien, your patch looks good to me except that it would be better to consolidate the three adjacent versionchanged entries into one. -- ___ Python tracker ___

[issue2211] Cookie.Morsel interface needs update

2015-03-22 Thread R. David Murray
R. David Murray added the comment: It looks like both of those changes were part of the python3 transition, and thus not subject to our backward compatibility rules. (Which, it should be noted, we applied rather more loosely in python 3.1, 3.2, and even to a smaller extent in 3.3). -

[issue23738] Clarify documentation of positional-only default values

2015-03-22 Thread R. David Murray
R. David Murray added the comment: Personally I would rather stick to the [] syntax in the docs, with the default values mentioned in the text. -- nosy: +georg.brandl, r.david.murray ___ Python tracker ___

[issue22350] nntplib file write failure causes exception from QUIT command

2015-03-22 Thread R. David Murray
R. David Murray added the comment: It looks to be clearly the case that there needs to be some error handling code wrapped around the file write in _getlongresp. Your patch doesn't do just that, however, so it seems like there may be other errors you are also worried about? Can you explain t

[issue23546] Windows, 'Edit withIDLE', and multiple installed versions

2015-03-22 Thread Terry J. Reedy
Terry J. Reedy added the comment: Some people use Windows Explorer as their default means for working with programs and files, including Python via Idle and their own .py files. What some need, as I said previously, is an explicit 'Edit with Idle x.y' for each installed Python. They need this

[issue23700] tempfile.NamedTemporaryFile can close too early if used as iterator

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset e9f03315d66c by R David Murray in branch '3.4': #23700: fix/improve comment https://hg.python.org/cpython/rev/e9f03315d66c New changeset 64f4dbac9d07 by R David Murray in branch 'default': Merge: #23700: fix/improve comment https://hg.python.org/cpy

[issue23700] tempfile.NamedTemporaryFile can close too early if used as iterator

2015-03-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23700] tempfile.NamedTemporaryFile can close too early if used as iterator

2015-03-22 Thread R. David Murray
R. David Murray added the comment: How's this? -- Added file: http://bugs.python.org/file38635/csv_iter_commemt.patch ___ Python tracker ___ _

[issue23657] Don't do isinstance checks in zipapp

2015-03-22 Thread Paul Moore
Changes by Paul Moore : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue23739] locale.setlocale checks locale name for string incorrectly

2015-03-22 Thread SilentGhost
Changes by SilentGhost : -- nosy: +lemburg, loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-03-22 Thread Zbyszek Jędrzejewski-Szmek
Zbyszek Jędrzejewski-Szmek added the comment: v2: - remove reflows - update TemporaryDirectory description too - do not call things which are not functions "functions" - with O_TMPFILE the file is not unlinked, also update TemporaryFile description for that - link to Examples -- Added f

[issue23739] locale.setlocale checks locale name for string incorrectly

2015-03-22 Thread Saulius Žemaitaitis
Saulius Žemaitaitis added the comment: Python 2.7.9 (default, Jan 29 2015, 06:27:40) [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.56)] on darwin -- ___ Python tracker ___ __

[issue23739] locale.setlocale checks locale name for string incorrectly

2015-03-22 Thread Saulius Žemaitaitis
New submission from Saulius Žemaitaitis: Steps to reproduce: python2.7 -c "import locale; locale.setlocale(locale.LC_ALL, u'en_US')" Raises: ValueError: too many values to unpack Problem lies in locale.py file from the standard library. It checks if locale is string incorrectly: if local

[issue23657] Don't do isinstance checks in zipapp

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0b2993742650 by Paul Moore in branch 'default': #23657 Don't explicitly do an isinstance check for str in zipapp https://hg.python.org/cpython/rev/0b2993742650 -- nosy: +python-dev ___ Python tracker

[issue23546] Windows, 'Edit withIDLE', and multiple installed versions

2015-03-22 Thread Steve Dower
Steve Dower added the comment: Also, that should be "py -3 -m idlelib.idle %1" so we get the actual latest IDLE from the context menu. (This does not affect the start menu items at all.) -- ___ Python tracker

[issue10482] subprocess and deadlock avoidance

2015-03-22 Thread Akira Li
Changes by Akira Li <4kir4...@gmail.com>: -- nosy: +akira ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue23700] tempfile.NamedTemporaryFile can close too early if used as iterator

2015-03-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Indeed. And all the comment could be better. Does anyone want to write better comment in the light of recent estimations? -- ___ Python tracker _

[issue22350] nntplib file write failure causes exception from QUIT command

2015-03-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I doubt that it is good idea to close connection on *any* error. For example in _getresp() resp.decode() can raise an exception, but this failure isn't related to the ability of sending QUIT and other commands. Sample error handling in your first message loo

[issue22163] max_wbits set incorrectly to -zlib.MAX_WBITS in tarfile, shouldn't be negative

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: Is the thinking and hence the patch correct here? -- nosy: +BreamoreBoy ___ Python tracker ___ ___ Py

[issue23738] Clarify documentation of positional-only default values

2015-03-22 Thread Brett Cannon
Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue1654408] Installer should split tcl/tk and tkinter install options.

2015-03-22 Thread Steve Dower
Steve Dower added the comment: tkinter and our tcl/tk builds are so closely linked there's no point separating them IMHO. It sounds like this report was prompted by a misconfiguration, so there's nothing really to fix here. -- ___ Python tracker <

[issue23731] Implement PEP 488

2015-03-22 Thread Brett Cannon
Brett Cannon added the comment: Will probably want to see http://bugs.python.org/issue17232 resolved as part of this as well. -- ___ Python tracker ___ _

[issue23723] Provide a way to disable bytecode staleness checks

2015-03-22 Thread Brett Cannon
Brett Cannon added the comment: I haven't thought about how to implement it, let alone document it. As I said, I might simply refactor importlib so that others can at least implement a loader which can do this without having to directly muck with importlib itself. It really depends on how far

[issue21313] Py_GetVersion() is broken when using mqueue and a long patch name

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: Any comments on the proposal to restrict the length of the returned string from Py_GetBuildInfo() to 80 characters? -- nosy: +BreamoreBoy ___ Python tracker ___

[issue18407] Fix compiler warnings in pythoncore for Win64

2015-03-22 Thread Steve Dower
Steve Dower added the comment: Does the patch still apply cleanly? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue23546] Windows, 'Edit withIDLE', and multiple installed versions

2015-03-22 Thread Steve Dower
Steve Dower added the comment: I believe so. py.exe doesn't provide the -m option, so it has already selected the version by the time that starts running. Shebangs are really just for launching the file directly. python -m on Linux will also ignore the shebang. -- __

[issue1654408] Installer should split tcl/tk and tkinter install options.

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: @Steve what is your take on this? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue22831] Use "with" to avoid possible fd leaks

2015-03-22 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, I forgot to publish my comments. I dropped the changes for treesync.py because treesync.py is not work with Python 3. I have written separate patch for it and will open separate issue after writing tests. -- _

[issue18407] Fix compiler warnings in pythoncore for Win64

2015-03-22 Thread Mark Lawrence
Mark Lawrence added the comment: Would someone like to review the patch please, being aware that there are other open issues relating to compiler warnings on Windows. -- nosy: +steve.dower, zach.ware ___ Python tracker

[issue22933] Misleading sentence in doc for shutil.move

2015-03-22 Thread Roundup Robot
Roundup Robot added the comment: New changeset e5de4ee6aa4a by Benjamin Peterson in branch '3.4': clarify behavior of shutil.move when destination exists (closes #22933) https://hg.python.org/cpython/rev/e5de4ee6aa4a New changeset 4502e598fe26 by Benjamin Peterson in branch '2.7': clarify behavi

[issue22831] Use "with" to avoid possible fd leaks

2015-03-22 Thread Martin Panter
Martin Panter added the comment: The new fd_leaks_tools1_2.patch seems to have dropped the changes for Tools/scripts/treesync.py, compared to the previous fd_leaks_tools1.patch. -- ___ Python tracker _

[issue22852] urllib.parse wrongly strips empty #fragment

2015-03-22 Thread Martin Panter
Martin Panter added the comment: Posting patch v2 with these changes: * Split out scheme documentation fixes to Issue 23684. * Renamed _NetlocResultMixinBase → _SplitParseBase * Explained the default values of the flags better, and what None means * Changed to Demian’s forward-looking “version c

[issue22350] nntplib file write failure causes exception from QUIT command

2015-03-22 Thread Martin Panter
Martin Panter added the comment: Well with a regular BufferedWriter, the chained exception is the same type as the original exception, so it does not really matter. I was just using the out-of-space exception as an easy way to get the body() method to abort in the middle of a command. The pro

[issue23700] tempfile.NamedTemporaryFile can close too early if used as iterator

2015-03-22 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: Comment in Lib/tempfile.py mentions issue #23000, but should mention issue #23700. -- nosy: +Arfrever ___ Python tracker _

[issue22079] Ensure in PyType_Ready() that base class of static type is static

2015-03-22 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue11410] Use GCC visibility attrs in PyAPI_*

2015-03-22 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

  1   2   >