[issue23439] Fixed http.client.__all__ and added a test

2015-02-19 Thread Berker Peksag
Berker Peksag added the comment: Committed now. Thanks for the patch, Martin and thanks for the review, Demian. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue23439] Fixed http.client.__all__ and added a test

2015-02-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 21b31f5438ae by Berker Peksag in branch '3.4': Issue #23439: Add missing entries to http.client.__all__. https://hg.python.org/cpython/rev/21b31f5438ae New changeset 95533c9edaaf by Berker Peksag in branch 'default': Issue #23439: Add missing entrie

[issue23487] argparse: add_subparsers 'action' broken

2015-02-19 Thread BJ Dierkes
New submission from BJ Dierkes: Related: http://bugs.python.org/issue9253 I came across issue9253 in trying to implement a default action for a subparser namespace. In the absence of a 'default' option, I thought that it may be possible by adding an 'action' to 'add_subparsers'. Per the docu

[issue22848] Subparser help does not respect SUPPRESS argument

2015-02-19 Thread BJ Dierkes
BJ Dierkes added the comment: I would like to add to this regarding the following: [QUOTE] Why would a user want to use `help=argparse.SUPPRESS`, as opposed to simply omitting the `help` parameter? The effect would be the same as your patch. [/QUOTE] This actually isn't the case, if you omi

[issue22000] cross type comparisons clarification

2015-02-19 Thread Martin Panter
Martin Panter added the comment: I think the patch for Issue 12067 covers all of the suggested points here, and is more accurate in some cases. -- nosy: +vadmium ___ Python tracker

[issue20699] Document that binary IO classes work with bytes-likes objects

2015-02-19 Thread Martin Panter
Martin Panter added the comment: Posting patch v3; thanks for the reviews! * Changed “buffer” → “object” * Made it clearer that the bytes-like object generalization only applies to method arguments, not return values * Minor fixes to wording -- Added file: http://bugs.python.org/file38

[issue23439] Fixed http.client.__all__ and added a test

2015-02-19 Thread Martin Panter
Martin Panter added the comment: Posting v3 patch that changes from a list to a set of expected API names -- Added file: http://bugs.python.org/file38180/http.client-all.v3.patch ___ Python tracker

[issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.

2015-02-19 Thread Martin Panter
Martin Panter added the comment: I guess you saying RemoteDisconnected effectively means the same thing as ConnectionResetError. Would it help if it was derived from ConnectionResetError, instead of the ConnectionError base class? Or are you also worried about the multiple inheritance or clutt

[issue15955] gzip, bz2, lzma: add option to limit output size

2015-02-19 Thread Nikolaus Rath
Nikolaus Rath added the comment: I've started to work on the bzip module. I'll attach I work-in-progress patch if I get stuck or run out of time. -- ___ Python tracker ___ _

[issue12855] linebreak sequences should be better documented

2015-02-19 Thread Martin Panter
Martin Panter added the comment: Posting linebreakdoc.v3.py3.5.patch: * Rebased onto recent “default” (3.5) branch * Add missing 1C–1E codes * Dropped reference to “universal newlines”, since that only handles CRs and LFs as I understand it The newlines are already tested by test_unicodedata.

[issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.

2015-02-19 Thread Demian Brecht
Demian Brecht added the comment: Left a few minor comments in Rietveld. My only opposition to the RemoteDisconnected error is now we have two exceptions that effectively mean the same thing. It looks like asyncio.streams has similar behaviour: https://hg.python.org/cpython/file/041a27298cf3/L

[issue21167] float('nan') returns 0.0 on Python compiled with icc

2015-02-19 Thread Scholes C
Scholes C added the comment: please disregard , the issue is resolved with your patch. -- ___ Python tracker ___ ___ Python-bugs-list

[issue21167] float('nan') returns 0.0 on Python compiled with icc

2015-02-19 Thread Scholes C
Scholes C added the comment: HI, can you please look into this ? thanks. icc builds of python 2.7 seem to have issues handling nan, inf, etc $ /usr/local/python-2.7.6/bin/python Python 2.7.6 (default, Jan 10 2014, 12:14:02) [GCC Intel(R) C++ gcc 4.1 mode] on linux2 Type "help", "copyright", "cr

[issue23486] Enum member lookup is 20x slower than normal class attribute lookup

2015-02-19 Thread Ethan Furman
Ethan Furman added the comment: Yup, you have it figured out. It's the lookup that is the slowdown. When performance is an issue one of the standard tricks is to create a local name, like you did with "tiny = Category.tiny". For the curious (taken from the docstring for Enum.__getattr__):

[issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.

2015-02-19 Thread Martin Panter
Martin Panter added the comment: Posting RemoteDisconnected.v4.patch with these changes: * Renamed ConnectionClosed → RemoteDisconnected. Hopefully avoids confusion with shutting down the local end of a connection, or closing a socket’s file descriptor. * Dropped the HTTPConnection.closed att

[issue23481] SSL module should not offer RC4 based cipher suites for clients by default

2015-02-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset c509e6f18d7d by Benjamin Peterson in branch '3.4': remove rc4 from the default client ciphers (closes #23481) https://hg.python.org/cpython/rev/c509e6f18d7d New changeset 3596081cfb55 by Benjamin Peterson in branch '2.7': remove rc4 from the default

[issue23486] Enum comparisons are 20x slower than comparing equivalent ints

2015-02-19 Thread Craig Holmquist
Craig Holmquist added the comment: It seems like performance is drastically improved by doing this: class Category(Enum): tiny = 1 medium = 2 large = 3 tiny = Category.tiny medium = Category.medium In other words, resolving Category.tiny and Category.medium is what's slow. The co

[issue23481] SSL module should not offer RC4 based cipher suites for clients by default

2015-02-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: Sounds fine to me. Should a test be added? -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue23486] Enum comparisons are 20x slower than comparing equivalent ints

2015-02-19 Thread Craig Holmquist
Craig Holmquist added the comment: I may not have been clear before. What I mean is, code like this: for obj in get_objects(): if obj.category == Cat.cat1: #do something elif obj.category == Cat.cat2: #do something else elif obj.category == Cat.cat3 or obj.category =

[issue23486] Enum comparisons are 20x slower than comparing equivalent ints

2015-02-19 Thread Ethan Furman
Ethan Furman added the comment: Craig Holmquist wrote: - > The consumer of that iteration processes each object with a switch-case-like > comparison of the category, checking it sequentially against each instance > of the Enum. So for every object you compare against every En

[issue21257] Document parse_headers function of http.client

2015-02-19 Thread Demian Brecht
Demian Brecht added the comment: And this really should likely now be closed as a duplicate of #23439. -- ___ Python tracker ___ ___ P

[issue23486] Enum comparisons are 20x slower than comparing equivalent ints

2015-02-19 Thread Ethan Furman
Changes by Ethan Furman : -- nosy: +ethan.furman ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue23486] Enum comparisons are 20x slower than comparing equivalent ints

2015-02-19 Thread Craig Holmquist
New submission from Craig Holmquist: Running the attached test script: $ time python test.py enum real0m6.546s user0m6.530s sys 0m0.007s $ time python test.py int real0m0.384s user0m0.377s sys 0m0.000s I encountered this with a script that yielded a sequence of objects

[issue9119] Python download page needs to mention crypto code in Windows installer

2015-02-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: No, this is really out of my ballpark. -- versions: +Python 3.5 -Python 3.1, Python 3.2, Python 3.3 ___ Python tracker ___ __

[issue8075] Windows (Vista/7) install error when choosing to compile .py files

2015-02-19 Thread Steve Dower
Steve Dower added the comment: I'm not interested in fixing the 2.7 installer, but patches are welcome. -- ___ Python tracker ___ ___ P

[issue8075] Windows (Vista/7) install error when choosing to compile .py files

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: @Steve what is your take on this issue? -- nosy: +BreamoreBoy ___ Python tracker ___ ___ Python-bugs-l

[issue20717] test_4_daemon_threads() fails randomly on "x86 Windows Server 2003 [SB] 3.x"

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: The "AMD64 Windows7 SP1 3.x" buildbot is currently green although it did fail at Feb 18 02:17. The "x86 Windows Server 2003 [SB] 3.4" has been showing an exception for the last two days. I'm sorry but I do not know how to investigate this further myself. ---

[issue20589] pathlib.owner() and pathlib.group() raise ImportError on Windows

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: Just to note that 3.5 still raises ImportError rather than NotImplementedError although the latter is the consensus here. -- nosy: +BreamoreBoy ___ Python tracker _

[issue19792] pathlib does not support symlink in Windows XP

2015-02-19 Thread Steve Dower
Steve Dower added the comment: Sounds good to me. -- resolution: -> wont fix status: open -> closed ___ Python tracker ___ ___ Python

[issue23439] Fixed http.client.__all__ and added a test

2015-02-19 Thread Demian Brecht
Demian Brecht added the comment: Left a super minor comment in Rietveld, but otherwise LGTM. -- ___ Python tracker ___ ___ Python-bugs

[issue21257] Document parse_headers function of http.client

2015-02-19 Thread Demian Brecht
Demian Brecht added the comment: Ignore my previous comment. It was intended for #23439. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue19792] pathlib does not support symlink in Windows XP

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: I've read the entire issue and don't believe there's anything to be done here. Plus the originator says in msg204557 "But anyway feel free to close this ticket". -- components: +Windows nosy: +BreamoreBoy, steve.dower, zach.ware ___

[issue9119] Python download page needs to mention crypto code in Windows installer

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: @Terry it does not look as if the download pages were ever updated so can you follow this up please? -- nosy: +BreamoreBoy ___ Python tracker ___

[issue10641] kill_python sometimes fails to kill processes on buildbots

2015-02-19 Thread Steve Dower
Steve Dower added the comment: Not sure if this still affects 2.7, but it doesn't affect 3.5 anymore. If one of the buildbot owners confirms that 2.7 is fine, I'll close. -- ___ Python tracker ___

[issue14672] Windows installer: add desktop shortcut(s)

2015-02-19 Thread Steve Dower
Steve Dower added the comment: Not going to happen. The desktop is for users, not installers, and apps installing shortcuts all over it is one of the reasons we got the Start Screen in Windows 8 (where only users can add items - no way for installers to do it). Besides, such an option would be

[issue14559] (2.7.3 Regression) PC\8.0 directory can no longer be used to build on windows

2015-02-19 Thread Steve Dower
Changes by Steve Dower : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue16111] Python 2.7.3 Windows MSI installer installs the VC++ 9 dlls directly to WinSxS folder

2015-02-19 Thread Martin v . Löwis
Changes by Martin v. Löwis : -- resolution: -> not a bug status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue16111] Python 2.7.3 Windows MSI installer installs the VC++ 9 dlls directly to WinSxS folder

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: Given the comments in msg194081 can we close this as "not a bug"? -- components: +Windows nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware ___ Python tracker _

[issue14672] Windows installer: add desktop shortcut(s)

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: I've never felt the need for these shortcuts but what do the rest of you guys think about it? -- components: +Windows nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware versions: +Python 3.5 ___ Python tracker

[issue23441] rlcompleter: tab on empty prefix => insert spaces

2015-02-19 Thread R. David Murray
R. David Murray added the comment: Looks good to me. I prefer 4 space indent as well, and since we have essentially deprecated the use of tabs for spacing in Python, I'd rather not reintroduce it here for the (minor) benefit of making backspacing easier. Just think about the copy and paste c

[issue14559] (2.7.3 Regression) PC\8.0 directory can no longer be used to build on windows

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: Presumably this can be closed as fixed? -- components: +Windows -Build nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware ___ Python tracker

[issue10641] kill_python sometimes fails to kill processes on buildbots

2015-02-19 Thread Mark Lawrence
Mark Lawrence added the comment: I don't recall seeing this flagged anywhere else so can we close it as out of date? -- components: +Windows -Build nosy: +BreamoreBoy, steve.dower, tim.golden, zach.ware ___ Python tracker

[issue23483] python 2.7 builds using icc

2015-02-19 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> duplicate ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue23485] PEP 475: handle EINTR in the select and selectors module

2015-02-19 Thread STINNER Victor
New submission from STINNER Victor: The implementation of the PEP 475 has to modify the following functions to restart on EINTR (and recompute the timeout): * select.select() * select.poll() * select.epoll.poll() * select.devpoll.poll() * select.kqueue.control() * selectors.SelectSelector.selec

[issue23484] SemLock acquire() keyword arg 'blocking' is invalid

2015-02-19 Thread Teodor Dima
New submission from Teodor Dima: The keyword for 'blocking' in the documentation for multiprocessing.Lock.acquire() (and all synchronization objects dependent on SemLock) differs from its implementation at Modules/_multiprocessing/semaphore.c:70 - https://docs.python.org/3.4/library/threading

[issue23483] python 2.7 builds using icc

2015-02-19 Thread SilentGhost
SilentGhost added the comment: I suggest you add this information to issue21167 as it's exactly the same behaviour you're seeing. There really is no need to have a separate issue. -- nosy: +SilentGhost status: open -> closed superseder: -> float('nan') returns 0.0 on Python compiled wi

[issue23483] python 2.7 builds using icc

2015-02-19 Thread Scholes C
New submission from Scholes C: HI, can you please look into this ? thanks. icc builds of python 2.7 seem to have issues handling nan, inf, etc $ /usr/local/python-2.7.6/bin/python Python 2.7.6 (default, Jan 10 2014, 12:14:02) [GCC Intel(R) C++ gcc 4.1 mode] on linux2 Type "help", "copyright", "

[issue433028] SRE: (?flag:...) is not supported

2015-02-19 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https: