[issue20080] Unused variable in Lib/sqlite3/test/factory.py

Vajrasky Kok added the comment: Thanks, Eric! Attached the patch to address Eric's concern. -- Added file: http://bugs.python.org/file33296/unused_variable_in_factory_py_v2.patch ___ Python tracker ___

[issue20097] Bad use of `self` in importlib

Eric Snow added the comment: Here's an updated patch that fixes as copy-and-paste mistake. -- Added file: http://bugs.python.org/file33295/issue20097-tests.diff ___ Python tracker __

[issue20097] Bad use of `self` in importlib

Changes by Eric Snow : Removed file: http://bugs.python.org/file33294/issue20097-tests.diff ___ Python tracker ___ ___ Python-bugs-list mailin

[issue20097] Bad use of `self` in importlib

Eric Snow added the comment: The patch passes on my linux box and on my windows 7 laptop (using Visual Studio 2010 Express). -- ___ Python tracker ___ __

[issue20097] Bad use of `self` in importlib

Eric Snow added the comment: Here's a patch with tests that cover find_module() and find_spec() for WindowsRegistryFinder (the missing case) and fixes the bug. -- keywords: +patch nosy: +eric.snow stage: test needed -> patch review Added file: http://bugs.python.org/file33294/issue20097

[issue20105] Codec exception chaining is losing traceback details

New submission from Nick Coghlan: The exception chaining in the codecs subsystem is currently losing the details of the original traceback. Compare this traceback from Python 3.3: >>> codecs.decode(b"abcdefgh", "hex_codec") Traceback (most recent call last): File "", line 1, in File "/usr

[issue20101] Determine correct behavior for time functions on Windows

Tim Peters added the comment: I'm not sanguine about fixing any of this :-( The Microsoft docs are awful, and the more web searches I do the more I realize that absolutely everyone is confused, just taking their best guesses. FYI, here are results from your new program on my 32-bit Vista box:

[issue20098] email policy needs a mangle_from setting

R. David Murray added the comment: Sorry, my message wasn't clear. The current default needs to remain the same. What needs to be added is email.policy.Policy.mange_from, which should be True in the compat32 policy and False in EmailPolicy. Then it needs to be hooked up the Generator, so tha

[issue20065] Python-3.3.3/Modules/socketmodule.c:1660:14: error: 'CAN_RAW' undeclared (first use in this function)

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue20104] expose posix_spawn(p)

Gregory P. Smith added the comment: Unless it could replace the fork+exec code path in its entirety, which I do not believe is possible, I see posix_spawn() as a distraction and additional maintenance burden with no benefit. http://pubs.opengroup.org/onlinepubs/759899/functions/posix_spawn

[issue20104] expose posix_spawn(p)

Changes by Antoine Pitrou : -- nosy: +gregory.p.smith, neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19108] Benchmark runner tries to execute external Python command and fails on error reporting

R. David Murray added the comment: The patch looks good to me, but since I'm not familiar with perf.py I'm not a good person to do a final review and commit it. One trivial question: why do you check for tupleness in PythonRuntime's init? Don't you control the input on both code paths to obta

[issue20104] expose posix_spawn(p)

Changes by Alex Gaynor : -- nosy: +alex ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue20104] expose posix_spawn(p)

Changes by Gennadiy Zlobin : -- nosy: +gennad ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue20104] expose posix_spawn(p)

New submission from Benjamin Peterson: posix_spawn is a nice, efficient replacement for fork()/exec(). We should expose it and possibly use it in subprocess where possible. -- components: Extension Modules messages: 207137 nosy: benjamin.peterson priority: normal severity: normal stage:

[issue20103] Documentation of itertools.accumulate is confused

Changes by Benjamin Peterson : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue20098] email policy needs a mangle_from setting

Gennadiy Zlobin added the comment: I created the patch, please review it. -- keywords: +patch nosy: +gennad Added file: http://bugs.python.org/file33293/20098.patch ___ Python tracker __

[issue20103] Documentation of itertools.accumulate is confused

New submission from Mitchell Model: The documentation of itertools.accumulate (10.1) starts out with 2 misleading sentences: "Make an iterator that returns accumulated sums. Elements may be any addable type..." It then goes on to show examples of using the func parameter added in 3.3 that are

[issue20075] help(open) eats first line

Gennadiy Zlobin added the comment: Zachary, thank you for review. Here's the updated patch. -- Added file: http://bugs.python.org/file33292/20075-3.patch ___ Python tracker ___ _

[issue20077] Format of TypeError differs between comparison and arithmetic operators

Mitchell Model added the comment: Patch looks good to me. I like the choice to drop the parens. This is my first time reviewing a change; did I go through the right mechanics? I clicked Review on the issue's patch, looked at the diff, and a published a message similar to this one. Was I suppos

[issue20101] Determine correct behavior for time functions on Windows

Changes by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue20102] shutil._make_zipfile possible resource leak

New submission from Peter Santoro: Now that zipfile.ZipFile supports the context manager protocol, shouldn't shutil._make_zipfile make use of it to avoid the possibility of the archive file not being closed properly if an exception occurs? It should be noted that shutil._unpack_zipfile does us

[issue20065] Python-3.3.3/Modules/socketmodule.c:1660:14: error: 'CAN_RAW' undeclared (first use in this function)

Changes by Charles-François Natali : -- assignee: -> neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19108] Benchmark runner tries to execute external Python command and fails on error reporting

Stefan Behnel added the comment: *bump* - patch pending review. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib