[issue11563] test_urllibnet is triggering a ResourceWarning

2013-12-03 Thread Martin Panter
Martin Panter added the comment: I think the fix for this bug only works if it gets the server to respond with a “Connection: close” header itself. I opened Issue 19524 because I was seeing keep-alive responses using chunked encoding that still trigger a socket leak. -- nosy: +vadmium

[issue19509] No SSL match_hostname() in ftp, imap, nntp, pop, smtp modules

2013-12-03 Thread Vajrasky Kok
Vajrasky Kok added the comment: I left my comment on the review. I forgot to mail the review. -- nosy: +vajrasky ___ Python tracker ___ __

[issue17134] Use Windows' certificate store for CA certs

2013-12-03 Thread Christian Heimes
Christian Heimes added the comment: The tests are passing again. Thanks! -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue10203] sqlite3.Row doesn't support sequence protocol

2013-12-03 Thread Claudiu.Popa
Claudiu.Popa added the comment: Thanks, Vajrasky! Here's an updated patch. -- Added file: http://bugs.python.org/file32968/sqlite2.patch ___ Python tracker ___ __

[issue19882] Closing a socket when makefile() is used

2013-12-03 Thread Martin Panter
New submission from Martin Panter: I think the documentation is rather vague about closing the underlying OS socket. Can someone verify if the following is true (*asterisked* bits are my additions), and maybe update the documentation? socket.close(): Close the socket *object*. *The underlying

[issue15883] Add Py_errno to work around multiple CRT issue

2013-12-03 Thread Christian Heimes
Changes by Christian Heimes : -- status: open -> pending versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ ___ Python-bugs-list

[issue19509] No SSL match_hostname() in ftp, imap, nntp, pop, smtp modules

2013-12-03 Thread Christian Heimes
Christian Heimes added the comment: PS: The test uses keycert3.pem and pycacert.pem from the 3.4 test directory. keycert3.pem contains privat + public key and is signed by the CA in pycacert.pem. -- ___ Python tracker

[issue19509] No SSL match_hostname() in ftp, imap, nntp, pop, smtp modules

2013-12-03 Thread Christian Heimes
Christian Heimes added the comment: I'd rather have integration test with a real SSL connection in order to check the entire stack. asyncio doesn't have a test for CERT_REQUIRED yet. The attached patch tests three common cases: missing CA, missing server_hostname and a successful connection wi

[issue10203] sqlite3.Row doesn't support sequence protocol

2013-12-03 Thread Vajrasky Kok
Vajrasky Kok added the comment: I got warning in compiling your patch: gcc -pthread -fPIC -Wno-unused-result -Werror=declaration-after-statement -g -O0 -Wall -Wstrict-prototypes -DMODULE_NAME="sqlite3" -DSQLITE_OMIT_LOAD_EXTENSION=1 -IModules/_sqlite -I/usr/include -I./Include -I. -IInclude -

[issue19881] Fix bigmem pickle tests

2013-12-03 Thread Alexandre Vassalotti
New submission from Alexandre Vassalotti: The bigmem tests for pickle are currently failing for protocol 4. The tests are broken because of an assumption rendered invalid by the frame header. Fixing the tests caught a legitimate bug in the save_bytes function of cpickle. -- assignee: a

[issue10203] sqlite3.Row doesn't support sequence protocol

2013-12-03 Thread Claudiu.Popa
Claudiu.Popa added the comment: I guess not, the documentation already states that Row tries to mimic a tuple in most of its features. Probably a MISC/News entry is required. -- ___ Python tracker

[issue19878] bz2.BZ2File.__init__() cannot be called twice with non-existent file

2013-12-03 Thread Vajrasky Kok
Vajrasky Kok added the comment: Here is the preliminary patch. -- keywords: +patch nosy: +vajrasky title: bz2.BZ2File.__init__() cannot be called twice -> bz2.BZ2File.__init__() cannot be called twice with non-existent file Added file: http://bugs.python.org/file32965/fix_segfault_in_b

[issue19138] doctest.IGNORE_EXCEPTION_DETAIL doesn't match when no detail exists

2013-12-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 017d7c27a4f6 by Tim Peters in branch '3.3': Issue #19138: doctest's IGNORE_EXCEPTION_DETAIL now allows no detail at all. http://hg.python.org/cpython/rev/017d7c27a4f6 -- ___ Python tracker

[issue19138] doctest.IGNORE_EXCEPTION_DETAIL doesn't match when no detail exists

2013-12-03 Thread Tim Peters
Changes by Tim Peters : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___ ___ Pytho

[issue19138] doctest.IGNORE_EXCEPTION_DETAIL doesn't match when no detail exists

2013-12-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5e14a3435f52 by Tim Peters in branch '2.7': Issue #19138: doctest's IGNORE_EXCEPTION_DETAIL now allows no detail at all. http://hg.python.org/cpython/rev/5e14a3435f52 -- ___ Python tracker

[issue19138] doctest.IGNORE_EXCEPTION_DETAIL doesn't match when no detail exists

2013-12-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset c80083ad142d by Tim Peters in branch 'default': Issue #19138: doctest's IGNORE_EXCEPTION_DETAIL now allows no detail at all. http://hg.python.org/cpython/rev/c80083ad142d -- nosy: +python-dev ___ Python t

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-12-03 Thread Chris Calloway
Chris Calloway added the comment: Format the martix of test reports. -- Added file: http://bugs.python.org/file32964/reports.html ___ Python tracker ___ _

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-12-03 Thread Chris Calloway
Chris Calloway added the comment: Formatted test directory layout. -- Added file: http://bugs.python.org/file32963/layouts.html ___ Python tracker ___ ___

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-12-03 Thread Chris Calloway
Chris Calloway added the comment: Reformat the filecmp test report matrix. -- Added file: http://bugs.python.org/file32962/test_filecmp_reports.rst ___ Python tracker ___ ___

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-12-03 Thread Chris Calloway
Changes by Chris Calloway : Removed file: http://bugs.python.org/file29746/test_filecmp_reports.rst ___ Python tracker ___ ___ Python-bugs-lis

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-12-03 Thread Chris Calloway
Chris Calloway added the comment: Reformat the filecmpdata directory layouts diagram. -- Added file: http://bugs.python.org/file32961/test_filecmp_layouts.rst ___ Python tracker

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-12-03 Thread Chris Calloway
Changes by Chris Calloway : Removed file: http://bugs.python.org/file29745/test_filecmp_layouts.rst ___ Python tracker ___ ___ Python-bugs-lis

[issue3208] function annotation for builtin and C function

2013-12-03 Thread Larry Hastings
Larry Hastings added the comment: Argument Clinic theoretically could support annotations for builtins, though it's never been tested. I don't know if it makes sense to close this bug yet. -- ___ Python tracker __

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-12-03 Thread Chris Calloway
Chris Calloway added the comment: The promised comments have been added to the patch. The refactoring of the pre-existing tests is not part of this patch. But I'm uploading this now as the patch does fix the issue. -- Added file: http://bugs.python.org/file32960/issue-15518-1.patch __

[issue3208] function annotation for builtin and C function

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: This issue has been addressed by the PEP 436 (Argument Clinic) which supports annotation per parameter and annotation on the return type. This PEP has been implemented in Python 3.4. I suggest to close the issue, but I would prefer that Larry closes the issue

[issue15518] Provide test coverage for filecmp.dircmp.report methods.

2013-12-03 Thread Chris Calloway
Changes by Chris Calloway : Removed file: http://bugs.python.org/file30040/issue-15518-1.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue11410] Use GCC visibility attrs in PyAPI_*

2013-12-03 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19817] tracemalloc add a memory limit feature

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: test_limit.patch: Patch to test the memory_limit on the Python test suite. tracemalloc_memory_limit-2.patch and unittest_leak.patch (of issue #19880) are required to test it. -- Added file: http://bugs.python.org/file32959/test_limit.patch ___

[issue19817] tracemalloc add a memory limit feature

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: Updated patch. -- Added file: http://bugs.python.org/file32958/tracemalloc_memory_limit-2.patch ___ Python tracker ___ _

[issue19741] tracemalloc: tracemalloc_log_alloc() doesn't check _Py_HASHTABLE_SET() return value

2013-12-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3c34ab550358 by Victor Stinner in branch 'default': Close #19741: tracemalloc_realloc() does not release the table lock anymore http://hg.python.org/cpython/rev/3c34ab550358 -- resolution: -> fixed stage: -> committed/rejected status: open

[issue19757] _tracemalloc.c: compiler warning with gil_state

2013-12-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 194f74044537 by Victor Stinner in branch 'default': Close #19757: Cleanup tracemalloc, move http://hg.python.org/cpython/rev/194f74044537 -- nosy: +python-dev resolution: -> fixed stage: -> committed/rejected status: open -> closed __

[issue19880] unittest: on failure, TestCase.run() keeps a reference to the exception

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: unittest_leak.patch: Fix the the initial bug, unittest_leak.py. I don't think that it's possible to write a generic fix for frame_ref_cycle.py. Storing sys.exc_info() to format it as a traceback later is a common pattern. Clearing a frame at function exit brea

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Radomir Dopieralski
Radomir Dopieralski added the comment: Actually, after looking closer, my @memoize_method decorator does something completely different than Serhiy suggested. Still it only solves the common case of methods, and does nothing if you pass your short-lived objects as other parameters than self.

[issue19880] unittest: on failure, TestCase.run() keeps a reference to the exception

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: I found this issue while working the memory limit feature of tracemalloc module (issue #19817). I opened #19835 to workaround an unlimited loop on PyErr_NoMemory() when Python is out of memory. See also the issue #17807 and the PEP 442 for a similar reference

[issue19827] Optimize socket.settimeout() and socket.setblocking(): avoid syscall

2013-12-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5f0d1aad7322 by Victor Stinner in branch 'default': Close #19827: On UNIX, setblocking() and settimeout() methods of socket.socket http://hg.python.org/cpython/rev/5f0d1aad7322 -- nosy: +python-dev resolution: -> fixed stage: -> committed/

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Radomir Dopieralski
Radomir Dopieralski added the comment: The method example is just the most common case where this problem can be easily seen, but not the only one. We indeed use the @cached_property decorator on properties (similar to https://github.com/mitsuhiko/werkzeug/blob/master/werkzeug/utils.py#L35), a

[issue19880] unittest: on failure, TestCase.run() keeps a reference to the exception

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: frame_ref_cycle.py: if I understood correctly, unittest_leak.py can be simplified to this script. A frame contains a local variable which contains the frame: reference cycle. -- Added file: http://bugs.python.org/file32956/frame_ref_cycle.py _

[issue19880] unittest: on failure, TestCase.run() keeps a reference to the exception

2013-12-03 Thread STINNER Victor
Changes by STINNER Victor : Added file: http://bugs.python.org/file32955/generator_workaround.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue10203] sqlite3.Row doesn't support sequence protocol

2013-12-03 Thread Éric Araujo
Éric Araujo added the comment: Patch looks good! Are documentation changes needed? -- keywords: +needs review stage: -> patch review ___ Python tracker ___

[issue19880] unittest: on failure, TestCase.run() keeps a reference to the exception

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: contextmanager_leak2.py: even simpler example, storing a current frame in a local variable of the frame is enough. generator_workaround.patch is another workaround: call frame.clear() when at generator exit to explicitly break the reference cycle. --

[issue8075] Windows (Vista/7) install error when choosing to compile .py files

2013-12-03 Thread Brian Curtin
Brian Curtin added the comment: Time between comments will never be a factor in closing bugs. If this isn't an issue with 2.7, then we can close it. I'm not near a Windows machine this week as I'm traveling, so I can't check it out for a while. -- _

[issue8075] Windows (Vista/7) install error when choosing to compile .py files

2013-12-03 Thread Mark Lawrence
Mark Lawrence added the comment: As a Windows user myself I'd say close it as it's been the better part of four years since there was a comment here. -- nosy: +BreamoreBoy ___ Python tracker ___

[issue19827] Optimize socket.settimeout() and socket.setblocking(): avoid syscall

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: LGTM. I know I've written similar code in Python. :-) -- ___ Python tracker ___ ___ Python-bugs-l

[issue19880] unittest: on failure, TestCase.run() keeps a reference to the exception

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: contextmanager_leak.py: shorter script to demonstrate the issue. Replacing "exc_info = sys.exc_info()" with "sys.exc_info()" works around the issue. -- Added file: http://bugs.python.org/file32953/contextmanager_leak.py ___

[issue19880] unittest: on failure, TestCase.run() keeps a reference to the exception

2013-12-03 Thread STINNER Victor
Changes by STINNER Victor : -- keywords: +patch Added file: http://bugs.python.org/file32952/unittest_workaround.patch ___ Python tracker ___

[issue19880] unittest: on failure, TestCase.run() keeps a reference to the exception

2013-12-03 Thread STINNER Victor
New submission from STINNER Victor: Test attached unittest_leak.py script: you will see MyException.ninstance counter increased up to 10, whereas I expect that MyException is destroyed at TestCase.run() exit. It looks like a tricky reference cycle between: - frames - exc_info local variable o

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: (What I meant to add was, I'd be happy if unregister() also just used a true/false return.) -- ___ Python tracker ___ ___

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: Heh, I'd forgotten the behavior of unregister(). It seems that there are two layers to the behavior -- if this FD was never register()ed it will raise; if it was register()ed but has since been close()d it may raise. For the higher-level APIs in asyncio I c

[issue19138] doctest.IGNORE_EXCEPTION_DETAIL doesn't match when no detail exists

2013-12-03 Thread Tim Peters
Tim Peters added the comment: On second thought, I don't want to use a regexp for this. The mandatory colon _was_ a kind of absolute wall, and the various instances of "[^:]" exploited that to avoid unintended matches. But "possibly dotted name followed possibly by a colon" is straightforward

[issue8075] Windows (Vista/7) install error when choosing to compile .py files

2013-12-03 Thread Ethan Furman
Ethan Furman added the comment: Just tried installing 2.6.6 on Windows 7 with compile checked and make default unchecked and did not observe any problems (although it did scroll by at high speed, and the windows didn't stay open for me to peruse). However, since we are no longer releasing bina

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: >>> import selectors, os >>> r,w=os.pipe() >>> s=selectors.SelectSelector() >>> s.register(r, selectors.EVENT_READ) SelectorKey(fileobj=3, fd=3, events=1, data=None) >>> os.close(r) >>> os.close(w) >>> s.unregister(r) SelectorKey(fileobj=3, fd=3, events=1, data=N

[issue19787] tracemalloc: set_reentrant() should not have to call PyThread_delete_key()

2013-12-03 Thread Charles-François Natali
Charles-François Natali added the comment: > STINNER Victor added the comment: > > Kristján> Only that issue #10517 mentions reasons to keep the old behavior, > specifically http://bugs.python.org/issue10517#msg134573 (...) > > @Kristján: The behaviour of PyThread_set_key() discussed in this iss

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread Charles-François Natali
Charles-François Natali added the comment: > Guido van Rossum added the comment: > > I think you're looking for the discussion in issue 19017. > > IIRC the conclusion is that not only do you not get the same error > everywhere, but you get it at different points -- sometimes register() of a > b

[issue19878] bz2.BZ2File.__init__() cannot be called twice

2013-12-03 Thread Nadeem Vawda
Nadeem Vawda added the comment: It appears that this *does* affect 2.7 (though not 3.2, 3.3 or 3.4, fortunately): ~/src/cpython/2.7☿ gdb --ex run --args ./python -c 'import bz2; obj = bz2.BZ2File("/dev/null"); obj.__init__("")' «... snip banner ...» Starting program: /home.u/nadeem

[issue19787] tracemalloc: set_reentrant() should not have to call PyThread_delete_key()

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: Kristján> Only that issue #10517 mentions reasons to keep the old behavior, specifically http://bugs.python.org/issue10517#msg134573 (...) @Kristján: The behaviour of PyThread_set_key() discussed in this issue is unrelated to the pthread bug related to fork()

[issue19879] imageop: bug in error handler

2013-12-03 Thread Ned Deily
Ned Deily added the comment: @Victor: On 2.6, it gets a DeprecationWarning. On 2.7, that is now a TypeError. -- ___ Python tracker ___ __

[issue19827] Optimize socket.settimeout() and socket.setblocking(): avoid syscall

2013-12-03 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +gvanrossum, neologix, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue19817] tracemalloc add a memory limit feature

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: This feature cannot be used without a reliable PyErr_NoMemory(): I add issue #19835 as a dependency. -- dependencies: +Add a MemoryError singleton to fix an unlimited loop when the memory is exhausted ___ Python tra

[issue19879] imageop: bug in error handler

2013-12-03 Thread Matthew Bergin
Matthew Bergin added the comment: Sweet, I will check it out -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19879] imageop: bug in error handler

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: "I typically host all of the code I write at https://github.com/levle but atm the github repo I use to host the project is private. Once I work out some of the kinks I will set it to Public." I worked on a Python fuzzer some years ago and fixed a lot of simila

[issue19879] imageop: bug in error handler

2013-12-03 Thread Ned Deily
Ned Deily added the comment: On 2.7 tip, it fails up front with a TypeError: File "/home/nad/PyCFunction.py", line 5, in imageop.rgb82rgb(u"%J8CBej >uFBi-",True,8.36) TypeError: integer argument expected, got float [18330 refs] -- nosy: +ned.deily ___

[issue19879] imageop: bug in error handler

2013-12-03 Thread Matthew Bergin
Matthew Bergin added the comment: I am going to test it against 2.7 a little later on this afternoon. I typically host all of the code I write at https://github.com/levle but atm the github repo I use to host the project is private. Once I work out some of the kinks I will set it to Public. -

[issue19878] bz2.BZ2File.__init__() cannot be called twice

2013-12-03 Thread Matthew Bergin
Matthew Bergin added the comment: I was fuzzing the interpreter otherwise it would init itself -- ___ Python tracker ___ ___ Python-bu

[issue19879] imageop: bug in error handler

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: I cannot test the issue, imageop cannot be compiled on 64-bit system and is not present in Python 3. (I don't have access to 32-bit system right now.) Can you reproduce the issue with Python 2.7? I'm interested by your fuzzer, is it public? -- nosy: +

[issue19878] bz2.BZ2File.__init__() cannot be called twice

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: I can reproduce the issue with Python 2.7. The problem is that BZ2File.__init__() doesn't reset the object when __init__() is called twice. For example, the following script fails with "too many open files" error, before the previous file is not called: --- im

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Raymond Hettinger
Raymond Hettinger added the comment: I don't think this is an appropriate use of an LRU cache. There are other ways to "freeze" a method return value (typically by storing the result in an instance). Here's one way of doing it (taken from the source code for Itty https://pypi.python.org/pypi

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps following technique can be used to prevent object's life prolongation: def spam(self, *args, **kwargs): @lru_cache(maxsize=20) def spam(foo, bar=1, *, baz=None): ... self.spam = spam return self.spam(*args, **kwargs) --

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- type: resource usage -> enhancement versions: -Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker ___ __

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Weak references make no sense in most cases when arguments disappear just after function call. For the self argument of a method it makes more sense. Perhaps lru_cache can return not a function, but a descriptor. This will allow implement special processing

[issue19862] Unclear xpath caching for custom namespaces

2013-12-03 Thread Stefan Behnel
Stefan Behnel added the comment: This is a duplicate of issue17011. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue19138] doctest.IGNORE_EXCEPTION_DETAIL doesn't match when no detail exists

2013-12-03 Thread Tim Peters
Tim Peters added the comment: I agree this is a bug, and at a first scan your fix looks good. I'll make it a priority to pay more attention to it now ;-) -- assignee: -> tim.peters ___ Python tracker ___

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +ncoghlan, rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue19859] functools.lru_cache keeps objects alive forever

2013-12-03 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file32950/66c1c9f32567.diff ___ Python tracker ___ __

[issue19878] PyFile_DecUseCount() SIGSEGV

2013-12-03 Thread Ned Deily
Ned Deily added the comment: Sorry, the Python 2.6 series is now officially retired. As of 2.6.9, "All official maintenance for Python 2.6, including security patches, has ended." If you can reproduce the problem with a currently supported version of Python, such as Python 2.7.6 or 3.3.3, pl

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: I think you're looking for the discussion in issue 19017. IIRC the conclusion is that not only do you not get the same error everywhere, but you get it at different points -- sometimes register() of a bad FD passes and then [Selector.]select() fails, other t

[issue19850] asyncio: limit EINTR occurrences with SA_RESTART

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: OK, I've harassed you enough. Sorry. Go ahead and commit this. -- ___ Python tracker ___ ___ Pytho

[issue19850] asyncio: limit EINTR occurrences with SA_RESTART

2013-12-03 Thread Charles-François Natali
Charles-François Natali added the comment: > The patch is fine, but it is hard to rely on it to prevent bugs from > happening because that requires cooperation from all modules registering > signal handlers. Once again, that's why the bug report says "*limit* EINTR occurrences". We all know th

[issue19877] test_resolve_dot of test_pathlib.py fails on Windows Vista

2013-12-03 Thread Brian Curtin
Brian Curtin added the comment: My build slave ran as admin in order to make sure symlinks were covered, but I don't have the hardware anymore. I'll see if I can get another machine up and running. -- nosy: +brian.curtin ___ Python tracker

[issue19878] PyFile_DecUseCount() SIGSEGV

2013-12-03 Thread Matthew Bergin
Changes by Matthew Bergin : -- type: -> crash ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue19879] PyCFunction_NewEx() SIGABRT

2013-12-03 Thread Matthew Bergin
New submission from Matthew Bergin: [level@ fuzz]# cat PyCFunction.py # # PyCFunction_NewEx crach poc (sigabrt) # import imageop imageop.rgb82rgb(u"%J8CBej >uFBi-",True,8.36) imageop.grey2grey(None,5,u"CRi") [level@ fuzz]# gdb --args python PyCFunction.py GNU gdb (GDB) Red Hat Enterprise Linux (7

[issue19878] PyFile_DecUseCount() SIGSEGV

2013-12-03 Thread Matthew Bergin
New submission from Matthew Bergin: [level@ fuzz]# cat pyfile.py import bz2 obj = bz2.BZ2File('/tmp/fileName') obj.__init__("fileName") obj.__reduce__ [level@ fuzz]# gdb --args python pyfile.py GNU gdb (GDB) Red Hat Enterprise Linux (7.2-60.el6_4.1) Copyright (C) 2010 Free Software Foundation, In

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: "(I don' like the idea of documenting possible behaviors, because it's non-portable, and really might change in a future version)." The description doesn't need to be precise, you can just say "depending on the platform, closing a file descriptor while selector

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: I think we should give the reader some kind of hint, since a bug in this area may cause a lot of pain when it has to be debugged on porting from a system where the issue is silent to one where it causes a crash. These docs (unlike a PEP) are not a formal st

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread Charles-François Natali
Charles-François Natali added the comment: Well, unregister() documentation currently contains this: """ .. method:: unregister(fileobj) Unregister a file object from selection, removing it from monitoring. A file object shall be unregistered prior to being closed. """ I'm not su

[issue18699] What is Future.running() for in PEP 3148 / concurrent.futures.Future?

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: I see no point in keeping this open. -- resolution: -> works for me stage: -> committed/rejected status: open -> closed type: enhancement -> behavior ___ Python tracker ___

[issue19866] tests aifc, sunau and wave failures on a fresh Win64 installation

2013-12-03 Thread Zachary Ware
Zachary Ware added the comment: Francis, would you like to work on a patch for this? The change should go in Tools/msi/msi.py, if I'm not mistaken. -- ___ Python tracker ___ __

[issue19875] test_getsockaddrarg occasional failure

2013-12-03 Thread Charles-François Natali
Charles-François Natali added the comment: This test is inherently subject to a race condition: """ port = support.find_unused_port() [...] try: self.assertRaises(OverflowError, sock.bind, (host, big_port)) self.assertRaises(OverflowError, sock.bind

[issue18699] What is Future.running() for in PEP 3148 / concurrent.futures.Future?

2013-12-03 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19833] asyncio: patches to document EventLoop and add more examples

2013-12-03 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19871] json module won't parse a float that starts with a decimal point

2013-12-03 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19877] test_resolve_dot of test_pathlib.py fails on Windows Vista

2013-12-03 Thread Antoine Pitrou
Antoine Pitrou added the comment: Now committed. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue19877] test_resolve_dot of test_pathlib.py fails on Windows Vista

2013-12-03 Thread Roundup Robot
Roundup Robot added the comment: New changeset 076824de7650 by Antoine Pitrou in branch 'default': Issue #19877: fix regression in test_pathlib when Windows has symlink support available (i.e. in administrator mode). http://hg.python.org/cpython/rev/076824de7650 -- nosy: +python-dev __

[issue19877] test_resolve_dot of test_pathlib.py fails on Windows Vista

2013-12-03 Thread Antoine Pitrou
Antoine Pitrou added the comment: Wow, thank you. It's a pity none of the Windows buildbots runs in administrator mode. -- ___ Python tracker ___ ___

[issue19877] test_resolve_dot of test_pathlib.py fails on Windows Vista

2013-12-03 Thread Vajrasky Kok
New submission from Vajrasky Kok: You must run this test as administrator. C:\Users\vajrasky\Code\cpython>PCbuild\python.exe Lib\test\test_pathlib.py ..s..s..s..s.s.E .

[issue19850] asyncio: limit EINTR occurrences with SA_RESTART

2013-12-03 Thread STINNER Victor
STINNER Victor added the comment: 2013/12/3 Guido van Rossum : > Please answer this question. Under what circumstances can a signal handler > interrupt a blocking system call in a thread that is not the main thread? There is no guarantee that the signal handler is called in the main thread. On

[issue7105] weak dict iterators are fragile because of unpredictable GC runs

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: I'm not sure I understand the hesitation about backporting the Python 3 solution. We're acknowledging it's a bug, so the fix is not a feature. The Python 3 solution is the future. So why not fix it? -- ___ Python

[issue16594] SocketServer should set SO_REUSEPORT along with SO_REUSEADDR when present

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: Note: it is possible that SO_REUSEPORT is defined yet not implemented (and you'll get an OSError when using it). -- nosy: +gvanrossum ___ Python tracker

[issue19876] selectors (and asyncio?): document behaviour on closed files/sockets

2013-12-03 Thread Guido van Rossum
Guido van Rossum added the comment: Yeah, the behavior is at least different for each type of polling system calls, and possibly also for different platforms. It would be good to describe at least all the different possible behaviors. -- ___ Python

[issue19864] multiprocessing Proxy docs need locking semantics explained

2013-12-03 Thread Richard Oudkerk
Richard Oudkerk added the comment: >From what I remember a proxy method will be thread/process-safe if the >referent's corresponding method is thread safe. It should certainly be documented that the exposed methods of a proxied object should be thread-safe. -- ___

  1   2   >