[issue19649] Clean up OS X framework and universal bin directories

2013-11-18 Thread Ned Deily
Changes by Ned Deily : -- keywords: +patch Added file: http://bugs.python.org/file32698/issue19649_bin_install_targets.patch ___ Python tracker ___ _

[issue19649] Clean up OS X framework and universal bin directories

2013-11-18 Thread Ned Deily
New submission from Ned Deily: There are currently various differences in the files installed by "make altinstall" and "make install" for OS X framework (./configure --enable-framework) and/or OS X universal (--with-universal-archs) configurations. Some of the differences are cosmetic; some a

[issue2927] expose html.parser.unescape

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I added comments on Rietveld. Yet one thing. For now the html module is very simple and has no dependencies. The patch adds an import of re and html.escapes and relative heavy re.compile operations. Due to the fact that the html module is implicitly imported

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

2013-11-18 Thread Eric Snow
Eric Snow added the comment: Brett: looks like something frozen-related broke due to 6d1656ab2c85a527c. test_frozen in test_frozen.py is failing now because frozen modules no longer have a __cached__ attribute (which was previously set to None). Previously it was set in PyImport_ExecCodeModul

[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-11-18 Thread Alexandre Vassalotti
Alexandre Vassalotti added the comment: I have been looking again at Stefan's previous proposal of making memoization implicit in the new pickle protocol. While I liked the smaller pickles it produced, I didn't the invasiveness of the implementation, which requires a change for almost every op

[issue19648] Empty tests in pickletester need to be implemented or removed

2013-11-18 Thread Zachary Ware
New submission from Zachary Ware: There are a couple of tests in pickletester that should either be implemented or removed, namely test_reduce and test_getinitargs of AbstractPickleTests. I don't know enough about pickling to suggest which route should be taken or how, so I'll leave that up to

[issue19597] Add decorator for tests not yet implemented

2013-11-18 Thread Zachary Ware
Zachary Ware added the comment: There are a couple in pickletester, one in test_io, a few in test_reprlib, and the ones in the patch from test_minidom; some 10 test methods in total that I've found and remembered. I suppose with that few, it would be best to just open issues for each test mod

[issue19596] Silently skipped tests in test_importlib

2013-11-18 Thread Zachary Ware
Zachary Ware added the comment: Committed in 3.3 and as 5d38989191bb in features/pep-451. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___

[issue19596] Silently skipped tests in test_importlib

2013-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1ac4f0645519 by Zachary Ware in branch '3.3': Issue #19596: Set untestable tests in test_importlib to None http://hg.python.org/cpython/rev/1ac4f0645519 New changeset 34a65109d191 by Zachary Ware in branch 'default': Issue #19596: Null merge with 3.

[issue19572] Report more silently skipped tests as skipped

2013-11-18 Thread Zachary Ware
Zachary Ware added the comment: I'll open new issues for test_posix and pickletester and commit the rest of the patch as soon as I can get it backported. Thanks for the reviews! -- ___ Python tracker

[issue19626] test_email and Lib/email/_policybase.py failures with -OO

2013-11-18 Thread R. David Murray
Changes by R. David Murray : -- status: pending -> open superseder: -> pyo's are not overwritten by different optimization levels ___ Python tracker ___

[issue19626] test_email and Lib/email/_policybase.py failures with -OO

2013-11-18 Thread R. David Murray
Changes by R. David Murray : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue2506] Add mechanism to disable optimizations

2013-11-18 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue19626] test_email and Lib/email/_policybase.py failures with -OO

2013-11-18 Thread R. David Murray
R. David Murray added the comment: I can't get this to fail. The code handles None docstrings correctly (_append_doc is not called if the __doc__ attribute is None). The only way I can see this error arising would be if the _policybase.pyo file had docstrings stripped, but the policy.pyo file

[issue17457] Unittest discover fails with namespace packages and builtin modules

2013-11-18 Thread Eric Snow
Eric Snow added the comment: Sorry for any confusion, Claudiu. the_module.__path__ only indicates that the module is a package. So until you can take advantage of PEP 451, you're stuck with the _path check (or several other unappealing hack) on line 224 of unittest-17457-3.patch. However, t

[issue19647] unittest.TestSuite consumes tests

2013-11-18 Thread R. David Murray
R. David Murray added the comment: This is presumably a consequence of issue 11798. How did you run into it in actual code? -- nosy: +r.david.murray ___ Python tracker ___

[issue17457] Unittest discover fails with namespace packages and builtin modules

2013-11-18 Thread Claudiu.Popa
Claudiu.Popa added the comment: Eric, thank you for your comment! I modified the patch to check for __path__ instead, is this a safe enough check for this use case? Since ModuleSpec isn't landed yet, I didn't use your __spec__ example. -- Added file: http://bugs.python.org/file32697/un

[issue12892] UTF-16 and UTF-32 codecs should reject (lone) surrogates

2013-11-18 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: ezio.melotti -> serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

2013-11-18 Thread Nick Coghlan
Nick Coghlan added the comment: Just a heads up - since the two of you appear to have this well in hand, don't wait for a review from me before committing it. I have plenty of other things to look at before the beta deadline :) -- ___ Python tracker

[issue17457] Unittest discover fails with namespace packages and builtin modules

2013-11-18 Thread Eric Snow
Eric Snow added the comment: I left a review relative to the use of the _path attribute (which shouldn't be used). -- nosy: +eric.snow ___ Python tracker ___ ___

[issue19596] Silently skipped tests in test_importlib

2013-11-18 Thread Zachary Ware
Zachary Ware added the comment: Alright, I'll try to do that later this evening. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue19513] Use PyUnicodeWriter instead of PyAccu in repr(tuple) and repr(list)

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Old version looks better to me (it is simpler and performance of writing final ",)" is not worth additional complication). -- ___ Python tracker

[issue19647] unittest.TestSuite consumes tests

2013-11-18 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +michael.foord ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19647] unittest.TestSuite consumes tests

2013-11-18 Thread Stefan Holek
New submission from Stefan Holek: This test passed in Python <= 3.3 but fails in 3.4: def testTestSuiteConsumesTest(self): class MyTestCase(unittest.TestCase): def testMethod(self): pass test = MyTestCase('testMethod') suite = unittest.Test

[issue19513] Use PyUnicodeWriter instead of PyAccu in repr(tuple) and repr(list)

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: Ok, here is a new version hyper optimized for the final ",)" string :-) -- Added file: http://bugs.python.org/file32696/tuple_repr_writer-2.patch ___ Python tracker ___

[issue19513] Use PyUnicodeWriter instead of PyAccu in repr(tuple) and repr(list)

2013-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset ead9043f69df by Victor Stinner in branch 'default': Issue #19513: Simplify list_repr() http://hg.python.org/cpython/rev/ead9043f69df -- ___ Python tracker

[issue19646] Use PyUnicodeWriter in repr(dict)

2013-11-18 Thread STINNER Victor
Changes by STINNER Victor : Added file: http://bugs.python.org/file32695/bench_dict_repr.py ___ Python tracker ___ ___ Python-bugs-list mailin

[issue19646] Use PyUnicodeWriter in repr(dict)

2013-11-18 Thread STINNER Victor
New submission from STINNER Victor: Attached patch modify dict_repr() function to use the _PyUnicodeWriter API instead of building a list of short strings with PyUnicode_AppendAndDel() and calling PyUnicode_Join() at the end to join the list. PyUnicode_Append() is inefficient because it has to

[issue19513] Use PyUnicodeWriter instead of PyAccu in repr(tuple) and repr(list)

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: I checked in list_repr_writer-2.patch, thanks Serhiy for your review. And now the patch for repr(tuple). Result of bench_tuple_repr.py: Common platform: CFLAGS: -Wno-unused-result -Werror=declaration-after-statement -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-pro

[issue19513] Use PyUnicodeWriter instead of PyAccu in repr(tuple) and repr(list)

2013-11-18 Thread STINNER Victor
Changes by STINNER Victor : Added file: http://bugs.python.org/file32693/bench_tuple_repr.py ___ Python tracker ___ ___ Python-bugs-list maili

[issue19581] PyUnicodeWriter: change the overallocation factor for Windows

2013-11-18 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19513] Use PyUnicodeWriter instead of PyAccu in repr(tuple) and repr(list)

2013-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset fc7ceb001eec by Victor Stinner in branch 'default': Issue #19513: repr(list) now uses the PyUnicodeWriter API, it is faster than http://hg.python.org/cpython/rev/fc7ceb001eec -- nosy: +python-dev ___ Pyth

[issue19581] PyUnicodeWriter: change the overallocation factor for Windows

2013-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 093b9838a41c by Victor Stinner in branch 'default': Issue #19581: Change the overallocation factor of _PyUnicodeWriter on Windows http://hg.python.org/cpython/rev/093b9838a41c -- nosy: +python-dev ___ Pyt

[issue7105] weak dict iterators are fragile because of unpredictable GC runs

2013-11-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Btw, I think a cleaner way to deal with unpredictable GC runs is to be able > to temporarily disable GC with a context manager Disabling the GC in a library function sounds very ugly to me. -- ___ Python tracker

[issue17397] ttk::themes missing from ttk.py

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Since splitlist() works with Tcl_Obj-s, proposed test should pass. klappnase, could you please sign a Contributor Licensing Agreement? http://www.python.org/psf/contrib/contrib-form/ What is your real name? What should I add in the Misc/ACKS file? -

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread Zachary Ware
Zachary Ware added the comment: I make no claims of being good at naming things :) -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread Tim Golden
Tim Golden added the comment: TBH I'm still fairly -0 and edging towards -0.5. If we didn't already have two keyword args I might be convinced towards a jfdi=True flag. But, as the OP described, the current params already allow for a workaround of sorts and another param of the semantics we're

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread R. David Murray
R. David Murray added the comment: That's not a good name for the flag. The problem is that 'read-only' means different things on Windows than it does on Unix. Which is why I suggested that the flag control whether or not it acts "posix like" on Windows. So perhaps 'posix_compat'? That fee

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread Zachary Ware
Zachary Ware added the comment: I like the idea of a remove_readonly flag. I was going to say that I'm a bit worried about the fact that shutil.rmtree already has a couple of keyword arguments, but it's nowhere near what, say, copytree has. Call me +0.75. --

[issue16596] Skip stack unwinding when "next", "until" and "return" pdb commands executed in generator context

2013-11-18 Thread Guido van Rossum
Guido van Rossum added the comment: Basically the debugger lost control and the program ran to completion after I hit 'n' that returned from the coroutine. -- ___ Python tracker ___

[issue19437] More failures found by pyfailmalloc

2013-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8f770cdb7a19 by Victor Stinner in branch 'default': Issue #19437: Fix error handling of CDataType_from_buffer() http://hg.python.org/cpython/rev/8f770cdb7a19 New changeset 556bdd8d0dde by Victor Stinner in branch 'default': Issue #19437: Fix error h

[issue16596] Skip stack unwinding when "next", "until" and "return" pdb commands executed in generator context

2013-11-18 Thread Xavier de Gaye
Xavier de Gaye added the comment: A description of what goes wrong when stepping out of the generator would be helpful. -- ___ Python tracker ___

[issue11344] Add os.path.splitpath(path) function

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Added examples and Martin's notes to the documentation. ntpath implementation rewrote with regular expressions (it is now shorter and perhaps more clear). -- Added file: http://bugs.python.org/file32691/ospath_splitpath_2.patch __

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread Ivan Radic
Ivan Radic added the comment: >You are essentially asking that we have an option to make the windows behavior >mirror the posix behavior? (A read only file in a writable directory can be >deleted in posix, since only the directory entry, not the file, is being >deleted.) Actually, your expla

[issue19638] dtoa: conversion from '__int64' to 'int', possible loss of data

2013-11-18 Thread Jeremy Kloth
Changes by Jeremy Kloth : -- nosy: +jkloth ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue19618] test_sysconfig_module fails on Ubuntu 12.04

2013-11-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I also can't reproduce this in Python 3.3 or 3.4 on Trusty Tahr (what will be Ubuntu 14.04). -- ___ Python tracker ___ ___

[issue19596] Silently skipped tests in test_importlib

2013-11-18 Thread Brett Cannon
Brett Cannon added the comment: I've actually started doing this in the PEP 451 repo and it's working out so far. When that all lands I should have all the loaders ported but not the finders. If you want, Zachary, you can make the chances in the PEP 451 repo so you don't have to wonder what ha

[issue9878] Avoid parsing pyconfig.h and Makefile by autogenerating extension module

2013-11-18 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I believe this has been fixed for a while. -- ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue19640] Drop _source attribute of namedtuple

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: > the 5th line allocating the memory memory oops, the 5th line allocating the *most* memory -- ___ Python tracker ___

[issue19645] decouple unittest assertions from the TestCase class

2013-11-18 Thread R. David Murray
R. David Murray added the comment: You should probably start by summarizing the assertThat proposal from issue 18054, which suggested making a separate issue for assertThat. -- nosy: +r.david.murray title: Improving unittest assertions -> decouple unittest assertions from the TestCase

[issue19638] dtoa: conversion from '__int64' to 'int', possible loss of data

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: See also the "meta-issue" #9566: "Compilation warnings under x64 Windows". -- ___ Python tracker ___ ___

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread R. David Murray
R. David Murray added the comment: Well, it would *definitely* need to be a new explicit option whose default value was the current behavior. -- ___ Python tracker ___ _

[issue19638] dtoa: conversion from '__int64' to 'int', possible loss of data

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: "I don't much like the use of Py_SSIZE_T and Py_SAFE_DOWNCAST here (...) And in fact I'd say that we *shouldn't* be silencing these warnings; rather, we should take them seriously." So size_t should be used instead ("s - s1" is unsigned, s >= s1). --

[issue19638] dtoa: conversion from '__int64' to 'int', possible loss of data

2013-11-18 Thread Mark Dickinson
Changes by Mark Dickinson : -- assignee: -> mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue19638] dtoa: conversion from '__int64' to 'int', possible loss of data

2013-11-18 Thread Mark Dickinson
Mark Dickinson added the comment: I don't much like the use of Py_SSIZE_T and Py_SAFE_DOWNCAST here: the dtoa.c code knows almost nothing about Python.h (aside from right at the top), and I'd like to keep it that way if possible. And in fact I'd say that we *shouldn't* be silencing these warn

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread Tim Golden
Tim Golden added the comment: This, unfortunately, is the classic edge-case where intra-platform consistency and inter-platform consistency clash. I (on Windows) would certainly be surprised if a tree delete removed read-only files without my specifying some kind of override. I understand why

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread R. David Murray
R. David Murray added the comment: You are essentially asking that we have an option to make the windows behavior mirror the posix behavior? (A read only file in a writable directory can be deleted in posix, since only the directory entry, not the file, is being deleted.) That makes some sen

[issue19642] shutil to support equivalent of: rm -f /dir/*

2013-11-18 Thread R. David Murray
R. David Murray added the comment: See also issue 13229. You can replicate 'rm -f' like this: for p in glob.glob('/dir/*'): os.remove(p) That doesn't seem worth an extra function. The annoying one to emulate is 'rm -rf /dir/*', because with the current shutil tools you have to make

[issue19645] Improving unittest assertions

2013-11-18 Thread Gregory Salvan
New submission from Gregory Salvan: Actually unittest assertions depends on testcase class forcing us to extend it to add assertions and to use it to make assertions outside tests. Seeing interests in rethinking the way assertions are done in unittest, this issue first intent to collect feedba

[issue13090] test_multiprocessing: memory leaks

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: > If a daemon thread is killed while it is blocking on os.read() > then the bytes object used as the read buffer will never be decrefed. Ah yes, so another reason to ensure that daemon threads exit normally at Python shutdown :-) -- __

[issue13090] test_multiprocessing: memory leaks

2013-11-18 Thread Richard Oudkerk
Richard Oudkerk added the comment: > If the result of os.read() was stored in a Python daemon thread, the > memory should be released since the following changeset. Can someone > check if this issue still exist? If a daemon thread is killed while it is blocking on os.read() then the bytes obj

[issue19617] Fix usage of Py_ssize_t type in Python/compile.c

2013-11-18 Thread Benjamin Peterson
Benjamin Peterson added the comment: I meant where you added casts, you could use it. 2013/11/18 STINNER Victor : > > STINNER Victor added the comment: > >> You could use the Py_SAFE_DOWNCAST macro everywhere. > > I prefer to store sizes in a size type (Py_ssize_t), and only downcast where > it

[issue11344] Add os.path.splitpath(path) function

2013-11-18 Thread Martin Panter
Martin Panter added the comment: The ntpath.splitpath() version is easy to get lost in. It would probably help if you spelt out all the single-letter variable names, and explained that tri-state root/separator = None/True/False flag. Maybe there is a less convoluted way to write it too, I dunn

[issue19644] Failing of interpreter when slicing a string in MacOS X Maverics

2013-11-18 Thread Ezio Melotti
Ezio Melotti added the comment: This is a duplicate of #18458. -- nosy: +ezio.melotti resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> interactive interpreter crashes and test_readline fails on OS X 10.9 Mavericks due to libedit update

[issue19644] Failing of interpreter when slicing a string in MacOS X Maverics

2013-11-18 Thread Dmitry
New submission from Dmitry: I launch python3 on MacOS X Maverics and do the following things: a = '12345' a[:-0] And the interpreter (application python3) crashes with sigfault. Everything is OK with python2 on this computer (the same code returnes '') and with the same version of Python on lin

[issue19575] subprocess.Popen with multiple threads: Redirected stdout/stderr files still open after process close

2013-11-18 Thread Bernt Røskar Brenna
Bernt Røskar Brenna added the comment: And here's a function that does not require pywin32: def open_noinherit_ctypes(*args, **kwargs): HANDLE_FLAG_INHERIT = 1 import msvcrt from ctypes import windll, WinError fp = open(*args, **kwargs) if not windll.kernel32.SetHandleInfor

[issue19638] dtoa: conversion from '__int64' to 'int', possible loss of data

2013-11-18 Thread Eric V. Smith
Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue5673] Add timeout option to subprocess.Popen

2013-11-18 Thread Thomas Guettler
Thomas Guettler added the comment: For Python 2.x there is a backport of the subprocess module of 3.x: https://pypi.python.org/pypi/subprocess32. It has the timeout argument for call() and pipe.wait(). -- ___ Python tracker

[issue7105] weak dict iterators are fragile because of unpredictable GC runs

2013-11-18 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Attached is a version for 2.7 Btw, I think a cleaner way to deal with unpredictable GC runs is to be able to temporarily disable GC with a context manager. -- nosy: +kristjan.jonsson Added file: http://bugs.python.org/file32689/issue7105.patch

[issue19643] shutil rmtree fails on readonly files in Windows

2013-11-18 Thread Ivan Radic
New submission from Ivan Radic: shutil.rmtree works nice on Windows until it hits file with read only attribute set. Workaround is to provide a onerror parameter as a function that checks and removes file attribute before attempting to delete it. Can option to delete read_only files be integra

[issue19641] Add audioop.byteswap()

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Updated patch addresses some Victor's comments. Added optimization for trivial case byteswap(bytes, 1). -- Added file: http://bugs.python.org/file32688/audioop_byteswap_2.patch ___ Python tracker

[issue19642] shutil to support equivalent of: rm -f /dir/*

2013-11-18 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +hynek, tarek versions: -Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue19642] shutil to support equivalent of: rm -f /dir/*

2013-11-18 Thread Ivan Radic
New submission from Ivan Radic: Shutil supports deleting of files and directories but it offers no way to delete directory content (without deleting directory itself). Shell programming includes a lot of "rm -rf /dir" and "rm -f /dir/*", and there is no direct equivalent of these commands in P

[issue19575] subprocess.Popen with multiple threads: Redirected stdout/stderr files still open after process close

2013-11-18 Thread Bernt Røskar Brenna
Bernt Røskar Brenna added the comment: Never mind, I figured it: On Python 3.3, the combination of locking around Popen and opening the file that I redirect to using the code below works (code from scons): def open_noinherit(*args, **kwargs): fp = open(*args, **kwargs) win32api.SetHand

[issue13090] test_multiprocessing: memory leaks

2013-11-18 Thread Stefan Krah
Stefan Krah added the comment: The leaks still exist here. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue19575] subprocess.Popen with multiple threads: Redirected stdout/stderr files still open after process close

2013-11-18 Thread Bernt Røskar Brenna
Bernt Røskar Brenna added the comment: I tested, and locking around the subprocess.Popen call indeed works on Python 3.4. Thanks! Do you have any tips on how to accomplish the same thing on Python 3.3 (locking around Popen did not make any difference on 3.3)? -- ___

[issue8402] Add a function to escape metacharacters in glob/fnmatch

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Ezio and Eric for your reviews. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue8402] Add a function to escape metacharacters in glob/fnmatch

2013-11-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5fda36bff39d by Serhiy Storchaka in branch 'default': Issue #8402: Added the escape() function to the glob module. http://hg.python.org/cpython/rev/5fda36bff39d -- nosy: +python-dev ___ Python tracker

[issue19638] dtoa: conversion from '__int64' to 'int', possible loss of data

2013-11-18 Thread Stefan Krah
Changes by Stefan Krah : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue8402] Add a function to escape metacharacters in glob/fnmatch

2013-11-18 Thread Eric V. Smith
Eric V. Smith added the comment: Looks good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue19575] subprocess.Popen with multiple threads: Redirected stdout/stderr files still open after process close

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: Ok, this issue is the corner case of the PEP 446: http://www.python.org/dev/peps/pep-0446/#only-inherit-some-handles-on-windows The PEP explicitly does nothing for this case. It can change in the future. Until the point is fixed, you have to use a lock around t

[issue19575] subprocess.Popen with multiple threads: Redirected stdout/stderr files still open after process close

2013-11-18 Thread Bernt Røskar Brenna
Changes by Bernt Røskar Brenna : -- components: +IO ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue13633] Handling of hex character references in HTMLParser.handle_charref

2013-11-18 Thread Ezio Melotti
Changes by Ezio Melotti : -- dependencies: +expose html.parser.unescape ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue19564] test_context() of test_multiprocessing_spawn hangs on "x86 Gentoo Non-Debug 3.x" buildbot

2013-11-18 Thread Richard Oudkerk
Richard Oudkerk added the comment: I don't think the patch to the _test_multiprocessing will work. It defines cls._Popen but I don't see how that would be used by cls.Pool to start the processes. I will have a think about a fix. -- ___ Python trac

[issue8402] Add a function to escape metacharacters in glob/fnmatch

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Updated patch addresses Eric's comment. -- Added file: http://bugs.python.org/file32687/glob_escape_3.patch ___ Python tracker ___

[issue19640] Drop _source attribute of namedtuple

2013-11-18 Thread Eric V. Smith
Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue19641] Add audioop.byteswap()

2013-11-18 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: The audio modules often need convert between little endian and big endian data. The array module can be used to byteswap 16- and 32-bit samples, but it can't help with 24-bit samples. Python implemented function for swapping bytes is not very efficient. In

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-18 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > If the file is truncated, why would the test suceed on little endian? The > file doesn't have the same size in bytes? The test doesn't check the number > of frames? Because this code is not used on little endian. On little endian a data is read by file's re

[issue19640] Drop _source attribute of namedtuple

2013-11-18 Thread Christian Heimes
Changes by Christian Heimes : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue19575] subprocess.Popen with multiple threads: Redirected stdout/stderr files still open after process close

2013-11-18 Thread Bernt Røskar Brenna
Changes by Bernt Røskar Brenna : -- versions: +Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue513840] entity unescape for sgml/htmllib

2013-11-18 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: -> ezio.melotti resolution: -> duplicate stage: test needed -> committed/rejected status: open -> closed superseder: -> expose html.parser.unescape ___ Python tracker

[issue19639] Improve re match objects display

2013-11-18 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: docs@python -> ezio.melotti nosy: +ezio.melotti stage: -> patch review type: -> enhancement ___ Python tracker ___ __

[issue19640] Drop _source attribute of namedtuple

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: I found this issue while using my tracemalloc module to analyze the memory consumption of Python. On the Python test suite, the _source attribute is the 5th line allocating the memory memory: /usr/lib/python3.4/collections/__init__.py: 676.2 kB -- __

[issue19640] Drop _source attribute of namedtuple

2013-11-18 Thread STINNER Victor
New submission from STINNER Victor: The definition of a new nametuple creates a large Python script to create the new type. The code stores the code in a private attribute: namespace = dict(__name__='namedtuple_%s' % typename) exec(class_definition, namespace) result = namespace[typ

[issue19575] subprocess.Popen with multiple threads: Redirected stdout/stderr files still open after process close

2013-11-18 Thread Bernt Røskar Brenna
Bernt Røskar Brenna added the comment: Increasing max_workers to 5 and running 20 tasks highlighs the 3.3-3.4 difference (code in attached file testscript4.py): Version: 3.4.0a4 (v3.4.0a4:e245b0d7209b, Oct 20 2013, 19:23:45) [MSC v.1600 32 b it (Intel)] Platform: Windows-XP-5.1.2600-SP3 Tasks:

[issue19639] Improve re match objects display

2013-11-18 Thread Claudiu.Popa
New submission from Claudiu.Popa: When issue17087 was accepted, the documentation wasn't changed to reflect the new changes. The attached patch fixes this, replacing the old <_sre.Match object ...> with the deterministic repr of the match object. -- assignee: docs@python components: Do

[issue19575] subprocess.Popen with multiple threads: Redirected stdout/stderr files still open after process close

2013-11-18 Thread Bernt Røskar Brenna
Bernt Røskar Brenna added the comment: I just tested on 3.4a0. Observed the following changes: - subprocess_devnull now NEVER fails. - subprocess_redirfile does not fail as often as before, but still fails. I changed the number of tasks to 20 and increased max_workers to 5 to get subprocess_

[issue9566] Compilation warnings under x64 Windows

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: I forgot to mention this issue in the following changesets. changeset: 87128:f0a7924fac56 user:Victor Stinner date:Fri Nov 15 23:16:15 2013 +0100 files: Modules/_randommodule.c description: Fix compiler warning on Windows 64-bit: explici

[issue19581] PyUnicodeWriter: change the overallocation factor for Windows

2013-11-18 Thread STINNER Victor
STINNER Victor added the comment: > Your patch implies that the two only supported OSes are Linux and Windows :-) It more means that Windows memory allocator is different to the one used on all other operating systems. Well, if you are not convinced, we can keep the overallocation factor of 25

[issue19638] dtoa: conversion from '__int64' to 'int', possible loss of data

2013-11-18 Thread Christian Heimes
New submission from Christian Heimes: The patch silences three compiler warnings on Win64 -- components: Windows files: dtoa.patch keywords: patch messages: 203264 nosy: christian.heimes, haypo, zach.ware priority: normal severity: normal stage: patch review status: open title: dtoa: con

  1   2   >