[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread Armin Rigo
Armin Rigo added the comment: @Serhiy: it's a behavior change and as such not an option for a micro release. For example, the following legal code would behave differently: it would compute s = '\\u1234' instead of s = 'UTF8:\xe1\x88\xb4'. try: s = repr(x) except UnicodeEncode

[issue17741] event-driven XML parser

2013-08-23 Thread Nick Coghlan
Nick Coghlan added the comment: Using tulip-inspired method names (when tulip hasn't landed) to duplicate existing data input functionality (feed() and close()) seems a rather dubious design decision to me. Given how popular lxml.etree is as an alternative to the standard library's etree impl

[issue17974] Migrate unittest to argparse

2013-08-23 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue15125] argparse: positional arguments containing - in name not handled well

2013-08-23 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue17883] Fix buildbot testing of Tkinter

2013-08-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- assignee: ezio.melotti -> terry.reedy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue18808] Thread.join returns before PyThreadState is destroyed

2013-08-23 Thread Jesús Cea Avión
Changes by Jesús Cea Avión : -- nosy: +jcea ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread Nick Coghlan
Nick Coghlan added the comment: The use case is to take data from a surrogate escaped interface and either filter it out entirely or convert it to a valid Unicode string at the point of *input*, before letting it make its way into the rest of the application. For example, this approach permits th

[issue18307] Relative path in co_filename for zipped modules

2013-08-23 Thread Vitaly Murashev
Vitaly Murashev added the comment: unit-test attached. There are 3 tests inside it: 2 failed, 1 succeeded. According to this test results it becomes clear that specified issue is reproduced only with zip modules which contain precompiled bytecode inside (pyc-files) -- Added file: http

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Zooko Wilcox-O'Hearn
Zooko Wilcox-O'Hearn added the comment: Aha! Mystery solved. I wouldn't say that you were stupid — I would say that "crtime" is way too close to "ctime", and I strongly agree with the suggestion (http://mail.python.org/pipermail/python-dev/2009-June/090026.html) on the mailing list by Greg Ewi

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: You're quite right. I stupidly misread "crtime" as "ctime". -- ___ Python tracker ___ ___ Python-b

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Zooko Wilcox-O'Hearn
Zooko Wilcox-O'Hearn added the comment: Benjamin: I'm sorry, I still don't understand. Do you think my proposal would involve setting something named "ctime" to contain a value that didn't come from the underlying stat "ctime"? -- ___ Python tracker

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Indeed, "hijacking" is a bit strong. I mean filling it with a value that is not in the underlying st_ctime field from stat() call. -- ___ Python tracker

[issue16123] IDLE - deprecate running without a subprocess

2013-08-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: I opened #18823 "Idle: use pipes instead of sockets to talk with user subprocess" I think this or a socket fix is needed before we remove -n. -- ___ Python tracker ___

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Zooko Wilcox-O'Hearn
Zooko Wilcox-O'Hearn added the comment: Benjamin Peterson: what do you mean "hijack ctime"? I don't think I — or anyone — has proposed anything that fits that description. Please be more specific. My proposal in http://bugs.python.org/issue5720#msg85750 does not break anything. -- _

[issue18823] Idle: use pipes instead of sockets to talk with user subprocess

2013-08-23 Thread Terry J. Reedy
New submission from Terry J. Reedy: Idle once used os.spawnv to open the user subprocess and 2.7 still does. Sockets were then used to interact with the subprocess. Since rev71746, 2011-8-3, 3.2+ use subprocess.Popen but still use sockets. A rare but continual problem is failure to make the so

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread R. David Murray
R. David Murray added the comment: The email package uses surrogateescape to store unknown bytes in unicode strings, just as with the handle-bad-data-from-os API surrogateescape was introduced for. (For the same reason: the source data may have improperly encoded bytes that we must neverthele

[issue17741] event-driven XML parser

2013-08-23 Thread Stefan Behnel
Stefan Behnel added the comment: Given that it seems to be hard to come to a consensus in this ticket, I've asked for removal of the code on python-dev. http://mail.python.org/pipermail/python-dev/2013-August/128095.html -- ___ Python tracker

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: I don't think we should hijack st_ctime. All the other members of the stat object correspond exactly to what you get back from the Unix stat() call. Let's not break that. How about just leaving st_ctime as it is and adding st_creationtime, which will have t

[issue18747] Re-seed OpenSSL's PRNG after fork

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: Oh i forgot that i wrote a patch for openssl: https://bitbucket.org/haypo/hasard/src/tip/patches/openssl_rand_fork.patch -- ___ Python tracker _

[issue5720] ctime: I don't think that word means what you think it means.

2013-08-23 Thread Zooko Wilcox-O'Hearn
Zooko Wilcox-O'Hearn added the comment: Well, read the thread! http://mail.python.org/pipermail/python-dev/2009-June/090021.html Basically just a couple of +1's, and a good suggestion to name it something clearer than "crtime". Please fix it! -- nosy: +Zooko.Wilcox-O'Hearn ___

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: "The email package needs has_escaped_bytes. Currently it tries to encode to ascii to find out if there are any, which we proved by microbenchmark is the fastest way to do it as things stand." In which function you need to check this? What do you do if there a

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: > Yes, but some new fds might be open in the child process, e.g. for > /dev/urandom. The issue #18756 is not implemented not, and I'm still opposed to change os.random() to use persistent FD :) Ok, no problem for not checking others FD, it's not the purpose o

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Can you sum the use cases for these? (don't want to read a blog post, sorry :-)) -- nosy: +pitrou ___ Python tracker ___ ___

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > The problem is that you are duplicating an existing class (the > XMLParser) for no good reason No. The logic was already in _IterParseIterator, just wrapped up differently. And the proof is that the original commit, while adding a feature, *removed* code from

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue18810] Stop doing stat calls in importlib.machinery.FileFinder to see if something is a file or folder

2013-08-23 Thread Brett Cannon
Brett Cannon added the comment: I did a quick check and at least stripping out the two stat calls for a directory or module file (left in package __init__.py) didn't make a significant difference. -- ___ Python tracker

[issue18810] Stop doing stat calls in importlib.machinery.FileFinder to see if something is a file or folder

2013-08-23 Thread Brett Cannon
Brett Cannon added the comment: I don't think it's related to the test_imp bug, but since it was never fully diagnosed I couldn't tell you. -- ___ Python tracker ___ ___

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread Charles-François Natali
Charles-François Natali added the comment: > Close_fds is not supposed to close them? Yes, but some new fds might be open in the child process, e.g. for /dev/urandom. That's why it's better to check that this precise FD is closed. Of course, if the /dev/urandom FD gets assigned the same FD as th

[issue18408] Fixes crashes found by pyfailmalloc

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: It's reported in issue18664 (you're nosied there :-)). -- ___ Python tracker ___ ___ Python-bugs-lis

[issue18408] Fixes crashes found by pyfailmalloc

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: I didn't know that buildbots are failing. Do you have at least an example? An error message, anything? -- ___ Python tracker ___ ___

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: Close_fds is not supposed to close them? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue18757] Fix internal references for concurrent modules

2013-08-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for the review Ezio. -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker _

[issue18757] Fix internal references for concurrent modules

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6575074aae1c by Serhiy Storchaka in branch '3.3': Issue #18757: Improved cross-references in the concurrent package. http://hg.python.org/cpython/rev/6575074aae1c New changeset 383d85249997 by Serhiy Storchaka in branch 'default': Issue #18757: Impr

[issue18803] Fix more typos in .py files

2013-08-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Incorrect fixes. accidentaly -> accidentally occurence -> occurrence -- nosy: +terry.reedy ___ Python tracker ___ __

[issue18820] json.dump() ignores its 'default' option when serializing dictionary keys

2013-08-23 Thread July Tikhonov
July Tikhonov added the comment: Proposed tests attached. -- Added file: http://bugs.python.org/file31450/json-default-tests.diff ___ Python tracker ___ _

[issue17741] event-driven XML parser

2013-08-23 Thread Stefan Behnel
Stefan Behnel added the comment: Could we please keep the discussion on rational terms? It's not just the method names. The problem is that you are duplicating an existing class (the XMLParser) for no good reason, instead of putting the feature where it belongs: *behind* the XMLParser. Even wo

[issue18783] No more refer to Python "long"

2013-08-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: For msilib, 'int numbers' should just be 'ints' or 'integers'. --- For PC/winreg.c '''\ PyDoc_STRVAR(PyHKEY_Detach_doc, "key.Detach() -> int\n" ... "On 64 bit windows, the result of this function is a long integer");''' This last line should be deleted rather th

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: To wrap things up: - the feature is desireable - the API is reasonable - the implementation is functional and properly tested Really, if you can't come up with an actual blocker, I'll ask you to leave this issue at rest. -- ___

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > In any case, it's not to late to remove the implementation. As far as I can say, there's no reason to remove the implementation except for your distaste of the method names. -- ___ Python tracker

[issue17741] event-driven XML parser

2013-08-23 Thread Stefan Behnel
Stefan Behnel added the comment: I don't think I understand what you mean. In any case, it's not to late to remove the implementation. There was only one alpha release so far that included it, so it can't really break any existing code that relies on it. The longer we wait, the more damage wil

[issue18408] Fixes crashes found by pyfailmalloc

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Victor, I'll let you find out how to improve your debug checks, but in the meantime I've reverted the commit that randomly broke some Windows buildbots. -- nosy: +pitrou ___ Python tracker

[issue18408] Fixes crashes found by pyfailmalloc

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 42aecc601a41 by Antoine Pitrou in branch 'default': Back out 5bd9db528aed (issue #18408). It caused unsolved buildbot failures. http://hg.python.org/cpython/rev/42aecc601a41 -- ___ Python tracker

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I was asking for the current implementation to be removed until we > have a working implementation that hurts neither the API nor the > module design. It would help if we could keep the discussion on rational terms. -- ___

[issue17741] event-driven XML parser

2013-08-23 Thread Stefan Behnel
Stefan Behnel added the comment: I was asking for the current implementation to be removed until we have a working implementation that hurts neither the API nor the module design. -- ___ Python tracker ___

[issue17741] event-driven XML parser

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've committed the inheritance removal patch. I personally don't think there's anything more to do, since the TreeEventBuilder proposal stumbled on some implementation issues. -- status: open -> closed ___ Python tr

[issue17741] event-driven XML parser

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 815f328a6578 by Antoine Pitrou in branch 'default': Issue #17741: use composition, rather than inheritance, for xml.etree.iterparse's result class. http://hg.python.org/cpython/rev/815f328a6578 -- ___ Py

[issue16123] IDLE - deprecate running without a subprocess

2013-08-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Slight correction: While I do not believe I have seen *clipboard* contents pasted, after running a program from the editor that prints (to the shell), I *have* seen the last line reprinted when trying to enter something new as the prompt. This sometimes might

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread Charles-François Natali
Charles-François Natali added the comment: > You might also add a check: > > self.assertLessEqual(remaining_fds, {0, 1, 2}) Well no, because the interpreter might have other FDs open than stdin, stdout and stderr. -- ___ Python tracker

[issue18820] json.dump() ignores its 'default' option when serializing dictionary keys

2013-08-23 Thread Ezio Melotti
Ezio Melotti added the comment: Are there already tests that cover the changes in your patch? If not, could you add them? -- nosy: +ezio.melotti, pitrou, rhettinger stage: -> test needed ___ Python tracker _

[issue18814] Add tools for "cleaning" surrogate escaped strings

2013-08-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18803] Fix more typos in .py files

2013-08-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue18799] Resurrect and fix test_404 in Lib/test/test_xmlrpc.py

2013-08-23 Thread Ezio Melotti
Ezio Melotti added the comment: We can always try to apply the patch and see what happens -- if the test starts failing again we can revert it. -- nosy: +ezio.melotti stage: -> patch review type: -> behavior versions: +Python 3.3 ___ Python tracker

[issue18800] Document Fraction's numerator and denominator properties

2013-08-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue18798] Typo and unused variables in test fcntl

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset d7bac470951b by Ezio Melotti in branch '2.7': #18798: fix typo in test_fcntl. Patch by Vajrasky Kok. http://hg.python.org/cpython/rev/d7bac470951b New changeset 41c90b8f49d9 by Ezio Melotti in branch '3.3': #18798: fix typo in test_fcntl. Patch by

[issue18798] Typo and unused variables in test fcntl

2013-08-23 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the report and the patch! -- assignee: -> ezio.melotti nosy: +ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> enhancement versions: +Python 2.7, Python 3.3 __

[issue18810] Stop doing stat calls in importlib.machinery.FileFinder to see if something is a file or folder

2013-08-23 Thread Eric Snow
Eric Snow added the comment: Isn't this related somewhat to #7732? -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mai

[issue18756] os.urandom() fails under high load

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, you're gonna laugh, the simplified patch has a complication (not theoretical, it would trip test_cmd_line). Attaching patch. -- Added file: http://bugs.python.org/file31449/persistent_urandom_fd4.patch ___ Python

[issue18796] Wrong documentation of show_code function from dis module

2013-08-23 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the report and the patch! -- assignee: docs@python -> ezio.melotti nosy: +ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed type: -> enhancement ___ Python tracke

[issue18796] Wrong documentation of show_code function from dis module

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 64678369c4d0 by Ezio Melotti in branch 'default': #18796: improve documentation of the file argument of dis.show_code. Initial patch by Vajrasky Kok. http://hg.python.org/cpython/rev/64678369c4d0 -- nosy: +python-dev _

[issue18795] pstats - allow stats sorting by cumulative time per call and total time per call

2013-08-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +georg.brandl stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: Serhiy Storchaka wrote: >> .__repr__() is not really allowed to return Unicode objects in Python 2.x. >> If you do this, you're on your own. > > PyObject_Repr() contains a code which converts unicode to str and raise an > exception if __repr__() result is

[issue18757] Fix internal references for concurrent modules

2013-08-23 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM. -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue7732] imp.find_module crashes Python if there exists a directory named "__init__.py"

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Seems fixed now. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue18760] Fix internal doc references for the xml package

2013-08-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Sorry. Can't believe I done it again. -- keywords: +patch Added file: http://bugs.python.org/file31448/refs.xml.diff ___ Python tracker ___ __

[issue18394] cgi.FieldStorage triggers ResourceWarning sometimes

2013-08-23 Thread Brett Cannon
Brett Cannon added the comment: I managed to write a similar patch to Vajrasky independently, so at least I know the approach is reasonable. =) I'm not backporting since it really isn't that critical; I fixed it just to turn off the ResourceWarning while running the test suite. -- nos

[issue18394] cgi.FieldStorage triggers ResourceWarning sometimes

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset c0e9ba7b26d5 by Brett Cannon in branch 'default': Issue #18394: Explicitly close the file object cgi.FieldStorage http://hg.python.org/cpython/rev/c0e9ba7b26d5 -- nosy: +python-dev ___ Python tracker

[issue18817] Got resource warning when running Lib/aifc.py

2013-08-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka priority: normal -> low ___ Python tracker ___ ___ Python-bugs-list ma

[issue18817] Got resource warning when running Lib/aifc.py

2013-08-23 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > It depends on sys.getdefaultencoding() which can be modified in the site > module (or in a PYTHONSTARTUP script) using sys.setdefaultencoding(). Of course. Every successful without patch repr() will left same with patch. However the patch allows you to see

[issue18818] Empty PYTHONIOENCODING is not the same as nonexistent

2013-08-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch with tests and documentation. For the documentation I hope on your help. -- Added file: http://bugs.python.org/file31447/empty_pythonioencoding_3.patch ___ Python tracker

[issue17618] base85 encoding

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Serhiy, Martin, is one of you still working on this? -- ___ Python tracker ___ ___ Python-bugs-list

[issue18774] There is still last bit of GNU Pth code in signalmodule.c

2013-08-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- Removed message: http://bugs.python.org/msg195643 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue13758] compile() should not encode 'filename' (at least on Windows)

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: > Victor, do you have any opinion on this unicode filename issue? I closed the issue #11619 in january 2013 before there was no user requesting the feature. I just reopened the issue because users now ask for it. -- ___

[issue18760] Fix internal doc references for the xml package

2013-08-23 Thread Ezio Melotti
Ezio Melotti added the comment: Serhiy, you forgot to attach the patch. -- type: -> enhancement ___ Python tracker ___ ___ Python-bug

[issue18776] atexit error display behavior changed in python 3

2013-08-23 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- stage: patch review -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: > I'd suggest closing this as won't fix. Agreed, it's time to upgrade to Python 3! -- resolution: -> fixed status: open -> closed ___ Python tracker __

[issue11619] On Windows, don't encode filenames in the import machinery

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: I reopen the issue because some users are now requesting this feature. I updated parser_unicode.patch to the last Python version. The new patch has just a minor nit: test_symtable does crash :-D I will investigate the crash later. -- resolution: wont

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: "the parent can know precisely which FD was opened by the preexec hook, and check it's closed in the child process." Oh ok, I see: +self.assertNotIn(fd, remaining_fds) You might also add a check: self.assertLessEqual(remaining_fds, {0, 1, 2})

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread Charles-François Natali
Charles-François Natali added the comment: > I don't understand why os.dup2() is more reliable than os.pipe() for a unit > test? I use dup2() because it allows me to specify a target FD, so the parent can know precisely which FD was opened by the preexec hook, and check it's closed in the child

[issue18808] Thread.join returns before PyThreadState is destroyed

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Here is a patch for 3.3/3.4. -- keywords: +patch stage: needs patch -> patch review versions: -Python 2.7 Added file: http://bugs.python.org/file31445/subinterp_threads.patch ___ Python tracker

[issue18822] poor proxyval() coverage in test_gdb

2013-08-23 Thread Antoine Pitrou
New submission from Antoine Pitrou: The proxyval() of many built-in types doesn't seem covered by test_gdb, as write_repr() is specialized for most of them. (check: add "1/0" to one of those proxyval() implementations and watch test_gdb succeed) -- components: Tests messages: 195998 n

[issue18772] Fix gdb plugin for new sets dummy object

2013-08-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Attached patch solves the issue and removes the repr()-based hack in the gdb plugin. -- Added file: http://bugs.python.org/file31444/gdb_sets_repr2.patch ___ Python tracker __

[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: .__repr__() is not really allowed to return Unicode objects in Python 2.x. If you do this, you're on your own. The CPython internals try to convert any non-str object to a str object, but this is only done to assure that PyObject_Repr() always returns a st

[issue17213] ctypes loads wrong version of C runtime, leading to error message box from system

2013-08-23 Thread Andrew Svetlov
Changes by Andrew Svetlov : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: I don't understand why os.dup2() is more reliable than os.pipe() for a unit test? Is subprocess_close-default-1.diff portable? test_os uses hasattr(os, "dup2"). In Modules/posixmodule.c, it looks like the function is always defined!? -- _

[issue18763] subprocess: file descriptors should be closed after preexec_fn is called

2013-08-23 Thread Charles-François Natali
Charles-François Natali added the comment: Here's a patch with a more robust test: the previous test worked, but assume that only stdin, stdout and stderr FDs would be open in the child process. This might not hold anymore in a near future (/dev/urandom persistent FD). The new test is much more

[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread Armin Rigo
Armin Rigo added the comment: @Serhiy: it would certainly break a program that tries to call the repr() and catches the UnicodeEncodeError to do something else, like encode the data differently. -- ___ Python tracker

[issue18709] SSL module fails to handle NULL bytes inside subjectAltNames general names (CVE-2013-4238)

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 79007c4244d6 by Barry Warsaw in branch '2.6': - Issue #18709: Fix CVE-2013-4238. The SSL module now handles NULL bytes http://hg.python.org/cpython/rev/79007c4244d6 -- ___ Python tracker

[issue18586] Allow running benchmarks for Python 3 from same directory

2013-08-23 Thread Brett Cannon
Changes by Brett Cannon : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker ___

[issue18586] Allow running benchmarks for Python 3 from same directory

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset b868d0a9c5d7 by Brett Cannon in branch 'default': Issue #18586: Remove the need for make_perf3.sh http://hg.python.org/benchmarks/rev/b868d0a9c5d7 -- nosy: +python-dev ___ Python tracker

[issue17702] os.environ converts key type from string to bytes in KeyError exception

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: > This patch introduces a bit ugly traceback. It is now fixed, thanks for the report! -- ___ Python tracker ___ ___

[issue17702] os.environ converts key type from string to bytes in KeyError exception

2013-08-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 26c049dc1a4a by Victor Stinner in branch '3.3': Close #17702: On error, os.environb now removes suppress the except context http://hg.python.org/cpython/rev/26c049dc1a4a New changeset 01f33959ddf6 by Victor Stinner in branch 'default': (Merge 3.3) C

[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread STINNER Victor
STINNER Victor added the comment: > How it can break backward compatibility? Currently repr() just raises > UnicodeEncodeError. It depends on sys.getdefaultencoding() which can be modified in the site module (or in a PYTHONSTARTUP script) using sys.setdefaultencoding(). It should not possible

[issue5876] __repr__ returning unicode doesn't work when called implicitly

2013-08-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: How it can break backward compatibility? Currently repr() just raises UnicodeEncodeError. UnicodeEncodeError: 'ascii' codec can't encode character u'\u20ac' in position 0: ordinal not in range(128) With patch it always returns 8-bit string. As far as repr()

[issue18760] Fix internal doc references for the xml package

2013-08-23 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18804] pythorun.c: is_valid_fd() should not duplicate the file descriptor

2013-08-23 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18783] No more refer to Python "long"

2013-08-23 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18769] argparse remove subparser

2013-08-23 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18767] csv documentation does not note default quote constant

2013-08-23 Thread Tshepang Lekhonkhobe
Changes by Tshepang Lekhonkhobe : -- nosy: +tshepang ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mai

[issue18623] Factor out the _SuppressCoreFiles context manager

2013-08-23 Thread Valerie Lambert
Valerie Lambert added the comment: Of course, here is the patch without the '--git' option. -- Added file: http://bugs.python.org/file31442/issue-18623_v2.patch ___ Python tracker __

  1   2   >