[issue18488] sqlite: finalize() method of user function may be called with an exception set if a call to step() method failed

Serhiy Storchaka added the comment: I think both (PyException_SetContext), as in Python code. See textiowrapper_close() in Modules/_io/textio.c for example. -- ___ Python tracker __

[issue18226] IDLE Unit test for FormatParagrah.py

Terry J. Reedy added the comment: I am dubious that the current code will work with tkinter. Marks name slice positions. Tags name 0 to many pairs of slice positions, with 'sel' predefined as corresponding to a mouse selection and limited to one pair. According to my tests, tag_add('sel.first'

[issue18226] IDLE Unit test for FormatParagrah.py

Changes by Roger Serwy : -- nosy: +roger.serwy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue18226] IDLE Unit test for FormatParagrah.py

Terry J. Reedy added the comment: What I think still needs to be done. * FormatParagraph.py: As near as I can tell from the patch, the comments are correct except that one is needed for reformat_paragraph. I gather that the substantive code change allows reformatting of a comment block when

[issue18489] IDLE Unit test for SearchEngine.py

New submission from Phil Webster: This test uses the mock text widget to search forwards and backwards, with and without wrapping. It also tests for empty matches with the 'ok' flag set in search_text(). The patch relies on the mock text tag_add function implemented in #18226. -- comp

[issue18408] Fixes crashes found by pyfailmalloc

STINNER Victor added the comment: http://buildbot.python.org/all/builders/PPC64%20AIX%203.x/builds/310/steps/test/logs/stdio -- ___ Python tracker ___ ___

[issue18408] Fixes crashes found by pyfailmalloc

STINNER Victor added the comment: Another buildbot failure: [150/375/4] test_ctypes Assertion failed: __EX, file Python/ceval.c, line 4064 Fatal Python error: Aborted Current thread 0x0001: File "/home/shager/cpython-buildarea/3.x.edelsohn-aix-ppc64/build/Lib/ctypes/test/test_random_th

[issue18408] Fixes crashes found by pyfailmalloc

STINNER Victor added the comment: Changesets 48a869a39e2d and 5bd9db528aed adding "assert(!PyErr_Occurred());" broke some buildbots. I fixed the issue on OpenSolaris, I'm unable to reproduce the 2 remaining issues (I tested on Fedora 18 and FreeBSD 9). http://buildbot.python.org/all/builders

[issue18408] Fixes crashes found by pyfailmalloc

Roundup Robot added the comment: New changeset ddff866d820d by Victor Stinner in branch 'default': Issue #18408: Fix PyInit__curses_panel(), handle import_curses() failure http://hg.python.org/cpython/rev/ddff866d820d -- ___ Python tracker

[issue18408] Fixes crashes found by pyfailmalloc

Roundup Robot added the comment: New changeset 9bae7696951f by Victor Stinner in branch 'default': Issue #18408: Fix _pysqlite_fetch_one_row(), in debug mode, don't call http://hg.python.org/cpython/rev/9bae7696951f New changeset 5bd9db528aed by Victor Stinner in branch 'default': Issue #18408:

[issue18488] sqlite: finalize() method of user function may be called with an exception set if a call to step() method failed

STINNER Victor added the comment: What is the expected behaviour? Should sqlite call finalize() if step() failed? If finalize() must be called: which exception should be kept? step() or failure() exception? -- ___ Python tracker

[issue18408] Fixes crashes found by pyfailmalloc

Roundup Robot added the comment: New changeset d85b0c355052 by Victor Stinner in branch 'default': Issue #18408: Fix array_index(), handle getarrayitem() failure http://hg.python.org/cpython/rev/d85b0c355052 New changeset b05a6a6eb525 by Victor Stinner in branch 'default': Issue #18408: Fix arra

[issue18488] sqlite: finalize() method of user function may be called with an exception set if a call to step() method failed

Roundup Robot added the comment: New changeset a2214ab0812e by Victor Stinner in branch 'default': Issue #18488: _pysqlite_final_callback() should not clear the exception set by http://hg.python.org/cpython/rev/a2214ab0812e -- nosy: +python-dev ___ Py

[issue18488] sqlite: finalize() method of user function may be called with an exception set if a call to step() method failed

Changes by STINNER Victor : -- nosy: +christian.heimes, ghaering, pitrou, serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue18488] sqlite: finalize() method of user function may be called with an exception set if a call to step() method failed

New submission from STINNER Victor: In Modules/_sqlite/connection.c, _pysqlite_final_callback() calls the finalize() method of the user function. Calling this method may clear the current exception, whereas test_sqlite excepts that exceptions of step() are reported. -- messages: 19325

[issue18482] dis.dis fails on one letter strings.

R. David Murray added the comment: Ah, yes, I see that you are correct. -- resolution: -> out of date stage: -> committed/rejected status: open -> closed type: crash -> enhancement ___ Python tracker

[issue18482] dis.dis fails on one letter strings.

STINNER Victor added the comment: > Haypo: it gives a result on python3. It is a new feature of Python 3.2: see issue #6507. New features are no more added to Python 2, so you now have a good reason to upgrade to Python 3 ;-) -- ___ Python tracker

[issue18482] dis.dis fails on one letter strings.

R. David Murray added the comment: Haypo: it gives a result on python3. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue10615] Trivial mingw compile fixes

Roumen Petrov added the comment: This patch cannot be closed as contain some fixes not reported/proposed yet . For instance I'm not aware of name clash in Modules/_pickle.c . I think that other are in scope of issue3871 or earlier . -- ___ Python tr

[issue18226] IDLE Unit test for FormatParagrah.py

Phil Webster added the comment: After reading Terry's comments on the initial patch I turned FormatParagraph's initial comments into a docstring and made sure that all lines were < 80 characters. -- Added file: http://bugs.python.org/file30960/18226IDLEUnitTestFormatParagraph4.patch

[issue18487] mingw implement exec prefix

New submission from Roumen Petrov: Enhancement of issue3871 - part for build of core modules. Patch in scope of 3871 is designed for compatibility with specific for MSC build installation scheme. Users don't like this. Updated patch is part of support 'posix' build and installation scheme fo

[issue18408] Fixes crashes found by pyfailmalloc

Roundup Robot added the comment: New changeset 736514fb7b52 by Victor Stinner in branch 'default': Issue #18408: Rewrite NEGATE() macro in longobject.c to handle PyLong_FromLong() failure http://hg.python.org/cpython/rev/736514fb7b52 -- ___ Python tr

[issue18486] mingw: dynamic loading support

New submission from Roumen Petrov: Split of issue3871 - part for build of core modules. -- components: Build files: 0005-MINGW-dynamic-loading-support.patch keywords: patch messages: 193249 nosy: rpetrov priority: normal severity: normal status: open title: mingw: dynamic loading support

[issue18482] dis.dis fails on one letter strings.

STINNER Victor added the comment: I don't understand why do you consider IndexError as an issue. Do you expect another exception? b"t" is not a valid bytecode. -- nosy: +haypo ___ Python tracker __

[issue6672] Add Mingw recognition to pyport.h to allow building extensions

Roumen Petrov added the comment: new patch - improved version with support for build of core modules -- Added file: http://bugs.python.org/file30957/0003-issue6672-v2-Add-Mingw-recognition-to-pyport.h-to-al.patch ___ Python tracker

[issue18485] mingw: configure for shared build

New submission from Roumen Petrov: Split of issue3871 - part for build of core modules. -- components: Build files: 0004-MINGW-configure-for-shared-build.patch keywords: patch messages: 193246 nosy: rpetrov priority: normal severity: normal status: open title: mingw: configure for shared

[issue18408] Fixes crashes found by pyfailmalloc

Roundup Robot added the comment: New changeset 4d3bb9763bf9 by Victor Stinner in branch 'default': Issue #18408: Fix time.tzset(), detect exception when calling PyInit_timezone() http://hg.python.org/cpython/rev/4d3bb9763bf9 New changeset 563b27bef79f by Victor Stinner in branch 'default': Issue

[issue18472] PEP 8 updates - internal interfaces and import *

Changes by Michael Foord : -- nosy: +michael.foord ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.

[issue18481] lcov report

Changes by Christian Heimes : Removed file: http://bugs.python.org/file30950/lcov.patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue18481] lcov report

Christian Heimes added the comment: The new patch removes 3rd party components like expat and libffi. lcov doesn't support complex matches so I had to remove each library on its own. -- Added file: http://bugs.python.org/file30955/lcov.patch ___ Pyth

[issue18258] Fix test discovery for test_codecmaps*.py

R. David Murray added the comment: +1. You should probably open a new issue for that proposal. -- ___ Python tracker ___ ___ Python-b

[issue16405] Explain how to set up the whitespace commit hook locally

Changes by Ronald Oussoren : -- nosy: +ronaldoussoren ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue16293] curses.ungetch raises OverflowError when given -1

Changes by Ankur Ankan : -- nosy: +Ankur.Ankan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue18258] Fix test discovery for test_codecmaps*.py

Zachary Ware added the comment: R. David Murray wrote: > So, the fact that the tests don't run if discovery is used is still a > bug. I'm not sure how we fix it, given the nature of the resource. My preferred solution short of adding resource management to unittest is to add a "regrtest_run" f

[issue18484] No unit test for iso2time function from http.cookiejar module

New submission from Vajrasky Kok: >From http.cookiejar module, we have http2time and iso2time functions. We have unit test for http2time, but not for iso2time. That's not fair. Attached the extended coverage test for iso2time function. -- components: Tests files: add_iso2time_test.txt

[issue18258] Fix test discovery for test_codecmaps*.py

R. David Murray added the comment: I'm sorry, I misspoke. It only works when you run the test file as command: ./python Lib/test/test_codecmaps_cn.py (which uses unittest.main, thus my error in calling it 'via unittest'). So, the fact that the tests don't run if discovery is used is still

[issue18258] Fix test discovery for test_codecmaps*.py

Serhiy Storchaka added the comment: But I don't see any effect. $ ./python -m test.regrtest -v test_codecmaps_tw == CPython 3.3.2+ (3.3:359002d4370d+, Jul 14 2013, 15:34:54) [GCC 4.6.3] == Linux-3.8.0-27-generic-i686-with-debian-wheezy-sid little-endian == /home/serhiy/py/cpython-3.3/build/t

[issue18482] dis.dis fails on one letter strings.

R. David Murray added the comment: NB: This is only a bug in python2. -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-bugs-

[issue13083] _sre: getstring() releases the buffer before using it

Matthew Barnett added the comment: It looks like this was fixed for issue #14212. -- ___ Python tracker ___ ___ Python-bugs-list maili

[issue18483] Add hour-24 type of time to test_http2time_formats in test_http_cookiejar.py

New submission from Vajrasky Kok: In test_http2time_formats test function, they test many type of date & time format, such as: ... 'Thu, 03 Feb 1994 00:00:00 GMT', # proposed new HTTP format 'Thursday, 03-Feb-94 00:00:00 GMT', # old rfc850 HTTP format 'Thursday, 03-

[issue18481] lcov report

Christian Heimes added the comment: https://dl.dropboxusercontent.com/u/19557108/python-lcov/index.html -- ___ Python tracker ___ ___

[issue18482] dis.dis fails on one letter strings.

New submission from James Lu: dis.dis fails on one letter strings. dis.dis("t") Traceback (most recent call last): File "", line 1, in dis.dis("t") File "C:\python 25\lib\dis.py", line 44, in dis disassemble_string(x) File "C:\python 25\lib\dis.py", line 111, in disassemble_string

[issue9338] argparse optionals with nargs='?', '*' or '+' can't be followed by positionals

Changes by TD22057 : -- nosy: +TD22057 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/ma

[issue9307] Py_TPFLAGS_LONG_SUBCLASS is not documented

Yury V. Zaytsev added the comment: Hi, I agree with Alexander, I've been recently investigating a related problem and I found the lack of documentation on the subject quite frustrating; I therefore propose the attached patch to the docs. Hope that helps, --Yury. -- keywords: +patch n

[issue18258] Fix test discovery for test_codecmaps*.py

R. David Murray added the comment: It enables the resource when the tests are run via unittest. (That is, it is equivalent to specifying '-u urlfetch' when running regrtest.) -- nosy: +r.david.murray ___ Python tracker

[issue18181] Add type.__locallookup__

Ronald Oussoren added the comment: issue-18181-full-v1.txt implements support for __locallookup__ to both super and _PyType_Lookup and should implement the entire PEP. The patch is not yet 100% and is missing: * Tests that add __locallookup__ to a metaclass at runtime, should enable the

[issue18481] lcov report

New submission from Christian Heimes: The patch adds a couple of ignores and three Makefile targets for gcov and lcov reports. lcov [1] is a project that can create html reports from gcov output for C files. make coverage-report first cleans up the source tree, then recompiles Python with gco

[issue18258] Fix test discovery for test_codecmaps*.py

Serhiy Storchaka added the comment: What is a purpose of `support.use_resources = ['urlfetch']`? I don't see any effect. -- ___ Python tracker ___ __

[issue18480] _elementtree: missing PyType_Ready call

Ronald Oussoren added the comment: It was a pretty easy catch, the _elementtree caused a crash while I was working on an implementation for PEP 447. The missing call to PyType_Ready helped to make that implementation more robust :-) I'm not entirely convinced that adding forward declarations

[issue18480] _elementtree: missing PyType_Ready call

Changes by Serhiy Storchaka : -- nosy: +eli.bendersky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue18480] _elementtree: missing PyType_Ready call

Christian Heimes added the comment: Good catch! ElementIter_Type has no prototype, too. $ grep Type Modules/_elementtree.c | grep static static PyTypeObject Element_Type; static PyTypeObject Element_Type = { static PyTypeObject ElementIter_Type = { static PyTypeObject TreeBuilder_Type; static

[issue18480] _elementtree: missing PyType_Ready call

Changes by Ronald Oussoren : -- keywords: +needs review, patch ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18480] _elementtree: missing PyType_Ready call

New submission from Ronald Oussoren: The _elementtree extension calls PyType_Ready for most, but not all, types defined in the extension. The attached patch calls PyType_Ready for the ElementIter_Type. -- components: Extension Modules, XML files: elementtree-missing-type-ready.txt mess

[issue18258] Fix test discovery for test_codecmaps*.py

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue16968] Fix test discovery for test_concurrent_futures.py

Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue18408] Fixes crashes found by pyfailmalloc

Roundup Robot added the comment: New changeset 7b81a535ad14 by Victor Stinner in branch 'default': Issue #18408: Fix structseq_reduce(), handle PyDict_SetItemString() failure http://hg.python.org/cpython/rev/7b81a535ad14 -- ___ Python tracker

[issue18408] Fixes crashes found by pyfailmalloc

STINNER Victor added the comment: Open issues (TODO list): - review and apply listpop.patch and frame_fasttolocals.patch - fix CJK codecs: using UNIINV to report _PyUnicodeWriter_WriteChar() failure in Modules/cjkcodecs/cjkcodecs.h does not work. The caller is not aware of the failure: multiby

[issue18266] Fix test discovery for test_largefile.py

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue17767] Fix test discovery for test_locale.py

Serhiy Storchaka added the comment: I combined two last Zachary's patches and added more robust locale test cleanup (old locale now restored even when print() in setUp() will failed). Thank you for your patch Zachary. -- resolution: -> fixed stage: patch review -> committed/rejected s

[issue18266] Fix test discovery for test_largefile.py

Roundup Robot added the comment: New changeset dd75dbed1135 by Serhiy Storchaka in branch '3.3': Issue #18266: test_largefile now works with unittest test discovery and http://hg.python.org/cpython/rev/dd75dbed1135 New changeset 2d8573e12591 by Serhiy Storchaka in branch 'default': Issue #18266:

[issue17767] Fix test discovery for test_locale.py

Roundup Robot added the comment: New changeset 3b883491a5f2 by Serhiy Storchaka in branch '3.3': Issue #17767: test_locale now works with unittest test discovery. http://hg.python.org/cpython/rev/3b883491a5f2 New changeset 60e72210683c by Serhiy Storchaka in branch 'default': Issue #17767: test_

[issue18226] IDLE Unit test for FormatParagrah.py

Phil Webster added the comment: Added tests for FormatParagraph using single/multiline comment blocks and single/multiline strings in the mock editor window. Here is a summary of the changes: FormatParagraph.py - description for format_paragraph_event - modified so that selecting a long commen

[issue18408] Fixes crashes found by pyfailmalloc

STINNER Victor added the comment: 2013/7/17 Charles-François Natali : > Victor, how about adding pyfailmalloc to the main repo (maybe under Tools), > with a script making it easy to run the tests suite with it enabled? > This way, it'll make it easier to run it from time to time (one could eve

[issue18408] Fixes crashes found by pyfailmalloc

STINNER Victor added the comment: 2013/7/17 Serhiy Storchaka : > listpop.patch: > > list_resize(a, Py_SIZE(a) + d) for d < 0 fails only when PyMem_Realloc(p, n) > returns NULL if n < allocated size. Is it possible? Is it desired behavior? > Perhaps we should declare that PyMem_Realloc() should

[issue18479] Improvements to Powershell activate script for venv

New submission from Paul Moore: Some small improvements to the powershell "Activate" script for venvs: 1. Can be run as a command, rather than needing to be dot sourced. This matches the behaviour of bat files, and of virtualenv's "activate" script, and avoids a source of user error. 2. Makes

[issue18266] Fix test discovery for test_largefile.py

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue17767] Fix test discovery for test_locale.py

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue18397] Python with MinGW

Václav Šmilauer added the comment: @David & others: mingw build is covered in detail under issue17605 by Roumen Petrov. -- nosy: +eudoxos ___ Python tracker ___

[issue17897] Optimize unpickle prefetching

Serhiy Storchaka added the comment: This patch is orthogonal to the PEP 3154 framing. The affecting of issue18073 is only an unexpected side effect. -- ___ Python tracker ___ __

[issue17897] Optimize unpickle prefetching

Antoine Pitrou added the comment: I'd prefer to see efforts go towards finishing the PEP 3154 implementation... -- ___ Python tracker ___

[issue17897] Optimize unpickle prefetching

Changes by Antoine Pitrou : -- nosy: -pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue18408] Fixes crashes found by pyfailmalloc

Serhiy Storchaka added the comment: > Victor, how about adding pyfailmalloc to the main repo (maybe under Tools), > with a script making it easy to run the tests suite with it enabled? Seconded. -- ___ Python tracker

[issue17897] Optimize unpickle prefetching

Serhiy Storchaka added the comment: See issue18073 for test case. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue18408] Fixes crashes found by pyfailmalloc

Charles-François Natali added the comment: Victor, how about adding pyfailmalloc to the main repo (maybe under Tools), with a script making it easy to run the tests suite with it enabled? This way, it'll make it easier to run it from time to time (one could eve imagine making it part of the tes

[issue18073] pickle.Unpickler may read too many bytes, causing hangs with blocking input stream

Serhiy Storchaka added the comment: Seems as the patch for issue17897 fixes this case. -- ___ Python tracker ___ ___ Python-bugs-list

[issue13083] _sre: getstring() releases the buffer before using it

Changes by Serhiy Storchaka : -- components: +Regular Expressions nosy: +ezio.melotti, mrabarnett, serhiy.storchaka versions: +Python 3.4 ___ Python tracker ___ _

[issue18085] Verifying refcounts.dat

Changes by Serhiy Storchaka : -- priority: normal -> low ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue18408] Fixes crashes found by pyfailmalloc

Serhiy Storchaka added the comment: listpop.patch: list_resize(a, Py_SIZE(a) + d) for d < 0 fails only when PyMem_Realloc(p, n) returns NULL if n < allocated size. Is it possible? Is it desired behavior? Perhaps we should declare that PyMem_Realloc() should return the original pointer if it c