[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-09 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti stage: -> patch review type: -> enhancement ___ Python tracker ___ ___ Python-bugs-

[issue17841] Remove missing aliases from codecs documentation

2013-05-09 Thread Nick Coghlan
Nick Coghlan added the comment: For anyone else reading the issue and wondering about Ezio's question above - this issue was actually spun out from issue 7475, which covers the long saga of getting these codecs fully restored in the new world order of Python 3 :) -- __

[issue17947] Code, test, and doc review for PEP-0435 Enum

2013-05-09 Thread Ethan Furman
New submission from Ethan Furman: PEP-0435 has been approved! Now for lots of code review. -- assignee: docs@python components: Documentation, Library (Lib), Tests files: ref435.py hgrepos: 189 messages: 188812 nosy: barry, docs@python, eli.bendersky, stoneleaf priority: normal severity

[issue17883] Fix buildbot testing of Tkinter

2013-05-09 Thread Martin v . Löwis
Martin v. Löwis added the comment: > a) Is Windows Server 2003 is really meant to be spported? Yes > b) Are UNCs expected to behave differently on Server 2003? No. > c) Can UNCs be disabled on a particular machine? I may misunderstand "can": yes, it is possible, but no, it is not desirable.

[issue17576] PyNumber_Index() is not int-subclass friendly (or operator.index() docos lie)

2013-05-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: if (PyLong_CheckExact(item) || (PyLong_Check(item) && item->ob_type->tp_as_number->nb_index == PyLong_Type.tp_as_number->nb_index)) -- nosy: +serhiy.storchaka ___ Python tracker

[issue17282] document the defaultTest parameter to unittest.main()

2013-05-09 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: needs patch -> patch review versions: -Python 3.2 ___ Python tracker ___ ___ Python-bugs-list mai

[issue17828] More informative error handling when encoding and decoding

2013-05-09 Thread Ezio Melotti
Ezio Melotti added the comment: The attached proof of concept catches Type/ValueError in str.encode and raises another exception with a better message: >>> 'example'.encode('hex_codec') Traceback (most recent call last): File "", line 1, in TypeError: invalid input type for hex_codec codec ('

[issue17828] More informative error handling when encoding and decoding

2013-05-09 Thread Ezio Melotti
Ezio Melotti added the comment: To summarize: * str.encode does only str->bytes; * bytes.decode does only bytes-> str; * codecs.encode/decode do obj->obj; The things that could go wrong are: 1) the input type is wrong (i.e. the codec doesn't accept the type of the input); 2) the input valu

[issue17828] More informative error handling when encoding and decoding

2013-05-09 Thread Ezio Melotti
Ezio Melotti added the comment: The attached patch changes the error message of str.encode/bytes.decode when the codec returns the wrong type: >>> import codecs >>> 'example'.encode('rot_13') TypeError: encoder returned 'str' instead of 'bytes', use codecs.decode for str->str conversions >>> c

[issue17927] Argument copied into cell still referenced by frame

2013-05-09 Thread Nick Coghlan
Nick Coghlan added the comment: Looks good to me, too. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:

[issue17927] Argument copied into cell still referenced by frame

2013-05-09 Thread Benjamin Peterson
Benjamin Peterson added the comment: I think it looks good now. I'll probably just rewrite the test once you commit it. -- keywords: -needs review ___ Python tracker ___ __

[issue17828] More informative error handling when encoding and decoding

2013-05-09 Thread Nick Coghlan
Nick Coghlan added the comment: Ezio pointed out on IRC that the extra type checks in str.encode, bytes.decode and bytearray.decode should reference the appopriate codecs module function in addition to the codec in use. So if str.encode produces something other than bytes, it should reference

[issue17841] Remove missing aliases from codecs documentation

2013-05-09 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patch! @Nick While this works as a short-term solution, I think it would be good to 1) reintroduce the aliases in 3.4 (so that codecs.encode(b'foo', 'base64') works without spelling out the full codec name); 2) either separate these codecs

[issue17841] Remove missing aliases from codecs documentation

2013-05-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset ead47bc3a763 by Ezio Melotti in branch '3.3': #17841: remove missing codecs aliases from the documentation. Patch by Thomas Fenzl. http://hg.python.org/cpython/rev/ead47bc3a763 New changeset eafff38a56cc by Ezio Melotti in branch 'default': #17841

[issue14878] Improve documentation for generator.send method

2013-05-09 Thread Ezio Melotti
Changes by Ezio Melotti : -- stage: needs patch -> committed/rejected type: -> enhancement versions: -Python 3.2, Python 3.3 ___ Python tracker ___

[issue14878] Improve documentation for generator.send method

2013-05-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7b8c0bf8fcb8 by Andrew Kuchling in branch '2.7': #14878: add cross-reference to the yield statement. http://hg.python.org/cpython/rev/7b8c0bf8fcb8 -- nosy: +python-dev ___ Python tracker

[issue14878] Improve documentation for generator.send method

2013-05-09 Thread A.M. Kuchling
A.M. Kuchling added the comment: Thanks for the patch! -- nosy: +akuchling resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue17927] Argument copied into cell still referenced by frame

2013-05-09 Thread Guido van Rossum
Guido van Rossum added the comment: cellfree4.diff. Addressed review: - Moved test to test_scope.py - Added @cpython_only - Fixed comment indent (and removed tabs :-) - Fixed missing NULL test I decided to keep the super() call; it's likely that it's tested elsewhere but I don't want to verif

[issue17700] Update Curses HOWTO for 3.4

2013-05-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1fa70b797973 by Andrew Kuchling in branch '3.3': #17700: update the curses HOWTO for 3.x http://hg.python.org/cpython/rev/1fa70b797973 New changeset 70f530161b9b by Andrew Kuchling in branch 'default': #17700: merge with 3.3 http://hg.python.org/cpy

[issue17700] Update Curses HOWTO for 3.4

2013-05-09 Thread A.M. Kuchling
A.M. Kuchling added the comment: Applied to 3.3 and 3.4. I'll leave this issue open for a week so that Victor can comment on Unicode/wide-characters. -- ___ Python tracker ___

[issue17927] Argument copied into cell still referenced by frame

2013-05-09 Thread Guido van Rossum
Guido van Rossum added the comment: I see. I really don't care, it's extremely rare to see a closure object. -- ___ Python tracker ___ ___

[issue11354] argparse: nargs could accept range of options count

2013-05-09 Thread paul j3
paul j3 added the comment: This patch adds this `nargs='{m,n}'` or `nargs=(m,n)` feature. It builds on the `better nargs error message` patch in http://bugs.python.org/msg187754 It includes an argparse.rst paragraph, changes to argparse.py, and additions to test_argparse.py. The tests includ

[issue17927] Argument copied into cell still referenced by frame

2013-05-09 Thread Benjamin Peterson
Benjamin Peterson added the comment: Consider the following testcase class X: def meth(self): print(self) super() def f(): k = X() def g(): return k return g c = f().__closure__[0] X.meth(c) With patch $ ./python unboxing.py Without patch $ ./python u

[issue17908] Unittest runner needs an option to call gc.collect() after each test

2013-05-09 Thread Michael Foord
Michael Foord added the comment: The default test runner is quite horrible. -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue17883] Fix buildbot testing of Tkinter

2013-05-09 Thread Terry J. Reedy
Terry J. Reedy added the comment: Amaury and Martin: there is a problem on one machine with test.test_tcl.TclTest.testLoadWithUNC that you two jointly wrote, reviewed, and applied in #6470. This issue (17883) is above getting the tcl/tk/tkinter tests to actually be run on 2.7, which they were

[issue17936] O(n**2) behaviour when adding/removing classes

2013-05-09 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue17576] PyNumber_Index() is not int-subclass friendly (or operator.index() docos lie)

2013-05-09 Thread STINNER Victor
STINNER Victor added the comment: Alex> In my opinion that should use PyLong_CheckExact +1 -- nosy: +haypo ___ Python tracker ___ ___

[issue17883] Fix buildbot testing of Tkinter

2013-05-09 Thread Zachary Ware
Zachary Ware added the comment: I'm not sure where to go with this from here, without knowing more about what's going wrong. Just to make sure there wasn't anything wrong with the Tcl/Tk build or some manner of issue with things not being properly cleaned up or something, I set the 'custom' b

[issue17925] asynchat.async_chat.initiate_send : del deque[0] is not safe

2013-05-09 Thread Xavier de Gaye
Xavier de Gaye added the comment: The attached script, test_initiate_send.py, tests initiate_send with threads, causing duplicate writes and an IndexError. This is the script output using python on the default branch: $ python test_initiate_send.py --- Test: duplicate data sent --- chat.send('th

[issue17946] base64 encoding result should be str, not bytes

2013-05-09 Thread R. David Murray
R. David Murray added the comment: This has been discussed numerous times. There are just as many times when you want the output to be binary (because you are about to send it on the wire). However, the deciding factor is that the API is now what it is, and changing it at this point would be

[issue17945] tkinter/Python 3.3.0: peer_create doesn't instantiate Text

2013-05-09 Thread Gregory HOULDSWORTH
Gregory HOULDSWORTH added the comment: Splendid, it works and is indeed far more elegant. Well done there, thanks. -- resolution: -> works for me ___ Python tracker ___

[issue17946] base64 encoding result should be str, not bytes

2013-05-09 Thread Lucas Clemente Vella
New submission from Lucas Clemente Vella: As stated in RFC 3548: Base encoding of data is used in many situations to store or transfer data in environments that, perhaps for legacy reasons, are restricted to only US-ASCII [9] data. thus, I was surprised to see, when I used base64 for t

[issue17941] namedtuple should support fully qualified name for more portable pickling

2013-05-09 Thread Guido van Rossum
Guido van Rossum added the comment: Agreed with Eric. We're already modifying PEP 435 to do it that way. -- nosy: +gvanrossum ___ Python tracker ___ _

[issue17945] tkinter/Python 3.3.0: peer_create doesn't instantiate Text

2013-05-09 Thread Guilherme Polo
Guilherme Polo added the comment: Here is a quick patch for it: http://pastebin.com/m1XQBGqU (I forgot my password for the tracker, and leaving home right now). Does it work for you ? -- ___ Python tracker ___

[issue17927] Argument copied into cell still referenced by frame

2013-05-09 Thread Guido van Rossum
Guido van Rossum added the comment: Ok, here's a version with a unittest. I've also improved the comment that set Nick off the track. -- keywords: +patch Added file: http://bugs.python.org/file30185/cellfree3.diff ___ Python tracker

[issue17945] tkinter/Python 3.3.0: peer_create doesn't instantiate Text

2013-05-09 Thread Guilherme Polo
Guilherme Polo added the comment: Uh.. well observed. It sounds like you are the first actual user of peer_create. Now I wish Tk had done this in a different way: when creating a text widget, specificy that it is a peer of some other text widget via an option ("-peer w" for example). If possibl

[issue17858] Different documentation for identical methods

2013-05-09 Thread Andriy Mysyk
Andriy Mysyk added the comment: Incorporated R. David Murray's feedback... .. method:: acquire(blocking=True, timeout=-1) Without any optional argument, this method acquires the lock unconditionally, if necessary waiting until it is released by another thread (only one thre

[issue17656] Python 2.7.4 breaks ZipFile extraction of zip files with unicode member paths

2013-05-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ah, fair enough. -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue17656] Python 2.7.4 breaks ZipFile extraction of zip files with unicode member paths

2013-05-09 Thread Arfrever Frehtes Taifersar Arahesis
Arfrever Frehtes Taifersar Arahesis added the comment: http://mail.python.org/pipermail/python-dev/2013-April/125761.html asked to leave bugs open. -- ___ Python tracker ___ ___

[issue17945] tkinter/Python 3.3.0: peer_create doesn't instantiate Text

2013-05-09 Thread Gregory HOULDSWORTH
New submission from Gregory HOULDSWORTH: Python version: 3.3.0 32bit OS: Windows 7 Service Pack 1 64bit The peer_create method of the Text class, introduced in changeset <71041c0dedd5> in response to issue <2843> creates a tk text widget but does not instantiate Text. Because they don't exist as

[issue17941] namedtuple should support fully qualified name for more portable pickling

2013-05-09 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue16741] `int()`, `float()`, etc think python strings are null-terminated

2013-05-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thanks, for 3.4 I will use new formatting feature. -- ___ Python tracker ___ ___ Python-bugs-list

[issue17700] Update Curses HOWTO for 3.4

2013-05-09 Thread Ezio Melotti
Ezio Melotti added the comment: Patch LGTM. You should commit it to 3.3 and then merge it with default (unless the patch contains parts that are specific to 3.4). -- ___ Python tracker

[issue17941] namedtuple should support fully qualified name for more portable pickling

2013-05-09 Thread Eric V. Smith
Eric V. Smith added the comment: I agree it should work the same as Enum, and I agree it should be possible to supply the module name. But wouldn't it be cleaner as: Point = namedtuple('Point', 'x y z', module=__name__) rather than: Point = namedtuple(__name__ + '.Point', 'x y z') ? ---

[issue17700] Update Curses HOWTO for 3.4

2013-05-09 Thread A.M. Kuchling
A.M. Kuchling added the comment: I've just verified that I still have commit access to the repo, so unless someone has any further suggested changes to the patch, I'll go ahead and commit it to trunk. Should I also commit it to the 3.3 branch? Victor: I'm willing to improve the HOWTO's discus

[issue17938] Duplicate text in docs/reference/import statement

2013-05-09 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the report! -- assignee: docs@python -> ezio.melotti resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 3.4 ___ Python tracker

[issue17938] Duplicate text in docs/reference/import statement

2013-05-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 844c6442a39e by Ezio Melotti in branch '3.3': #17938: remove duplicate paragraphs. http://hg.python.org/cpython/rev/844c6442a39e New changeset ebc296bf23d1 by Ezio Melotti in branch 'default': #17938: merge with 3.3. http://hg.python.org/cpython/rev

[issue17809] FAIL: test_expanduser when $HOME ends with /

2013-05-09 Thread Ezio Melotti
Ezio Melotti added the comment: Fixed, thanks for the patch! -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ ___

[issue17943] AttributeError: 'long' object has no attribute 'release' in Queue.put()

2013-05-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: Waiters are created through _allocate_lock(), so you should look there. But, unless you have further info, I don't think keeping this open as a bug is useful. -- ___ Python tracker

[issue17809] FAIL: test_expanduser when $HOME ends with /

2013-05-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset dee0a2dea11e by Ezio Melotti in branch '3.3': #17809: fix a test failure in test_expanduser when $HOME has a trailing /. Patch by Kubilay Kocak. http://hg.python.org/cpython/rev/dee0a2dea11e New changeset 489f075430de by Ezio Melotti in branch 'de

[issue17656] Python 2.7.4 breaks ZipFile extraction of zip files with unicode member paths

2013-05-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't think so. The bug is fixed, and the fix will be in the release. -- ___ Python tracker ___ __

[issue17656] Python 2.7.4 breaks ZipFile extraction of zip files with unicode member paths

2013-05-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Shouldn't it left opened until regression fix release has released. -- ___ Python tracker ___ ___

[issue16631] tarfile.extractall() doesn't extract everything if .next() was used

2013-05-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Patch for issue16601 has fixed this issue too. -- resolution: -> duplicate stage: patch review -> committed/rejected status: open -> closed superseder: -> Restarting iteration over tarfile continues from where it left off. _

[issue16601] Restarting iteration over tarfile continues from where it left off.

2013-05-09 Thread Michael Birtwell
Michael Birtwell added the comment: Sorry about the delay in the contributor form. Things got in the way then I completely forgot about it. It's done now. -- ___ Python tracker

[issue16601] Restarting iteration over tarfile continues from where it left off.

2013-05-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for contribution. I have committed simpler test. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: -Python 3.2 ___ Python tracker

[issue16601] Restarting iteration over tarfile continues from where it left off.

2013-05-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9b86fb6f5bc9 by Serhiy Storchaka in branch '2.7': Issue #16601: Restarting iteration over tarfile no more continues from where http://hg.python.org/cpython/rev/9b86fb6f5bc9 New changeset 9ed127d8ad61 by Serhiy Storchaka in branch '3.3': Issue #16601

[issue17941] namedtuple should support fully qualified name for more portable pickling

2013-05-09 Thread Richard Oudkerk
Richard Oudkerk added the comment: > If the name is a qualified dotted name, it will be split and the first > part becomes the __module__. That will not work correctly if the module name has a dot in it. -- nosy: +sbt ___ Python tracker

[issue17927] Argument copied into cell still referenced by frame

2013-05-09 Thread Nick Coghlan
Nick Coghlan added the comment: Ah, I misread the second patch, I think due to the "copy the cell into" in the comment. I believe I would have grasped it immediately if it said something like "reference the cell from". -- ___ Python tracker

[issue17944] Refactor test_zipfile

2013-05-09 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Here is a patch which refactors test_zipfile, decreases it's size by 269 lines, makes adding tests for new compression types and new tests for all compression types simpler, and makes test_zipfile discoverable. -- components: Tests files: test_zipf

[issue17583] IDLE HOWTO

2013-05-09 Thread Amit Saha
Amit Saha added the comment: Hello, I just wanted to check if I should attach the image files separately and submit the text as a diff? Thanks. -- ___ Python tracker ___ _

[issue16584] unhandled IOError filecmp.cmpfiles() if file not readable

2013-05-09 Thread Till Maas
Till Maas added the comment: I just tried on a Windows 8 system with python from GIMP. The error occurs there as well if I compare two empty files after I removed permissions for one of the files. I do not know how to manage Windows' file ACLs in python, therefore I created the test case using

[issue11354] argparse: nargs could accept range of options count

2013-05-09 Thread paul j3
paul j3 added the comment: I think this patch should build on http://bugs.python.org/issue9849, which seeks to improve the error checking for nargs. There, add_argument returns an ArgumentError if the nargs value is not a valid string, interger, or it there is mismatch between a tuple metavar

[issue17922] Crash in clear_weakref

2013-05-09 Thread Jan Safranek
Jan Safranek added the comment: On 05/07/2013 05:32 PM, Antoine Pitrou wrote: > Jan, one possibility would be for Pegasus to stop "unloading" Python, > it seems. It is always possibility. Actually, Pegasus "plugin" is just a shared object (.so) and the .so is linked with Python. Pegasus calls dl

[issue17922] Crash in clear_weakref

2013-05-09 Thread Jan Safranek
Jan Safranek added the comment: On 05/07/2013 06:06 PM, Antoine Pitrou wrote: > a significant amount of static data inside CPython actually survives > Py_Finalize :-/ As a solution, would it be possible to wipe all registered types in Py_Finalize? Jan -- __