[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: Yep, that is promising. At worst we’ll have a new cool API and three obsolete sets in the os module, not a big deal. -- ___ Python tracker ___ __

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Nick Coghlan
Nick Coghlan added the comment: Éric - there's almost certainly going to be a PEP for 3.4 about doing this kind of feature advertisement in a cleaner and more consistent way. -- ___ Python tracker

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: I was at work, and moving out of my apartment, and desperating at the subthreads spawned by my mail about packaging, and agreeing with the people being -1 on is_implemented on Signature objects :-) -- ___ Python track

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: > I guess it’s too late to propose “os.open.supports_dir_fd and > os.unlink.supports_dir_fd” (and I don’t know if that is feasible > with C functions) :) Where were you when "is_implemented" was being savagely torn apart last week? ;-) -- __

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset c2be81151994 by Nick Coghlan in branch 'default': Issue #4489: Rename the feature marker for the symlink resistant rmtree and store it as a function attribute http://hg.python.org/cpython/rev/c2be81151994 -- __

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: The code using set operations seems slightly too cryptic for me, even though I’m comfortable with sets and functions as first-class objects. A matter of taste I guess. BTW it sounds a bit strange to me to have the verb in the singular in supports_dir_fd when i

[issue15056] Have imp.cache_from_source() raise NotImplementedError when cache tag not available

2012-06-23 Thread Eric Snow
Eric Snow added the comment: Brett meant the implementation would set it. You'd still expect it to not change values during the execution of the interpreter. I suppose anyone could change that value, but I'd see that more as a consenting adults situation. -- ___

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: Bikeshedding: (os.unlink in os.supports_dir_fd and os.open in os.supports_dir_fd) could be rewritten as { os.open, os.unlink } <= os.supports_dir_fd As you were! -- ___ Python tracker

[issue10053] Don’t close fd when FileIO.__init__ fails

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: I don’t know; Antoine is the io expert. I just remember that io used to be in C and was moved to _pyio for documentation and experimentation purposes, so I was sure it was a fully standalone lib but I could be mistaken. -- _

[issue15056] Have imp.cache_from_source() raise NotImplementedError when cache tag not available

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: > So sys.dont_write_bytecode is there to prevent bytecode writing but not > loading. Ah right. Providing a way to avoid reading them sounds good. > If you set sys.implementation.cache_tag to None you stop all bytecode usage > (reading and writing) This I feel u

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Hynek Schlawack
Hynek Schlawack added the comment: Excellent Nick! I discussed the very same thing with David yesterday but somehow we didn't come up with a good name. So we kept it on "safe" (which predates the secure discussion). -- ___ Python tracker

[issue14772] Return destination values in some shutil functions

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.o

[issue13512] ~/.pypirc created insecurely

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: Do you have links to those patches? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Nick Coghlan
Nick Coghlan added the comment: I'm in the process of updating the LBYL support to use a "rmtree.avoids_symlink_attacks" function attribute rather than the "rmtree_is_safe" module level attribute. As I said in the hmac.secure_compare function discussion, the words "safe" and "secure" are too

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Hynek Schlawack
Hynek Schlawack added the comment: I thought about that too but couldn't find a precedent (I didn't look very long though :)) where we've done that before so I went for an attribute. I'd change it immediately if others agree. -- ___ Python tracker

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: Can I suggest setting a “safe” attribute on the rmtree function object instead of adding another name to the module? -- nosy: +larry ___ Python tracker __

[issue13590] extension module builds fail with python.org OS X installers on OS X 10.7 and 10.6 with Xcode 4.2

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 796d9fc28e95 by Ned Deily in branch 'default': Issue #13590: Improve support for OS X Xcode 4: http://hg.python.org/cpython/rev/796d9fc28e95 -- ___ Python tracker ___

[issue15118] uname and other os functions should return a struct sequence instead of a tuple

2012-06-23 Thread Larry Hastings
Changes by Larry Hastings : -- assignee: -> larry stage: -> patch review type: -> behavior ___ Python tracker ___ ___ Python-bugs-l

[issue14815] random_seed uses only 32-bits of hash on Win64

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: I got bored so I made you a patch. -- keywords: +patch Added file: http://bugs.python.org/file26125/larry.random_seed.ssize_t.1.diff ___ Python tracker ___

[issue15016] Add special case for latin messages in email.mime.text

2012-06-23 Thread Dmitry Shachnev
Dmitry Shachnev added the comment: > This seems to be an enhancement sort of request rather than a bug... so I > wonder why Python 3.2 is listed? Fixed. > ... although I see nothing in the PEP about how to access that information > from Python. You are right, it seems there is no Python API

[issue14917] Make os.symlink on Win32 detect if target is directory

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: Note: I can't test this, as I only run Windows XP. But it compiles cleanly on Windows, and on Linux it compiles and passes the test suite fine. -- ___ Python tracker ___

[issue14917] Make os.symlink on Win32 detect if target is directory

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: Patch attached. Implementation now uses GetFileAttributes (A or W) to determine whether or not src is a directory. Fixed docstring, docs, and updated Misc/NEWS. -- assignee: -> larry keywords: +patch nosy: +mhammond stage: needs patch -> patch revi

[issue15118] uname and other os functions should return a struct sequence instead of a tuple

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: Whoops, here's the patch. -- Added file: http://bugs.python.org/file26123/larry.uname.and.times.structseq.3.diff ___ Python tracker ___ __

[issue15118] uname and other os functions should return a struct sequence instead of a tuple

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: Attached is patch #3. Ned Deily advised me not to touch distutils, and packaging is in the process of being removed. So I backed out of my changes to those two packages. Apart from that the patch is the same as #2. Georg: mind if this goes in before freeze

[issue15159] Add failover for follow_symlinks and effective_ids where possible

2012-06-23 Thread Larry Hastings
New submission from Larry Hastings : Serhiy Storchaka suggested (in private email, not on tracker or python-dev): why not make follow_symlinks and effective_ids failover where possible? Let's take the example of effective_ids first, that's simpler. Let's say the user calls os.access("x", os

[issue15147] Remove packaging from the stdlib

2012-06-23 Thread Ramchandra Apte
Ramchandra Apte added the comment: Oh.. understand now packaging is being deferred. -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue15147] Remove packaging from the stdlib

2012-06-23 Thread Ramchandra Apte
Ramchandra Apte added the comment: Why are you removing packaging? -- nosy: +ramchandra.apte ___ Python tracker ___ ___ Python-bugs-l

[issue15147] Remove packaging from the stdlib

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: Packaging removed in 576b8b182039. I’m going to wait an hour or two and in the absence of feedback will remove sysconfig.cfg too; that will be easy to revert if consensus was to keep it and I was not online (but I really think sysconfig.cfg should go). I’ll al

[issue15158] Add support for multi-character delimiters in csv

2012-06-23 Thread Ramchandra Apte
Ramchandra Apte added the comment: BTW, conincidentally just like the stackoverflow, even I want to split double pipes -- ___ Python tracker ___ ___

[issue15158] Add support for multi-character delimiters in csv

2012-06-23 Thread Ramchandra Apte
New submission from Ramchandra Apte : It would be nice if csv supported multi-character delimiters. I need it for my project. Another person had this problem: http://stackoverflow.com/questions/6352409/how-to-use-python-csv-module-for-splitting-double-pipe-delimited-data . -- componen

[issue11113] html.entities mapping dicts need updating?

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: The explanations make sense, don’t change anything. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue11113] html.entities mapping dicts need updating?

2012-06-23 Thread Ezio Melotti
Ezio Melotti added the comment: The problem is that the standard allows some charref to end without a ';', but not all of them. So both "Éric" and Éric" will be parsed as "Éric", but only "αcentauri" will result in "αcentauri" -- "&alphacentauri" will be returned unchanged. I'm now working

[issue11113] html.entities mapping dicts need updating?

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: BTW in the doc you may point to collections.ChainMap to explain to people how to make one dict with HTML 4 and HTML 5 entities. (Note that I assume there are two dicts, but I only skimmed the diff.) -- ___ Python tra

[issue11113] html.entities mapping dicts need updating?

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: The ';' is not part of the entity name but an SGML delimiter, like '&'; the strings in the dict should not include it (like in the other dict they don’t). -- ___ Python tracker

[issue15157] venvs should include pydoc

2012-06-23 Thread Éric Araujo
New submission from Éric Araujo : To get documentation about a module installed in a venv, one needs to use “python -m pydoc” instead of just “pydoc”; I would like a pydoc script with the appropriate shebang to be installed in the venv’s bin dir. Similar request in virtualenv for the reference

[issue15156] Refactor HTMLParser.unescape to use html.entities.html5

2012-06-23 Thread Ezio Melotti
New submission from Ezio Melotti : HTMLParser has an internal method called unescape [0] used to convert named character references to the equivalent characters, and it does so by using html.entities.name2codepoint to recreate the equivalent of html.entities.entityrefs with the addition of '.

[issue11113] html.entities mapping dicts need updating?

2012-06-23 Thread Ezio Melotti
Changes by Ezio Melotti : -- resolution: -> fixed stage: commit review -> committed/rejected status: open -> closed ___ Python tracker ___ __

[issue11113] html.entities mapping dicts need updating?

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2b54e25d6ecb by Ezio Melotti in branch 'default': #3: add a new "html5" dictionary containing the named character references defined by the HTML5 standard and the equivalent Unicode character(s) to the html.entities module. http://hg.python.or

[issue15147] Remove packaging from the stdlib

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: The sysconfig module was modified (and sysconfig.cfg was introduced) to serve the needs of the resource system (install_data putting files into system-configured locations and packaging.database finding them); one of the thousand things mentioned in the “Status

[issue15147] Remove packaging from the stdlib

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: On it. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.or

[issue15118] uname and other os functions should return a struct sequence instead of a tuple

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: Okay, this patch is definitely ready. Changes from the last patch: * The two return types are now exposed in the os module (os.uname_result and os.times_result) and are permanently on even if os.uname() or os.times() are not available. * I updated the libra

[issue15016] Add special case for latin messages in email.mime.text

2012-06-23 Thread Glenn Linderman
Glenn Linderman added the comment: Patch is interesting, using an encoder to detect validity. However, it suffers from some performance problems for long text that has large ASCII prefixes. This seems to be an enhancement sort of request rather than a bug... so I wonder why Python 3.2 is list

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-23 Thread Christian Heimes
Christian Heimes added the comment: New patch. I've removed the special handling of PyBytes_CheckExact, support subclasses of str, non compact ASCII str and updated the docs. (Next time I'll create a sandbox and push my work to its own branch.) -- Added file: http://bugs.python.org/f

[issue15154] remove "rmdir" argument from os.unlink, add "dir_fd" to os.rmdir

2012-06-23 Thread Larry Hastings
Changes by Larry Hastings : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue15154] remove "rmdir" argument from os.unlink, add "dir_fd" to os.rmdir

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: I made two documentation changes to the patch before committing it: * I restored the text under os.remove about how it doesn't handle directories. * I added a Misc/NEWS entry. But I didn't have to touch the code--that looked dead-on to me. Proper job, Georg

[issue15154] remove "rmdir" argument from os.unlink, add "dir_fd" to os.rmdir

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3b7230997425 by Larry Hastings in branch 'default': Issue #15154: Add "dir_fd" parameter to os.rmdir, remove "rmdir" http://hg.python.org/cpython/rev/3b7230997425 -- nosy: +python-dev ___ Python tracker

[issue15155] sporadic failure in RecvmsgSCTPStreamTest

2012-06-23 Thread Antoine Pitrou
New submission from Antoine Pitrou : Sometimes seen on buildbots (e.g. http://www.python.org/dev/buildbot/all/builders/AMD64%20Ubuntu%20LTS%203.x/builds/309/steps/test/logs/stdio ). It seems it's always testRecvmsgEOF which fails. $ ./python -m test -m RecvmsgSCTPStreamTest -unetwork -Fv test

[issue15078] Change os.sendfile so its arguments are stable

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: It is usually folly to disagree with MvL, and yet I am about to do just that. As stated, I don't believe in the "thin wrappers" theory of os; where would a Windows programmer find the man page to learn how os.access works on their system? I think os should

[issue13590] extension module builds fail with python.org OS X installers on OS X 10.7 and 10.6 with Xcode 4.2

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 688d48e434e4 by Ned Deily in branch 'default': Issue #13590: Improve support for OS X Xcode 4: http://hg.python.org/cpython/rev/688d48e434e4 -- ___ Python tracker ___

[issue15146] Implemented PyType_FromSpecWithBases

2012-06-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, 33737210c906 seems to have fixed it. -- stage: -> committed/rejected ___ Python tracker ___ __

[issue15003] make PyNamespace_New() public

2012-06-23 Thread Eric Snow
Changes by Eric Snow : Removed file: http://bugs.python.org/file25853/issue15003_public.diff ___ Python tracker ___ ___ Python-bugs-list maili

[issue15003] make PyNamespace_New() public

2012-06-23 Thread Eric Snow
Eric Snow added the comment: Here's an updated patch to address the use of _PyNamespace_New() in changeset 77414:0011536f2a06. -- Added file: http://bugs.python.org/file26119/issue15003_public.diff ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9c71d7f057b3 by Martin v. Löwis in branch 'default': Issue #15102: find python.exe in OutDir, not SolutionDir. http://hg.python.org/cpython/rev/9c71d7f057b3 -- ___ Python tracker

[issue15146] Implemented PyType_FromSpecWithBases

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: I have no clue what might have caused this. My guess is that there is a refcounting bug *somewhere*. -- ___ Python tracker ___ __

[issue15133] tkinter.BooleanVar.get() behavior and docstring disagree

2012-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Just that, which I used to verify with 2.7.3 and 3.3.0a4 in Win7 and do some more experiments: bv.set/get happily accept *and return* 2, -1, bv.set(2.2) 'works' bv.get() then raises TypeError: must be str, not float This will annoy you ;-) bv.set('1'); bv.get

[issue14286] xxlimited.obj: unresolved external symbol __imp__PyObject_New

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: Closing as works-for-me. -- resolution: -> works for me status: open -> closed ___ Python tracker ___ ___

[issue11626] Py_LIMITED_API on windows: unresolved symbol __imp___PyArg_ParseTuple_SizeT

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: As some time has passed (unfortunately), I now decided to add these functions only to the stable ABI of 3.3+. I'd appreciate if you could review the beta releases and comment whether they fix the issue. Notice that you will have to set Py_LIMITED_API to 0x03

[issue11626] Py_LIMITED_API on windows: unresolved symbol __imp___PyArg_ParseTuple_SizeT

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3f14119e4af7 by Martin v. Löwis in branch 'default': Issue #11626: Add _SizeT functions to stable ABI. http://hg.python.org/cpython/rev/3f14119e4af7 -- nosy: +python-dev ___ Python tracker

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-23 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue14226] Expose dict_proxy type from descrobject.c

2012-06-23 Thread Eric Snow
Changes by Eric Snow : -- resolution: -> duplicate status: open -> closed superseder: -> Expose dict_proxy internal type as types.MappingProxyType ___ Python tracker ___ __

[issue15146] Implemented PyType_FromSpecWithBases

2012-06-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: There was a crash here: http://www.python.org/dev/buildbot/all/builders/x86%20OpenIndiana%203.x/builds/4014/steps/test/logs/stdio -- nosy: +pitrou ___ Python tracker _

[issue15139] Speed up threading.Condition wakeup

2012-06-23 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue15139] Speed up threading.Condition wakeup

2012-06-23 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Well, the rationale for keeping the try_finally is that the Condition should continue to work with other Locks, as long as they provide _release_save and _acquire_restore methods. Lock._acquire_condtion onnly knows Lock and RLock intimately enough to

[issue13115] tp_as_{number, sequence, mapping} can't be set using PyType_FromSpec

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: For 3.3, this is fixed in bb6df3781edb. However, this needs to be backported to 3.2. -- ___ Python tracker ___ __

[issue15146] Implemented PyType_FromSpecWithBases

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: Thanks for the patch. Committed with slight modifications: if the spec contained a tp_base/tp_bases pointer, that needed to be considered. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue15146] Implemented PyType_FromSpecWithBases

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset bb6df3781edb by Martin v. Löwis in branch 'default': Issue #15146: Add PyType_FromSpecWithBases. Patch by Robin Schreiber. http://hg.python.org/cpython/rev/bb6df3781edb -- nosy: +python-dev ___ Python tr

[issue8271] str.decode('utf8', 'replace') -- conformance with Unicode 5.2.0

2012-06-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is updated patch with resolved merge conflict with 3214c9ebcf5e. -- Added file: http://bugs.python.org/file26118/issue8271-3.3-fast-3.patch ___ Python tracker __

[issue15139] Speed up threading.Condition wakeup

2012-06-23 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: Made lock_acquire_condition() more robust, always acquiring the outer lock if possible. For Lock objects (not RLocks), set the "locked" variable that was recently added. -- Added file: http://bugs.python.org/file26117/condition.patch

[issue14923] Even faster UTF-8 decoding

2012-06-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Serhiy, does this patch also fix #8271? No, this patch not change behavior. But updated patch for issue 8271 now contains this patch (I hope this will help merge). > If so, can you also include the tests I wrote for it? Your tests included in patch for is

[issue8271] str.decode('utf8', 'replace') -- conformance with Unicode 5.2.0

2012-06-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is updated, a little faster, patch. It merged with decode_utf8_range_check.patch from issue14923. Patch contains non-modified Ezio Melotti's tests which all successfully passed. -- Added file: http://bugs.python.org/file26116/issue8271-3.3-fast

[issue14923] Even faster UTF-8 decoding

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3214c9ebcf5e by Mark Dickinson in branch 'default': Issue #14923: Optimize continuation-byte check in UTF-8 decoding. Patch by Serhiy Storchaka. http://hg.python.org/cpython/rev/3214c9ebcf5e -- ___ Pyt

[issue14923] Even faster UTF-8 decoding

2012-06-23 Thread Mark Dickinson
Mark Dickinson added the comment: Patch applied. Closing. Ezio: the patch is pure optimization, with no change in semantics; I don't see how it could fix #8271. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: >>> About code. Instead (PyBytes_CheckExact(a) && PyBytes_CheckExact(b)) you >>> should use ((PyBytes_CheckExact(a) != 0) & (PyBytes_CheckExact(b) != >>> 0)). >> >> What's the difference? They are the same. > > Laziness. If "a" (a secret key) is not bytes then

[issue14596] struct.unpack memory leak

2012-06-23 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is Struct.__sizeof__ patch with tests. -- Added file: http://bugs.python.org/file26115/struct_sizeof-2.patch ___ Python tracker ___diff

[issue14626] os module: use keyword-only arguments for dir_fd and nofollow to reduce function count

2012-06-23 Thread Georg Brandl
Georg Brandl added the comment: The Windows buildbots are now content; closing. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue15154] remove "rmdir" argument from os.unlink, add "dir_fd" to os.rmdir

2012-06-23 Thread Georg Brandl
Georg Brandl added the comment: Works for me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.p

[issue15042] Implemented PyState_AddModule, PyState_RemoveModule

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: Thanks for the patch! -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ P

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

2012-06-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: There's still a problem when building ssl: Project "C:\Users\Buildbot\buildbot.python.org\3.x.kloth-win64\build\PCbuild\pcbuild.sln" (1) is building "C:\Users\Buildbot\buildbot.python.org\3.x.kloth-win64\build\PCbuild\_ssl.vcxproj" (18) on node 1 (default t

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

2012-06-23 Thread Stefan Krah
Stefan Krah added the comment: Antoine Pitrou wrote: > Stefan, don't fear interfering. Merging is easy. Good to know, I loathe merging. :) -- ___ Python tracker ___ __

[issue15139] Speed up threading.Condition wakeup

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: If the claim is that the _acquire_restore call becomes unnecessary, the entire try-finally should go. If that causes _acquire_restore to become unused, it should also go. -- ___ Python tracker

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset c56783fe2e3b by Stefan Krah in branch 'default': Issue #15102: Fix paths in external-amd64.bat. http://hg.python.org/cpython/rev/c56783fe2e3b -- ___ Python tracker __

[issue15154] remove "rmdir" argument from os.unlink, add "dir_fd" to os.rmdir

2012-06-23 Thread Larry Hastings
Larry Hastings added the comment: I think it's a good idea, and I didn't spot anything on my first pass at reviewing the patch. But I'm on my way out the door and won't be back for a few hours. Tell you what: once I'm back, if I don't spot anything out of place, I'll just check it in. If I

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

2012-06-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Stefan, don't fear interfering. Merging is easy. -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue15139] Speed up threading.Condition wakeup

2012-06-23 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: I'll fix the patch so that the lock is _always_ re-aqcuired. -- ___ Python tracker ___ ___

[issue15139] Speed up threading.Condition wakeup

2012-06-23 Thread Kristján Valur Jónsson
Kristján Valur Jónsson added the comment: _acquire_condition() should _always_ re-aquire the outer lock, even for a timeout or an interrupt. I see however that it doesn't do so if there is an argument error, but that should not be a problem for an internal method, since it would mean that th

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

2012-06-23 Thread Stefan Krah
Stefan Krah added the comment: I've fixed some paths in external-amd64.bat. Uploading a diff instead of committing right away so as not to interfere with the steadily incoming commits. -- Added file: http://bugs.python.org/file26114/external-amd64.diff _

[issue15102] Fix 64-bit building for buildbot scripts (issue 15102)

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset a9d4cf7d15b9 by Martin v. Löwis in branch 'default': Issue #15102: Use HOST_PYTHON only if it is set. http://hg.python.org/cpython/rev/a9d4cf7d15b9 -- ___ Python tracker

[issue11113] html.entities mapping dicts need updating?

2012-06-23 Thread Ezio Melotti
Ezio Melotti added the comment: Here's a new patch that uses the "html5" name for the dict, if there aren't other comments I'll commit it. -- Added file: http://bugs.python.org/file26113/issue3-2.diff ___ Python tracker

[issue4489] shutil.rmtree is vulnerable to a symlink attack

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 53fc7f59c7bb by Hynek Schlawack in branch 'default': #4489: Fix usage of fd-based functions to new api introduced earlier today http://hg.python.org/cpython/rev/53fc7f59c7bb -- ___ Python tracker

[issue11113] html.entities mapping dicts need updating?

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: How about calling it just "html5", or "HTML5"? That it is about entities already follows from the module name. -- ___ Python tracker ___

[issue15154] remove "rmdir" argument from os.unlink, add "dir_fd" to os.rmdir

2012-06-23 Thread Hynek Schlawack
Changes by Hynek Schlawack : -- nosy: +hynek ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

[issue15061] hmac.secure_compare() leaks information about length of strings

2012-06-23 Thread Christian Heimes
Christian Heimes added the comment: New patch. The compare_digest method now lives in the operator module as operator._compare_digest -- Added file: http://bugs.python.org/file26112/compare_digest_c.patch ___ Python tracker

[issue15150] Windows build does not link

2012-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset f3d28feef2ea by Martin v. Löwis in branch 'default': Issue #15150: regenerate python3stub.def. http://hg.python.org/cpython/rev/f3d28feef2ea -- nosy: +python-dev ___ Python tracker

[issue15150] Windows build does not link

2012-06-23 Thread Martin v . Löwis
Changes by Martin v. Löwis : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue15150] Windows build does not link

2012-06-23 Thread Martin v . Löwis
Martin v. Löwis added the comment: This should be fixed with the patch above. As python3.mak was using the wrong target names, the failing command probably wasn't executed. -- ___ Python tracker _

[issue15114] Deprecate strict mode of HTMLParser

2012-06-23 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue13263] Group some os functions in submodules

2012-06-23 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue15154] remove "rmdir" argument from os.unlink, add "dir_fd" to os.rmdir

2012-06-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Looks fine to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://

[issue15147] Remove packaging from the stdlib

2012-06-23 Thread Éric Araujo
Éric Araujo added the comment: Just a note: a this time I am cleaning the apartment that I’m leaving, so when I say “Saturday afternoon” it’s in Montreal time, so you may see it as early Sunday from Europe. So don’t worry if your Saturday night comes and I did not commit. -- __

  1   2   3   >