[issue13197] subprocess: move shell arguments to a separate keyword param

2011-10-18 Thread anatoly techtonik
anatoly techtonik added the comment: List not only needs to be joined, it should be quoted as well. But the biggest problem will be the change of behavior between Python versions which may confuse users even more. Perhaps it's a good time to start embedding 'best practice' recipes in manual.

[issue13205] NameErrors in generated setup.py (codecs, split_multiline)

2011-10-18 Thread David Barnett
David Barnett added the comment: Regression tests. Not positive that subprocess is the best approach for running these, but it seems to work. In the process of writing tests, I discovered another missing import for PackagingFileError when there's no setup.cfg. -- Added file: http://b

[issue13121] collections.Counter's += copies the entire object

2011-10-18 Thread Raymond Hettinger
Changes by Raymond Hettinger : Added file: http://bugs.python.org/file23457/counter.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue10860] Handle empty port after port delimiter in httplib

2011-10-18 Thread Shawn Ligocki
Shawn Ligocki added the comment: Great! Glad it landed :) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue1757072] Zipfile robustness

2011-10-18 Thread R. David Murray
R. David Murray added the comment: "This issue" is currently a collection point for specific "allow this in lax mode" issues. Do you have one or more specific cases in point that you'd like to talk about? (Note that the 'garbage after end of file' bug has already been fixed.) -- _

[issue10680] argparse: titles and add_mutually_exclusive_group don't mix (even with workaround)

2011-10-18 Thread Łukasz Langa
Changes by Łukasz Langa : -- Removed message: http://bugs.python.org/msg145883 ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue10680] argparse: titles and add_mutually_exclusive_group don't mix (even with workaround)

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5c5c6a28b349 by Łukasz Langa in branch 'default': A ricochet from fixing #10680: http://http://example.com/ no longer reports http://hg.python.org/cpython/rev/5c5c6a28b349 -- nosy: +python-dev ___ Python

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

2011-10-18 Thread Justin Love
Justin Love added the comment: re: test_glob_to_re Could not reproduce (OS X 10.6) I built branch 2.7, and also tried the expressions from glob_to_re on my system 2.7 and 3.2, all returned the (?ms) version. -- ___ Python tracker

[issue13217] Missing header dependencies in Makefile

2011-10-18 Thread Meador Inge
Changes by Meador Inge : -- nosy: +meador.inge stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue13217] Missing header dependencies in Makefile

2011-10-18 Thread John O'Connor
New submission from John O'Connor : I think ucs{1,2,4}lib.h, asciilib.h and a few other files should be in the Makefile deps list for unicodeobject.c. Patch included. -- components: Build files: makefile.patch keywords: patch messages: 145881 nosy: haypo, jcon, pitrou priority: normal

[issue10860] Handle empty port after port delimiter in httplib

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6ac59218c049 by Łukasz Langa in branch '3.2': Fixes #10860: Handle empty port after port delimiter in httplib http://hg.python.org/cpython/rev/6ac59218c049 New changeset 18dc3811f2b8 by Łukasz Langa in branch 'default': Merged fix for #10860 from 3

[issue10860] Handle empty port after port delimiter in httplib

2011-10-18 Thread Łukasz Langa
Łukasz Langa added the comment: Patch merged. Thanks, Shawn. -- nosy: +lukasz.langa resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed versions: -Python 3.1 ___ Python tracker

[issue13152] textwrap: support custom tabsize

2011-10-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: +1 -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue13197] subprocess: move shell arguments to a separate keyword param

2011-10-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: I don't think you can tighten the API at this point. We could however make Popen complain when options are going to be thrown away. Or it could be made more liberal about what is accepts (running shlex on string input or join on list input as needed). -

[issue13173] Default values for string.Template

2011-10-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: This looks like a reasonable use case. That being said, I question whether the defaults should be attached directly to the template instance or whether they should be part of the substitution method. FWIW, there already have a couple of other ways to do i

[issue12533] python-celementtree prevents me from running python develop.py to compile Imprudence Viewer

2011-10-18 Thread Kristoffer Grundström
Kristoffer Grundström added the comment: Uhhhm. You could bypass the python-celementtree issue when compiling by editing fastest_celementree.py & uncommenting some lines so you compile using other instructions. -- ___ Python tracker

[issue13173] Default values for string.Template

2011-10-18 Thread Bfontaine
Bfontaine added the comment: A "light" version of diff added (rewrapped content is replaced by "[rewrapping]") -- Added file: http://bugs.python.org/file23455/string_template_default_values2-light.patch ___ Python tracker

[issue13173] Default values for string.Template

2011-10-18 Thread Bfontaine
Bfontaine added the comment: diff updated -- Added file: http://bugs.python.org/file23454/string_template_default_values2.patch ___ Python tracker ___ _

[issue13216] Add cp65001 codec

2011-10-18 Thread STINNER Victor
STINNER Victor added the comment: > Users want the code page 65001 See issues #6058, #7441 and #10920. -- ___ Python tracker ___ ___

[issue13216] Add cp65001 codec

2011-10-18 Thread STINNER Victor
New submission from STINNER Victor : Thanks to #12281, it is now trivial to implement any Windows code page in Python. I don't know if existing code pages (e.g. cp932) should use codecs.code_page_encode/.code_page_decode on Windows, or continue to use the (portable) Python code. Users want th

[issue13150] Most of Python's startup time is sysconfig

2011-10-18 Thread Roumen Petrov
Roumen Petrov added the comment: 10x for solution, 10x for commit . Good bye cross compilation! Any attempt to improve python build system to support cross-build, multilib build, build outside source tree with different options is useless. -- nosy: +rpetrov ___

[issue12281] bytes.decode('mbcs', 'ignore') does replace undecodable bytes on Windows Vista or later

2011-10-18 Thread STINNER Victor
STINNER Victor added the comment: test_codecs pass on Windows XP and Windows Seven buildbots. -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue13214] Cmd: list available completions from the cmd.Cmd subclass and filter out EOF handler(s)

2011-10-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: This looks to be a reasonable request. I think the patch would be better if the filtering were done directly in get_names(). A subclass can override or extend that method if it wants to customize the filter. -- assignee: -> rhettinger nosy: +rhe

[issue12174] Multiprocessing logging levels unclear

2011-10-18 Thread Vinay Sajip
Vinay Sajip added the comment: > Should there be another issue opened to do something about the extra logging > levels? IMO they shouldn't have been added in the first place, but I'm not sure if they're part of the public API and hence subject to backward-compatibility constraints. It would

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Uploaded a new patch that raises TypeError -- Added file: http://bugs.python.org/file23452/issue3067_v3.patch ___ Python tracker ___ _

[issue12281] bytes.decode('mbcs', 'ignore') does replace undecodable bytes on Windows Vista or later

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 413b89242766 by Victor Stinner in branch 'default': Issue #12281: Fix test_codecs.test_cp932() on Windows XP http://hg.python.org/cpython/rev/413b89242766 -- ___ Python tracker

[issue3067] setlocale error message is confusing

2011-10-18 Thread Martin v . Löwis
Martin v. Löwis added the comment: > Thanks for clarification! I see the problem now. So if I get this > correctly we should change the _build_localename to raise TypeError? Yes, that's what I'm proposing. > If the given locale is in wrong format, we'll get TypeError, but if > it's valid type

[issue12281] bytes.decode('mbcs', 'ignore') does replace undecodable bytes on Windows Vista or later

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5841920d1ef6 by Victor Stinner in branch 'default': Issue #12281: Skip code page tests on non-Windows platforms http://hg.python.org/cpython/rev/5841920d1ef6 -- ___ Python tracker

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Thanks for clarification! I see the problem now. So if I get this correctly we should change the _build_localename to raise TypeError? If the given locale is in wrong format, we'll get TypeError, but if it's valid type but otherwise invalid locale (like 'en

[issue13208] Problems with urllib on windows

2011-10-18 Thread Deepak Dodo
Deepak Dodo added the comment: The log file is also attached. This error is because the entire content of the webpage has not been read. -- Added file: http://bugs.python.org/file23451/error.log ___ Python tracker

[issue13208] Problems with urllib on windows

2011-10-18 Thread Deepak Dodo
Deepak Dodo added the comment: This is the source code I am using. Even if I use any module other than urllib to read the contents, its not reading the entire contents of the webpage. This happens only on Windows. -- Added file: http://bugs.python.org/file23450/tester.py

[issue3067] setlocale error message is confusing

2011-10-18 Thread Martin v . Löwis
Martin v. Löwis added the comment: > Maybe we should return TypeError with the same message then? That > would require some modification of documentation though, as it > states: "If the modification of the locale fails, the exception Error > is raised.". No, any operation can report TypeError a

[issue12281] bytes.decode('mbcs', 'ignore') does replace undecodable bytes on Windows Vista or later

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset af0800b986b7 by Victor Stinner in branch 'default': Issue #12281: Rewrite the MBCS codec to handle correctly replace and ignore http://hg.python.org/cpython/rev/af0800b986b7 -- nosy: +python-dev ___ Pyth

[issue13215] multiprocessing Manager.connect() aggressively retries refused connections

2011-10-18 Thread Benjamin Gilbert
New submission from Benjamin Gilbert : multiprocessing.managers.BaseManager.connect() takes 20 seconds to return on failure, even if the server refuses the connection. This is because the function that creates the connection, multiprocessing.connection.SocketClient(), handles ECONNREFUSED by

[issue13214] Cmd: list available completions from the cmd.Cmd subclass and filter out EOF handler(s)

2011-10-18 Thread Garrett Cooper
New submission from Garrett Cooper : 1. The current code in cmd.get_names does a dir on the derived class for cmd.Cmd object instead, which means that if I do something similar to the following: class CLI(cmd.Cmd): def register_subcommand(self, cmd, cli_class): def call_cli(self)

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Maybe we should return TypeError with the same message then? That would require some modification of documentation though, as it states: "If the modification of the locale fails, the exception Error is raised.". I don't really understand the "locale unpacki

[issue1294] Management of KeyboardInterrupt in cmd.py

2011-10-18 Thread Garrett Cooper
Garrett Cooper added the comment: I realize that this bug is closed, but I just had a comment to make. Handling EOF is simple: def do_EOF(self, arg): pass For my purposes I want to raise an EOFError so I can trickle up the chain to the appropriate caller because I'm coding a CLI where I

[issue7723] sqlite only accept buffer() for BLOB objects (input/output)

2011-10-18 Thread Florent Xicluna
Changes by Florent Xicluna : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue13212] json library is decoding/encoding when it should not

2011-10-18 Thread Raymond Hettinger
Raymond Hettinger added the comment: I don't see any way of changing this without breaking lots of code that currently works fine. It may be possible to add a strict-mode (off by default) or to add warnings. -- nosy: +rhettinger ___ Python tracker

[issue3067] setlocale error message is confusing

2011-10-18 Thread Martin v . Löwis
Martin v. Löwis added the comment: I think the reported exception type is incorrect. Given that the error message is 'Locale must be None, a string, or an iterable of two strings -- language code, encoding.', it very much sounds like a TypeError is being reported here. So I think all that's n

[issue13213] generator.throw() behavior

2011-10-18 Thread Florent Xicluna
Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13212] json library is decoding/encoding when it should not

2011-10-18 Thread Florent Xicluna
Changes by Florent Xicluna : -- nosy: +flox stage: -> needs patch type: -> behavior versions: -Python 2.6, Python 3.1, Python 3.4 ___ Python tracker ___ __

[issue1053687] PyOS_InputHook not called in IDLE subprocess

2011-10-18 Thread Roger Serwy
Roger Serwy added the comment: This is related to http://bugs.python.org/issue989712 -- nosy: +serwy ___ Python tracker ___ ___ Pyt

[issue12405] packaging does not record/remove directories it creates

2011-10-18 Thread Carl Meyer
Carl Meyer added the comment: > This is what I proposed earlier: we’d need to record all directories that > would have been created, but I’m not sure if it will be possible. For > example, if one uses --prefix /tmp/usr and pysetup install creates /tmp/usr, > /tmp/usr/lib, /tmp/usr/lib/python

[issue12797] io.FileIO and io.open should support openat

2011-10-18 Thread Ross Lagerwall
Ross Lagerwall added the comment: I guess that would make it more general... I'll play around with it for a bit. It mustn't become too hard to use though since the original point was to simplify the opening of files :-) -- ___ Python tracker

[issue13213] generator.throw() behavior

2011-10-18 Thread Petri Lehtinen
New submission from Petri Lehtinen : The documentation of generator.throw() gives this signature: generator.throw(type[, value[, traceback]]) Looking at the code, it accepts the following arguments: g.throw(ExcType) --> raise ExcType() g.throw(ExcType, None) --> raise ExcType() g

[issue13212] json library is decoding/encoding when it should not

2011-10-18 Thread Tomasz Buchert
New submission from Tomasz Buchert : Hi there! According to http://www.ietf.org/rfc/rfc4627.txt . The JSON object is either a list or a dictionary with other elements in it. However Python's implementation took liberty to parse also basic types, like integers, strings, floats, etc. For example

[issue13210] Support Visual Studio 2010

2011-10-18 Thread Martin v . Löwis
Martin v. Löwis added the comment: I think this issue urgently needs a scope defined. What *exactly* is it that you want to achieve? If it's merely being able to compile Python with VS 2010, many of the proposed changes are unnecessary. If you propose that the patch should be used to replace

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Petri Lehtinen
Petri Lehtinen added the comment: BTW, shouldn't this be applied to 2.7 too? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue13208] Problems with urllib on windows

2011-10-18 Thread Martin v . Löwis
Martin v. Löwis added the comment: Can you please provide a test case? What exact source code you are using, and what exact result are you getting? Attach those pieces as files. -- nosy: +loewis ___ Python tracker

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Petri Lehtinen
Petri Lehtinen added the comment: Antoine Pitrou wrote: > Actually, it is documented: > “Return the traceback associated with the exception as a new reference (...)” Ah, you're right. It just doesn't have the green "Return value: New reference" note. Thanks for committing! -- ___

[issue12296] Minor clarification in devguide

2011-10-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: To be more exact, "optional arguments" should be more extended to "optional arguments whose default maintains the existing behavior" -- ___ Python tracker ___

[issue13150] Most of Python's startup time is sysconfig

2011-10-18 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue13172] Improve detection of availability of bdist_msi command

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: > The existing traceback doesn't even mention _msi. Looks like #12703, which I’m going to fix shortly. -- dependencies: +Improve error reporting for packaging.util.resolve_name ___ Python tracker

[issue1673007] urllib2 requests history + HEAD support

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: Doc patch to fix a reST error and tweak a few things. -- Added file: http://bugs.python.org/file23448/urllib.request-doc.diff ___ Python tracker ___

[issue868845] Need unit tests for <...> reprs

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: > I sometimes wish that the str() of a class would return the class name > rather than its repr(); that way "print(str)" would print "str" > instead of . (Use case: printing an exception and its > message: I wish I could print("%s: %s" % (err.__class__, err)) inst

[issue13150] Most of Python's startup time is sysconfig

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: BTW, distutils2 backports the sysconfig module and cfg file from 3.3, so now the two versions will diverge. -- ___ Python tracker ___ ___

[issue13205] NameErrors in generated setup.py (codecs, split_multiline)

2011-10-18 Thread David Barnett
David Barnett added the comment: Sure, I can give it a go. I'll probably have a chance sometime today. -- ___ Python tracker ___ ___

[issue3990] The Linux2 platform definition is incorrect for alpha, hppa, mips, sparc

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: If we keep the plat-* directories, I think too that introducing new sys.platform values seems a bit heavy-handed. -- dependencies: +Automatically regenerate platform-specific modules nosy: +eric.araujo ___ Python track

[issue10197] subprocess.getoutput fails on win32

2011-10-18 Thread bpoaugust
bpoaugust added the comment: I got the () syntax from: http://technet.microsoft.com/en-us/library/cc737438%28WS.10%29.aspx which refers to grouping, not subshell. -- ___ Python tracker __

[issue3990] The Linux2 platform definition is incorrect for alpha, hppa, mips, sparc

2011-10-18 Thread Éric Araujo
Changes by Éric Araujo : -- versions: +Python 3.2, Python 3.3 -Python 2.6, Python 3.1 ___ Python tracker ___ ___ Python-bugs-list maili

[issue1565071] update Lib/plat-linux2/IN.py

2011-10-18 Thread Éric Araujo
Changes by Éric Araujo : -- dependencies: +Automatically regenerate platform-specific modules stage: test needed -> needs patch versions: +Python 2.7, Python 3.2, Python 3.3 -Python 2.6 ___ Python tracker ___

[issue13193] test_packaging and test_distutils failures under Windows

2011-10-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Similar test failure under x86 OpenIndiana: == ERROR: test_resources (packaging.tests.test_command_install_data.InstallDataTestCase) ---

[issue13205] NameErrors in generated setup.py (codecs, split_multiline)

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: Thanks! I haven’t tested generate-setup for some time. It would be great to add a regression test for this. Would you like to do it? To mock user input, just copy the Inputs class from test_command_register. If not, I will do it. -- assignee: tarek

[issue13170] distutils2 test failures

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5d858149df06 by Éric Araujo in branch 'default': Synchronize config with packaging (fixes #13170) http://hg.python.org/distutils2/rev/5d858149df06 -- nosy: +python-dev ___ Python tracker

[issue11638] python setup.py sdist crashes if version is unicode

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: David: I don’t think packaging and pysetup generate-setup have anything to do with this bug. You can create a setup.py file manually and see the error with distutils in 2.7. As I said before, I agree this is a bug. I’m working on many things right now, so if

[issue3067] setlocale error message is confusing

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: I modified the patch not to contain the tests against exception messages -- Added file: http://bugs.python.org/file23447/issue3067_v2.patch ___ Python tracker ___

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

2011-10-18 Thread Jyrki Pulliainen
Changes by Jyrki Pulliainen : Removed file: http://bugs.python.org/file23444/issue10817.patch ___ Python tracker ___ ___ Python-bugs-list mail

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: I had a bad patch, containing changes to locale.py, so I've uploaded a new patch for this. -- Added file: http://bugs.python.org/file23446/issue10817.patch ___ Python tracker _

[issue12296] Minor clarification in devguide

2011-10-18 Thread Ezio Melotti
Ezio Melotti added the comment: LGTM. (Actually you can still break someone's code by introducing new functions/classes, in case they get imported with 'from mod import *' and override some local function/class with the same name -- but this is such an obscure case that doesn't deserve to be

[issue868845] Need unit tests for <...> reprs

2011-10-18 Thread Guido van Rossum
Guido van Rossum added the comment: I think there's nothing to be done for a bug this general. If you find a specific object whose repr() is awkward, go ahead and file a specific bug. In most cases I think people who parse repr() output know they are on thin ice, and would prefer that the ob

[issue12703] Improve error reporting for packaging.util.resolve_name

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: Thanks. I’ll add more tests and commit. (I also prefer to create modules in test methods instead of using another file, so that I can see right here what the module contains.) -- ___ Python tracker

[issue12296] Minor clarification in devguide

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: I like it. Terry, objections? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue10197] subprocess.getoutput fails on win32

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: If Windows shell syntax is similar to POSIX one, then () will run in a sub-shell, which would be a different behavior than using {} (which merely group statements and their streams). -- versions: -Python 3.1 ___ Pyth

[issue13150] Most of Python's startup time is sysconfig

2011-10-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Done! If someone wants to give life to the C approach, they are welcome :) -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker ___

[issue13150] Most of Python's startup time is sysconfig

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset 70160b53117f by Antoine Pitrou in branch 'default': Issue #13150: sysconfig no longer parses the Makefile and config.h files http://hg.python.org/cpython/rev/70160b53117f -- ___ Python tracker

[issue12277] Missing comma in os.walk docs

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: Sorry, I was too busy with real bugs to fix this minor one. -- ___ Python tracker ___ ___ Python-bugs-

[issue13210] Support Visual Studio 2010

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: The wiki page contains change to distutils, which I believe would not be allowed by the feature freeze. New features (such as support for a new compiler) need to target packaging. -- ___ Python tracker

[issue13210] Support Visual Studio 2010

2011-10-18 Thread Santoso Wijaya
Changes by Santoso Wijaya : -- nosy: +santa4nt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue13207] os.path.expanduser breaks when using unicode character in the username

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: On POSIX, Python 3 works correctly if my home dir is /tmp/éric, and Python 2.7 returns a UTF-8-encoded (not locale-encoded!) bytes string. For Windows, a patch would probably need to add a private function to the _nt module (in C): ctypes is too dangerous to be

[issue3067] setlocale error message is confusing

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: Thanks for the patch. Exception messages are considered implementation details, so I would not test them. Testing that an exception is raised is good enough IMO. -- nosy: +eric.araujo ___ Python tracker

[issue868845] Need unit tests for <...> reprs

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: Original report: > Samuele Pedroni points out in python-dev that the <...> style reprs of Python > objects are > not documented, standardized or even consistent (e.g. compare old-style and > new-style > classes). > > Yet there is plenty of code out there that for

[issue12405] packaging does not record/remove directories it creates

2011-10-18 Thread Éric Araujo
Éric Araujo added the comment: [Vinay] > I think you mean "Only the paste/util directory is recorded." Obviously :) > How about if you record all directories that you would create if they didn't > exist, as well > as those actually created? That way, you would record the paste directory > und

[issue10860] Handle empty port after port delimiter in httplib

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset a3e48273dce3 by Łukasz Langa in branch '2.7': Fixes #10860: Handle empty port after port delimiter in httplib http://hg.python.org/cpython/rev/a3e48273dce3 -- nosy: +python-dev ___ Python tracker

[issue12568] Add functions to get the width in columns of a character

2011-10-18 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Roundup Robot
Roundup Robot added the comment: New changeset dcf5cc88d5c9 by Antoine Pitrou in branch '3.2': Issue #13188: When called without an explicit traceback argument, http://hg.python.org/cpython/rev/dcf5cc88d5c9 New changeset f4e3db1194e4 by Antoine Pitrou in branch 'default': Issue #13188: When cal

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Actually, it is documented: “Return the traceback associated with the exception as a new reference (...)” http://docs.python.org/dev/c-api/exceptions.html#PyException_GetTraceback Thanks for the patch, will apply! -- __

[issue13210] Support Visual Studio 2010

2011-10-18 Thread Sébastien Sablé
Sébastien Sablé added the comment: Here is a quick and dirty draft of the modifications I had to do in order to get Python 2.7.2 to compile with VS2010 on the wiki: http://wiki.python.org/moin/VS2010 I will improve/complete it as I progress. I will also do a 64 bits version. --

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Petri Lehtinen
Petri Lehtinen added the comment: Attached an updated patch. I incref'd the return value of PyErr_GetTraceback() because PyErr_Restore() steals the reference. The documentation of PyErr_GetTraceback() doesn't tell whether it returns a new or borrowed reference, but apparently a new reference

[issue13210] Support Visual Studio 2010

2011-10-18 Thread Brian Curtin
Brian Curtin added the comment: We can make Python compile with Visual Studio 2010, but it will not be the platform Python is released on, it would be optional while 2008 stays the release target, at least through Python 3.3. In Python 3.4, we may re-evaluate this, and it's likely we would ju

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Andreas Stührk
Andreas Stührk added the comment: It leaks because `PyException_GetTraceback()` already returns a new reference, hence the "Py_XINCREF(tb)" is wrong. -- nosy: +Trundle ___ Python tracker _

[issue12458] Tracebacks should contain the first line of continuation lines

2011-10-18 Thread Florent Xicluna
Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you! There is a memory leak somewhere: $ ./python -m test -R 3:2 test_generators [1/1] test_generators beginning 5 repetitions 12345 . test_generators leaked [1945, 1945] references, sum=3890 1 test failed: test_generators Also, since the patch

[issue10817] urllib.request.urlretrieve never raises ContentTooShortError if no reporthook

2011-10-18 Thread Jyrki Pulliainen
Jyrki Pulliainen added the comment: Changed the code so that the content length is set as size if reporthook is not set and wrote two tests for it. Note: I moved fakehttp behavior to a mixin, so that it's more reusable. -- keywords: +patch nosy: +nailor Added file: http://bugs.python.

[issue12737] str.title() is overzealous by upcasing combining marks inappropriately

2011-10-18 Thread Florent Xicluna
Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13188] generator.throw() ignores __traceback__ of exception

2011-10-18 Thread Petri Lehtinen
Petri Lehtinen added the comment: Attached a patch that fixes this. The test case is a bit ugly, as it only checks that the traceback's depth is correct. -- keywords: +patch nosy: +ezio.melotti, petri.lehtinen stage: -> patch review Added file: http://bugs.python.org/file23443/issue13

[issue11085] expose _abcoll as collections.abc

2011-10-18 Thread Florent Xicluna
Changes by Florent Xicluna : -- nosy: +flox ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue13211] urllib2.HTTPError does not have 'reason' attribute.

2011-10-18 Thread Jason R. Coombs
New submission from Jason R. Coombs : The urllib2 docs indicate that HTTPError is a subclass of URLError and that URLError has an attribute of 'reason', but HTTPError does not have this attribute. The docs should be updated to reflect this deviance. It appears the Python 3.2 docs no longer inc

[issue13210] Support Visual Studio 2010

2011-10-18 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +loewis ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python

  1   2   >