[issue12353] argparse cannot handle empty arguments

2011-06-23 Thread Torsten Landschoff
Torsten Landschoff added the comment: Here is another possible patch that will catch the problem. But this enables the fromfile_prefix_chars option for all tests checking empty and space arguments. This way a problem that occurs only without that option might be hidden. We would need to run

[issue12353] argparse cannot handle empty arguments

2011-06-23 Thread Torsten Landschoff
Torsten Landschoff added the comment: > Your unit test isn't consistent with the other unit tests in that set, which > makes me suspicious that it isn't testing what we need to test. That is because I did not try to understand the machinery behind the argparse unit tests completely. I did no

[issue11812] transient socket failure to connect to 'localhost'

2011-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: Perhaps Michael or Ezio have an idea of whether 'reason' or 'happenstance' is the answer to your questions. -- nosy: +ezio.melotti, michael.foord ___ Python tracker _

[issue12356] more argument error improving

2011-06-23 Thread Nick Coghlan
Nick Coghlan added the comment: Revised error messages and tests look reasonable and the code seems fine on a visual scan. +1 from me. -- ___ Python tracker ___ __

[issue11909] Doctest sees directives in strings when it should only see them in comments

2011-06-23 Thread R. David Murray
R. David Murray added the comment: For the most part the patch looks good to me, too. My one concern is the encoding. tokenize detects the encoding...is it possible for the doctest fragment to be detected to be some encoding other than utf-8? -- nosy: +benjamin.peterson, r.david.mur

[issue9921] os.path.join('x','') behavior

2011-06-23 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue9921] os.path.join('x','') behavior

2011-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1e89444f4ebc by R David Murray in branch '2.7': #9921: clarify os.path.join joining algorithm http://hg.python.org/cpython/rev/1e89444f4ebc New changeset f5f5b715be7e by R David Murray in branch '3.2': #9921: clarify os.path.join joining algorithm

[issue10206] python program starting with unmatched quote spews spaces to stdout

2011-06-23 Thread R. David Murray
R. David Murray added the comment: Hmm. I don't know that it is really necessary to cater to the particular failure mode, I was more interested in seeing a unit test that checked the correct behavior: that a syntax error is raised (by capturing the output using the tools in script_helper).

[issue12353] argparse cannot handle empty arguments

2011-06-23 Thread R. David Murray
R. David Murray added the comment: Your unit test isn't consistent with the other unit tests in that set, which makes me suspicious that it isn't testing what we need to test. Also, there are unit tests for this case further up in the test file (TestEmptyAndSpaceContainingArguments). I have

[issue11812] transient socket failure to connect to 'localhost'

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: Some tests of test_ftplib and test_telnetlib use HOST or directly 'localhost' instead of getting the host from the server socket. About the test_ftplib failures, only the tests using explicitly 'localhost' do fail. Attached patch reads the name of the server

[issue11812] transient socket failure to connect to 'localhost'

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: > I only saw the failure on test_telnetlib, not in other tests > using sockets. Oh, the last failure of the buildbot "x86 Windows7 3.x" is on test_ftplib, not test_telnetlib! == ERROR: testTi

[issue11812] transient socket failure to connect to 'localhost'

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: Does the failure occur on other buildbots? If not, it's maybe something specific to this Windows Seven: a local firewall or something like that? Can we use start 127.0.0.1 instead of "localhost"? I don't know if it would change anything. Note: the TCP server

[issue11812] transient socket failure to connect to 'localhost'

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: > With a bit of searching, HOST == support.HOST == 'localhost'. > Looking at the traceback, it is socket that fails, not telnetlib > or its test. I only saw the failure on test_telnetlib, not in other tests using sockets. I think that this issue is specific to

[issue11812] transient socket failure to connect to 'localhost'

2011-06-23 Thread Terry J. Reedy
Terry J. Reedy added the comment: With a bit of searching, HOST == support.HOST == 'localhost'. Looking at the traceback, it is socket that fails, not telnetlib or its test. Hence the clearer title. I am still curious what you propose: catch and skip or something else? For Windows, I consid

[issue12392] pthread_kill() doesn't work on the main thread on FreeBSD6

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: FreeBSD 7 is not affected by this issue. To test this issue, call signal.pthread_kill(threading.get_ident(), signal.SIGINT) in an interpreter: it should raise a KeyboardInterrupt. On FreeBSD6, it does nothing. Or run ./python -m test -v test_signal: test_pen

[issue12392] pthread_kill() doesn't work on the main thread on FreeBSD6

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: Attached patch implements the suggested fix. -- keywords: +patch Added file: http://bugs.python.org/file22431/thread_init_freebsd6.patch ___ Python tracker ___

[issue12392] pthread_kill() doesn't work on the main thread on FreeBSD6

2011-06-23 Thread STINNER Victor
New submission from STINNER Victor : pthread_kill() doesn't work on the main thread on FreeBSD6: sending a signal to the main thread does nothing. It works on the main thread just after the creation of the first thread. PyThread__init_thread() has 3 implementations in Python/thread_pthread.h:

[issue12353] argparse cannot handle empty arguments

2011-06-23 Thread Torsten Landschoff
Torsten Landschoff added the comment: Here is an updated patch including unit test coverage. -- keywords: +patch nosy: +torsten Added file: http://bugs.python.org/file22430/issue12353_test.diff ___ Python tracker

[issue12372] semaphore errors on AIX 7.1

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: It is the fourth issue for the same problem, other issues: - #1106262 (AIX 5, 2005) - #1234 (duplicate of #1106262, 2007) - #9700 (AIX 6) The initial issue was related to semaphores and fork() (msg60639). Pass pshared=1 to sem_init() gets around this issue,

[issue12242] distutils2 environment marker for current compiler

2011-06-23 Thread Eli Collins
Eli Collins added the comment: Attached is a patch that implements this enhancement along the lines of what was last discussed. The behavior introduced in the patch is as follows: * It adds a stub method named get_compiler_version() to CCompiler, and implementations of that method for the

[issue12372] semaphore errors on AIX 7.1

2011-06-23 Thread Charles-François Natali
Charles-François Natali added the comment: Patch attached. I've used a wildcard so that it won't break when AIX 8 goes out (and it's POSIX). -- keywords: +needs review, patch nosy: +haypo, neologix stage: -> patch review Added file: http://bugs.python.org/file22428/aix_broken_sem.diff

[issue10636] subprocess module has race condition with SIGCHLD handlers

2011-06-23 Thread Ross Lagerwall
Ross Lagerwall added the comment: > The right approach is to use sigblock/sigsetmask before creating the > process, and then again after creating it. Unfortunately, these aren't > exposed from the signal module. Since 3.3, pthread_sigmask is exposed so the right approach can now be taken ;-) C

[issue10635] Calling subprocess.Popen with preexec_fn=signal.pause blocks forever

2011-06-23 Thread Ross Lagerwall
Changes by Ross Lagerwall : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2011-06-23 Thread R. David Murray
R. David Murray added the comment: 3.3. IMO this is in the grey area between feature and bug fix. I think it is possible to argue that it can be treated as a bug fix, but I think we need opinions from other developers if we want to try to go that route. The reason I think it can be argued t

[issue12356] more argument error improving

2011-06-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Nick (or anyone else), do you want to look at this? -- ___ Python tracker ___ ___ Python-bugs-li

[issue11812] transient test_telnetlib failure

2011-06-23 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue12383] subprocess.Popen(..., env={}) fails to pass empty env.

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: All Python 3.x buildbots are green again (except FreeBSD 7.2, but the failures are not related to this issue). -- status: open -> closed ___ Python tracker __

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2011-06-23 Thread Chris Withers
Chris Withers added the comment: ...which is, of course, rather disappointing. When *would* md5-sess land? 2.7? 3.3?! -- ___ Python tracker ___ __

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2011-06-23 Thread R. David Murray
R. David Murray added the comment: Oh, the bad error message is definitely a bug. The question is whether we can also add md5-sess support while fixing it. Sounds like Senthil thinks no, in which case this issue needs to be split into two parts. -- _

[issue6715] xz compressor support

2011-06-23 Thread jeremybanks
Changes by jeremybanks : -- nosy: +jeremybanks ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pytho

[issue11223] interruption of locks by signals not guaranteed when locks are implemented using POSIX condition variables; add sys.thread_info

2011-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset e5183f16c49d by Victor Stinner in branch '3.2': Issue #11223: skip also test_rlock_acquire_interruption() on FreeBSD6 http://hg.python.org/cpython/rev/e5183f16c49d New changeset 54fb77e0762c by Victor Stinner in branch 'default': (null merge 3.2 fo

[issue11223] interruption of locks by signals not guaranteed when locks are implemented using POSIX condition variables; add sys.thread_info

2011-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3f18a03a2a1e by Victor Stinner in branch 'default': (null merge 3.2 for issue #11223) python 3.3 has already a better fix http://hg.python.org/cpython/rev/3f18a03a2a1e -- ___ Python tracker

[issue11223] interruption of locks by signals not guaranteed when locks are implemented using POSIX condition variables; add sys.thread_info

2011-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 07655b3dee4f by Victor Stinner in branch '3.2': Issue #11223: skip test_lock_acquire_interruption() on FreeBSD6 http://hg.python.org/cpython/rev/07655b3dee4f -- ___ Python tracker

[issue12363] test_signal.test_without_siginterrupt() sporadic failures on FreeBSD 6.4

2011-06-23 Thread STINNER Victor
STINNER Victor added the comment: All Python 3.x buildbots are green (except FreeBSD 7.2, but it's not related to this issue). Let close this issue. -- status: open -> closed ___ Python tracker __

[issue12386] packaging fails in install_distinfo when writing RESOURCES

2011-06-23 Thread Vinay Sajip
Changes by Vinay Sajip : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue12391] packaging install fails to clean up temp files

2011-06-23 Thread Vinay Sajip
New submission from Vinay Sajip : There are a number of places in packaging.install where temporary directories are created, but never cleaned up: 1. In _move_files, if no destination path is passed in, one is created using mkdtemp(), but it's not clear where this would be deleted. Moreover, i

[issue10206] python program starting with unmatched quote spews spaces to stdout

2011-06-23 Thread Petri Lehtinen
Petri Lehtinen added the comment: Attached a test case. The patch is against the current default tip. -- Added file: http://bugs.python.org/file22427/issues10206_test.patch ___ Python tracker _

[issue9921] os.path.join('x','') behavior

2011-06-23 Thread Brian Brazil
Brian Brazil added the comment: David's change sounds good to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue12390] urllib.parse.urlencode encoding lists as strings

2011-06-23 Thread Senthil Kumaran
Senthil Kumaran added the comment: Joseph, resolution applies for the bug not the process. tc. :) -- resolution: accepted -> invalid ___ Python tracker ___ _

[issue12390] urllib.parse.urlencode encoding lists as strings

2011-06-23 Thread Joesph
Joesph added the comment: Hrm, yes. 'Tis what I get for working while sick. -- resolution: invalid -> accepted ___ Python tracker ___ ___

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2011-06-23 Thread Chris Withers
Chris Withers added the comment: Hmm, I'd argue it's a bug: File "/usr/lib64/python2.5/urllib2.py", line 972, in get_algorithm_impls return H, KD UnboundLocalError: local variable 'H' referenced before assignment ...does not say anything like: "The digest authentication scheme you have

[issue10206] python program starting with unmatched quote spews spaces to stdout

2011-06-23 Thread Petri Lehtinen
Petri Lehtinen added the comment: By checking out the parent of r85904 I now can reproduce this. -- ___ Python tracker ___ ___ Python

[issue10206] python program starting with unmatched quote spews spaces to stdout

2011-06-23 Thread Stefan Krah
Stefan Krah added the comment: I remember that I could reproduce it at the time. The issue was indeed fixed in r85904. -- nosy: +skrah ___ Python tracker ___ ___