[issue1054967] bdist_deb - Debian packager

2010-04-28 Thread Andrew Straw
Andrew Straw added the comment: Barry, stdeb does much of what you're describing. (Try the "python setup.py sdist_dsc" command.) I'm not particularly pleased with the stdeb codebase as it stands, but it does work reasonably well, and I'd like to see progress in this domain, but I'm afraid I

[issue7946] Convoy effect with I/O bound threads and New GIL

2010-04-28 Thread Nir Aides
Nir Aides added the comment: On Thu, Apr 29, 2010 at 2:03 AM, David Beazley wrote: > Wow, that is a *really* intriguing performance result with radically > different behavior than Unix. Do you have any ideas of what might be causing > it? Instrument the code and I'll send you a trace.

[issue1462525] URI parsing library

2010-04-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Should we close this as out-of-date? I was inclined to see it as fixed as urlparse has gone changes in direction as suggested by the issue. Sorry Paul, for no response. Regarding this issue, I plan to use the testcases provided in the patch in the stdlib te

[issue8562] hasattr(open, 'newlines') example gives incorrect results from PEP0278

2010-04-28 Thread Matt Wartell
Changes by Matt Wartell : -- nosy: +Matt.Wartell ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue8566] 2to3 should run under python 2.5

2010-04-28 Thread Dave Malcolm
Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue5553] Py_LOCAL_INLINE(type) doesn't actually inline except using MSC

2010-04-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: Py_LOCAL_INLINE is also not used a lot. Usually, the compiler will inline small static functions by itself. Most of the time, we used #defines rather than functions when we want to inline short snippets of code. -- nosy: +pitrou _

[issue8566] 2to3 should run under python 2.5

2010-04-28 Thread Collin Winter
Changes by Collin Winter : -- nosy: +collinwinter ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.py

[issue8566] 2to3 should run under python 2.5

2010-04-28 Thread Jeffrey Yasskin
New submission from Jeffrey Yasskin : Sorry for being all curmudgeonly, but we're using 2to3 in the benchmark suite at http://hg.python.org/benchmarks/, and, since many of the non-CPython implementations are still only 2.5-compatible, the version there needs to run under python 2.5. At the sam

[issue8565] Always run regrtest.py with -bb

2010-04-28 Thread STINNER Victor
New submission from STINNER Victor : -bb option helps debug because it detects errors earlier (comparing byte and unicode strings looks strange, it should be a bug). Attached patch re-exec regrtest.py with -bb if -bb was not used. -- components: Tests files: regrtest_bb.patch keywords:

[issue7946] Convoy effect with I/O bound threads and New GIL

2010-04-28 Thread David Beazley
David Beazley added the comment: Wow, that is a *really* intriguing performance result with radically different behavior than Unix. Do you have any ideas of what might be causing it? -- ___ Python tracker ___

[issue7449] A number tests "crash" if python is compiled --without-threads

2010-04-28 Thread STINNER Victor
STINNER Victor added the comment: Ported to py3k (r80600), blocked in 2.6 (r80602) and 3.1 (r80601). -- status: pending -> closed ___ Python tracker ___ _

[issue1574217] isinstance swallows exceptions

2010-04-28 Thread Tres Seaver
Changes by Tres Seaver : -- versions: +Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue1574217] isinstance swallows exceptions

2010-04-28 Thread Tres Seaver
Tres Seaver added the comment: I can confirm that the patch applies cleanly to the 2.6 branch, that the new test fails before rebuilding, and that the test passes afterwards: $ hg summary parent: 41597:295c02a21979 tip [svn r80597] Merged revisions 80596 via svnmerge from branch: release2

[issue5553] Py_LOCAL_INLINE(type) doesn't actually inline except using MSC

2010-04-28 Thread Roumen Petrov
Roumen Petrov added the comment: Configure could call macro to define inline - cf. autoconf manuals. -- nosy: +rpetrov ___ Python tracker ___

[issue8564] Update documentation on doctest/unittest2 integration

2010-04-28 Thread Peter Fein
Peter Fein added the comment: See http://lists.idyll.org/pipermail/testing-in-python/2010-April/003039.html for discussion -- ___ Python tracker ___

[issue8564] Update documentation on doctest/unittest2 integration

2010-04-28 Thread Peter Fein
New submission from Peter Fein : The documentation on integrating doctests in a file of unittests is confusing and out of date. This patch updates the documentation to use unittest2 test discovery. -- assignee: d...@python components: Documentation files: doctest_unittest_integration_

[issue8510] update to autoconf2.65

2010-04-28 Thread Roumen Petrov
Roumen Petrov added the comment: You don't need to add source in case of AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])] .. when the the test is ..main() { return 0 ;} ... , posted long time ago as part of issue3754 ( minimal cross-compilation support for configure ). Also thanks for fixing ext

[issue8535] passing optimization flags to the linker required for builds with gcc -flto

2010-04-28 Thread Roumen Petrov
Roumen Petrov added the comment: LDSHARED not always is compiler and I'm not sure that linkers always accept compiler flags . After fix of issue xxx about CFLAGS and issues a, b, c, for LDFLAGS now all is passed to python build system and users could set argument to both variables : CFLAGS an

[issue7584] datetime.rfcformat() for Date and Time on the Internet

2010-04-28 Thread anatoly techtonik
anatoly techtonik added the comment: I do not think that -00:00 or +00:00 will be invalid Atom timestamp, but to implement parser of rfc3339 timestamp, Z handling is still needed. I can easily imagine people making wrong assumption that parsing 00:00 at the end would be enough for proper roun

[issue2810] _winreg.EnumValue sometimes raises WindowsError ("More data is available")

2010-04-28 Thread Daniel Stutzbach
Changes by Daniel Stutzbach : Removed file: http://bugs.python.org/file16802/winreg_test.pach ___ Python tracker ___ ___ Python-bugs-list maili

[issue2810] _winreg.EnumValue sometimes raises WindowsError ("More data is available")

2010-04-28 Thread Daniel Stutzbach
Daniel Stutzbach added the comment: Attached is a new test-case patch. -- Added file: http://bugs.python.org/file17122/winreg_test.patch ___ Python tracker ___ __

[issue7584] datetime.rfcformat() for Date and Time on the Internet

2010-04-28 Thread anatoly techtonik
anatoly techtonik added the comment: > It also says that if "the offset to local time is unknown, this can > be > represented with an offset of "-00:00"". So I don't think we can write > "Z" or "+00:00" if we don't know the UTC offset. >> but Atom >> specification mentions that > It says "an

[issue5178] Add context manager for temporary directory

2010-04-28 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue7865] io close() swallowing exceptions

2010-04-28 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue1909] Backport: Mixing default keyword arguments with *args

2010-04-28 Thread Benjamin Peterson
Benjamin Peterson added the comment: Wouldn't this imply a full backport of keyword only arguments? That seems unlikely at the moment. -- ___ Python tracker ___

[issue1909] Backport: Mixing default keyword arguments with *args

2010-04-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: Besides someone having to produce the patch, it would also need the release manager's approval (Benjamin). -- nosy: +benjamin.peterson, pitrou ___ Python tracker _

[issue7865] io close() swallowing exceptions

2010-04-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: For what it's worth, I documented the possibility to call close() several times in r80592. > Then when you try to wrap a non-readable stream into a readable > buffered stream (like BufferedRWPair), it should raise a value error as > well, Good point. Unfort

[issue7978] SocketServer doesn't handle syscall interruption

2010-04-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: > In BaseServer, a threading.Event is used in shutdown, so it can block > until server_forever is finished (after checking __serving). Since the > SIGTERM interrupts the select system call, the event set is never > reached, and shutdown hangs waiting on the even

[issue8563] [PEP 3147] compileall.compile_file() creates empty __pycache__ directories for non-.py files

2010-04-28 Thread Arfrever Frehtes Taifersar Arahesis
New submission from Arfrever Frehtes Taifersar Arahesis : compileall.compile_file() creates empty __pycache__ directories for non-.py files. This problem usually occurs when compileall.compile_file() is called by compileall.compile_dir() and a subdirectory contains non-code files (e.g. locale

[issue8558] StringIO().truncate causes zero-bytes in getvalue()

2010-04-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: I've updated the doc in r80591. Sorry for the inconvenience! -- resolution: -> invalid status: open -> closed ___ Python tracker ___ __

[issue1054967] bdist_deb - Debian packager

2010-04-28 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I'm not so sure about sdist_debian for the command I'm thinking about because it doesn't actually build a distribution. It just creates a 'debian' directory so I think I like just 'debian' as the name of the command. But thanks for the feedback; time to wr

[issue7978] SocketServer doesn't handle syscall interruption

2010-04-28 Thread Bryce Allen
Bryce Allen added the comment: I encountered this issue when trying to exit cleanly on SIGTERM, which I use to terminate background daemons running serve_forever. In BaseServer, a threading.Event is used in shutdown, so it can block until server_forever is finished (after checking __serving).

[issue8562] hasattr(open, 'newlines') example gives incorrect results from PEP0278

2010-04-28 Thread AdamN
New submission from AdamN : This bug from the Ubuntu list is being moved here: https://bugs.launchpad.net/ubuntu/+source/python-defaults/+bug/570737 Newlines support is enabled on Ubuntu but the example from: http://www.python.org/dev/peps/pep-0278/ Does not give the correct results (of True)

[issue7946] Convoy effect with I/O bound threads and New GIL

2010-04-28 Thread Nir Aides
Nir Aides added the comment: Dave, there seems to be some problem with your patch on Windows: F:\dev>z:\dabeaz-wcg\PCbuild\python.exe y:\ccbench.py -b == CPython 3.2a0.0 (py3k) == == x86 Windows on 'x86 Family 6 Model 23 Stepping 10, GenuineIntel' == --- I/O bandwidth --- Background CPU task:

[issue7946] Convoy effect with I/O bound threads and New GIL

2010-04-28 Thread Nir Aides
Nir Aides added the comment: On Wed, Apr 28, 2010 at 12:41 AM, Larry Hastings wrote: > The simple solution: give up QPC and use timeGetTime() with > timeBeginPeriod(1), which is totally > reliable but only has millisecond accuracy at best. It is preferable to use a high precision clock and I

[issue8561] Install .exes generated with distutils to not do a CRC check

2010-04-28 Thread Nate DeSimone
New submission from Nate DeSimone : During network transit, .exe generated with distutils may become corrupted. The part of the file that is a binary executable is small compared to the full package typically, so it is possible for the installer to run and lay down bad files. It would be nic

[issue1909] Backport: Mixing default keyword arguments with *args

2010-04-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: Ok, I though 2.7 was in feature freeze. Updating version. -- versions: +Python 2.7 -Python 2.6 ___ Python tracker ___ __

[issue2380] Raise a Py3K warning for catching nested tuples with non-BaseException exceptions

2010-04-28 Thread Terry J. Reedy
Changes by Terry J. Reedy : -- versions: +Python 2.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue2345] Using an exception variable outside an 'except' clause should raise a Py3K warning

2010-04-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am assuming that this is an unfixed bug that might still be fixed in 2.7 sometime and that it should not be closed yet, so I am just updating the version. -- nosy: +tjreedy versions: +Python 2.7 -Python 2.6 ___ P

[issue5559] IDLE Output Window 's goto fails when path has spaces

2010-04-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: Resolution should only be set when an issue is closed. So should this be closed? or unfixed and the versions updated? -- nosy: +tjreedy ___ Python tracker

[issue1909] Backport: Mixing default keyword arguments with *args

2010-04-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: It should still be done if any one has the time. Guido approved it long ago. -- ___ Python tracker ___ __

[issue1909] Backport: Mixing default keyword arguments with *args

2010-04-28 Thread Terry J. Reedy
Terry J. Reedy added the comment: Can this be closed as either fixed or out-or-date, as the case may be? -- nosy: +tjreedy ___ Python tracker ___

[issue8552] msilib can't create large CAB files

2010-04-28 Thread Bill Janssen
Bill Janssen added the comment: I've now been able to build my installer. I applied Travis Oliphant's patch from http://bugs.python.org/issue2399 to Lib/msilib/__init__.py, then added a __del__ method to the Directory class: def __del__(self): if self._numfiles_wo_commit > 0:

[issue8552] msilib can't create large CAB files

2010-04-28 Thread Bill Janssen
Changes by Bill Janssen : Removed file: http://bugs.python.org/file17118/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue8295] add unpack_archive to shutil

2010-04-28 Thread Tarek Ziadé
Tarek Ziadé added the comment: done in r80589 -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue6312] httplib fails with HEAD requests to pages with "transfer-encoding: chunked"

2010-04-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Whenever the HEAD method is queried, the httplib recognizes it read method and returns an '' empty string as expected. Fixed in revision 80583, release26-maint: r80584, py3k: r80587 and release31-maint in 80588. -- resolution: accepted -> fixed stag

[issue7584] datetime.rfcformat() for Date and Time on the Internet

2010-04-28 Thread Daniel Urban
Daniel Urban added the comment: > My Python code as well as your patch doesn't specify that "Z" must be > present when time zone offset is unknown or absent, Yes, that is because RFC 3339 explicitly says (in 4.3.) that -00:00 is "differs semantically from an offset of "Z" or "+00:00", which im

[issue7865] io close() swallowing exceptions

2010-04-28 Thread Pascal Chambon
Pascal Chambon added the comment: >Probably an oversight. Do you want to add some tests? That's WIP > Because it's not an IO error at all. No I/O occurs. You are just using the file wrongly (or the wrong file), hence the ValueError. Then when you try to wrap a non-readable stream into a reada

[issue1462525] URI parsing library

2010-04-28 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> out of date ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue8560] regrtest: add a minimal "progress bar"

2010-04-28 Thread STINNER Victor
New submission from STINNER Victor : regrtest takes between 10 and 20 minutes to run the full test suite. It would be nice to see the progress of the test suite with a kind of progress bar. Add the test number would be enough: $ ./python Lib/test/regrtest.py ... te

[issue7582] [patch] diff.py to use iso timestamp

2010-04-28 Thread anatoly techtonik
anatoly techtonik added the comment: I still do not understand your policy - it is a tool, it is not a part of standard library. -- ___ Python tracker ___ __

[issue8552] msilib can't create large CAB files

2010-04-28 Thread Bill Janssen
Bill Janssen added the comment: Yes, I've tried that. No joy. Right now I'm trying an approach which packages each top-level directory as a separate cab. What I'm finding is that if I get up around 4200 files, it breaks, regardless of the file sizes. Out of curiosity, how many files are in t

[issue8557] subprocess portability issue

2010-04-28 Thread Mark Summerfield
Mark Summerfield added the comment: IMO there's another problem with subprocess portablity---the lack of control over encodings: see issue 6135. -- nosy: +mark ___ Python tracker __

[issue5251] contextlib.nested inconsistent with, well, nested with statements due exceptions raised in __enter__

2010-04-28 Thread Nick Coghlan
Changes by Nick Coghlan : -- versions: +Python 3.2 -Python 3.0 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue1644818] Allow importing built-in submodules

2010-04-28 Thread Nick Coghlan
Nick Coghlan added the comment: I'll have a closer look at this tomorrow with the aim of getting it into 2.7b2. (I'm inclined to agree with jd that this is just a bug in the existing implementation, hence the change in the issue type) -- type: feature request -> behavior versions: +Py

[issue5178] Add context manager for temporary directory

2010-04-28 Thread Nick Coghlan
Nick Coghlan added the comment: Missed the boat for 2.7 I'm afraid. Definitely one to take another look at for 3.2 though. -- assignee: ncoghlan -> versions: -Python 2.7 ___ Python tracker __

[issue8202] sys.argv[0] and python -m package

2010-04-28 Thread Nick Coghlan
Nick Coghlan added the comment: Committed for 2.7 in r80580 (as it turns out, the hack I remembered was probably from the original pre-runpy 2.4 implementation and has since been replaced by the proper runpy based system. This bug was likely just a lingering remnant of that original hackish a

[issue5516] equality not symmetric for subclasses of datetime.date and datetime.datetime

2010-04-28 Thread Nick Coghlan
Nick Coghlan added the comment: I think I'll concur with the "this is a mess" assessment. Given that state of affairs, punting on this until 3.2 (at the earliest). -- assignee: ncoghlan -> versions: +Python 3.2 -Python 2.4, Python 2.7, Python 3.0, Python 3.1 _

[issue7490] IGNORE_EXCEPTION_DETAIL should ignore the module name

2010-04-28 Thread Nick Coghlan
Nick Coghlan added the comment: Committed for 2.7 in r80578 I'll forward port to 3.2 at some point after the next 2.7 beta is out. -- resolution: -> accepted stage: patch review -> committed/rejected status: open -> pending ___ Python tracker

[issue1813] Codec lookup failing under turkish locale

2010-04-28 Thread Jakub Wilk
Changes by Jakub Wilk : -- nosy: +jwilk ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue8559] test_gdb: test_strings() fails with ASCII locale

2010-04-28 Thread STINNER Victor
New submission from STINNER Victor : http://www.python.org/dev/buildbot/builders/alpha Debian 3.x/builds/67/steps/test/logs/stdio == ERROR: test_strings (test.test_gdb.PrettyPrintTests) Verify the pretty-printing of unicode str

[issue7582] [patch] diff.py to use iso timestamp

2010-04-28 Thread Brian Curtin
Brian Curtin added the comment: 2.7 is now frozen as far as new features go. It's still good for 3.2. I think this is ready to go, so I'll probably commit it later in the day. -- versions: -Python 2.7 ___ Python tracker

[issue8557] subprocess portability issue

2010-04-28 Thread Dave Abrahams
Dave Abrahams added the comment: It's worse than I thought; there isn't even one setting for shell that works everywhere. This is what happens on POSIX (tested on Mac and Ubuntu): $ mkdir /tmp/xxx $ cd /tmp/xxx xxx $ virtualenv /tmp/zzz xxx $ python Python 2.6.5 (r265:79063, Mar 23 2010, 08:1

[issue6662] HTMLParser.HTMLParser doesn't handle malformed charrefs

2010-04-28 Thread Fredrik Håård
Fredrik Håård added the comment: Confirmed on trunk. Attached a (what I think is) minimal patch to fix, together with a tweak of existing unit test case to verify it. -- keywords: +patch versions: +Python 2.7 Added file: http://bugs.python.org/file17117/Issue6662.patch ___

[issue8550] Expose SSL contexts

2010-04-28 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +heikki ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.

[issue3928] os.mknod missing on Solaris

2010-04-28 Thread Jesús Cea Avión
Jesús Cea Avión added the comment: Patch committed. trunk (2.7): r80574 2.6: r80575 py3k (3.2): r80576 3.1: r80577 -- resolution: -> accepted stage: commit review -> committed/rejected status: open -> closed ___ Python tracker

[issue7865] io close() swallowing exceptions

2010-04-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I'm quite surprised it wasn't already covered by the test suite :S Probably an oversight. Do you want to add some tests? > Should a flush on a closed stream fail (at the moment sometimes it > does, sometimes doesn't) ? It probably should, yes. > Why is som

[issue8558] StringIO().truncate causes zero-bytes in getvalue()

2010-04-28 Thread holger krekel
holger krekel added the comment: Ah, thanks for the pointer. So indeed, for me truncate(0)+seek(0) works fine for all interpreters i care for (python2.4 - 3.1.X), previously truncate(0) was enough. -- ___ Python tracker

[issue8558] StringIO().truncate causes zero-bytes in getvalue()

2010-04-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: This is a last-minute API change. truncate() was modified not to change the file position anymore. We should probably document it more explicitly. See the following subthread in python-dev: http://mail.python.org/pipermail/python-dev/2009-September/092127.html

[issue8558] StringIO().truncate causes zero-bytes in getvalue()

2010-04-28 Thread holger krekel
New submission from holger krekel : Running the attached file with python3.1.1 works fine, all assertions pass. Running it with 3.1.2 gives me this output: $ python3.1.2/bin/python3.1 stringio_fail.py Traceback (most recent call last): File "stringio_fail.py", line 12, in assert s == "

[issue8557] subprocess portability issue

2010-04-28 Thread Dave Abrahams
New submission from Dave Abrahams : On POSIX systems, the PATH environment variable is always used to look up directory-less executable names passed as the first argument to Popen(...), but on Windows, PATH is only considered when shell=True is also passed. Actually I think it may be slightl

[issue808164] socket.close() doesn't play well with __del__

2010-04-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Unfortunately, that can result in ugly error messages when the > interpreter is exiting. The classical solution is to early bind the necessary globals to argument defaults, such as: def __del__(self, _socketclose=_socketclose): _socketclose(self.

[issue6560] socket sendmsg(), recvmsg() methods

2010-04-28 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue8106] SSL session management

2010-04-28 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue5565] Strange behavior when I logout() with IMAP4_SSL

2010-04-28 Thread Giampaolo Rodola'
Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue7584] datetime.rfcformat() for Date and Time on the Internet

2010-04-28 Thread anatoly techtonik
anatoly techtonik added the comment: Thanks Daniel. I am still interested in this. My Python code as well as your patch doesn't specify that "Z" must be present when time zone offset is unknown or absent, but Atom specification mentions that and I believe this is that most users expect to see

[issue7582] [patch] diff.py to use iso timestamp

2010-04-28 Thread anatoly techtonik
anatoly techtonik added the comment: So, what about 2.7 ? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue7584] datetime.rfcformat() for Date and Time on the Internet

2010-04-28 Thread Daniel Urban
Daniel Urban added the comment: Is anyone still interested in this? Is there a problem with my patch? Thanks. -- ___ Python tracker ___ __

[issue1368247] unicode in email.MIMEText and email/Charset.py

2010-04-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: Hi David, The attached patch for this issue: +if isinstance(payload, unicode): +payload = payload.encode(msg.get_charset().output_charset or 'us-ascii') looks fine enough to me. Are you worried about the /or 'us-ascii'/ part of this patc