[issue5990] Memory leak in os.rename() and other functions

Martin v. Löwis added the comment: The problem is more general. It can always happen that another argument conversion fails after the O& conversion had failed. Instead of going through the code and fixing each and every usage of the FSConverter callback, I'd rather want to discuss a more general

[issue5993] python produces zombie in webbrowser.open

New submission from dontbugme : the webbrowser library produces a zombie process when opening urls. please see http://dev.deluge-torrent.org/ticket/928 and the original bug report (by me) on ubuntu's launchpad (https:// bugs.launchpad.net/bugs/313149) for details. could not find any references i

[issue5964] WeakSet cmp methods

Robert Schuppenies added the comment: Here is a patch which will return False instead of TypeError. This is the same behavior a normal set has. Two things though. 1. I don't know wether the 'import _abcoll' statement somehow influences the bootstrap in one way or the other, because 'from _abcol

[issue5442] test_importlib fails on Mac OSX 10.5.6 w/ case-sensitive file system

Brett Cannon added the comment: OK, that means everything is fixed as case_sensitivity_tests.diff fixes those test errors. Committed in r72559. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python trac

[issue5986] Avoid reversed() in Random.shuffle()

Changes by Benjamin Peterson : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue5992] spurious space after opening parenthesis when auto-completing

Changes by Antoine Pitrou : -- priority: release blocker -> normal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue5992] spurious space after opening parenthesis when auto-completing

New submission from Antoine Pitrou : Recent trunk/py3k revisions add a spurious space character after the opening parenthesis when doing completion at the interpreter prompt. For example if you type "he" and then press the Tab key, it will display "help( " instead of "help(". -- messages

[issue5991] Add non-command help topics to help completion of cmd.Cmd

New submission from Floris Bruynooghe : The cmd.Cmd module has a default complete_help() method which will complete all existing commands (methods starting with "do_"). It would be useful to complete all exising help topics too by default, i.e. all methods starting with "help_". The attached pa

[issue5753] CVE-2008-5983 python: untrusted python modules search path

Antoine Pitrou added the comment: It seems other projects are already fighting with the path-changing behaviour of PySys_SetArgv(), e.g.: - py2exe: http://www.google.com/codesearch/p?hl=fr#QCS1naFbAGM/trunk/py2exe/source/start.c&q=PySys_SetArgv - gtk: http://www.google.com/codesearch/p?hl=fr#4d1

[issue5989] unittest.TestLoader.loadTestsFromNames should accept module / class name

Michael Foord added the comment: Actually they do - it is an obscure bug in the way the module is specified in TestProgram that prevents this from working. The code in parseArgs that is currently: if len(args) > 0: self.testNames = args Should probably be:

[issue5006] Duplicate UTF-16 BOM if a file is open in append mode

Antoine Pitrou added the comment: Updated patch against py3k. -- Added file: http://bugs.python.org/file13953/append_bom-4.patch ___ Python tracker ___ __

[issue5990] Memory leak in os.rename() and other functions

Antoine Pitrou added the comment: Committed in r72556. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Pyth

[issue4066] smtplib SMTP_SSL._get_socket doesn't return a value

Marcin Bachry added the comment: Here's a dumbed down version of the test from #4470. It requires network, but no gmail account is needed to run the test. -- Added file: http://bugs.python.org/file13952/test_smtpnet.py ___ Python tracker

[issue5804] Add an 'offset' argument to zlib.decompress

Robert Collins added the comment: Maybe I'm missing something, but isn't the offset parameter just another way of spelling buffer(input, offset)? I like the avoiding of copying, just wondering if having a magic parameter to get a tuple is really better than (say) result, used = zlib.decompress2

[issue5804] Add an 'offset' argument to zlib.decompress

Gregory P. Smith added the comment: Overall, this looks good. Some mostly minor comments in this review. http://codereview.appspot.com/63060/diff/1/2 File Doc/library/zlib.rst (right): http://codereview.appspot.com/63060/diff/1/2#newcode136 Line 136: When specified, it will cause the function

[issue4066] smtplib SMTP_SSL._get_socket doesn't return a value

Daniel Diniz added the comment: Marcin, Done and set this one as a dependency of 4470. It would be very good to have a test that flexes this patch, can you work on one? -- priority: -> critical ___ Python tracker

[issue4470] smtplib SMTP_SSL not working.

Changes by Daniel Diniz : -- dependencies: +smtplib SMTP_SSL._get_socket doesn't return a value priority: -> high stage: -> patch review type: -> behavior ___ Python tracker __

[issue5442] test_importlib fails on Mac OSX 10.5.6 w/ case-sensitive file system

Ismail Donmez added the comment: Applied skip_bytecode.diff and test_file_loader.diff clean build results in: == FAIL: test_case_insensitivity (importlib.test.extension.test_case_sensitivity.ExtensionModuleCaseSensi tivityTes

[issue1739118] Investigated ref leak report related to thread regrtest.py

Antoine Pitrou added the comment: Hmm, rather than some C code in the internals, couldn't we simply iterate over the registered Thread objects and join() on those which are still running? -- nosy: +pitrou ___ Python tracker

[issue5964] WeakSet cmp methods

Antoine Pitrou added the comment: I don't think it is the intended behaviour. Comparison for equality should return either True or False (or perhaps NotImplemented?), not raise a TypeError. -- nosy: +pitrou priority: -> normal stage: -> needs patch ___

[issue5238] ssl makefile never closes socket

Antoine Pitrou added the comment: Bill, can you check if it's a real bug? Unclosed sockets are pretty bad. -- nosy: +pitrou priority: -> high versions: +Python 2.7, Python 3.0, Python 3.1 ___ Python tracker __

[issue5238] ssl makefile never closes socket

Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file13935/unnamed ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue2652] 64 bit python memory leak usage

Antoine Pitrou added the comment: Closing since no further information was given about the workload. -- nosy: +pitrou resolution: -> invalid status: open -> closed ___ Python tracker __

[issue5804] Add an 'offset' argument to zlib.decompress

Changes by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://m

[issue5596] memory leaks in 3.1

Changes by Antoine Pitrou : -- dependencies: +Memory leak in os.rename() and other functions ___ Python tracker ___ ___ Python-bugs-lis

[issue5990] Memory leak in os.rename() and other functions

New submission from Antoine Pitrou : A small memory leak appeared in test_os with the PEP 383 checkins. The leak occurs in test_rename and is due to posix_2str. Here is a patch. -- components: Library (Lib) files: os_leak.patch keywords: patch messages: 87543 nosy: loewis, pitrou priorit

[issue5596] memory leaks in 3.1

Antoine Pitrou added the comment: New results: test_os leaked [1, 1] references, sum=2 test_urllib leaked [4, 2] references, sum=6 test_urllib2 leaked [227, 227] references, sum=454 test_urllib2_localnet leaked [3, 3] references, sum=6 -- ___ Python

[issue4066] smtplib SMTP_SSL._get_socket doesn't return a value

Marcin Bachry added the comment: Your diff is better than mine and looks quite similar to patch number 2 in #4470. If the whole #4470 can't be accepted for now, we could at least apply this one change, because without it SMTP_SSL is totally unusable. Daniel, maybe we can mark this bug or #4470 a

[issue5989] unittest.TestLoader.loadTestsFromNames should accept module / class name

New submission from Michael Foord : It would be really nice if unittest.TestLoader.loadTestsFromNames accepted module and class names. My main motivation for that is so that I can do: python -m unittest module_name There is no backwards compatibility issue as currently this doesn't work...

[issue5987] Broken link to "Curses Programming with Python"

Georg Brandl added the comment: This is already fixed in later versions. -- resolution: -> out of date status: open -> closed ___ Python tracker ___

[issue5442] test_importlib fails on Mac OSX 10.5.6 w/ case-sensitive file system

Changes by Brett Cannon : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue5442] test_importlib fails on Mac OSX 10.5.6 w/ case-sensitive file system

Brett Cannon added the comment: Bah, I screwed up and left a file out of skip_bytecode_writing.diff. If you apply test_file_loader along with that patch that should fix the error. -- Added file: http://bugs.python.org/file13950/test_file_loader.diff

[issue4066] smtplib SMTP_SSL._get_socket doesn't return a value

Farhan Ahmad added the comment: Marcin, thanks for finding the cause. I have attached another diff that, instead of removing the assignment, makes the _get_socket function return the socket, which is the expected behavior. You mentioned that the LMTP class also has this issue. I looked throug

[issue5988] Delete PyOS_ascii_formatd, PyOS_ascii_strtod, and PyOS_ascii_atof

New submission from Eric Smith : These 3 functions were deprecated in 2.7 and 3.1, and need to be removed in 2.8 and 3.2. This is currently assigned to version 3.2 only because the bug tracker can't assign issues to 2.8. -- assignee: eric.smith components: Interpreter Core keywords: eas

[issue5987] Broken link to "Curses Programming with Python"

New submission from Ralph Corderoy : http://www.python.org/doc/2.5.2/lib/module-curses.html links to http://docs.python.org/dev/howto/index.htmlcurses/curses.html as "Curses Programming with Python" but it's 404 Not Found. It may be that this link is broken in other Python versions, 2.5.2 is jus

[issue1578269] Add os.link() and os.symlink() and os.path.islink() support for Windows

Martin v. Löwis added the comment: > Would you elaborate just a bit more on why a ctypes implementation would be > undesirable? ctypes is inherently insecure. It must be possible to use Python itself with ctypes removed. Therefore, there is a strict policy not to use ctypes in the core. >> Peo

[issue5986] Avoid reversed() in Random.shuffle()

Changes by Antoine Pitrou : -- priority: -> normal stage: -> patch review type: -> performance versions: +Python 2.7, Python 3.1 ___ Python tracker ___

[issue1578269] Add os.link() and os.symlink() and os.path.islink() support for Windows

Jason R. Coombs added the comment: > How would you provide access to the system functions in pure Python? > If you think of using ctypes, then yes, that would be unreasonable. Would you elaborate just a bit more on why a ctypes implementation would be undesirable? "What's New" for Python 2.5 s

[issue1578269] Add os.link() and os.symlink() and os.path.islink() support for Windows

Jason R. Coombs added the comment: > How would you provide access to the system functions in pure Python? > If you think of using ctypes, then yes, that would be unreasonable. Would you elaborate just a bit more on why a ctypes implementation would be undesirable? "What's New" for Python 2.5

[issue5986] Avoid reversed() in Random.shuffle()

New submission from STINNER Victor : reversed(xrange(1, len(x))) is inefficient, xrange(len(x) - 1, 0, -1) gives exactly the same sequence but avoid reversed(). See attached patch. Don't expect amazing speedup. -- components: Library (Lib) files: shuffle.patch keywords: patch messages:

[issue5752] xml.dom.minidom does not escape newline characters within attribute values

Changes by Tomalak : -- title: xml.dom.minidom does not handle newline characters in attribute values -> xml.dom.minidom does not escape newline characters within attribute values ___ Python tracker ___

[issue1578269] Add os.link() and os.symlink() and os.path.islink() support for Windows

Martin v. Löwis added the comment: > Would it be unreasonable for a patch to add a new Python module > (something like _nt_supplemental.py or platform_windows.py) which > exposes symlink() and islink(), and then in os.py to import those > functions into the os namespace at the same time as impor

[issue5970] sys.exc_info leaks into a generator

Changes by Jeffrey Yasskin : Removed file: http://bugs.python.org/file13928/exc_info_26.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue5970] sys.exc_info leaks into a generator

Jeffrey Yasskin added the comment: Re py3k: oops, thanks for checking. Re 2.6: Fine with me, second patch removed. -- assignee: barry -> ___ Python tracker ___

[issue5752] xml.dom.minidom does not handle newline characters in attribute values

Tomalak added the comment: Francesco, I think you are missing the point. :-) The problem has two sides. If I create an XML document using the DOM (not by parsing it from a string!), then I can put newline characters into attribute value. This is allowed and conforms to the XML spec. However,

[issue5752] xml.dom.minidom does not handle newline characters in attribute values

Francesco Sechi added the comment: I try to explain better what is my opinion: - If you add the attribute by using setAttribute the newlines are kept and the toxml works well - If you add the attribute by using the parsestring, passing it an XML string the newlines are replaced - Your patch wor

[issue5979] strptime() gives inconsistent exceptions

Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyt

[issue5752] xml.dom.minidom does not handle newline characters in attribute values

Francesco Sechi added the comment: I think that the problem is: the xmldoc1 has the newline or not? If it hasn't your patch works only in the particular case you pass a toxml return value to 'parsestring'. If I pass an XML string with newlines it doesn't work. So your solution is not generic and

[issue5977] distutils build_ext.get_outputs returns wrong result (patch)

kxroberto added the comment: its with any .pyx (Cython) module , when after pyximport.install() and injection of --inplace option a .pyx module is imported. the relevant lines in pyxbuild.py are dist.run_commands() return dist.get_command_obj("build_ext").get_outputs()[0] whic

[issue5977] distutils build_ext.get_outputs returns wrong result (patch)

Tarek Ziadé added the comment: I was talking about your use case (pyximport (Cython) do crash then ?) If I can have a real example, with the output and the expected one, I will build a test with it in Distutils before I fix it -- ___ Python tracker

[issue5970] sys.exc_info leaks into a generator

Barry A. Warsaw added the comment: I agree with Antoine. -- versions: -Python 2.6 ___ Python tracker ___ ___ Python-bugs-list mailing

[issue5970] sys.exc_info leaks into a generator

Antoine Pitrou added the comment: Adding some tests to check that a bug is /not/ fixed looks weird to me. If we did that for every trunk change that we don't want to end up in the stable branch, there'd be lots of new tests of dubious utility. Besides, py3k isn't affected ;) -- nosy: +

[issue5984] distutils.command.build_ext.check_extensions_list broken checkings

Tarek Ziadé added the comment: (the pending deprecation warning will be done separately) -- ___ Python tracker ___ ___ Python-bugs-lis

[issue5984] distutils.command.build_ext.check_extensions_list broken checkings

Tarek Ziadé added the comment: done in r72531, r72532, r72533, r72534 -- status: open -> closed ___ Python tracker ___ ___ Python-bugs

[issue1578269] Add os.link() and os.symlink() and os.path.islink() support for Windows

Jason R. Coombs added the comment: I see now that symlink is defined in posixmodule.c (which ends up as the builtin module 'nt'). Then, in os.py, there's a short section that does effectively 'from nt import *'. Would it be unreasonable for a patch to add a new Python module (something like _n

[issue5985] Implement os.path.samefile and os.path.sameopenfile on Windows

New submission from Erik Sandberg : It would be nice if samefile / sameopenfile was present on Windows. Right now I usually work around this by keeping a platform-specific hack for Windows that approximates samefile by comparing normalized paths; this is ugly and doesn't handle junctions correctl

[issue5984] distutils.command.build_ext.check_extensions_list broken checkings

New submission from Tarek Ziadé : distutils.command.build_ext.check_extensions_list is not really working for old style extensions. Will fix it and put a pending deprecation warning for 2.7 and 3.1 (then remove it under 3.2) -- assignee: tarek components: Distutils messages: 87517 nosy: