[issue4753] Faster opcode dispatch on gcc

Paolo 'Blaisorblade' Giarrusso added the comment: Ok, then vmgen adds almost just direct threading instead of indirect threading. Since the purpose of superinstructions is to eliminate dispatch overhead, and that's more important when little actual work is done, what about all ones which uncond

[issue4889] difflib

Gabriel Genellina added the comment: You (as a human) most likely parse these lines: hostname vaijain123 hostname CAVANC1001CR1 as "two words, the first one is the same, the second word changed". But difflib sees them more or less as: "21 letters, 8 of them are the same, 13 are different". Th

[issue4753] Faster opcode dispatch on gcc

Jeffrey Yasskin added the comment: @Paolo: I'm going to be looking into converting more common sequences into superinstructions. We only have LOAD_CONST+XXX so far. The others are difficult because vmgen doesn't provide easy ways to deal with error handling, but Jakob and I have come up with a c

[issue4896] Faster why variable manipulation in ceval.c

Changes by Paolo 'Blaisorblade' Giarrusso : -- nosy: +blaisorblade ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue4871] zipfile can't decrypt

Gabriel Genellina added the comment: Lukas Lueg> The default encoding is UTF8 What do you mean? Not inside a zip file. The default encoding is CP437 (the original IBM PC US character set). A zipfile password is a sequence of bytes, not characters, as defined in the specification. Probably th

[issue4908] adding a get_metadata in distutils

Andi Albrecht added the comment: Is it intended that when reading PKG-INFO files the PEP 314 attributes (provides, requires, obsoletes) are only set if version is exactly "1.1"? I'd expected that those attributes are available regardless of the metadata version of the parsed file (with None as

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by Gabriel Genellina : -- nosy: +gagenellina ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue3720] segfault in for loop with evil iterator

Gregory P. Smith added the comment: nice hack! :) I'm going to guess that existing code in the wild setting tp_iternext = &PyObject_GetIter is rare. I certainly can not rule it entirely out but I don't see anything in the open source world using http://www.google.com/codesearch I'd be okay

[issue4913] wave.py: add writesamples() and readsamples()

Guilherme Polo added the comment: > "DC (0 hz) assumption"? > wave.py makes the assumption that what the user wants is whatever > happens to be in the file, however arbitrary. (That 8 bit samples are > unsigned bytes is probably an artifact of early ADC logic. Typically you > got an absolute, n-

[issue4903] binascii.crc32() - document signed vs unsigned results

Gabriel Genellina added the comment: Just a small note on the wording: "will have" and "will always be" look too strong to me. I'd just use is, are. Present tense seems to be --in general-- the preferred style in the documentation. -- nosy: +gagenellina __

[issue4913] wave.py: add writesamples() and readsamples()

Alex Robinson added the comment: "DC (0 hz) assumption"? wave.py makes the assumption that what the user wants is whatever happens to be in the file, however arbitrary. (That 8 bit samples are unsigned bytes is probably an artifact of early ADC logic. Typically you got an absolute, n-bit value f

[issue4881] Python's timezon handling: daylight saving option

Pablo Castagnino added the comment: Ok, everything seems to be working now in Ubuntu. However, I can't get it work in WIN XP (at work). :( Thanks for all your help! ___ Python tracker __

[issue4905] Use INVALID_FILE_ATTRIBUTES instead of magic numbers

Gabriel Genellina added the comment: The patch looks fine to me -- nosy: +gagenellina ___ Python tracker ___ ___ Python-bugs-list mail

[issue3720] segfault in for loop with evil iterator

Amaury Forgeot d'Arc added the comment: Yes, a hack: What about setting tp_iternext to PyObject_GetIter? they happen to have the same signature. Yes, calling next() will call iter() instead; but an iterator is often its own iterator, and more importantly, PyIter_Check() is also called. And th

[issue3720] segfault in for loop with evil iterator

Amaury Forgeot d'Arc added the comment: Fixed in r68560 (trunk) and r68561 (py3k). Difficult to backport: extensions compiled with 2.6.x would not run on 2.6.0. -- keywords: -needs review resolution: -> fixed status: open -> pending ___ Python tr

[issue3720] segfault in for loop with evil iterator

Gregory P. Smith added the comment: Any crash is a potential security problem. This needs to be fixed in 2.6.x without breaking 2.6.0 extension compatibility. (requiring extensions to be recompiled to fix the problem for an extension is fine, but they still need to load and work normally ev

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson : Added file: http://bugs.python.org/file12710/3.x.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

Changes by David Watson : Added file: http://bugs.python.org/file12709/2.x.diff ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue4926] putenv() accepts names containing '=', return value of unsetenv() not checked

New submission from David Watson : One of these problems interacts with the other, and can cause os.unsetenv() to free memory that's still in use. Firstly, calling os.putenv("FOO=BAR", "value") causes putenv(3) to be called with the string "FOO=BAR=value", which sets a variable called FOO, not F

[issue1696199] Add collections.counts()

Raymond Hettinger added the comment: Thanks for the review comments. Incorporated all suggested changes and did some other minor tidying-up. Extended the update example to include c.update(Counter('abcdee')). Committed as r68559 . Decided to leave __repr__() with a sort. Though it's not str

[issue4921] Object lifetime and inner recursive function

Antoine Pitrou added the comment: Well, tracking memory consumption of each container would be better than simpling couting them, but it's much more complicated as well (not to mention that memory consumption can vary, so you must recalculate it periodically...). ___

[issue1479611] speed up function calls

Changes by Collin Winter : -- nosy: +collinwinter, jyasskin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue4907] ast.literal_eval does not properly handled complex numbers

Armin Ronacher added the comment: Here a patch with unittests to correctly handle complex numbers. This does not allow the user of arbitrary add/sub expressions on complex numbers. Added file: http://bugs.python.org/file12707/literal-eval.patch ___ Python t

[issue3582] thread_nt.c update

Changes by Martin v. Löwis : -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue2233] Makefile.pre.in contains extra slash before $(DESTDIR) which can cause Cygwin build to fail

Jason Tishler added the comment: Obviously not... :,( It seems like we might have to go with your "/./" workaround, but let me see if I can come up with another approach. ___ Python tracker ___

[issue3038] Return results from Python callbacks to Tcl as Tcl objects, please backport it.

Guilherme Polo added the comment: Not going to happen, python 2.5.4 is already out there. -- resolution: -> wont fix status: open -> closed ___ Python tracker ___ __

[issue2486] Recode (parts of) decimal module in C

Nick Coghlan added the comment: FWIW, I actually prefer Mark's graduated approach to the Python->C migration since we have a continuously working module that will get incrementally faster over time. As profiling finds performance bottlenecks in the Python code, those parts can be migrated to C (

[issue4907] ast.literal_eval does not properly handled complex numbers

Mark Dickinson added the comment: BTW, both those "I'm not sure"s should be taken literally: I'm not a user of the ast module, I don't know who the typical users are, and I don't know what the typical uses for the literal_eval function are. The patch just struck me as odd, so I thought I'd

[issue2486] Recode (parts of) decimal module in C

Mark Dickinson added the comment: Guess that makes this a bit of a wasted effort on my part, then. Darn. > a substantial portion of the module should be coded in C and > needs to function independently of Python, with accessors provided to > for Python to wrap around. I'm curious what sort of

[issue4753] Faster opcode dispatch on gcc

Jeffrey Yasskin added the comment: I've left some line-by-line comments at http://codereview.appspot.com/11905. Sorry if there was already a Rietveld thread; I didn't see one. ___ Python tracker

[issue1696199] Add collections.counts()

Changes by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://ma

[issue1696199] Add collections.counts()

Georg Brandl added the comment: Attaching new patch with small changes: * Don't describe a class with "Returns ..." as if it was a function. * Indent interposed paragraphs so that the method descriptions still belong to the .. class directive. * Fixed Ned's typo. * Note that elements() and most

[issue4925] Improve error message of subprocess

David W. Lambert added the comment: (Actual command stream includes chmod +x ./s.sh) ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue1696199] Add collections.counts()

Ned Deily added the comment: In counter6.diff line 56 "Assigning a count of zero or reducing the count to the zero leaves the" suggest s/the zero/zero/ -- nosy: +nad ___ Python tracker

[issue4753] Faster opcode dispatch on gcc

Paolo 'Blaisorblade' Giarrusso added the comment: A couple percent maybe is not worth vmgen-ing. But even if I'm not a vmgen expert, I read many papers from Ertl about superinstructions and replication, so the expected speedup from vmgen'ing is much bigger. Is there some more advanced feature we

[issue1696199] Add collections.counts()

Steven Bethard added the comment: The whole point was to have a function (or class) that accumulates a sequence and counts it. collections.defaultdict(lambda: 0) doesn't achieve this on its own because it only knows how to handle sequences of (key, value): >>> d = collections.defaultdict(lambda

[issue3720] segfault in for loop with evil iterator

Benjamin Peterson added the comment: I think PyObject_NextNotImplemented should be renamed to _PyObject_NextNotImplemented. Aside from that, I think the patch is ready for committing. -- nosy: +benjamin.peterson ___ Python tracker

[issue4913] wave.py: add writesamples() and readsamples()

Guilherme Polo added the comment: I was going to reply about your "code layout" answer but forgot. Well, each one has their preferences so I'm not going to question yours. The only problem is that there is no maintainer for wave.py, so, the more you follow the rules for Python code (or at least

[issue4913] wave.py: add writesamples() and readsamples()

Guilherme Polo added the comment: 1) wave.py doesn't do assumptions about what the user wants, so I don't think it is the place to put the DC (0 hz) assumption. 3) writesamples would raise an exception in the case of the current number of channels set being wrong. 4) Well, lets fix a format th

[issue1696199] Add collections.counts()

Amaury Forgeot d'Arc added the comment: > the typical usage is c=Counter(myseq) with no other non-dict accesses > (mostly just c[elem]+=1 and print c[elem]) Isn't collections.defaultdict(lambda:0) enough for this purpose? -- nosy: +amaury.forgeotdarc __

[issue4910] Remove uses of nb_long slot, and rename to nb_reserved.

Benjamin Peterson added the comment: The first installment looks good! ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue4753] Faster opcode dispatch on gcc

Jeffrey Yasskin added the comment: Here's the vmgen-based patch for comparison. Again, it passes all the tests, but isn't complete outside of that and (unless consensus develops that a couple percent is worth requiring vmgen) shouldn't distract from reviewing Antoine's patch. I'll look over thre

[issue1168055] Add current dir when running try_run test program

Fernando Gomes added the comment: Dear Community, I'd fronted problems to install Statistics module on my Ubuntu. There are errors that are hard to solve without an expert help, such as the one received from Michiel (Thank you again!!!). Errors are listed below: # XX

[issue4913] wave.py: add writesamples() and readsamples()

Alex Robinson added the comment: "8 bit samples stored as unsigned bytes"? 8 bit samples are 0..255 in the file. But to work with them, you'll want them -128..127. The code assumes DC==0 sample values for simplicity. "if len(wavs) not in [ 1, 2, 4 ]" ? That way if you're working with mono, you

[issue4925] Improve error message of subprocess

David W. Lambert added the comment: Related, but outside python realm, this error likewise confuses: $ cat < s.sh #! invalid path echo hi EOF $ ./s.sh zsh: no such file or directory: ./s.sh -- nosy: +LambertDW ___ Python tracker

[issue4925] Improve error message of subprocess

New submission from Martin Mokrejs : I think the following error output unsatisfactory as it does not give me any hint what file was not found: $ fetch_quals.py blah.txt Traceback (most recent call last): File "/home/mmokrejs/bin/fetch_quals.py", line 15, in _p1 = subprocess.Popen(['quer

[issue4760] cmp gone documentations

David W. Lambert added the comment: http://docs.python.org/dev/3.1/library/unittest.html#module-unittest Search for "cmp". There are two references. I apologize if I misunderstand issue 1717, -- title: cmp gone---What's new in 3.1 -> cmp gone documentations _

[issue1403068] cannot import extension module with Purify

Amaury Forgeot d'Arc added the comment: Newer versions of Purify seem to convert the file name to uppercase letters (PYTHON27__D$Purify...), so the error is does not occur anymore. The current code is fragile though... -- resolution: -> works for me status: open -> closed

[issue4913] wave.py: add writesamples() and readsamples()

Guilherme Polo added the comment: Aren't 8 bit samples stored as unsigned bytes ? If yes, they don't range between -128 and 127 (first disagreement). So this line: wav = [ s - 128 for s in wav ] and the respective one (that adds +128 in writesamples) should go. Why is this check: "if len(wavs)

[issue4921] Object lifetime and inner recursive function

Hirokazu Yamamoto added the comment: A little followup. Attached script q112.py (some puzzle program) ate up my RAM (80MB) and never ran GC while solving. Current python GC looks at the number of GC objects, but GC object like set object can contain many non GC object, so... I feel it would b

[issue4908] adding a get_metadata in distutils

Ray added the comment: I've tested it out using the straight distutils installation, and it works great! ___ Python tracker ___ ___ Python-bugs

[issue4913] wave.py: add writesamples() and readsamples()

Alex Robinson added the comment: Polo: "I could do it, but I'm in disagreement with big part of your patch." Why surely you can't mean the bug. :) (The test program has it fixed.) What is the disagreement? Apparently this bug system allows file attachments, so I will upload a test program and

[issue4908] adding a get_metadata in distutils

Tarek Ziadé added the comment: yes the patch doesn't treat the eggs installed with easy_install yet, just plain distutils I'll let you know when EGG_INFO/PKG-INFO is ready (should be in the coming days) ___ Python tracker

[issue4908] adding a get_metadata in distutils

Ray added the comment: The patch didn't install correctly using 'patch', but I manually merged the changes into my environment (Ubuntu 8.10 running 2.5.2) - I'll upload the diff rejections if they'll be helpful. After installing, I attempted to use the new code to determine the version number,

[issue881261] Overflow in Python Profiler

Amaury Forgeot d'Arc added the comment: on POSIX, clock() indeed wraps around after some time. This was corrected with issue645894, and is available since python 2.5. -- nosy: +amaury.forgeotdarc resolution: -> out of date status: open -> closed superseder: -> better timer resolution

[issue4924] gc.collect() won't always collect as expected

Martin v. Löwis added the comment: It should be possible to trigger this by invoking gc.collect in an __del__ implementation of an object that is attached to a cycle. However, I don't think this is an important issue; +0 for resolving this by documenting the status quo (instead of making the im

[issue4924] gc.collect() won't always collect as expected

New submission from Antoine Pitrou : I haven't verified this through any test (actually I'm wondering how to deterministically reproduce it), but logically there are cases where gc.collect() (and, similarly, PyGC_Collect()) won't work as advertised. Specifically, when the GC is asked to collect

[issue4921] Object lifetime and inner recursive function

Hirokazu Yamamoto added the comment: Thank you for explanation. The combination of inner function + method variable was very handy for me, but maybe I should refrain from using it lightly. :-( -- resolution: -> invalid status: open -> closed ___ P

[issue812369] module shutdown procedure based on GC

Antoine Pitrou added the comment: Looking at the patch, is there any reason it doesn't get rid of the current _PyModule_Clear() implementation to replace it by a call to PyDict_Clear() followed by PyGC_Collect()? (the call to PyGC_Collect could be disabled while finalizing, because there's no us

[issue4921] Object lifetime and inner recursive function

Antoine Pitrou added the comment: Since g calls "itself" in its own scope, it is stored as one of its own cell vars, which creates a reference cycle. a is also part of its reference cycle for the same reason, so it must wait for garbage collection to be reclaimed. If g didn't keep a reference t

[issue4913] wave.py: add writesamples() and readsamples()

Guilherme Polo added the comment: I could do it, but I'm in disagreement with big part of your patch. Can you add some kind of test you used for it ? Raw data, sample file, or something like this. ___ Python tracker __

[issue4913] wave.py: add writesamples() and readsamples()

Alex Robinson added the comment: I might be able to do doc/test/patch in a month or two, but know zero.zero about the process so would expect it to take far more than a few hours when I do have time. ___ Python tracker

[issue4923] time.strftime documentation needs update

New submission from Riccardo Attilio Galli : there are discrepancies in the online documentation of strftime in time.strftime http://docs.python.org/library/time.html and datetime.strftime (http://docs.python.org/library/datetime.html) In particular, seems like datetime.strftime is the one up

[issue4920] Inconsistent usage of next/__next__ in ABC collections; collections.Iterator is not compatible with Python 2.6 iterators.

Raymond Hettinger added the comment: Good catch! -- nosy: +rhettinger priority: -> high ___ Python tracker ___ ___ Python-bugs-list m

[issue4922] set.add and set.discard are not conformant to collections.MutableSet interface

New submission from Jaroslaw Rosiek : Methods set.add and set.discard should return boolean values according to collections.MutableSet but they are not. >>> print set().add(5) None >>> print set().discard(5) None -- components: Library (Lib) messages: 79665 nosy: jrosiek severity: norma

[issue4921] Object lifetime and inner recursive function

New submission from Hirokazu Yamamoto : Hello. Sorry if this is noise. I expected __del__ out of function __del__ out of function __del__ out of function on following code, but actually I got out of function out of function out of function __del__ __del__ __del__ Is this expected behavoir? (I

[issue1696199] Add collections.counts()

Changes by Raymond Hettinger : Removed file: http://bugs.python.org/file12695/counter5.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue1696199] Add collections.counts()

Changes by Raymond Hettinger : Removed file: http://bugs.python.org/file12671/counter4.diff ___ Python tracker ___ ___ Python-bugs-list mail

[issue1696199] Add collections.counts()

Raymond Hettinger added the comment: Attaching an update with improved docs. Thanks for looking at this. Added file: http://bugs.python.org/file12702/counter6.diff ___ Python tracker ___

[issue4920] Inconsistent usage of next/__next__ in ABC collections; collections.Iterator is not compatible with Python 2.6 iterators.

Changes by Jaroslaw Rosiek : -- keywords: +patch Added file: http://bugs.python.org/file12701/_abcoll.patch ___ Python tracker ___ ___

[issue4920] Inconsistent usage of next/__next__ in ABC collections; collections.Iterator is not compatible with Python 2.6 iterators.

Changes by Jaroslaw Rosiek : Added file: http://bugs.python.org/file12700/example2.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue4920] Inconsistent usage of next/__next__ in ABC collections; collections.Iterator is not compatible with Python 2.6 iterators.

Changes by Jaroslaw Rosiek : Removed file: http://bugs.python.org/file12699/example2.py ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue4920] Inconsistent usage of next/__next__ in ABC collections; collections.Iterator is not compatible with Python 2.6 iterators.

Changes by Jaroslaw Rosiek : Added file: http://bugs.python.org/file12699/example2.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue4920] Inconsistent usage of next/__next__ in ABC collections; collections.Iterator is not compatible with Python 2.6 iterators.

New submission from Jaroslaw Rosiek : 1. collections.MutableSet refers to __next__() slot instead of next() buildin. 2. collection.Iterator is not compatible with 2.6's iterators which should have next() slot. Proposed solution: add a next() method to collections.Iterator that falls back to __n

[issue4913] wave.py: add writesamples() and readsamples()

Changes by Guilherme Polo : -- versions: -Python 2.6, Python 3.0 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1483545] Wave.py support for ulaw and alaw audio

Changes by Guilherme Polo : -- type: -> feature request versions: +Python 2.7, Python 3.1 ___ Python tracker ___ ___ Python-bugs-li

[issue1696199] Add collections.counts()

Georg Brandl added the comment: Yes, I'll have a look this evening. ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue4913] wave.py: add writesamples() and readsamples()

Guilherme Polo added the comment: Documentation, tests and patch against trunk are needed to get this into Python, but to me the request is fine. -- title: wave.py writes 16 bit sample files of half the correct duration -> wave.py: add writesamples() and readsamples() versions: -Pytho

[issue4910] Remove uses of nb_long slot, and rename to nb_reserved.

Mark Dickinson added the comment: That was a pretty poor patch. Here's a better one: - added Misc/NEWS entry - added tests to check that __long__ is never called - removed Modules/_struct.c change, in the interests of keeping the patch focused. Added file: http://bugs.python.org/file126

[issue4293] Thread Safe Py_AddPendingCall

Kristján Valur Jónsson added the comment: Added MISC/News entry in revision: 68545 ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue3582] thread_nt.c update

Kristján Valur Jónsson added the comment: Misc/NEWS updated in revision: 68544 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue3582] thread_nt.c update

Kristján Valur Jónsson added the comment: Note, see defect 4906 for fallout caused by this checkin. ___ Python tracker ___ ___ Python-bugs-list

[issue4910] Remove uses of nb_long slot, and rename to nb_reserved.

Mark Dickinson added the comment: Here's a patch against the py3k branch that gets rid of the two existing uses of nb_long in the core: - in PyNumber_Long, conversion was attempted first using nb_int and then using nb_long. The patch simply removes the nb_long code, so int(x) no longer

[issue4919] 2.6.1 build issues on solaris with SunStudio 12

New submission from scott wedel : The HUGE_VAL aka infinity issue is solved if the LIB is -lsunmath -lm instead of just -lm Sun Studio 12 compiler also seems to choke on the PyByteArray_GET_SIZE and _AS_STRING because those macros use the ',' operator to stuff an assert before the pointer lookup

[issue3582] thread_nt.c update

Martin v. Löwis added the comment: Please add a Misc/NEWS entry for this change. -- assignee: -> krisvale status: closed -> open ___ Python tracker ___ _

[issue4893] Use separate thread support code under MS Windows CE

Martin v. Löwis added the comment: I see. Whether the call to PyThread_get_thread_ident comes before the access to errno (in the original version) depends on the compiler, of course. Also, this function should be trusted to not affect the last error, since it can't fail. I've added a comment to

[issue4915] Port sysmodule.c to MS Windows CE

Martin v. Löwis added the comment: Thanks for the patch. Committed as r68540, r68541. -- resolution: -> accepted status: open -> closed ___ Python tracker ___ __

[issue1696199] Add collections.counts()

Raymond Hettinger added the comment: Georg, could you give this a once over before I commit? Thanks. -- assignee: rhettinger -> georg.brandl nosy: +georg.brandl Added file: http://bugs.python.org/file12695/counter5.diff ___ Python tracker