[issue3703] open() on directory raises IOError with unhelpful message

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: looks good to me -- nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3647] urlparse - relative url parsing and joins to be RFC3986 compliance

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: given where we are in the release process at the moment I doubt this can go into 2.6/3.0. Bring it up on python-dev if you have compelling reasons why it should. Otherwise, looks good for trunk 2.7/3.1 immediately after the releases are br

[issue3704] cookielib doesn't handle URLs with / in parameters

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: attached is a patch with the suggested fix along with a unit test. -- assignee: -> gregory.p.smith keywords: +needs review nosy: +gregory.p.smith priority: -> normal Added file: http://bugs.python.org/file11283/cookielib-querystri

[issue3014] file_dealloc() assumes errno is set when EOF is returned

Changes by Laszlo (Laca) Peter <[EMAIL PROTECTED]>: -- nosy: +laca ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list maili

[issue3704] cookielib doesn't handle URLs with / in parameters

Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- keywords: +patch Added file: http://bugs.python.org/file11282/cookielib.diff ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3708] os.urandom(1.1): infinite loop

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: better patch with tests attached, no explicit int conversion is done. i also wrapped the use of the fd returned by open with a try: finally: to avoid any chance of a leak and renamed the bytes variable to bs to match whats in py3k and avoid

[issue3708] os.urandom(1.1): infinite loop

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: i'll fix this and add a unit test. -- assignee: -> gregory.p.smith keywords: +easy nosy: +gregory.p.smith priority: -> low ___ Python tracker <[EMAIL PROTECTED]>

[issue1868] threading.local doesn't free attrs when assigning thread exits

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I like Amaury's patch, it gets rid of what seems like an existing gross hack of having localobject->dict exist at all. I believe it may also fix #3710 by getting rid of the unnecessary localobject->dict member. Could someone else please re

[issue1868] threading.local doesn't free attrs when assigning thread exits

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: see also #3710 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing li

[issue3710] Reference leak in thread._local

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: fyi - This bug and #1868 (http://bugs.python.org/issue1868) seem related. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3678] Ignored LDFLAGS during linking libpython$(VERSION).so

Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I think this ldflags-ldlast patch (added) is whats really needed. -- keywords: +easy, needs review Added file: http://bugs.python.org/file11280/ldflags-ldlast-gps01.diff ___ Python tracker <[EMAI

[issue1868] threading.local doesn't free attrs when assigning thread exits

Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- keywords: +patch nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3710] Reference leak in thread._local

Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- nosy: +gregory.p.smith ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-li

[issue3602] Move test.test_suport.catch_warning() to the 'warnings' module

Mark Hammond <[EMAIL PROTECTED]> added the comment: I stumbled across this when mimetools import of test failed due to finding a local test package, not the python test package, so I too will be happy to see this fixed. -- nosy: +mhammond ___ Python t

[issue3678] Ignored LDFLAGS during linking libpython$(VERSION).so

Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- assignee: -> gregory.p.smith nosy: +gregory.p.smith priority: -> normal ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3706] Fix error message for wrong exec() argument type

Guido van Rossum <[EMAIL PROTECTED]> added the comment: Looks okay, although my taste would be to let the calls to source_as_string() be slightly more verbose and include the "string, bytes" part. While that has a little more redundancy, it is easier to read, and possibly easier to grep for. ---

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Henry Precheur <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11266/fix_mbstowcs_openbsd.diff ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Henry Precheur <[EMAIL PROTECTED]> added the comment: I removed my previous patch. It was not dealing with all broken mbstowcs cases and yours is much better. Some comments on the other patch: I don't think the macro HAVE_BROKEN_MBSTOWCS alone is a perfect idea. It won't fix the problem in the

[issue3710] Reference leak in thread._local

Ben Cottrell <[EMAIL PROTECTED]> added the comment: The specific thing that was happening for me is that an _sqlite3.Connection object was in the dictionary. In Modules/_sqlite/connection.c, in pysqlite_connection_dealloc(), it uses Py_BEGIN_ALLOW_THREADS/Py_END_ALLOW_THREADS. So it's the call t

[issue3710] Reference leak in thread._local

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > But then if there is a context switch during the last Py_XDECREF, then > it could be the case that self->dict is not set properly on return from > _ldict(). Well, C code is effectively locked in a single thread until the GIL is released. It

[issue3710] Reference leak in thread._local

Ben Cottrell <[EMAIL PROTECTED]> added the comment: But then if there is a context switch during the last Py_XDECREF, then it could be the case that self->dict is not set properly on return from _ldict(). Functions like local_setattro() use _ldict() more for its side effect (setting self->dict)

[issue3705] py3k aborts if "-c" or "-m" is given a non-ascii value

Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- keywords: +needs review nosy: +loewis ___ Python tracker <[EMAIL PROTECTED]> ___ ___ P

[issue3710] Reference leak in thread._local

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Hmm, rather than the while loop in your proposal, the proper idiom would be: PyObject *olddict = self->dict; Py_INCREF(ldict); self->dict = ldict; Py_XDECREF(olddict); -

[issue3710] Reference leak in thread._local

New submission from Ben Cottrell <[EMAIL PROTECTED]>: This is a copy of a message I sent to the python-dev mailing list; it was suggested in a reply that I file a bug for this issue. I'm filing it against Python 2.5 because that's where I noticed it, but it doesn't look like this code has changed

[issue3709] BaseHTTPRequestHandler innefficient when sending HTTP header

New submission from Yang Zhao <[EMAIL PROTECTED]>: send_header() in BaseHTTPRequestHandler currently does a write to socket every time send_header() is called. This results in excessive number of TCP packets being regenerated. Ideally, as much of the HTTP packet is buffered as possible, but, at m

[issue3708] os.urandom(1.1): infinite loop

New submission from Daniel Diniz <[EMAIL PROTECTED]>: Calling os.urandom(1 + float(x)) ends in a infinite loop due to a naive condition check: while len(bytes) < n: bytes += read(_urandomfd, n - len(bytes)) Trivial patch attached. -- components: Library (Lib) files: urandom.diff ke

[issue3521] file.readline: bad exception recovery

Daniel Diniz <[EMAIL PROTECTED]> added the comment: Patch attached, suggested test below. def test_readline(): for mode in ('r', 'rb', 'r+', 'r+b'): f = open(__file__, mode) try: f.readline(0.1) except TypeError: tmp = f.readline() f.cl

[issue3707] help('finally') behaves bizarrely

Georg Brandl <[EMAIL PROTECTED]> added the comment: Good catch! Patch attached. -- keywords: +easy, needs review, patch nosy: +georg.brandl priority: -> critical Added file: http://bugs.python.org/file11275/pydoc.diff ___ Python tracker <[EMAIL PROTE

[issue3707] help('finally') behaves bizarrely

New submission from Mike Speciner <[EMAIL PROTECTED]>: I'm running Python 3.0b2 (r30b2:65106, Jul 18 2008, 18:44:17) [MSC v.1500 32 bit (Intel)] on win32. Typing help('finally') loops, repeatedly typing the following two lines File "C:\Python30\lib\pydoc.py", line 1777, in showtopic return sel

[issue3706] Fix error message for wrong exec() argument type

New submission from Georg Brandl <[EMAIL PROTECTED]>: Fixes exec() message that claims it supports file objects. Also makes error messages from compile(), exec() and eval() more concrete, and in the case of compile() more correct. -- files: bltin.diff keywords: needs review, patch, patc

[issue3660] reference leaks in 3.0

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: As of r66047, I get the following results (without "-uall", though): test_unittest leaked [124, 124] references, sum=248 test_binascii leaked [1, 1] references, sum=2 test_distutils leaked [141, 142] references, sum=283 test_logging leaked [2

[issue3623] _json: fix raise_errmsg(), py_encode_basestring_ascii() and linecol()

Changes by Daniel Diniz <[EMAIL PROTECTED]>: -- nosy: +ajaksu2 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing l

[issue3626] python3.0 interpreter on Cygwin ignores all arguments

Yaakov (Cygwin Ports) <[EMAIL PROTECTED]> added the comment: Another thing: _bsddb does not compile with db4.7: Modules/_bsddb.c: In function `DBSequence_get_cachesize': Modules/_bsddb.c:5022: warning: passing arg 2 of pointer to function from incompatible pointer type Modules/_bsddb.c: In funct

[issue3611] invalid exception context

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > Can this patch go in? I'm ok for it. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Pyth

[issue3626] python3.0 interpreter on Cygwin ignores all arguments

Yaakov (Cygwin Ports) <[EMAIL PROTECTED]> added the comment: Thanks for your persistence with this. Corinna got _wcsrtombs_r fixed in newlib, so I imagine the next Cygwin 1.7 preview will have the fix. Unfortunately that won't help the still-stable Cygwin 1.5. I'm not sure what you mean by PyU

[issue3611] invalid exception context

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Some progress: The lines suppressed by the patch at http://bugs.python.org/msg71579 either do nothing (because e.g exc_type is already NULL or None), or happen to be in a case similar to the script "lostcontext2.py" (Most of the time, th

[issue3705] py3k aborts if "-c" or "-m" is given a non-ascii value

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- priority: -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Pyt

[issue3705] py3k aborts if "-c" or "-m" is given a non-ascii value

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch which works under Linux. Under Windows it doesn't choke when converting arguments anymore, but it fails later in the process (in the parser for '-c', in the importing logic for '-m'). Here is an example: $ ./python -c "print(

[issue1204] readline configuration for shared libs w/o curses dependencies

Roumen Petrov <[EMAIL PROTECTED]> added the comment: In the configure{.in} exist another bug: -- AC_CHECK_LIB(readline, readline) if test "$ac_cv_have_readline_readline" = no then AC_CHECK_LIB(termcap, readline) fi -- but "grep _readline_readline configure" show that var

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Mmh, in Modules/python.c and Python/frozenmain.c, the return value of the second call to mbstowcs() should be checked as well (since the first one is sometimes replaced by a call to strlen(), which never fails). __

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The patch looks fine and harmless to me (but I'm a configure newbie too). +1 for committing it and seeing if the OpenBSD buildbot feels better. In the process of testing this patch, I've found another bug: #3705. -- nosy: +pitrou __

[issue3705] py3k aborts if "-c" or "-m" is given a non-ascii value

New submission from Antoine Pitrou <[EMAIL PROTECTED]>: The explanation is quite simple: in Py_Main, the arguments are converted from wide to byte strings, but the required length of the byte string is assumed equal to that of the wide string. Which gives: $ ./python -c "print('à')" Fatal Pytho

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bu

[issue3704] cookielib doesn't handle URLs with / in parameters

New submission from Andy Kilpatrick <[EMAIL PROTECTED]>: cookielib doesn't handle URLs like "http://server/script? err=/base/error.html&ok=/base/ok.html", as CookieJar::_cookie_from_cookie_tuple uses rfind("/") to strip off the end of the URL, returning "http://server/script? err=/base/error.ht

[issue3703] open() on directory raises IOError with unhelpful message

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: There is a call to dircheck(), but not in the correct place. The attached patch makes sure that the "Is a directory" message is not overwritten. -- keywords: +needs review, patch nosy: +amaury.forgeotdarc priority: -> critical

[issue3703] open() on directory raises IOError with unhelpful message

New submission from Hagen Fürstenau <[EMAIL PROTECTED]>: When trying to open a directory (on Linux), Python 2.x complained with >>> open("local") Traceback (most recent call last): File "", line 1, in IOError: [Errno 21] Is a directory Python 3.0 however gives the rather unhelpful or even wr

[issue3702] test_urllib2.test_trivial fails when run from another Windows drive

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: What I forgot to say is that the test was launched from the C: drive: C:\>z:PCbuild\python_d.exe z:Lib\test\regrtest.py -uall -v test_urllib2 ___ Python tracker <[EMAIL PROTECTED]>

[issue3702] test_urllib2.test_trivial fails when run from another Windows drive

New submission from Antoine Pitrou <[EMAIL PROTECTED]>: == ERROR: test_trivial (test.test_urllib2.TrivialTests) -- Traceback (most recent call last): File "Z:\

[issue3701] test_ntpath.test_relpath fails when launched from a different Windows drive

New submission from Antoine Pitrou <[EMAIL PROTECTED]>: C:\>z:PCbuild\python_d.exe z:Lib\test\regrtest.py -uall -v test_ntpath test_ntpath test_abspath (test.test_ntpath.TestNtpath) ... ok test_commonprefix (test.test_ntpath.TestNtpath) ... ok test_expandvars (test.test_ntpath.TestNtpath) ... ok

[issue3626] python3.0 interpreter on Cygwin ignores all arguments

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: cygwin has also a nasty bug: printf("%ls", wide_string) fails for strings of length 1. %S has the same problem. $ ./python.exe ab ./python: can't open file 'ab': [Errno 2] No such file or directory $ ./python.exe a ./python The ou

[issue3700] test_bigmem broken

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: It would be nice if at least one of the buildbots could run the bigmem tests. ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3700] test_bigmem broken

New submission from Antoine Pitrou <[EMAIL PROTECTED]>: ./python3 Lib/test/regrtest.py -v -M 2.1Gb test_bigmem test_bigmem [snip skipped tests] == ERROR: test_center_unicode (test.test_bigmem.StrTest) -

[issue3675] Python 2.6 can't read sets pickled with Python 3.0

Hagen Fürstenau <[EMAIL PROTECTED]> added the comment: Well, this is obviously caused by renaming "__builtin__" to "builtins" and the fact that set (as well as frozenset) doesn't have its own opcode and therefore gets looked up in "builtins". The problem therefore extends to all builtin objects w

[issue3699] test_bigaddrspace broken

New submission from Antoine Pitrou <[EMAIL PROTECTED]>: ./python3 Lib/test/regrtest.py -v -M 2.1Gb test_bigaddrspace test_bigaddrspace test_concat (test.test_bigaddrspace.StrTest) ... ERROR test_optimized_concat (test.test_bigaddrspace.StrTest) ... ERROR =

[issue2464] urllib2 can't handle http://www.wikispaces.com

Senthil <[EMAIL PROTECTED]> added the comment: That was reason in making fix_broken in the urlparse in my patch, Facundo. I had thought, it should be handled in urlparse module and if we make changes in the urlparse.urlunparse/urlparse.urlparse, then we are stepping into area which will break a l

[issue3698] incompatible arguments in warning formatting for idle

New submission from Guillaume Coffin <[EMAIL PROTECTED]>: In idle, the function idle_formatwarning_subproc overrides warnings.formatwarning, however the latter in Python 2.6 is called from warnings._show_warning with an additional "line" argument: line 29, in _show_warning file.write(formatwarni

[issue1840] Tools/i18n/msgfmt.py fixes for Python 3.0

Peter Harris <[EMAIL PROTECTED]> added the comment: As far as I can tell, it is OK now. Thanks! ___ Python tracker <[EMAIL PROTECTED]> ___ ___ P

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Patch uploaded to http://codereview.appspot.com/3276, verified to fix the problem on a Windows XP virtual machine. Please review. -- keywords: +needs review, patch priority: critical -> release blocker ___

[issue3626] python3.0 interpreter on Cygwin ignores all arguments

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: See also issue3696, and the patch provided there. Yaakov, you should remove the _locale.dll from your build directory: for the compilation phase, better have no locale at all than a broken "U" as default encoding ("U" is the initial of

[issue3626] python3.0 interpreter on Cygwin ignores all arguments

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- priority: -> release blocker ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Pyt

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Here is another patch, which tries to replace all problematic usages of mbstowcs, and a new "#define HAVE_BROKEN_MBSTOWCS" to activate it. It needs a review, especially the "configure" stuff, it's my first time to deal with this. Teste

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: It is because of the USE_STACKCHECK macro, which is only defined in debug mode with Microsoft compilers. ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

New submission from Antoine Pitrou <[EMAIL PROTECTED]>: This error appears more or less regularly on the Windows py3k buildbots. Today it has appeared following my changes to isinstance() / issubclass(), but it had already appeared before, e.g. http://www.python.org/dev/buildbot/3.0.stable/x86%20

[issue3694] Undetected error in _struct.pack_into

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: Isn't PyNumber_AsSsize_t designed for this purpose? -- nosy: +amaury.forgeotdarc ___ Python tracker <[EMAIL PROTECTED]>

[issue3694] Undetected error in _struct.pack_into

Changes by Georg Brandl <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11268/s30.diff ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3694] Undetected error in _struct.pack_into

Georg Brandl <[EMAIL PROTECTED]> added the comment: The attached patches at least correct the XXX undetected error. -- keywords: +patch Added file: http://bugs.python.org/file11267/s26.diff ___ Python tracker <[EMAIL PROTECTED]>

[issue3694] Undetected error in _struct.pack_into

Georg Brandl <[EMAIL PROTECTED]> added the comment: The problem is that, unlike PyInt_AsSsize_t, PyLong_AsSsize_t expects its argument to already be a long object and else raises the SystemError. It should probably behave like PyInt_AsSsize_t and raise the TypeError since in 3.0 it's used in man

[issue3626] python3.0 interpreter on Cygwin ignores all arguments

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: See also issue3626 ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list ma

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: See also issue3626, which is exactly the same for cygwin. Maybe a "./configure" paragraph could discover whether mbstowcs is broken. I don't know how to do it though. -- nosy: +amaury.forgeotdarc __

[issue3696] Error parsing arguments on OpenBSD <= 4.4

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- title: mbstowcs -> Error parsing arguments on OpenBSD <= 4.4 ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3696] mbstowcs

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>: -- title: Error parsing arguments on OpenBSD <= 4.4 -> mbstowcs ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3692] improper scope in list comprehension, when used in class declaration

Georg Brandl <[EMAIL PROTECTED]> added the comment: This won't change -- in 3.0, list comprehensions and generator expressions are both implemented using a function, so it's like the following: class Foo: attribute1 = 1 def f(): return attribute1 attribute2 = f() --