[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

2008-04-15 Thread Ralf Schmitt
Ralf Schmitt <[EMAIL PROTECTED]> added the comment: me and amk are talking about the commit that introduced this bug (which was meant as a fix for another bug). neal seems to think that this commit is the fix to this bug itself. and gregory, you are now confused :) hope it's clear now.

[issue2008] cookielib lacks FileCookieJar class for Safari

2008-04-15 Thread sams.james
sams.james <[EMAIL PROTECTED]> added the comment: would you mind posting the read code you have? I would really like to at least be able to import Safari cookies in an app or two I have lying around.. -- nosy: +sams.james __ Tracker <[EMAIL PROTECTED]>

[issue2603] Make range __eq__ work

2008-04-15 Thread Alexander Belopolsky
Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: On Tue, Apr 15, 2008 at 10:21 PM, Benjamin Peterson <[EMAIL PROTECTED]> wrote: > I'm not really sure what to do about the hash. I > just removed the Py_SIZE parts. I hope that's OK. If you want to maintain hash(range(a,b,c)) == hash((

[issue2630] repr() should not escape non-ASCII characters

2008-04-15 Thread atsuo ishimoto
atsuo ishimoto <[EMAIL PROTECTED]> added the comment: Sorry, I missed to write "for interactive session". I agree for sys.stdout and other files should not have default backslashescape, but for iteractive session, I think sys.stdout can have backslasespape handler to avoid exceptions.

[issue2603] Make range __eq__ work

2008-04-15 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Attaching a new patch. I'm not really sure what to do about the hash. I just removed the Py_SIZE parts. I hope that's OK. Added file: http://bugs.python.org/file10038/range_eq4.patch __ Tracker <[EMAIL PROT

[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

2008-04-15 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: or else i'm missing something here in the maze of three bugs talking about the same issue.. which revisions fixed the introduced performance issue? __ Tracker <[EMAIL PROTECTED]>

[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

2008-04-15 Thread Gregory P. Smith
Gregory P. Smith <[EMAIL PROTECTED]> added the comment: I don't think the fix was acceptable. Now python spins consuming all cpu trying to read trivial amounts of data one byte at a time... See the discusson at the end of http://bugs.python.org/issue1092502 as well as a recent python-dev thread

[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

2008-04-15 Thread Neal Norwitz
Neal Norwitz <[EMAIL PROTECTED]> added the comment: So if the fix was applied to 2.5 branch and 2.6 (3.0 should have picked up from 2.6 automatically), can we close this bug? __ Tracker <[EMAIL PROTECTED]> ___

[issue2642] MSVCRT packing in Windows Installer (3.0a4)

2008-04-15 Thread Wesley Spikes
New submission from Wesley Spikes <[EMAIL PROTECTED]>: I've searched and did not find any open ticket to make suggestions on, so I'm posting it here. You currently have posted "The MSI installers for Python 3.0a4 are compiled with the new Visual Studio 2008 Professional version. Therefore Pyt

[issue2630] repr() should not escape non-ASCII characters

2008-04-15 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: I don't think this is a good idea; I've explained why earlier on this issue. __ Tracker <[EMAIL PROTECTED]> __ __

[issue2630] repr() should not escape non-ASCII characters

2008-04-15 Thread atsuo ishimoto
atsuo ishimoto <[EMAIL PROTECTED]> added the comment: I think sys.stdout need to have backslashreplace error handler. Without backslashreplace, print(listOfJapaneseString) prints nothing, but raises an exception. This is worse than Python2. __ Tracker <[EMAIL PR

[issue2640] "excel" csv option generates multiple lines

2008-04-15 Thread Skip Montanaro
Skip Montanaro <[EMAIL PROTECTED]> added the comment: What platform are you on? Did you open the output file in binary mode? I sort of suspect you failed to add 'b' to the file mode and are getting a text file. -- nosy: +skip.montanaro __ Tracker <[EMAI

[issue2483] int and float accept bytes, complex does not

2008-04-15 Thread Mark Dickinson
Mark Dickinson <[EMAIL PROTECTED]> added the comment: Closing this: the consensus seems to be that things are fine as they are. See the thread at http://mail.python.org/pipermail/python-3000/2008-April/013100.html for discussion. -- resolution: -> invalid _

[issue2603] Make range __eq__ work

2008-04-15 Thread Amaury Forgeot d'Arc
Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment: The patch uses Py_SIZE(v) on a rangeobject? I guess you borrowed too much from the tuple implementation ;-) __ Tracker <[EMAIL PROTECTED]> __

[issue2603] Make range __eq__ work

2008-04-15 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: Close. Just a few nits: line 298: These two fit on one line. Possibly the whole thing fits. If it doesn't, the '{' should be on a line by itself. (Are you aware of PEP 7, C code guidelines? I realize it's incomplete, but you should still

[issue2603] Make range __eq__ work

2008-04-15 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Thanks for the review! How does this look? Added file: http://bugs.python.org/file10037/range_eq_after_review.patch __ Tracker <[EMAIL PROTECTED]>

[issue2504] Add gettext.pgettext() and variants support

2008-04-15 Thread Martin v. Löwis
Changes by Martin v. Löwis <[EMAIL PROTECTED]>: -- assignee: -> loewis __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Uns

[issue1628484] Python 2.5 64 bit compile fails on Solaris 10/gcc 4.1.1

2008-04-15 Thread Martin v. Löwis
Martin v. Löwis <[EMAIL PROTECTED]> added the comment: Just to repeat my concern about this patch: It gives the impression of supporting CFLAGS, but doesn't really. There *is* a hard rule that CFLAGS given to configure should override any options passed to configure, and there is a reason for tha

[issue2632] performance problem in socket._fileobject.read

2008-04-15 Thread Curt Hagenlocher
Curt Hagenlocher <[EMAIL PROTECTED]> added the comment: At least in 2.5.2, there appear to be only two places in the standard library where an arbitrary and unchecked size is passed directly to _socketobject.recv. _fileobject.read is one such place and the other is in logging/config.py. In b

[issue2641] setuptools gets site-packages wrong on Mac

2008-04-15 Thread Jason Orendorff
New submission from Jason Orendorff <[EMAIL PROTECTED]>: On my Mac, /usr/local/bin/python2.5 is a symlink to "../../../Library/Frameworks/Python.framework/Versions/2.5/bin/python2.5". When I install Mercurial from source, the "mercurial" package is installed at "/usr/local/lib/python2.5/site-pac

[issue2504] Add gettext.pgettext() and variants support

2008-04-15 Thread Franz Glasner
Franz Glasner <[EMAIL PROTECTED]> added the comment: I have written a patch against the current Python trunk's gettext to add support for pgettext and friends (upgettext, npgettext, unpgettext, ...). I have also changed Tools/i18n/msgfmt.py to recognize the "msgctxt" keyword. Some new unittests

[issue2638] tkSimpleDialog Window Flashing

2008-04-15 Thread Guilherme Polo
Guilherme Polo <[EMAIL PROTECTED]> added the comment: Isn't overrideredirect only used to enable/disable borders in the window ? Why doing this fix what you described ? Also, make a patch against python-trunk instead of sending the entire file. -- nosy: +gpolo __

[issue2603] Make range __eq__ work

2008-04-15 Thread Guido van Rossum
Guido van Rossum <[EMAIL PROTECTED]> added the comment: Code review: Objects/rangeobject.c: line 259-260: AFAIK register is completely useless in this day and age; drop it. line 296 and further: Please move the || and && operators to the end of the previous line. line 313 etc: This all fits o

[issue2640] "excel" csv option generates multiple lines

2008-04-15 Thread Jeff Hall
New submission from Jeff Hall <[EMAIL PROTECTED]>: Current: csv.py indicates lineterminator = '\r\n' Issue: looks fine in notepad but when pulled into excel (office 2003) extra lines are added Resolution: should read lineterminator = '\r' -- components: Extension Modules messages: 65523

[issue2639] shutil.copyfile() documentation is vague

2008-04-15 Thread Roy Smith
Roy Smith <[EMAIL PROTECTED]> added the comment: Reading closer, I see that copy() has the shell-like semantics I was expecting copyfile() to have. Perhaps the right fix is to include a note in the copyfile() docs saying, "dst must be a file path; see also copy() for a version which allows ds

[issue2639] shutil.copyfile() documentation is vague

2008-04-15 Thread Roy Smith
New submission from Roy Smith <[EMAIL PROTECTED]>: The current doc says, "Copy the contents of the file named src to a file named dst". Anybody used to the unix shell "cp" command would assume that dst could be a directory, in which case the true destination is a file in that directory with t

[issue2603] Make range __eq__ work

2008-04-15 Thread Alexander Belopolsky
Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: The patch does not add unit tests for hash(range(..)). I would actually test that hash(range(a,b,c)) == hash((a,b,c)) for various values of a, b, and c. A nit-pick: while I personally like the coding style with line breaks before b

[issue2638] tkSimpleDialog Window Flashing

2008-04-15 Thread Ron Longo Work
New submission from Ron Longo Work <[EMAIL PROTECTED]>: When a Tkinter window comes up that uses tkSimpleDialog to construct a dialog box, the window first flashes on the screen as an unpopulated top-level window, before being drawn in its completed state. This problem is easily corrected by a

[issue1092502] Memory leak in socket.py on Mac OS X

2008-04-15 Thread Gregory P. Smith
Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- nosy: +gregory.p.smith _ Tracker <[EMAIL PROTECTED]> _ ___ Python-bugs-list maili

[issue2637] urllib.quote() escapes characters unnecessarily and contrary to docs

2008-04-15 Thread Tim Lesher
New submission from Tim Lesher <[EMAIL PROTECTED]>: The urllib.quote docstring implies that it quotes only characters in RFC 2396's "reserved" set. However, urllib.quote currently escapes all characters except those in an "always_safe" list, which consists of alphanumerics and three punctuation

[issue2636] Regexp 2.6 (modifications to current re 2.2.2)

2008-04-15 Thread A.M. Kuchling
Changes by A.M. Kuchling <[EMAIL PROTECTED]>: -- components: +Regular Expressions -Library (Lib) __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bu

[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

2008-04-15 Thread A.M. Kuchling
A.M. Kuchling <[EMAIL PROTECTED]> added the comment: It was applied to 2.5-maint after 2.5.2 was released, BTW, so the change isn't in any stable released version, only the 2.6 alphas. __ Tracker <[EMAIL PROTECTED]> _

[issue1628484] Python 2.5 64 bit compile fails on Solaris 10/gcc 4.1.1

2008-04-15 Thread Sérgio Durigan Júnior
Sérgio Durigan Júnior <[EMAIL PROTECTED]> added the comment: On Tue, 2008-04-15 at 02:01 +, Bob Atkins wrote: > I don't know why you are resisting this change. I took the time to > report the bug, proposed a fix /_*and*_/ contributed the patch that > would make the Python build process mor

[issue1628484] Python 2.5 64 bit compile fails on Solaris 10/gcc 4.1.1

2008-04-15 Thread Sérgio Durigan Júnior
Sérgio Durigan Júnior <[EMAIL PROTECTED]> added the comment: Hi Martin, On Mon, 2008-04-14 at 20:04 +, Martin v. Löwis wrote: > Martin v. Löwis <[EMAIL PROTECTED]> added the comment: > > > This is what you get when you try to build a 64-bit Python on a biarch > > machine (64-bit kernel, 32-

[issue2636] Regexp 2.6 (modifications to current re 2.2.2)

2008-04-15 Thread A.M. Kuchling
Changes by A.M. Kuchling <[EMAIL PROTECTED]>: -- nosy: +akuchling __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscri

[issue2630] repr() should not escape non-ASCII characters

2008-04-15 Thread atsuo ishimoto
atsuo ishimoto <[EMAIL PROTECTED]> added the comment: I revised a patch against Python 3.0a4. - As-per suggestion from Michael Urman, unicode_repr() refers unicode database to determine characters to be hex-encoded. - sys.stdout doesn't use 'backslashreplace'. Added file: http://bugs.p

[issue2636] Regexp 2.6 (modifications to current re 2.2.2)

2008-04-15 Thread Jeffrey C. Jacobs
New submission from Jeffrey C. Jacobs <[EMAIL PROTECTED]>: I am working on adding features to the current Regexp implementation, which is now set to 2.2.2. These features are to bring the Regexp code closer in line with Perl 5.10 as well as add a few python-specific niceties and potential speed-

[issue2541] Unicode escape sequences not parsed in raw strings.

2008-04-15 Thread Benjamin Peterson
Benjamin Peterson <[EMAIL PROTECTED]> added the comment: It's rejected because the OP wanted unicode escapes to be applied in unicode strings, and I haven't applied the docs because nobody has told me I should. __ Tracker <[EMAIL PROTECTED]>

[issue2439] Patch to add a get_data function to pkgutil

2008-04-15 Thread Nick Coghlan
Nick Coghlan <[EMAIL PROTECTED]> added the comment: Test file added in rev 62351 (forgot to svn add it the first time around) __ Tracker <[EMAIL PROTECTED]> __ _

[issue2439] Patch to add a get_data function to pkgutil

2008-04-15 Thread Nick Coghlan
Nick Coghlan <[EMAIL PROTECTED]> added the comment: Commited as rev 62350 -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> __ _

[issue2439] Patch to add a get_data function to pkgutil

2008-04-15 Thread Paul Moore
Paul Moore <[EMAIL PROTECTED]> added the comment: Thanks, Paul. __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe: http:/

[issue2439] Patch to add a get_data function to pkgutil

2008-04-15 Thread Nick Coghlan
Nick Coghlan <[EMAIL PROTECTED]> added the comment: I should be able to review/commit this for the next alpha (looking into it right now). -- assignee: -> ncoghlan __ Tracker <[EMAIL PROTECTED]>

[issue1628484] Python 2.5 64 bit compile fails on Solaris 10/gcc 4.1.1

2008-04-15 Thread Bob Atkins
Bob Atkins <[EMAIL PROTECTED]> added the comment: Martin, Martin v. Löwis wrote: It does not when link stage specific options are required that are not valid for compilation stages. My mistake. I was thinking of another package - you can scratch that comment. There is no hard and fast rule

[issue1225769] Proposal to implement comment rows in csv module

2008-04-15 Thread Raymond Hettinger
Raymond Hettinger <[EMAIL PROTECTED]> added the comment: -1 on the change. Comments in CSV files are not a common use case. I'm less worried about cluttering the C code and more concerned about cluttering the API, making the module harder to learn and remember. Also, it is already trivial to

[issue1225769] Proposal to implement comment rows in csv module

2008-04-15 Thread Andrew McNamara
Andrew McNamara <[EMAIL PROTECTED]> added the comment: I think it's a reasonable enough request - I've certainly had to process CSV files with comments. Iain - appologies for not looking at your request before now - 3 years is a pretty poor response time. Some thoughts: * this should target 2