thierry marked 2 inline comments as done.
thierry added inline comments.
INLINE COMMENTS
> koobs wrote in Makefile:32
> I posted a specific target because many packages do not work with a standard
> invocation.
USES=pytest can be used with this port.
REPOSITORY
R11 FreeBSD ports repository
koobs added inline comments.
INLINE COMMENTS
> sunpoet wrote in Makefile:32
> It is outdated.
> Please use USE_PYTHON=pytest instead.
> See
> https://cgit.freebsd.org/ports/commit/Mk/Uses/python.mk?id=535f310d337c0b7de64a972bc0b855bba6c6f1f0
> for details.
I posted a specific target because ma
koobs added inline comments.
INLINE COMMENTS
> sunpoet wrote in Makefile:24
> This should be USES=python:3.6+
>
> See https://github.com/joblib/threadpoolctl/blob/3.1.0/pyproject.toml#L11
Unless upstream tests with and the tests pass beyond the versions supported,
should be capped. Incomplete
sunpoet added inline comments.
INLINE COMMENTS
> koobs wrote in Makefile:32
> Upstream provides tests in their sources. If these are not packaged in the
> PyPI sdist, feel free to `USE_GITHUB` in the meantime after asking upstream
> to ship them there.
>
> Should be able to:
>
> do-test:
>
thierry marked 3 inline comments as done.
REPOSITORY
R11 FreeBSD ports repository
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D35513/new/
REVISION DETAIL
https://reviews.freebsd.org/D35513
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: thie
thierry updated this revision to Diff 107139.
thierry added a comment.
Taking koobs’s remarks into account:
- set the range of Python versions;
- build and run the tests (using the pytest helper), as an option since it
requires more dependencies.
Unfortunately, on my machine, I
koobs added inline comments.
INLINE COMMENTS
> Makefile:22
> +
> +USES=python:3.8+
> +NO_ARCH= yes
Upstream declares requires-python = ">=3.6" (capping at 3.9). Match upstream
version support declarations as closely as possible given our current
`USES=python:` syntax. 3.6-3
thierry added subscribers: Python, freebsd-python-list.
REPOSITORY
R11 FreeBSD ports repository
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D35513/new/
REVISION DETAIL
https://reviews.freebsd.org/D35513
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferen
