Re: [PyQt] Extending configure.py/siputils.py to pass CPPFLAGS

2012-06-23 Thread Scott Kitterman
On Saturday, June 23, 2012 10:15:13 AM Phil Thompson wrote: > On Sat, 23 Jun 2012 10:07:02 +0100, Andrew Suffield > > wrote: > > On Sat, Jun 23, 2012 at 09:57:56AM +0100, Phil Thompson wrote: > >> Why? Does Debian need it to be called CPPFLAGS specifically rather than > >> the already supported C

Re: [PyQt] Extending configure.py/siputils.py to pass CPPFLAGS

2012-06-23 Thread Phil Thompson
On Sat, 23 Jun 2012 10:07:02 +0100, Andrew Suffield wrote: > On Sat, Jun 23, 2012 at 09:57:56AM +0100, Phil Thompson wrote: >> Why? Does Debian need it to be called CPPFLAGS specifically rather than >> the already supported CXXFLAGS? > > I'm going to guess that you've made the common mistake. CPP

Re: [PyQt] Extending configure.py/siputils.py to pass CPPFLAGS

2012-06-23 Thread Andrew Suffield
On Sat, Jun 23, 2012 at 09:57:56AM +0100, Phil Thompson wrote: > Why? Does Debian need it to be called CPPFLAGS specifically rather than > the already supported CXXFLAGS? I'm going to guess that you've made the common mistake. CPPFLAGS is the preprocessor flags, not the C++ compiler flags. Hence i

Re: [PyQt] Extending configure.py/siputils.py to pass CPPFLAGS

2012-06-23 Thread Phil Thompson
On Fri, 22 Jun 2012 18:45:27 -0400, Scott Kitterman wrote: > In order to support Debian's goal to have a common set of default build > flags > for the distribution (with a particular focus on hardening related > changes), I > need to pass CPPFLAGS through configure. > > I came up with the attac

[PyQt] Extending configure.py/siputils.py to pass CPPFLAGS

2012-06-22 Thread Scott Kitterman
In order to support Debian's goal to have a common set of default build flags for the distribution (with a particular focus on hardening related changes), I need to pass CPPFLAGS through configure. I came up with the attached patch for sip4 0.13.3. I'd appreciate a review. It works. I won't