Re: [pve-devel] [PATCH qemu-server 1/1] Close #2443: qemu-server: add MTU option to virtio-net device

2019-12-12 Thread tacid
Thomas Lamprecht писал 2019-12-12 08:54: On 12/11/19 6:03 PM, Paul Shepel wrote: This patch adds support of QEMU host_mtu virtio-net parameter thats expose host MTU to guest Looks OK, a nit (which I can fixup locally) and a question out of interest inline. Signed-off-by: Paul Shepel ---

Re: [pve-devel] [PATCH pve-manager 1/1] Close #2443: gui: qemu/NetworkEdit: add network mtu advanced option

2019-12-12 Thread tacid
On 2019-12-12 09:25 Thomas Lamprecht wrote: First, thanks for the patch! Most seems to be adapted from surrounding code, which is OK. Some comments inline. Also, a pve-docs patch about this would be nice, to clear up things like: * MTU cannot be bigger than those used by the host in it's chai