[pve-devel] [PATCH container] lxc: fall back to 'unmanaged' on unknown ostype

2020-05-16 Thread Arnout Engelen
Rather than failing, it would be nice to fall back to 'unmanaged' when the ostype cannot be determined/found. Signed-off-by: Arnout Engelen --- src/PVE/LXC.pm | 2 +- src/PVE/LXC/Setup.pm | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/PVE/LXC.pm

Re: [pve-devel] [PATCH container] lxc: fall back to 'unmanaged' on unknown ostype

2020-05-17 Thread Arnout Engelen
On Sun, May 17, 2020 at 7:16 AM Dietmar Maurer wrote: > > Rather than failing, it would be nice to fall back to 'unmanaged' when > > the ostype cannot be determined/found. > > Why exactly would that be nice? FWICT it would start the container > with wrong and unexpected setup. It would make the s

Re: [pve-devel] [PATCH container] lxc: fall back to 'unmanaged' on unknown ostype

2020-05-17 Thread Arnout Engelen
On Sun, May 17, 2020 at 10:44 PM Thomas Lamprecht wrote: > Am 5/17/20 um 10:10 AM schrieb Arnout Engelen: > > It would make the scenario of starting an unmanaged image without explicit > > parameters work. > > I'd rather add recognizing an explicit "unmanaged"

Re: [pve-devel] [PATCH container] lxc: fall back to 'unmanaged' on unknown ostype

2020-05-18 Thread Arnout Engelen
On Mon, May 18, 2020 at 9:10 AM Thomas Lamprecht wrote: > On 5/17/20 11:03 PM, Arnout Engelen wrote: > > AFAICT the 'create CT' web UI does not currently allow setting the ostype. > > This of course could be changed/fixed, but the auto-detection that is > >

[pve-devel] [PATCH container] lxc: fall back to 'unmanaged' when no OS detected

2020-05-18 Thread Arnout Engelen
even more consistent to make 'unmanaged' a plugin next to the various OS plugins, but I wanted to keep the change as simple as possible for now. I'm afraid the whitespace gets munged by my email client, sorry about that... Signed-off-by: Arnout Engelen --- src/PVE/LXC/Setup.pm

Re: [pve-devel] [PATCH container] lxc: fall back to 'unmanaged' when no OS detected

2020-05-26 Thread Arnout Engelen
On Tue, May 26, 2020 at 11:31 AM Thomas Lamprecht wrote: > On 5/18/20 1:17 PM, Arnout Engelen wrote: > > Perhaps it would be even more consistent to make 'unmanaged' a plugin > > next to the various OS plugins, but I wanted to keep the change as > > simple as pos

[pve-devel] [PATCH container] lxc: fall back to 'unmanaged' when no OS detected

2020-05-28 Thread Arnout Engelen
This is useful when the uploaded CT does not contain a full OS. When the autodetection detects an OS, that OS is returned. When it does not successfully detect a supported OS, but /etc/os-release exists and has an ID other than 'unmanaged', then the setup fails. Signed-off-by: Arno