[pve-devel] [PATCH pve-network 1/3] add simple plugin

2020-07-01 Thread Alexandre Derumier
allow to create standalone or simple routed vnets Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Zones.pm | 1 + PVE/Network/SDN/Zones.pm | 2 + PVE/Network/SDN/Zones/Makefile| 2 +- PVE/Network/SDN/Zones/SimplePlugin.pm | 70 ++

[pve-devel] [PATCH pve-manager 2/3] sdn: move mtu from vnetview to zoneview

2020-07-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/VnetView.js | 7 +-- www/manager6/sdn/ZoneView.js | 5 + 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/sdn/VnetView.js b/www/manager6/sdn/VnetView.js index 8afb29cf..e73632d1 100644 --- a/www/manager6/sdn

[pve-devel] [PATCH pve-network 3/3] cleanup code with wrong copy/paste from Storage

2020-07-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Zones.pm | 2 +- PVE/API2/Network/SDN/Zones/Content.pm | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/PVE/API2/Network/SDN/Zones.pm b/PVE/API2/Network/SDN/Zones.pm index 3e371df..f629f43 100644 --- a/PVE/API2

[pve-devel] [PATCH pve-docs] sdn: add simple zone plugin

2020-07-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- pvesdn.adoc | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/pvesdn.adoc b/pvesdn.adoc index c1597b8..ed8652d 100644 --- a/pvesdn.adoc +++ b/pvesdn.adoc @@ -142,12 +142,22 @@ Common options nodes:: Deploy and allow to use a

[pve-devel] [PATCH pve-network 2/3] vnet: make tag optional and verify value in zone plugins

2020-07-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Vnets.pm | 15 +++ PVE/Network/SDN/VnetPlugin.pm | 5 +++-- PVE/Network/SDN/Zones/EvpnPlugin.pm | 7 +++ PVE/Network/SDN/Zones/Plugin.pm | 5 + PVE/Network/SDN/Zones/QinQPlugin.pm | 8

[pve-devel] [PATCH pve-network 0/3] add simple zone plugin

2020-07-01 Thread Alexandre Derumier
This add a new simple plugin, to create standalone/isolated bridge without any vlan tag. This can be used for routed setup or NAT bridge (I'll look to implemented NAT with subnets) Tag is now optionnal, and tag value is checked in zone plugin now. Alexandre Derumier (3): add simple plugin vn

[pve-devel] [PATCH pve-manager 1/3] sdn: vnetedit: tag optional && fix max tag value

2020-07-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/VnetEdit.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js index dfe6cb13..aa40b41f 100644 --- a/www/manager6/sdn/VnetEdit.js +++ b/www/manager6/sdn/VnetEdit

[pve-devel] [PATCH pve-manager 3/3] sdn: add simple zone plugin

2020-07-01 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile| 1 + www/manager6/Utils.js| 5 +++ www/manager6/sdn/zones/SimpleEdit.js | 53 3 files changed, 59 insertions(+) create mode 100644 www/manager6/sdn/zones/SimpleEdit.js dif

[pve-devel] [PATCH pve-manager 0/3] add simple zone plugin

2020-07-01 Thread Alexandre Derumier
Following the pve-network && pve-docs patch series Alexandre Derumier (3): sdn: vnetedit: tag optional && fix max tag value sdn: move mtu from vnetview to zoneview sdn: add simple zone plugin www/manager6/Makefile| 1 + www/manager6/Utils.js| 5 +++ www/ma

Re: [pve-devel] [PATCH container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Fabian Grünbichler
On June 30, 2020 3:56 pm, Oguz Bektas wrote: > do a simple check to see if our $opt is already in the delete section. > > Signed-off-by: Oguz Bektas > --- > src/PVE/LXC/Config.pm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm > index 0a

Re: [pve-devel] [RFC pve-qemu] Add systemd journal logging patch

2020-07-01 Thread Stefan Reiter
On 6/30/20 6:28 PM, Dietmar Maurer wrote: comments inline On 06/30/2020 2:06 PM Stefan Reiter wrote: Prints QEMU errors that occur *after* the "-daemonize" fork to the systemd journal, instead of pushing them into /dev/null like before. Signed-off-by: Stefan Reiter --- Useful for debug

[pve-devel] applied: Re: [PATCH qemu-server 02/11] update_disksize: make interface leaner

2020-07-01 Thread Thomas Lamprecht
On 20.05.20 10:20, Fabian Ebner wrote: > Pass new size directly, so the function doesn't need to know about > how some hash is organized. And return a message directly, instead > of both size-strings. Also dropped the wantarray, because both > existing callers use the message anyways. > > Signed-o

[pve-devel] applied: Re: [PATCH qemu-server 01/11] sync_disks: fix check

2020-07-01 Thread Thomas Lamprecht
On 20.05.20 10:20, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > This is a re-send of a previously stand-alone patch. > > PVE/QemuMigrate.pm | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > applied, thanks! ___ pve-devel

[pve-devel] applied: [PATCH pve-network] use PVE::Tools::split_list for ip lists

2020-07-01 Thread Fabian Grünbichler
with the following applied on-top, since we don't want declarations combined with post-if: my $foo = 'bla' if $bar; is undefined behaviour[1]. -8<- diff --git a/PVE/Network/SDN/Controllers/EvpnPlugin.pm b/PVE/Network/SDN/Controllers/EvpnPlugin.pm index 9321af1..d82de2a 100644 --- a/PVE

[pve-devel] applied: [PATCH pve-network 1/2] remove more variable declarations with post-ifs

2020-07-01 Thread Fabian Grünbichler
usage of $mtu is always guarded by an if itself anyway, so all of these are redundant post-ifs and can be removed. Signed-off-by: Fabian Grünbichler --- PVE/Network/SDN/Zones/QinQPlugin.pm | 4 ++-- PVE/Network/SDN/Zones/VlanPlugin.pm | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-)

[pve-devel] applied: [PATCH pve-network 2/2] build: fix erroneous install with empty DESTDIR

2020-07-01 Thread Fabian Grünbichler
dh calls make in the dh_auto_build step without setting DESTDIR, so the missing empty default target meant that we'd install all the files to the build system during dh_auto_build, and then install them again to the tmp build dir during dh_auto_install. obviously the former is not something we want

[pve-devel] applied: [PATCH firewall] ebtables: keep policy of custom chains

2020-07-01 Thread Fabian Grünbichler
with bug # added to commit subject. sorry for the delay, and thanks for the fix! On June 2, 2020 10:06 am, Stoiko Ivanov wrote: > currently all ebtalbes chains are created with a hardcoded policy of ACCEPT. > This patch changes the functionality to store the configured policy of a > chain while r

[pve-devel] [PATCH v2 container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Oguz Bektas
if a user tries to add a mountpoint mpX which is waiting for a pending delete, hotplugging a new mountpoint with name mpX before the previous one is detached should not be allowed. do a simple check to see if the given mpX is already in the pending delete section. Signed-off-by: Oguz Bektas ---

[pve-devel] applied: [PATCH storage 3/5] scan_cifs: do not enforce password for users

2020-07-01 Thread Thomas Lamprecht
there can be accounts with explicit null password others than the mapped guest account. Signed-off-by: Thomas Lamprecht --- PVE/Storage.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 42e769a..1de2bcb 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@

[pve-devel] applied: [PATCH storage 1/5] scan_cifs: add workgroup domain independent of user param

2020-07-01 Thread Thomas Lamprecht
they are not really bound to each other Signed-off-by: Thomas Lamprecht --- PVE/Storage.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index 9ed8c07..e2a6fd0 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -1199,10 +1199,10 @@ sub scan_

[pve-devel] applied: [PATCH storage 4/5] scan_cifs: do not add NT_STATUS lines to result

2020-07-01 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/CLI/pvesm.pm | 1 - PVE/Storage.pm | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 8c86714..c5e2d91 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -504,7 +504,6 @@ __PACKAGE__->r

[pve-devel] applied: [PATCH storage 5/5] scan storage: order scanned shares alphabetically

2020-07-01 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/CLI/pvesm.pm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index c5e2d91..4f934d6 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -434,7 +434,7 @@ __PACKAGE__->register_method ({

[pve-devel] applied: [PATCH storage 2/5] scan_cifs: pass user/pass over environment

2020-07-01 Thread Thomas Lamprecht
As command line argument they are readable by ever user in the same PID namespace. Signed-off-by: Thomas Lamprecht --- PVE/Storage.pm | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index e2a6fd0..42e769a 100755 --- a/PVE/Storage.pm

[pve-devel] applied: Re: [PATCH v3 storage 03/13] Add archive_remove

2020-07-01 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > Changes in v3: > * die if unlink of archive fails > * check whether log file exists before trying to unlink it > * warn if unlink of log file fails > > PVE/Storage.pm | 17 + > 1 file chan

[pve-devel] applied: Re: [PATCH v3 storage 02/13] Extend archive_info to include filename and logfilename

2020-07-01 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > Only expect the logfilename if the archive has a standard name. > This also gives a mechanism to get an untainted filename. > > archive_info can take either a volume ID or a path as it's > currently implemented. This is useful for vzdump when there > is no

[pve-devel] applied: Re: [PATCH v3 storage 04/13] PBSPlugin: Add print_volid helper

2020-07-01 Thread Thomas Lamprecht
On 30.06.20 10:24, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > PVE/Storage/PBSPlugin.pm | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http

[pve-devel] [PATCH vncterm 1/2] libvncserver: update sources to 0.9.13

2020-07-01 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- LibVNCServer-0.9.11.tar.gz | Bin 1413739 -> 0 bytes LibVNCServer-0.9.13.tar.gz | Bin 0 -> 567491 bytes 2 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 LibVNCServer-0.9.11.tar.gz create mode 100644 LibVNCServer-0.9.13.tar.gz diff --git

[pve-devel] [PATCH vncterm 2/2] build: rebase on libvncserver 0.9.13

2020-07-01 Thread Fabian Grünbichler
upstream switched to cmake from autotools. it is possible to drop systemd via a build option now, so use that instead of patching. Signed-off-by: Fabian Grünbichler --- Makefile | 7 +++--- vncpatches/tls-auth-pluging.patch | 41 +++ debian/

[pve-devel] [PATCH qemu-server 3/3] Use new move_config_to_node method

2020-07-01 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/QemuMigrate.pm | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index 96de0db..cd4a005 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -1179,16 +1179,9 @@ sub phase3_cleanup {

[pve-devel] [PATCH guest-common 1/3] Add move_config_to_node method

2020-07-01 Thread Fabian Ebner
Allows to mock moving the configuration for testing and reduces duplication between the migration modules by a tiny amount. Signed-off-by: Fabian Ebner --- Dependency bumps container,qemu-server -> guest-common are needed PVE/AbstractConfig.pm | 11 +++ 1 file changed, 11 insertions(+)

[pve-devel] [PATCH container 2/3] Use new move_config_to_node method

2020-07-01 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- I felt like this makes sense as a single block now (without each line being separated by a blank), but I can send a v2 without that style change if you want. Same for the next patch. src/PVE/LXC/Migrate.pm | 12 ++-- 1 file changed, 2 insertions(+), 10 de

Re: [pve-devel] [PATCH v2 container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Fabian Grünbichler
On July 1, 2020 11:56 am, Oguz Bektas wrote: > if a user tries to add a mountpoint mpX which is waiting for a pending > delete, hotplugging a new mountpoint with name mpX before the > previous one is detached should not be allowed. > > do a simple check to see if the given mpX is already in the pe

Re: [pve-devel] [PATCH container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Thomas Lamprecht
On 01.07.20 09:11, Fabian Grünbichler wrote: > - we can actually just put the new mpX into the pending queue, and > remove the entry from the pending deletion queue? (it's hotplugging > that is the problem, not queuing the pending change) Even if we could I'm not sure I want to be able to ad

Re: [pve-devel] [PATCH v2 widget-toolkit 3/5] add TimezonePanel for containers

2020-07-01 Thread Thomas Lamprecht
On 17.06.20 15:32, Oguz Bektas wrote: > with 3 modes; > - CT managed (no action) > - match host (use same timezone as host) > - select from list > > also move 'UTC' to the top of the TimezoneStore for convenience > > Signed-off-by: Oguz Bektas > --- > > v1->v2: > no changes > > > src/Makefile

[pve-devel] [PATCH qemu] PVE-Backup: remove dirty-bitmap in pvebackup_complete_cb for failed jobs

2020-07-01 Thread Dietmar Maurer
Note: We remove the device from di_list, so pvebackup_co_cleanup does not handle this case. --- pve-backup.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/pve-backup.c b/pve-backup.c index 61a8b4d2a4..1c4f6cf9e0 100644 --- a/pve-backup.c +++ b/pve-backup.c @@ -318,6 +318,12 @@ static v

Re: [pve-devel] [PATCH container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Fabian Grünbichler
On July 1, 2020 2:05 pm, Thomas Lamprecht wrote: > On 01.07.20 09:11, Fabian Grünbichler wrote: >> - we can actually just put the new mpX into the pending queue, and >> remove the entry from the pending deletion queue? (it's hotplugging >> that is the problem, not queuing the pending change)

Re: [pve-devel] [PATCH container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Thomas Lamprecht
On 01.07.20 14:43, Fabian Grünbichler wrote: > On July 1, 2020 2:05 pm, Thomas Lamprecht wrote: >> On 01.07.20 09:11, Fabian Grünbichler wrote: >>> - we can actually just put the new mpX into the pending queue, and >>> remove the entry from the pending deletion queue? (it's hotplugging >>> th

Re: [pve-devel] [PATCH container] fix #2820: block adding new volume with same id if it's pending delete

2020-07-01 Thread Oguz Bektas
fabian's variant can be done like this: --- diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 0a28380..ba5e548 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -1248,6 +1248,9

[pve-devel] Proxmox pveproxy - "to many http header lines" - issues with Cloudflare + latest Chrome

2020-07-01 Thread Victor Hooi
Hi, Google Chrome is rolling out some changes to headers (UA-CH - which causes extra headers to be included), which seems to be unearthing some latent issues with Proxmox. Specifically, in the web UI, when using the latest version of Chrome, we're getting an error message: Connection failure. Ne

[pve-devel] applied: [PATCH http-server] increase max headers to 64 to cope with modern browsers + proxy combinations

2020-07-01 Thread Thomas Lamprecht
This is mostly a "do not allow infinity headers" limit in the sense of "it's good to have limits". With modern browsers and users behind proxies we may actually get over 30 headers, so increase it for now to 64 - hopefully enough for another decade ;) Signed-off-by: Thomas Lamprecht Reported-by:

Re: [pve-devel] Proxmox pveproxy - "to many http header lines" - issues with Cloudflare + latest Chrome

2020-07-01 Thread Thomas Lamprecht
Hi, On 02.07.20 03:46, Victor Hooi wrote: > Hi, > > Google Chrome is rolling out some changes to headers (UA-CH - which causes > extra headers to be included), which seems to be unearthing some latent > issues with Proxmox. Dominik looked into this, and it seems that not only Chrome is at fault

Re: [pve-devel] [PATCH qemu] PVE-Backup: remove dirty-bitmap in pvebackup_complete_cb for failed jobs

2020-07-01 Thread Fabian Grünbichler
it should also be possible to keep the old bitmap (and associated backup checksum) in this case? this is what bitmap-mode on-success is supposed to do, but maybe errors are not triggering the right code paths? On July 1, 2020 2:17 pm, Dietmar Maurer wrote: > Note: We remove the device from di_li