Re: [pve-devel] [PATCH v6 qemu-server] vzdump: move include logic for volumes to method

2020-06-18 Thread Thomas Lamprecht
Am 6/17/20 um 2:13 PM schrieb Aaron Lauterer: > Move the logic which volumes are included in the backup job to its own > method and adapt the VZDump code accordingly. This makes it possible to > develop other features around backup jobs. > > Signed-off-by: Aaron Lauterer > --- > > v5 -> v6: crea

Re: [pve-devel] bug in backup/restore for non-64K aligned disks + host mem leak to backups

2020-06-18 Thread Roland Kammerer
On Wed, Jun 17, 2020 at 06:03:25PM +0200, Dietmar Maurer wrote: > > I initially noticed that backup/restore has a bug when the disk size is > > not a multiple of 64K for DRBD devices. > > But qemu block size is 64K, so disk size should/must always be a multiple of > 64K? hm, I think this depend

[pve-devel] [PATCH qemu-server 2/3] CPUConfig: add add_cpu_json_properties()

2020-06-18 Thread Stefan Reiter
Useful for APIs and docs. Signed-off-by: Stefan Reiter --- PVE/QemuServer/CPUConfig.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm index b884498..6250591 100644 --- a/PVE/QemuServer/CPUConfig.pm +++ b/PVE/QemuServer/CP

[pve-devel] [PATCH qemu-server 3/3] Add man page cpu-models.conf(5)

2020-06-18 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- Requires updated pve-docs. Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index cb95044..0bf3d96 100644 --- a/Makefile +++ b/Makefile @@ -52,7 +52,7 @@ qmrestore.zsh-completion: mv $@.tmp $@ PKGSOURC

[pve-devel] [PATCH docs 1/3] Add man-page and notes about custom CPU models

2020-06-18 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- Requires qemu-server with patch 2 applied. Makefile | 1 + cpu-models.conf.adoc | 82 +++ gen-cpu-models.conf.5-opts.pl | 14 ++ qm.adoc | 11 + 4 files changed, 108 ins

Re: [pve-devel] [PATCH docs 1/3] Add man-page and notes about custom CPU models

2020-06-18 Thread Aaron Lauterer
a few small nits and some suggestions on the phrasing inline On 6/18/20 11:05 AM, Stefan Reiter wrote: Signed-off-by: Stefan Reiter --- Requires qemu-server with patch 2 applied. Makefile | 1 + cpu-models.conf.adoc | 82 +++

Re: [pve-devel] [PATCH docs 1/2] zfs-local: fix #2704 add disk replacement steps for grub

2020-06-18 Thread Aaron Lauterer
ping in case this was drowned by all the other patches sent :) On 5/20/20 4:05 PM, Aaron Lauterer wrote: The documentation only covered replacing the disk with systemd-boot but not if grub is used. Signed-off-by: Aaron Lauterer --- Once this is applied and rolled out (in the Wiki), we should

Re: [pve-devel] bug in backup/restore for non-64K aligned disks + host mem leak to backups

2020-06-18 Thread Dietmar Maurer
> Don't get me wrong, I just wanted to report what IMO is a bug in a > backup tool (an actually pretty clever one looking at the format), and > that to me is the point of view that really matters here. Sure, this is clearly a bug a we should fix it - thanks for reporting. But AFAIK this does not

[pve-devel] [PATCH v2 qemu-server 2/3] CPUConfig: add add_cpu_json_properties()

2020-06-18 Thread Stefan Reiter
Useful for APIs and docs. Signed-off-by: Stefan Reiter --- PVE/QemuServer/CPUConfig.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PVE/QemuServer/CPUConfig.pm b/PVE/QemuServer/CPUConfig.pm index b884498..6250591 100644 --- a/PVE/QemuServer/CPUConfig.pm +++ b/PVE/QemuServer/CP

[pve-devel] [PATCH v2 docs 1/3] Add man-page and notes about custom CPU models

2020-06-18 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- Requires qemu-server with patch 2 applied. v2: * improved wording from Aaron's review Other patches are unchanged. Makefile | 1 + cpu-models.conf.adoc | 82 +++ gen-cpu-models.conf.5-opts.pl | 14 +

[pve-devel] [PATCH v2 qemu-server 3/3] Add man page cpu-models.conf(5)

2020-06-18 Thread Stefan Reiter
Signed-off-by: Stefan Reiter --- Requires patched pve-docs. Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index cb95044..0bf3d96 100644 --- a/Makefile +++ b/Makefile @@ -52,7 +52,7 @@ qmrestore.zsh-completion: mv $@.tmp $@ PKGSOURC

[pve-devel] [PATCH qemu-server 2/3] cfg2cmd: hostpci: move code to PCI.pm

2020-06-18 Thread Stefan Reiter
To avoid further cluttering config_to_command with subsequent changes. Signed-off-by: Stefan Reiter --- PVE/QemuServer.pm | 170 ++ PVE/QemuServer/PCI.pm | 170 ++ 2 files changed, 177 insertions(+), 163 deletion

[pve-devel] [PATCH qemu-server 3/3] fix #2794: allow legacy IGD passthrough

2020-06-18 Thread Stefan Reiter
Legacy IGD passthrough requires address 00:1f.0 to not be assigned to anything on QEMU startup (currently it's assigned to bridge pci.2). Changing this in general would break live-migration, so introduce a new hostpci parameter "legacy-igd", which if set to 1 will move that bridge to be nested unde

[pve-devel] [PATCH 0/3] fix #2794: Allow legacy-igd passthrough assignment

2020-06-18 Thread Stefan Reiter
Some Intel iGPUs support a special passthrough mode called "legacy-igd passthrough" which requires certain conditions to be true. The patches in this series include a fix for a regression in QEMU 5.0.0 which was already accepted upstream for 5.1, but is very straightforward, so it can be picked up

[pve-devel] [PATCH qemu 1/3] fix #2794: Include legacy-igd passthrough fix

2020-06-18 Thread Stefan Reiter
See https://bugs.launchpad.net/qemu/+bug/1882784 Signed-off-by: Stefan Reiter --- ...ks-Fix-broken-legacy-IGD-passthrough.patch | 34 +++ debian/patches/series | 1 + 2 files changed, 35 insertions(+) create mode 100644 debian/patches/extra/0001-hw-vfio

[pve-devel] [PATCH container] fix #2778: use vm_start instead of systemctl to start/restart container

2020-06-18 Thread Oguz Bektas
when a backup task in 'stop' mode is executed, VZDump calls 'start_vm' sub instead of 'PVE::LXC::vm_start'. 'start_vm' however does not follow our regular process but instead uses systemctl to start the container, which results in the guest hookscripts not being executed in 'pre-start' and 'post-s

Re: [pve-devel] bug in backup/restore for non-64K aligned disks + host mem leak to backups

2020-06-18 Thread Dietmar Maurer
May I request that you open a bug at: https://bugzilla.proxmox.com That way it is easier to track the bug status ... > On 06/18/2020 3:22 PM Dietmar Maurer wrote: > > > > Don't get me wrong, I just wanted to report what IMO is a bug in a > > backup tool (an actually pretty clever one looking a

[pve-devel] applied-series: [PATCH docs 1/2] zfs-local: fix #2704 add disk replacement steps for grub

2020-06-18 Thread Thomas Lamprecht
Am 5/20/20 um 4:05 PM schrieb Aaron Lauterer: > The documentation only covered replacing the disk with systemd-boot but > not if grub is used. > > Signed-off-by: Aaron Lauterer > --- > > Once this is applied and rolled out (in the Wiki), we should remove the > old steps in the ZFS tips and trick

Re: [pve-devel] [PATCH qemu-server 3/3] fix #2794: allow legacy IGD passthrough

2020-06-18 Thread Thomas Lamprecht
Am 6/18/20 um 4:36 PM schrieb Stefan Reiter: > Legacy IGD passthrough requires address 00:1f.0 to not be assigned to > anything on QEMU startup (currently it's assigned to bridge pci.2). > Changing this in general would break live-migration, so introduce a new > hostpci parameter "legacy-igd", whic

[pve-devel] applied: [PATCH container] fix #2778: use vm_start instead of systemctl to start/restart container

2020-06-18 Thread Thomas Lamprecht
Am 6/18/20 um 4:42 PM schrieb Oguz Bektas: > when a backup task in 'stop' mode is executed, VZDump calls 'start_vm' > sub instead of 'PVE::LXC::vm_start'. > > 'start_vm' however does not follow our regular process but instead uses > systemctl to start the container, which results in the guest hook

Re: [pve-devel] [PATCH v2 qemu-server 2/3] CPUConfig: add add_cpu_json_properties()

2020-06-18 Thread Thomas Lamprecht
Am 6/18/20 um 3:44 PM schrieb Stefan Reiter: > Useful for APIs and docs. > > Signed-off-by: Stefan Reiter > --- > PVE/QemuServer/CPUConfig.pm | 10 ++ > 1 file changed, 10 insertions(+) > Ah, fun times adding a new manpage ahead - the ol' dependency dance can begin ;) applied, thanks!

[pve-devel] [PATCH qemu-server] vncproxy: allow to request a generated VNC password

2020-06-18 Thread Thomas Lamprecht
We used the VNC API $ticket as password for VNC, but QEMU limits the password to the first 8 chars and ignores the rest[0]. As our tickets start with a static string (e.g., "PVE") the entropy was a bit limited. For Proxmox VE this does not matters much as the noVNC viewer provided by has to go alw

[pve-devel] [PATCH novnc-pve] POV: always request the server to generate a random password

2020-06-18 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- mostly sent along to have something to test this also with our implementation, I'd not plan to adopt it during 6.x, for us it does not matters much after all debian/patches/0001-add-pve-specific-js-code.patch | 10 ++ 1 file changed, 6 insertions(+),