[pve-devel] [PATCH widget-toolkit 2/2] add DiskSmart window and DiskList from PVE

2020-06-16 Thread Dominik Csapak
for use with other produts. the models are now all prefixed with 'pmx' instead of pve, so they should not conflict includes some changes to the model for remapping some fields and some small refactors (change to controller for the DiskList, some cleanup of the initComponent of the DiskSmart windo

[pve-devel] [PATCH manager 2/2] ui: use pmxDiskList from widget-toolkit

2020-06-16 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 - www/manager6/node/Config.js | 3 +- www/manager6/node/Disks.js | 387 3 files changed, 2 insertions(+), 389 deletions(-) delete mode 100644 www/manager6/node/Disks.js diff --git a/www/

[pve-devel] [PATCH widget-toolkit/manager] move diskrelated code to widget-toolkti

2020-06-16 Thread Dominik Csapak
so that we can reuse it. where applicable i refactored some code or added some mappings/properties, but nothing substantial proxmox-widget-toolkit: Dominik Csapak (2): add DiskSelector from PVE add DiskSmart window and DiskList from PVE src/Makefile | 3 + src/form/DiskSelecto

[pve-devel] [PATCH manager 1/2] ui: use pmxDiskSelector from widget-toolkit

2020-06-16 Thread Dominik Csapak
Signed-off-by: Dominik Csapak --- www/manager6/Makefile | 1 - www/manager6/ceph/OSD.js | 6 +-- www/manager6/form/DiskSelector.js | 80 --- www/manager6/node/Directory.js| 2 +- www/manager6/node/LVM.js | 2 +- www/manager6/node/L

[pve-devel] [PATCH widget-toolkit 1/2] add DiskSelector from PVE

2020-06-16 Thread Dominik Csapak
to be usable with other products. also add a parameter 'typeProperty' to be able to configure the backend property for the usage type Signed-off-by: Dominik Csapak --- src/Makefile | 1 + src/form/DiskSelector.js | 80 2 files changed, 81 ins

[pve-devel] applied: [PATCH widget-toolkit v2 1/4] ProxmoxProxy: add duration fields for proxmox-tasks

2020-06-16 Thread Thomas Lamprecht
Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > changes from v1: > * do not truncate the decimal places > src/data/ProxmoxProxy.js | 12 > 1 file changed, 12 insertions(+) > applied, thanks! ___ pve-

[pve-devel] applied: [PATCH widget-toolkit v2 4/4] format_duration_human: say <0.1s instead of 0s

2020-06-16 Thread Thomas Lamprecht
Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: > if we get a duration of <=0.1s it should actually be somewhere > betweeen 0 and 0.1 so return <0.1s > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * change <1s to <0.1s which is more inline with our normal display (e.g. 1.5s) > > src

[pve-devel] applied: [PATCH widget-toolkit v2 2/4] show Task warnings differently

2020-06-16 Thread Thomas Lamprecht
Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: > tasks can now show also 'WARNINGS: ' > filter it out and provide a 'parse_task_status' function for easy reuse > > Signed-off-by: Dominik Csapak > --- > src/Utils.js | 17 + > src/css/ext6-pmx.css | 4 > src/node/Tasks

Re: [pve-devel] [PATCH widget-toolkit v2 3/4] TaskViewer: show endtime and duration in status

2020-06-16 Thread Thomas Lamprecht
Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: > but only when the caller gives us the endtime, since the status > api call does not give us the endtime > > Signed-off-by: Dominik Csapak > --- > changes from v1: > * always show duration and calculate the endtime from 'now' > > src/node/Tasks.js

Re: [pve-devel] [PATCH widget-toolkit v2 3/4] TaskViewer: show endtime and duration in status

2020-06-16 Thread Dominik Csapak
On 6/16/20 11:19 AM, Thomas Lamprecht wrote: Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: but only when the caller gives us the endtime, since the status api call does not give us the endtime Signed-off-by: Dominik Csapak --- changes from v1: * always show duration and calculate the endtime f

[pve-devel] applied: [PATCH widget-toolkit v2 3/4] TaskViewer: show endtime and duration in status

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 12:26 PM schrieb Dominik Csapak: > On 6/16/20 11:19 AM, Thomas Lamprecht wrote: >> Am 6/15/20 um 4:07 PM schrieb Dominik Csapak: >>> but only when the caller gives us the endtime, since the status >>> api call does not give us the endtime >>> >>> Signed-off-by: Dominik Csapak >>> ---

[pve-devel] applied: [PATCH widget-toolkit 2/2] add DiskSmart window and DiskList from PVE

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 11:06 AM schrieb Dominik Csapak: > for use with other produts. > > the models are now all prefixed with 'pmx' instead of pve, so they > should not conflict > > includes some changes to the model for remapping some fields and > some small refactors (change to controller for the DiskL

[pve-devel] applied: [PATCH widget-toolkit 1/2] add DiskSelector from PVE

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 11:06 AM schrieb Dominik Csapak: > to be usable with other products. > also add a parameter 'typeProperty' to be able to configure > the backend property for the usage type > > Signed-off-by: Dominik Csapak > --- > src/Makefile | 1 + > src/form/DiskSelector.js | 80 ++

Re: [pve-devel] [pve-zsync] Discussion/Feedback: Extending pve-zsync to handle intervening snapshots

2020-06-16 Thread Bruce Wainer
Hi Wolfgang, Understood re: not using a flag and new copies of the functions. The reason I thought to do it that way, is that this can be seen as a change in behavior, even if the new behavior yields the same result. I come from an environment where any change shouldn't happen without the administr

[pve-devel] [PATCH manager 4/5] add timezone setting to lxc options

2020-06-16 Thread Oguz Bektas
this allows us to set the timezone of a container in the options menu. Signed-off-by: Oguz Bektas --- www/manager6/lxc/Options.js | 13 + 1 file changed, 13 insertions(+) diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js index 40bde35f..f6e457a3 100644 --- a/www

[pve-devel] [PATCH manager 5/5] add timezone option to container creation wizard

2020-06-16 Thread Oguz Bektas
renames the 'DNS' step to 'DNS / Time' and allows one to set the timezone of the container during setup. Signed-off-by: Oguz Bektas --- www/manager6/lxc/CreateWizard.js | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/www/manager6/lxc/CreateWizard.js b/www/ma

[pve-devel] [PATCH 0/5] timezones for containers

2020-06-16 Thread Oguz Bektas
this patch series implements the 'timezone' option for containers. more detailed info is in the commit messages. pve-common: Oguz Bektas (1): jsonschema: register 'timezone' format and add verification method src/PVE/JSONSchema.pm | 24 1 file changed, 24 insertion

[pve-devel] [PATCH common 1/5] jsonschema: register 'timezone' format and add verification method

2020-06-16 Thread Oguz Bektas
/usr/share/zoneinfo/zone.tab has the valid list of time zones. Signed-off-by: Oguz Bektas --- src/PVE/JSONSchema.pm | 24 1 file changed, 24 insertions(+) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index 84fb694..ff97a3d 100644 --- a/src/PVE/JSONSchema.p

[pve-devel] [PATCH container 2/5] fix #1423: add timezone config option

2020-06-16 Thread Oguz Bektas
optionally enabled. adds the 'timezone' option to config, which takes a valid timezone (i.e. Europe/Vienna) to set in the container. if nothing is selected, then it will show as 'container managed' in GUI, and nothing will be done. if set to 'host', the /etc/localtime symlink from the host node

[pve-devel] [PATCH widget-toolkit 3/5] add TimezonePanel for containers

2020-06-16 Thread Oguz Bektas
with 3 modes; - CT managed (no action) - match host (use same timezone as host) - select from list also move 'UTC' to the top of the TimezoneStore for convenience Signed-off-by: Oguz Bektas --- src/Makefile | 1 + src/data/TimezoneStore.js | 2 +- src/panel/TimezonePanel.js | 7

Re: [pve-devel] [PATCH common 1/5] jsonschema: register 'timezone' format and add verification method

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 3:36 PM schrieb Oguz Bektas: > /usr/share/zoneinfo/zone.tab has the valid list of time zones. > > Signed-off-by: Oguz Bektas > --- > src/PVE/JSONSchema.pm | 24 > 1 file changed, 24 insertions(+) > > diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.

Re: [pve-devel] Adding creation time as metadata field to VM/containers?

2020-06-16 Thread Victor Hooi
Hi, In our case, we have users clone templates via the Proxmox Web UI - so I don't think setting the description field automatically there is an option. (As in, not sure how you'd hook it into the Web UI - or is there another way to have hooks/triggers for VMs created via the Web UI). What is Dom

Re: [pve-devel] [PATCH container 2/5] fix #1423: add timezone config option

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 3:36 PM schrieb Oguz Bektas: > optionally enabled. > > adds the 'timezone' option to config, which takes a valid timezone (i.e. > Europe/Vienna) to set in the container. > > if nothing is selected, then it will show as 'container managed' in > GUI, and nothing will be done. > > if

[pve-devel] applied: [PATCH manager] dc/Tasks: pass endtime to make duration calculation correct

2020-06-16 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- www/manager6/dc/Tasks.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/Tasks.js b/www/manager6/dc/Tasks.js index b1441a72..6708d67d 100644 --- a/www/manager6/dc/Tasks.js +++ b/www/manager6/dc/Tasks.js @@ -44,7 +44,8 @@ Ex

[pve-devel] applied: [PATCH manager 2/2] ui: use pmxDiskList from widget-toolkit

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 11:06 AM schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > www/manager6/Makefile | 1 - > www/manager6/node/Config.js | 3 +- > www/manager6/node/Disks.js | 387 > 3 files changed, 2 insertions(+), 389 deletions(-) > del

[pve-devel] applied: [PATCH manager 1/2] ui: use pmxDiskSelector from widget-toolkit

2020-06-16 Thread Thomas Lamprecht
Am 6/16/20 um 11:06 AM schrieb Dominik Csapak: > Signed-off-by: Dominik Csapak > --- > www/manager6/Makefile | 1 - > www/manager6/ceph/OSD.js | 6 +-- > www/manager6/form/DiskSelector.js | 80 --- > www/manager6/node/Directory.js| 2 +- > w

[pve-devel] [PATCH pve-zsync 1/1] pve-zsync: Flip Source and Dest in functions to so jobs can share Dest

2020-06-16 Thread Bruce Wainer
Signed-off-by: Bruce Wainer --- pve-zsync | 42 +- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/pve-zsync b/pve-zsync index 347866a..f3b98c4 100755 --- a/pve-zsync +++ b/pve-zsync @@ -634,13 +634,13 @@ sub sync { my $sync_path = s

[pve-devel] [PATCH pve-zsync 0/1] Allow pve-zsync jobs to share dest

2020-06-16 Thread Bruce Wainer
By flipping Source and Dest in snapshot_get and snapshot_exist, we can allow multiple sync jobs to share the same source. snapshot_get now checks the destination instead of source, and sets last_sync to the last snapshot regardless of name. old_sync and whether to delete it is still based on the jo

Re: [pve-devel] [PATCH pve-zsync 0/1] Allow pve-zsync jobs to share dest

2020-06-16 Thread Wolfgang Link
Hi, thank you for this patch and the work. I will look at this patch and give you feedback. Regards Wolfgang > On 06/16/2020 8:53 PM Bruce Wainer wrote: > > > By flipping Source and Dest in snapshot_get and snapshot_exist, we can allow > multiple sync jobs to share the same source. > snapsho