[pve-devel] [PATCH storage 3/6] Introduce prune-backups property for directory-based storages

2020-06-04 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/Storage/CIFSPlugin.pm | 1 + PVE/Storage/CephFSPlugin.pm| 1 + PVE/Storage/DirPlugin.pm | 5 ++-- PVE/Storage/GlusterfsPlugin.pm | 5 ++-- PVE/Storage/NFSPlugin.pm | 5 ++-- PVE/Storage/PBSPlugin.pm | 1 + PVE/Storage/Plugin.pm

[pve-devel] [PATCH storage 4/6] Add prune_backups to storage API

2020-06-04 Thread Fabian Ebner
Implement it for generic storages supporting backups (i.e. directory-based storages) and add a wrapper for PBS. Signed-off-by: Fabian Ebner --- PVE/Storage.pm | 27 - PVE/Storage/PBSPlugin.pm | 50 PVE/Storage/Plugin.pm | 128 test/prune_bac

[pve-devel] [PATCH storage 6/6] Add API and pvesm calls for prune_backups

2020-06-04 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Not sure if this is the best place for the new API endpoints. I decided to opt for two distinct calls rather than just using a --dry-run option and use a worker for actually pruning, because removing many backups over the network might take a while. PVE/API2/Sto

[pve-devel] [PATCH storage 0/6] partially fix #2649: Introduce prune-backups for storages supporting backups

2020-06-04 Thread Fabian Ebner
What's still missing is to use this setting when executing backups as we do with 'maxfiles' at the moment, and also GUI integration. archive_info has been extended to include more information, mainly for being able to tell when a backup doesn't use a standard name. But the information might be use

[pve-devel] [PATCH storage 2/6] Expand archive_info to include ctime, vmid and is_std_name

2020-06-04 Thread Fabian Ebner
where 'is_std_name' shows whether the backup name uses the standard naming schema and most likely was created by our tools. Also adds a '^' to the existing filename matching regex, which should be fine since basename() is used beforehand. Signed-off-by: Fabian Ebner --- PVE/Storage.pm

[pve-devel] [PATCH storage 5/6] Whitespace cleanup

2020-06-04 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/API2/Storage/Status.pm | 65 +++--- 1 file changed, 32 insertions(+), 33 deletions(-) diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm index 14f5930..d9d9b36 100644 --- a/PVE/API2/Storage/Status.pm +++ b/PVE/

[pve-devel] [PATCH storage 1/6] PBSPlugin: list_volumes: filter by vmid if specified

2020-06-04 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- PVE/Storage/PBSPlugin.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index 3c0879c..65696f4 100644 --- a/PVE/Storage/PBSPlugin.pm +++ b/PVE/Storage/PBSPlugin.pm @@ -291,6 +291,7 @@ sub list_volumes {

Re: [pve-devel] [PATCH v2 manager 1/2] Don't show empty parentheses when size is not known

2020-06-04 Thread Fabian Ebner
Any feedback for these patches? On 5/4/20 10:50 AM, Fabian Ebner wrote: The size of VM state files and the size of unused disks not referenced by any snapshot is not saved in the VM configuration, so it's not available here either. Signed-off-by: Fabian Ebner --- Changes from v1: * use v

[pve-devel] applied: Re: [PATCH qemu-server] add virtio host_mtu feature.

2020-06-04 Thread Thomas Lamprecht
On 4/17/20 7:47 AM, Alexandre Derumier wrote: > This add a new "mtu" param to vm nic, > and force the mtu in the guest for virtio nic only. > > Special value: 1 = set the same value than the bridge > --- > PVE/QemuServer.pm | 19 +++ > 1 file changed, 19 insertions(+) > > applie

Re: [pve-devel] [PATCH storage 4/6] Add prune_backups to storage API

2020-06-04 Thread Fabian Ebner
On 6/4/20 11:08 AM, Fabian Ebner wrote: Implement it for generic storages supporting backups (i.e. directory-based storages) and add a wrapper for PBS. Signed-off-by: Fabian Ebner --- PVE/Storage.pm | 27 - PVE/Storage/PBSPlugin.pm | 50 PVE/Storage/Plugin.pm

[pve-devel] [PATCH widget-toolkit] button: make xtype of parent configurable

2020-06-04 Thread Dominik Csapak
to get the selection model of the parent, we use by default the xtype 'grid', but sometimes we want to use something else (e.g. 'treepanel') to be flexible we make this configurable Signed-off-by: Dominik Csapak --- we could of course fall back to 'treepanel' directly in the code if thats prefer

[pve-devel] applied: Re: [PATCH widget-toolkit] button: make xtype of parent configurable

2020-06-04 Thread Thomas Lamprecht
On 6/4/20 12:32 PM, Dominik Csapak wrote: > to get the selection model of the parent, we use by default the xtype > 'grid', but sometimes we want to use something else (e.g. 'treepanel') > > to be flexible we make this configurable > > Signed-off-by: Dominik Csapak > --- > we could of course fal

[pve-devel] [PATCH ifupdown2] add patch 0009-address-don-t-process_mtu-if-ovs-mtu-is-defined.patch

2020-06-04 Thread Alexandre Derumier
https://github.com/CumulusNetworks/ifupdown2/pull/166 Openvswitch already manage mtu if ovs-mtu is defined. (Ovs manage mtu in userland, and sync mtu for some interfaces in kernel). If mtu is changed by address module, before the ovs userland mtu, this give packets drop. Signed-off-by: Alexandre

[pve-devel] [PATCH manager 3/3] add by-id link as hidden column to disklist

2020-06-04 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- www/manager6/node/Disks.js | 8 1 file changed, 8 insertions(+) diff --git a/www/manager6/node/Disks.js b/www/manager6/node/Disks.js index 555956f6..7a1358ff 100644 --- a/www/manager6/node/Disks.js +++ b/www/manager6/node/Disks.js @@ -97,6 +97,14 @@ Ext.

[pve-devel] [PATCH manager 2/3] adapt zfs pool creation layout for by-id links

2020-06-04 Thread Stoiko Ivanov
hide the Serial column (the by-id link contains the same information) and add flex to all columns Signed-off-by: Stoiko Ivanov --- www/manager6/node/ZFS.js | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js index b

[pve-devel] [PATCH storage/manager] create zpools with stable disk paths

2020-06-04 Thread Stoiko Ivanov
This patchset fixes #2777. Creating zpools should be done using the more stable device paths instead of /dev/sdX. The case where this was reported was: * hotplugging 2 disks in a server * creating the zpool * rebooting (the disks got new assignments) so a not too unusual use-case. The logic for

[pve-devel] [PATCH storage 1/1] fix #2777 add by-id link to disk udev info

2020-06-04 Thread Stoiko Ivanov
when compiling the disk list add a property with a stable /dev/disk/by-id/ path for a block device when available. This is needed to create zpools with the stable by-id links The /dev/disk/by-id/ directory can contain multiple links to the same device (e.g. when it's used as a LVM PV, or one for

[pve-devel] [PATCH manager 1/3] fix #2777: create zpool with stable dev links

2020-06-04 Thread Stoiko Ivanov
If a device has a stable /dev/disk/by-id link use that instead of /dev/sdX Signed-off-by: Stoiko Ivanov --- www/manager6/node/ZFS.js | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/www/manager6/node/ZFS.js b/www/manager6/node/ZFS.js index c978f742..b8978559 100644 -

Re: [pve-devel] [PATCH storage/manager] create zpools with stable disk paths

2020-06-04 Thread Dietmar Maurer
Why do we handle this at the GUI side? I would prefer to do that on the host instead... ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: Re: [PATCH ifupdown2] add patch 0009-address-don-t-process_mtu-if-ovs-mtu-is-defined.patch

2020-06-04 Thread Thomas Lamprecht
On 6/4/20 1:33 PM, Alexandre Derumier wrote: > https://github.com/CumulusNetworks/ifupdown2/pull/166 > > Openvswitch already manage mtu if ovs-mtu is defined. > (Ovs manage mtu in userland, and sync mtu for some interfaces in kernel). > > If mtu is changed by address module, before the ovs userla

Re: [pve-devel] [PATCH storage/manager] create zpools with stable disk paths

2020-06-04 Thread Thomas Lamprecht
On 6/4/20 5:38 PM, Dietmar Maurer wrote: > Why do we handle this at the GUI side? > > I would prefer to do that on the host instead... > yeah, please. In general I'd like that the disk manage stuff adheres more to what we do in the installer - as it solved those "issues" already long ago. I.e.

Re: [pve-devel] [PATCH v2 manager 2/2] vzdump: test: add first tests to the guest include logic

2020-06-04 Thread Thomas Lamprecht
On 5/4/20 4:08 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > v1 -> v2: adapt handling of return values, closer to what is used in > production code. > in general OK, two suggestions below. > test/Makefile | 5 +- > test/vzdump_guest_included_test.pl |