[pve-devel] [PATCH manager] api: improve node index with missing/broken cert

2020-06-02 Thread Fabian Grünbichler
since this API endpoint is used for the node selector in the GUI, which causes quite widespread breakage. Signed-off-by: Fabian Grünbichler --- PVE/API2/Nodes.pm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 58497b2b..9008dcad

[pve-devel] [PATCH firewall] ebtables: keep policy of custom chains

2020-06-02 Thread Stoiko Ivanov
currently all ebtalbes chains are created with a hardcoded policy of ACCEPT. This patch changes the functionality to store the configured policy of a chain while reading the 'ebtables-save' output and uses this policy when creating the command list. This is only relevant for ebtablers chains not g

Re: [pve-devel] [PATCH firewall] ebtables: keep policy of custom chains

2020-06-02 Thread Stoiko Ivanov
missed that there was a bugzilla issue for this: this fixes #2773 On Tue, 2 Jun 2020 10:06:17 +0200 Stoiko Ivanov wrote: > currently all ebtalbes chains are created with a hardcoded policy of ACCEPT. > This patch changes the functionality to store the configured policy of a > chain while readi

[pve-devel] applied: Re: [PATCH manager] api: improve node index with missing/broken cert

2020-06-02 Thread Thomas Lamprecht
On 6/2/20 9:40 AM, Fabian Grünbichler wrote: > since this API endpoint is used for the node selector in the GUI, which > causes quite widespread breakage. > > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Nodes.pm | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > applied, th

[pve-devel] [PATCH V2 ifupdown2 10/10] add patch 0008-openvswitch-ovs-ports-condone-regex-exclude-tap-veth.patch

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- ...ports-condone-regex-exclude-tap-veth.patch | 34 +++ debian/patches/series | 1 + 2 files changed, 35 insertions(+) create mode 100644 debian/patches/pve/0008-openvswitch-ovs-ports-condone-regex-exclude-tap-veth.p

[pve-devel] [PATCH V2 ifupdown2 09/10] changelog: bump to 3.0.0-1

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- debian/changelog | 6 ++ 1 file changed, 6 insertions(+) diff --git a/debian/changelog b/debian/changelog index 7ca7226..ff13c56 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +ifupdown2 (3.0.0-1+pve1) pve; urgency=medium + + * Bum

[pve-devel] [PATCH V2 ifupdown2 01/10] remove extra patches

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- ...g-option-to-common_argparse-to-avoid.patch | 44 .../extra/0002-fix-default-forwarding.patch | 100 -- debian/patches/series | 2 - 3 files changed, 146 deletions(-) delete mode 100644 debian/patches/

[pve-devel] [PATCH V2 ifupdown2 04/10] remove 0008-add-openvswitch-addon.patch

2020-06-02 Thread Alexandre Derumier
openvswitch is now upstream add extra-patch for ovs-ports-condone-regex https://github.com/CumulusNetworks/ifupdown2/pull/157 Signed-off-by: Alexandre Derumier --- .../0001-ovs-ovs-ports-condone-regex.patch| 66 ++ .../pve/0008-add-openvswitch-addon.patch | 595 -- deb

[pve-devel] [PATCH V2 ifupdown2 05/10] add extra patch: 0002-nllistener-increase-buffer.patch

2020-06-02 Thread Alexandre Derumier
https://github.com/CumulusNetworks/ifupdown2/commit/523b347ad49234efb7787f6f084070034de7e977 Signed-off-by: Alexandre Derumier --- .../0002-nllistener-increase-buffer.patch | 25 +++ debian/patches/series | 1 + 2 files changed, 26 insertions(+) creat

[pve-devel] [PATCH V2 ifupdown2 02/10] rebase 0001-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- ...-veth-fwpr-interfaces-from-bridge-on.patch | 29 +-- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/debian/patches/pve/0001-don-t-remove-tap-veth-fwpr-interfaces-from-bridge-on.patch b/debian/patches/pve/0001-don-t-remove

[pve-devel] [PATCH V2 ifupdown2 00/10] 3.0.0-1 version

2020-06-02 Thread Alexandre Derumier
Hi, This patch series update ifupdown2 to 3.0.0-1. Please bump the proxmox git mirror to 3.0.0-1 tag. Main change python2 to python3 conversion. I have tested it since 2 weeks with differents sdn setup, I don't have seen regression. I have added extra patches from master branch, on top of 3

[pve-devel] [PATCH V2 ifupdown2 08/10] control: update python3

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- debian/control | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/debian/control b/debian/control index 62358f6..5a95659 100644 --- a/debian/control +++ b/debian/control @@ -5,12 +5,13 @@ Maintainer: Proxmox Support Team Build

[pve-devel] [PATCH V2 ifupdown2 03/10] rebase 0007-networking.service-fix-dependencies-and-ordering.patch

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- service-fix-dependencies-and-ordering.patch | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/debian/patches/pve/0007-networking.service-fix-dependencies-and-ordering.patch b/debian/patches/pve/0007-networking.servic

[pve-devel] [PATCH V2 ifupdown2 06/10] add extra patch: 0003-ovs-multiple-ovsport.patch

2020-06-02 Thread Alexandre Derumier
https://github.com/CumulusNetworks/ifupdown2/pull/164 Signed-off-by: Alexandre Derumier --- .../extra/0003-ovs-multiple-ovsport.patch | 53 +++ debian/patches/series | 1 + 2 files changed, 54 insertions(+) create mode 100644 debian/patches/extra/0003

[pve-devel] [PATCH V2 ifupdown2 07/10] add extra patch: 0004-fix-start-networking-permission.patch

2020-06-02 Thread Alexandre Derumier
https://github.com/CumulusNetworks/ifupdown2/commit/5cbe13d17a28e1ce4a411092f0bd659360406572 Signed-off-by: Alexandre Derumier --- .../0004-fix-start-networking-permission.patch | 13 + debian/patches/series | 1 + 2 files changed, 14 insertions(+)

[pve-devel] [PATCH qemu-server 2/2] fix #2774: add early check for non-managed volumes

2020-06-02 Thread Fabian Grünbichler
when checking whether a to-be-added drive's and the VM's replication status are matching. otherwise, we end up in a failing generic 'parse_volume_id' with no mention of the actual reason. adding 'replicate=0' to the new drive string fixes the underlying issue with and without this patch, so this i

[pve-devel] [PATCH qemu-server 1/2] create_disks: fix uninitialized warning

2020-06-02 Thread Fabian Grünbichler
Signed-off-by: Fabian Grünbichler --- PVE/API2/Qemu.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index fd51bf3..5e6fd42 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1095,7 +1095,7 @@ my $update_vm_api = sub { retur

[pve-devel] [PATCH V2 pve-network 4/7] catch errors on sdn config generation

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones.pm| 8 +++- PVE/Network/SDN/Zones/QinQPlugin.pm | 1 + PVE/Network/SDN/Zones/VlanPlugin.pm | 2 ++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/PVE/Network/SDN/Zones.pm b/PVE/Network/SDN/Zones.pm index b

[pve-devel] [PATCH V2 pve-network 0/7] vlanaware vnets

2020-06-02 Thread Alexandre Derumier
This ass support for vlan-aware vnets. patch1 && 2 were already submit on the mailing patch3 is a small fix to avoid packet lost on reload with ovs + qinq|vlan plugins changelog v2: add more fixes for ovs Alexandre Derumier (7): add vnet vlan-aware option vlan: ovs: use dot1q-tunnel when vla

[pve-devel] [PATCH V2 pve-network 5/7] vlan|qinq: add mtu to ovsint link port

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/QinQPlugin.pm | 1 + PVE/Network/SDN/Zones/VlanPlugin.pm | 1 + 2 files changed, 2 insertions(+) diff --git a/PVE/Network/SDN/Zones/QinQPlugin.pm b/PVE/Network/SDN/Zones/QinQPlugin.pm index 2ae2649..73c2e84 100644 --- a/PVE/Network/SDN

[pve-devel] [PATCH V2 pve-network 7/7] vlan: ovs : vlanaware: use 802.1q for tunnel

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/VlanPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Network/SDN/Zones/VlanPlugin.pm b/PVE/Network/SDN/Zones/VlanPlugin.pm index 0abe8da..edb132c 100644 --- a/PVE/Network/SDN/Zones/VlanPlugin.pm +++ b/PV

[pve-devel] [PATCH V2 pve-network 6/7] vlan: ovs: remove twice defined ovsbridge ports

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/VlanPlugin.pm | 5 - 1 file changed, 5 deletions(-) diff --git a/PVE/Network/SDN/Zones/VlanPlugin.pm b/PVE/Network/SDN/Zones/VlanPlugin.pm index 3bff970..0abe8da 100644 --- a/PVE/Network/SDN/Zones/VlanPlugin.pm +++ b/PVE/Network/SD

[pve-devel] [PATCH V2 pve-network 1/7] add vnet vlan-aware option

2020-06-02 Thread Alexandre Derumier
Some users would like to be able to defined vlans at vm level, or allow trunks, on top of already tagged vnet. (including vlan on top of vxlan tunnel) Allow it on all layer2 plugins, and add a warn for evpn layer3 plugin. Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/VnetPlugin.pm

[pve-devel] [PATCH V2 pve-network 3/7] qinq|vlan: ovs: add ovsint interfaces to ovs-ports list

2020-06-02 Thread Alexandre Derumier
if not, on reload, interfaces are unplug/replugged with packet loss. Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/QinQPlugin.pm | 4 PVE/Network/SDN/Zones/VlanPlugin.pm | 6 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/Network/SDN/Zones/QinQPlugin.

[pve-devel] [PATCH V2 pve-network 2/7] vlan: ovs: use dot1q-tunnel when vlanaware is enabled

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/VlanPlugin.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/Network/SDN/Zones/VlanPlugin.pm b/PVE/Network/SDN/Zones/VlanPlugin.pm index 8364451..987c553 100644 --- a/PVE/Network/SDN/Zones/VlanPlugin.pm ++

[pve-devel] applied: Re: [PATCH qemu-server] fix #2748: make order of interfaces consistent

2020-06-02 Thread Thomas Lamprecht
On 5/28/20 4:48 PM, Mira Limbeck wrote: > As perl hashes have random order, sort them before iterating through. > This makes the output of 'qm cloudinit dump network' consistent > between calls if the config has not changed. > > Signed-off-by: Mira Limbeck > --- > PVE/QemuServer/Cloudinit.pm |

[pve-devel] applied-series: Re: [PATCH qemu-server 1/2] create_disks: fix uninitialized warning

2020-06-02 Thread Thomas Lamprecht
On 6/2/20 10:46 AM, Fabian Grünbichler wrote: > Signed-off-by: Fabian Grünbichler > --- > PVE/API2/Qemu.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.

[pve-devel] [PATCH pve-manager 2/2] sdn: vlan : add mtu field

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/zones/VlanEdit.js | 10 ++ 1 file changed, 10 insertions(+) diff --git a/www/manager6/sdn/zones/VlanEdit.js b/www/manager6/sdn/zones/VlanEdit.js index 9060b4e5..79b6bc39 100644 --- a/www/manager6/sdn/zones/VlanEdit.js +++ b/www/mana

[pve-devel] [PATCH pve-manager 1/2] sdn: add vlan aware option to vnet

2020-06-02 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/sdn/VnetEdit.js | 7 +++ www/manager6/sdn/VnetView.js | 5 + 2 files changed, 12 insertions(+) diff --git a/www/manager6/sdn/VnetEdit.js b/www/manager6/sdn/VnetEdit.js index 9ef2b1c0..c5e3859d 100644 --- a/www/manager6/sdn/VnetEdit.js ++

[pve-devel] [PATCH pve-manager 0/2] sdn: vlanaware + vlan mtu

2020-06-02 Thread Alexandre Derumier
Patch1 is a resend with fix Patch2 add missing mtu option to vlan plugin Alexandre Derumier (2): sdn: add vlan aware option to vnet sdn: vlan : add mtu field www/manager6/sdn/VnetEdit.js | 7 +++ www/manager6/sdn/VnetView.js | 5 + www/manager6/sdn/zones/VlanEdit.js |

[pve-devel] [PATCH docs] pvesm: Add example & clarification for export

2020-06-02 Thread Dominic Jäger
The literal usage of "qcow2+size" as well as what the command is supposed to do has confused users [0]. [0] https://forum.proxmox.com/threads/trying-to-convert-raw-disk-to-vmdk-using-pvesm.70046/ --- It has also confused me and I think some other devs, too. pvesm.adoc | 8 1 file chang

[pve-devel] [PATCH storage] doc: Clarify that pvesm export is mostly internal

2020-06-02 Thread Dominic Jäger
--- PVE/CLI/pvesm.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/pvesm.pm b/PVE/CLI/pvesm.pm index 30bdcf6..8c86714 100755 --- a/PVE/CLI/pvesm.pm +++ b/PVE/CLI/pvesm.pm @@ -204,7 +204,7 @@ __PACKAGE__->register_method ({ name => 'export', path => 'expo

[pve-devel] applied: Re: [PATCH manager 1/2] ui: Replication: use render_duration from widget-toolkit

2020-06-02 Thread Thomas Lamprecht
On 5/28/20 1:02 PM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/manager6/Utils.js| 27 --- > www/manager6/grid/Replication.js | 2 +- > 2 files changed, 1 insertion(+), 28 deletions(-) > > applied, thanks! _

[pve-devel] applied: Re: [PATCH manager 2/2] css: remove icon colors

2020-06-02 Thread Thomas Lamprecht
On 5/28/20 1:02 PM, Dominik Csapak wrote: > they are now in the widget-toolkit > > Signed-off-by: Dominik Csapak > --- > www/css/ext6-pve.css | 25 - > 1 file changed, 25 deletions(-) > > applied, thanks! ___ pve-devel mailin

Re: [pve-devel] [PATCH manager 2/2] error message on failed config dump command

2020-06-02 Thread Thomas Lamprecht
On 5/28/20 4:41 PM, Alwin Antreich wrote: > Prior Ceph Nautilus the ceph config dump command was not available. > This patch provides a more meaningful info for the user. > what is the verbatim error message you get from ceph in that case? As you're now assuming that any error is dump not availa

Re: [pve-devel] [PATCH manager 1/2] Make PVE6 compatible with supported ceph versions

2020-06-02 Thread Thomas Lamprecht
On 5/28/20 4:41 PM, Alwin Antreich wrote: > Luminous, Nautilus and Octopus. In Octopus the mon_status was dropped. > Also the ceph status was cleaned up and doesn't provide the mgrmap and > monmap. > > The rados queries used in the ceph status API endpoints (cluster / node) > were factored out and

Re: [pve-devel] [PATCH manager 2/2] error message on failed config dump command

2020-06-02 Thread Alwin Antreich
On Tue, Jun 02, 2020 at 02:05:26PM +0200, Thomas Lamprecht wrote: > On 5/28/20 4:41 PM, Alwin Antreich wrote: > > Prior Ceph Nautilus the ceph config dump command was not available. > > This patch provides a more meaningful info for the user. > > > > what is the verbatim error message you get fro

Re: [pve-devel] [PATCH manager 2/2] error message on failed config dump command

2020-06-02 Thread Thomas Lamprecht
On 6/2/20 2:57 PM, Alwin Antreich wrote: > On Tue, Jun 02, 2020 at 02:05:26PM +0200, Thomas Lamprecht wrote: >> On 5/28/20 4:41 PM, Alwin Antreich wrote: >>> Prior Ceph Nautilus the ceph config dump command was not available. >>> This patch provides a more meaningful info for the user. >>> >> >> wh

[pve-devel] applied-series: Re: [PATCH manager 1/2] ui: fix missing change from 'pve-' to 'pmx-' models

2020-06-02 Thread Thomas Lamprecht
On 5/29/20 1:07 PM, Dominik Csapak wrote: > we forgot to change these > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/AuthView.js | 2 +- > www/manager6/dc/RoleView.js | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > applied series, thanks!

[pve-devel] applied-series: Re: [PATCH kernel-meta 1/2] pve-efiboot-tool: format: fix handling of disk/by-id

2020-06-02 Thread Thomas Lamprecht
On 5/19/20 9:59 AM, Aaron Lauterer wrote: > The format command will fail when using other paths like > /dev/disk/by-id/ instead of /dev/sdXY directly. It cannot find > the path /sys/block///partition path. > > The part name in /dev/disk/by-id is a symlink to /dev/sdXY. At that > point we already h