On 4/23/20 8:44 AM, Wolfgang Bumiller wrote:
>
>> On April 23, 2020 7:56 AM Thomas Lamprecht wrote:
>>
>>
>> On 4/9/20 4:10 PM, Dominik Csapak wrote:
>>> we use this format for all 'delete' options but we have some options
>>> that have a '-' in the name (e.g. 'sync-defaults-options') that cann
On April 23, 2020 7:56 am, Thomas Lamprecht wrote:
> On 4/9/20 4:10 PM, Dominik Csapak wrote:
>> we use this format for all 'delete' options but we have some options
>> that have a '-' in the name (e.g. 'sync-defaults-options') that cannot
>> be deleted if it is not included
>>
>> Signed-off-by: D
On Thu, Apr 23, 2020 at 05:52:29AM +0200, Dietmar Maurer wrote:
> > On April 22, 2020 6:00 PM Alwin Antreich wrote:
> >
> >
> > On Wed, Apr 22, 2020 at 05:35:05PM +0200, Dietmar Maurer wrote:
> > > AFAIK this can have ugly side effects ...
> > Okay, I was not aware of any know side effects.
> >
if our self-signed certificate expires in more than 825 days, but was
created after July 2019 it won't be accepted by modern Apple devices. we
fixed the issuance to generate shorter-lived certificates in November
2019, this cleans up the existing ones to fix this and similar future
issues.
two yea
I like it. Having for example one $mocked_vmlist is clean.
Two ideas for further testing (in the future):
- Passing only a subset of $types to list_volumes
- Unintended situations, like when $mocked_vmlist has a VM without type =>
list_volumes roughly does if (defined($type) && $type eq 'lxc')
Thank you for merging the test files!
Love the dropdown to set a compression:
GZIP (good)
ZSTD (better)
Tests work and creating and restoring backups in the GUI with the new option,
too.
Tested-by: Dominic Jäger
On Wed, Apr 22, 2020 at 04:57:51PM +0200, Alwin Antreich wrote:
> Zstandard (
On Thu, Apr 23, 2020 at 12:35:34PM +0200, Dominic Jäger wrote:
> Thank you for merging the test files!
No problem. I hope I didn't miss any. :)
>
> Love the dropdown to set a compression:
> GZIP (good)
> ZSTD (better)
>
> Tests work and creating and restoring backups in the GUI with the new
sometimes vendors do not put the 'rasd' namespaces in the
top level Envelope, but in every 'rasd' element
this adds a test for this
Signed-off-by: Dominik Csapak
---
this test will fail when applied, but will be corrected by the next
patch in this series (3/4)
for a real world example of this se
when one of the ovmf tests fails to parse at all,
we just get the 'die' message of the failing component, but not which
file actually failed to parse
to get better output, convert the parsing also to a test
and ok() and fail() respectively and then printing the error
Signed-off-by: Dominik Csapak
some ovfs to not declare 'rasd' as a default namespace
(in the top level Envelope element), but inline in each element
(e.g. ...)
this trips up our relative findvalue with
XPath error : Undefined namespace prefix
to avoid this, search in the global XPathContext (where we register
those namespace
also add missing '\n' at the end of error messages
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/OVF.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm
index 536e0eb..dbcc361 100644
--- a/PVE/QemuServer/OVF.pm
+++ b/PVE
LGTM
maybe we should shorten the lifespan to 1 year already?
according to [0], safari on macos will reject certs
that are longer valid than 398 days, when issued on/after
2020-09-01
0: https://support.apple.com/en-us/HT211025
On 4/23/20 12:20 PM, Fabian Grünbichler wrote:
if our self-signed ce
the subjects for this and the 2/4 patch are wrong, replace ovmf with ovf^^
(damn acronyms)
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
See [0] for the details. The call tree for the variants is
lock_config -> lock_config_full -> lock_config_mode
so it is sufficient to adapt lock_config_mode.
[0]: https://bugzilla.proxmox.com/show_bug.cgi?id=2682
Suggested-by: Fabian Grünbichler
Signed-off-by: Fabian Ebner
---
PVE/AbstractCon
No functional change is intended.
Signed-off-by: Fabian Ebner
---
PVE/AbstractConfig.pm | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/PVE/AbstractConfig.pm b/PVE/AbstractConfig.pm
index beb10c7..f1b395c 100644
--- a/PVE/AbstractConfig.pm
+++ b/PVE/AbstractConfig.pm
@
On April 23, 2020 1:07 pm, Dominik Csapak wrote:
> LGTM
>
> maybe we should shorten the lifespan to 1 year already?
> according to [0], safari on macos will reject certs
> that are longer valid than 398 days, when issued on/after
> 2020-09-01
>
> 0: https://support.apple.com/en-us/HT211025
>
fo
On 23.04.20 13:51, Fabian Ebner wrote:
See [0] for the details. The call tree for the variants is
lock_config -> lock_config_full -> lock_config_mode
so it is sufficient to adapt lock_config_mode.
[0]: https://bugzilla.proxmox.com/show_bug.cgi?id=2682
Suggested-by: Fabian Grünbichler
Signed-of
Signed-off-by: Moayad Almalat
---
ar.po | 177 +-
1 file changed, 76 insertions(+), 101 deletions(-)
diff --git a/ar.po b/ar.po
index eb09a68..cec3aa4 100644
--- a/ar.po
+++ b/ar.po
@@ -11,14 +11,14 @@ msgstr ""
"Project-Id-Version: pve-ma
nice that you cleaned up the panel :) (LGTM)
but the actual fix would be much easier ;)
since the 'total cores' is just informational
we can set
'isFormField: false'
on the totalcore field
which then will not be reset (and not tracked as a formfield)
if you do this you can drop the whole setValu
comments inline
On 4/22/20 3:39 PM, Stefan Reiter wrote:
CPU models are retrieved from the new /nodes/X/cpu call and ordered by
vendor to approximate the previous sort order (less change for accustomed
users).
With this, custom CPU models are now selectable via the GUI.
Signed-off-by: Stefan R
On 4/23/20 1:59 PM, Fabian Grünbichler wrote:
> On April 23, 2020 1:07 pm, Dominik Csapak wrote:
>> LGTM
>>
>> maybe we should shorten the lifespan to 1 year already?
>> according to [0], safari on macos will reject certs
>> that are longer valid than 398 days, when issued on/after
>> 2020-09-01
>>
On April 23, 2020 9:42 pm, Thomas Lamprecht wrote:
> On 4/23/20 1:59 PM, Fabian Grünbichler wrote:
>> On April 23, 2020 1:07 pm, Dominik Csapak wrote:
>>> LGTM
>>>
>>> maybe we should shorten the lifespan to 1 year already?
>>> according to [0], safari on macos will reject certs
>>> that are longer
22 matches
Mail list logo
