[pve-devel] [PATCH pmg-api] fix #2622: include all spem levels

2020-03-03 Thread Dominik Csapak
by using 'LIMIT 10' for the spamlevels, we only got the first 10 spamlevels back from the database (whatever they were) this is only ok if there are only <= 10 different spamlevels in the database but not if there are more the call site of this uses the combined spam count of this sub for calcula

Re: [pve-devel] [PATCH pmg-api] fix #2622: include all spem levels

2020-03-03 Thread Dominik Csapak
oops, sent to the wrong list, meant for pmg-de...@pve.proxmox.com On 3/3/20 9:33 AM, Dominik Csapak wrote: by using 'LIMIT 10' for the spamlevels, we only got the first 10 spamlevels back from the database (whatever they were) this is only ok if there are only <= 10 different spamlevels in the

Re: [pve-devel] applied: [PATCH manager] Add all standard output options that are not yet defined

2020-03-03 Thread Fabian Ebner
On 3/2/20 8:21 PM, Thomas Lamprecht wrote: On 3/2/20 10:21 AM, Fabian Ebner wrote: When a property description already contained an option, no standard output options at all would be added to it, e.g. '/nodes/NODE/vzdump' already defines its own 'quiet'. Now all not yet defined options are added

Re: [pve-devel] [PATCH pmg-api] fix #2622: include all spem levels

2020-03-03 Thread Thomas Lamprecht
subject: s/spem/spam/ On 3/3/20 9:33 AM, Dominik Csapak wrote: > by using 'LIMIT 10' for the spamlevels, we only got the first > 10 spamlevels back from the database (whatever they were) "whatever they were" is misleading, as this is ordered, so the top 10 should get returned, or? > > this is o

Re: [pve-devel] [PATCH pmg-api] fix #2622: include all spem levels

2020-03-03 Thread Dominik Csapak
On 3/3/20 10:02 AM, Thomas Lamprecht wrote: subject: s/spem/spam/ On 3/3/20 9:33 AM, Dominik Csapak wrote: by using 'LIMIT 10' for the spamlevels, we only got the first 10 spamlevels back from the database (whatever they were) "whatever they were" is misleading, as this is ordered, so the top

[pve-devel] applied: [PATCH pmg-api] fix #2622: include all spem levels

2020-03-03 Thread Thomas Lamprecht
On 3/3/20 9:33 AM, Dominik Csapak wrote: > by using 'LIMIT 10' for the spamlevels, we only got the first > 10 spamlevels back from the database (whatever they were) > > this is only ok if there are only <= 10 different spamlevels in the database > but not if there are more > > the call site of th

[pve-devel] applied: [PATCH ifupdown2] patch: don't change interface forwarding value if not defined

2020-03-03 Thread Thomas Lamprecht
On 2/24/20 3:35 PM, Alexandre Derumier wrote: > Seem that my previous patch was forgot in the 2.0 > https://github.com/CumulusNetworks/ifupdown2/pull/101 > > Without this, user with routed setup with sysctl fordwarding enable, > is removed when interface is up > > User have reported the bug here:

Re: [pve-devel] [PATCH http-server 1/1] increase allowed spiceport range

2020-03-03 Thread Thomas Lamprecht
On 3/2/20 10:32 AM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > PVE/APIServer/AnyEvent.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm > index 3ce948f..4bac1ca 100644 > --- a/PVE/APIServer/AnyEven

Re: [pve-devel] [PATCH http-server 1/1] increase allowed spiceport range

2020-03-03 Thread Dominik Csapak
On 3/3/20 10:25 AM, Thomas Lamprecht wrote: On 3/2/20 10:32 AM, Dominik Csapak wrote: Signed-off-by: Dominik Csapak --- PVE/APIServer/AnyEvent.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm index 3ce948f..4bac1ca 1

[pve-devel] [PATCH common v2 1/1] fix #2618: increase maximum port for spice to 61999

2020-03-03 Thread Dominik Csapak
and expose the range in its own sub to reuse it in http-server Signed-off-by: Dominik Csapak --- src/PVE/Tools.pm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index db4cdf7..f02c0ae 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.

[pve-devel] [PATCH common/http-server v2] fix #2618: increase number of allowed spice ports

2020-03-03 Thread Dominik Csapak
each vm needs a port to listen to for spice, and we allowed only 100 for each host, meaning the 101. vm with spice could not start for it to work, both patches have to be applied on all servers involved in the spice connection, otherwise the user cannot connect to the vm via spice also http-serve

[pve-devel] [PATCH http-server v2 1/1] increase allowed spiceport range

2020-03-03 Thread Dominik Csapak
by using the new spice_port_range sub from PVE::Tools Signed-off-by: Dominik Csapak --- PVE/APIServer/AnyEvent.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/APIServer/AnyEvent.pm b/PVE/APIServer/AnyEvent.pm index 3ce948f..664afbd 100644 --- a/PVE/APIServer/AnyEvent

[pve-devel] applied: [PATCH docs v2] pveceph: Reducing number of PGs is possible

2020-03-03 Thread Thomas Lamprecht
On 2/27/20 10:55 AM, Dominic Jäger wrote: > From Ceph Nautilus onwards reducing the number of placement groups is > possible. > > Signed-off-by: Dominic Jäger > --- > v1->v2: > - s/later/later on/ > - use {ceph_codename} > Thank you, Alwin! > > pveceph.adoc | 5 +++-- > 1 file changed, 3 i

[pve-devel] applied-series: [PATCH storage 1/2] fix #2620: storage API: iSCSI: return active field as integer

2020-03-03 Thread Thomas Lamprecht
On 3/2/20 8:52 AM, Aaron Lauterer wrote: > If active, the return value was a string: "1" and not an integer. > > Signed-off-by: Aaron Lauterer > --- > PVE/Storage/ISCSIPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/Storage/ISCSIPlugin.pm b/PVE/Storage/ISC

[pve-devel] applied: [PATCH container 3/3] fix #2611: use correct operation in get_bandwidth_limit

2020-03-03 Thread Thomas Lamprecht
On 2/25/20 4:32 PM, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > src/PVE/LXC/Migrate.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm > index 7df3c4c..6c1e9c1 100644 > --- a/src/PVE/LXC/Migrate.pm > +++ b/s

[pve-devel] applied: [PATCH qemu-server 2/3] fix #2611: use correct operation in get_bandwidth_limit

2020-03-03 Thread Thomas Lamprecht
On 2/25/20 4:32 PM, Stefan Reiter wrote: > Signed-off-by: Stefan Reiter > --- > PVE/QemuMigrate.pm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxm

Re: [pve-devel] [PATCH ifupdown2] add ifupdown2-pre.service service

2020-03-03 Thread Alexandre DERUMIER
>>hmm, can we not just add a after dependency in the "networking.service" on >>the >>already existing "systemd-udev-settle.service" service? this was the first proposal in the discuss https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=920623 https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;b