[pve-devel] [PATCH qemu-server] Fix description for vm_config and change description for vm_pending

2020-02-04 Thread Fabian Ebner
The description for vm_config was out of date and from the description for vm_pending it was hard to tell what the difference to vm_config was. Signed-off-by: Fabian Ebner --- PVE/API2/Qemu.pm | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/

Re: [pve-devel] [PATCH docs 1/2] document API tokens

2020-02-04 Thread Fabian Grünbichler
On February 3, 2020 9:43 am, Aaron Lauterer wrote: > Inline suggestions for restructuring some paragraphs for an easier > understanding and some other small things. > I hope I didn't lose information in the restructured paragraphs. > > On 1/30/20 1:54 PM, Fabian Grünbichler wrote: >> Signed-off-b

[pve-devel] [PATCH manager] fix #2574: filter duplicate storage paths in ACL selector

2020-02-04 Thread Fabian Grünbichler
we don't need one entry per storage per node, since ACLs just operate on the storage ID and don't care about the node. use the fact that record IDs are unique in ExtJS stores, and just re-use our ACL 'ID' as record ID. Signed-off-by: Fabian Grünbichler --- we could also re-define contains to fil

Re: [pve-devel] [PATCH manager] fix #2574: filter duplicate storage paths in ACL selector

2020-02-04 Thread Dominik Csapak
lgtm, one comment inline On 2/4/20 11:09 AM, Fabian Grünbichler wrote: we don't need one entry per storage per node, since ACLs just operate on the storage ID and don't care about the node. use the fact that record IDs are unique in ExtJS stores, and just re-use our ACL 'ID' as record ID. Sign

Re: [pve-devel] [PATCH manager v2 1/2] Fix #2124: Add support for zstd

2020-02-04 Thread Alwin Antreich
On Mon, Feb 03, 2020 at 05:51:38PM +0100, Stefan Reiter wrote: > On 1/31/20 5:00 PM, Alwin Antreich wrote: > > Adds the zstd to the compression selection for backup on the GUI and the > > .zst extension to the backup file filter. > > > > Signed-off-by: Alwin Antreich > > --- > > > > PVE/VZDump

[pve-devel] [PATCH 1/2] vzdump: handle pigz property string

2020-02-04 Thread Moayad Almalat
From: Moayad Signed-off-by: Moayad --- PVE/VZDump.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 3caa7ab8..0f04d4db 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -405,6 +405,10 @@ sub new { } } +if (defin

[pve-devel] [PATCH 2/2] fix #2559: vzdump: handle pigz blocksize property

2020-02-04 Thread Moayad Almalat
From: Moayad potentially improves backup speed. Signed-off-by: Moayad --- PVE/VZDump.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 0f04d4db..232f0550 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -592,7 +592,12 @@ sub compr

[pve-devel] [PATCH v2 manager 2/3] vzdump: handle pigz property string

2020-02-04 Thread Moayad Almalat
From: Moayad Signed-off-by: Moayad --- PVE/VZDump.pm | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 3caa7ab8..0f04d4db 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -405,6 +405,10 @@ sub new { } } +if (defin

[pve-devel] [PATCH v2 manager 3/3] fix #2559: vzdump: handle pigz blocksize property

2020-02-04 Thread Moayad Almalat
From: Moayad potentially improves backup speed. Signed-off-by: Moayad --- PVE/VZDump.pm | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 0f04d4db..232f0550 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -592,7 +592,12 @@ sub compr

[pve-devel] [PATCH v2 guest-common 1/3] vzdump.conf: make pigz a property string

2020-02-04 Thread Moayad Almalat
From: Moayad and add blocksize property. Signed-off-by: Moayad --- PVE/VZDump/Common.pm | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/PVE/VZDump/Common.pm b/PVE/VZDump/Common.pm index 4789a50..0ee7aba 100644 --- a/PVE/VZDump/Common.pm +++ b/PVE

[pve-devel] applied: [PATCH qemu-server] fix #2578: check if $target is provided in clone

2020-02-04 Thread Fabian Grünbichler
using following variant to improve readability: diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index e15c0c3..18fb8fd 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -2751,10 +2751,10 @@ __PACKAGE__->register_method({ if ($target && ($target eq $localnode || $target eq 'localho

[pve-devel] applied: [PATCH qemu-server] Fix description for vm_config and change description for vm_pending

2020-02-04 Thread Fabian Grünbichler
On February 4, 2020 9:41 am, Fabian Ebner wrote: > The description for vm_config was out of date and from the description > for vm_pending it was hard to tell what the difference to vm_config was. > > Signed-off-by: Fabian Ebner > --- > PVE/API2/Qemu.pm | 7 --- > 1 file changed, 4 insertion

[pve-devel] applied: [PATCH widget-toolkit] ComboGrid: fix validation for !allowBlank disabled fields

2020-02-04 Thread Thomas Lamprecht
Am 2/3/20 um 3:14 PM schrieb Stefan Reiter: > Used in "Add USB to VM" dialog for example. > > This was broken before 15206214d9 "ComboGrid: fix on-load validation for blank > values" (only the one you enabled first was validated, the other always showed > as valid), and afterwards too, but in a di

Re: [pve-devel] [PATCH v2 guest-common 1/3] vzdump.conf: make pigz a property string

2020-02-04 Thread Thomas Lamprecht
Am 2/4/20 um 3:56 PM schrieb Moayad Almalat: > From: Moayad > > and add blocksize property. > > Signed-off-by: Moayad > --- Thanks for the patches, I'll will take a closer look today, a general comment below: You sent a v2 without telling what changed, please always add a short changelog, li