Re: [pve-devel] [RFC manager 1/2] api: backup: Add endpoint for disk included status

2019-12-13 Thread Fabian Grünbichler
On December 12, 2019 11:27 am, Aaron Lauterer wrote: > This endpoint provides information if disks and mountpoints of guests are > included in a VZDump job. > > The returned object is formatted to be used with the TreePanel of ExtJS. > > Signed-off-by: Aaron Lauterer > --- > > Unfortunately the

[pve-devel] [PATCH v2 qemu-server 2/3] add error handling to vmconfig_apply_pending

2019-12-13 Thread Oguz Bektas
--- PVE/API2/Qemu.pm | 6 +++--- PVE/QemuServer.pm | 9 - 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 3c7ef30..baa96f2 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/API2/Qemu.pm @@ -1241,13 +1241,13 @@ my $update_vm_api = sub {

[pve-devel] [PATCH v2 qemu-server 1/3] hotplug_pending: remove redundant write/load config calls

2019-12-13 Thread Oguz Bektas
instead of writing the config after every change, we can do it once for all the changes in the end to avoid redundant i/o. we also don't need to load_config after writing fastplug changes. Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 9 ++--- 1 file changed, 2 insertions(+), 7 deletio

[pve-devel] [PATCH v2 qemu-server 3/3] apply_pending: handle errors gracefully and remove redundant config write calls

2019-12-13 Thread Oguz Bektas
wrap code in eval to handle errors gracefully. that way we can replace redundant write/load config calls with a single write_config at the end to avoid unnecessary i/o Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 52 +++ 1 file changed, 26 inser

[pve-devel] [PATCH manager] API: OSD: Fix #2496 Check OSD Network

2019-12-13 Thread Aaron Lauterer
It's possible to have a situation where the cluster network (used for inter-OSD traffic) is not configured on a node. The OSD can still be created but can't communicate. This check will abort the creation if there is no IP within the subnet of the cluster network present on the node. If there is n

Re: [pve-devel] [PATCH manager] API: OSD: Fix #2496 Check OSD Network

2019-12-13 Thread Alwin Antreich
Some comments inline. On Fri, Dec 13, 2019 at 03:56:42PM +0100, Aaron Lauterer wrote: > It's possible to have a situation where the cluster network (used for > inter-OSD traffic) is not configured on a node. The OSD can still be > created but can't communicate. > > This check will abort the creat