>>You added quite a lot already, nice! The origin of the DC -> SDN section
>>seems
>>to be the permission one, at least judging from the icons :P
Yes, I'm totally lacking of ideas for icons ;)
If I try to create a zone I get:
> create sdn zone object failed: error with cfs lock 'file-sdn_zon
some more nits, in addition to what Dominik and Thomas already said ;)
On November 26, 2019 3:27 pm, Stoiko Ivanov wrote:
> Installation on disks with 4k logical blocksize (4kn) failed, because the
> bios_boot (a.k.a. gdisk partitiontype EF02, place for grub in legacy BIOS
> boot mode) partition i
On November 25, 2019 7:56 pm, Thomas Lamprecht wrote:
> Signed-off-by: Thomas Lamprecht
> ---
>
> Mostly just line-wrapping, as:
> # git show --word-diff=color --word-diff-regex=.
> tells you. Sorry, to lazy to split that up :)
>
> data/PVE/DataCenterConfig.pm | 17 ++---
> 1 file
On 11/27/19 9:24 AM, Fabian Grünbichler wrote:
> On November 25, 2019 7:56 pm, Thomas Lamprecht wrote:
>> Signed-off-by: Thomas Lamprecht
>> ---
>>
>> Mostly just line-wrapping, as:
>> # git show --word-diff=color --word-diff-regex=.
>> tells you. Sorry, to lazy to split that up :)
>>
>> data/PV
On 11/26/19 4:18 PM, Oguz Bektas wrote:
hi,
found an issue here:
1 - create a new mp on running container
2 - mp gets added as pending, but disk is not created yet
3 - revert the pending mp
4 - this adds an unused disk, which doesn't exist and can't be removed via GUI
when i try to revert a new
On November 27, 2019 9:39 am, Fabian Ebner wrote:
> On 11/26/19 4:18 PM, Oguz Bektas wrote:
>> hi,
>>
>> found an issue here:
>> 1 - create a new mp on running container
>> 2 - mp gets added as pending, but disk is not created yet
>> 3 - revert the pending mp
>> 4 - this adds an unused disk, which
Signed-off-by: Thomas Lamprecht
---
www/manager6/dc/OptionView.js | 43 +--
1 file changed, 42 insertions(+), 1 deletions(-)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index dd585b7b..79494b6d 100644
--- a/www/manager6/dc/OptionView
Signed-off-by: Thomas Lamprecht
---
I talked a bit with Dominik, while he prefered to use a hidden field for the
"real" value and a dummy field for the user editing side with the transformed
value it was not really easier than this, even if it might be the less
"hackier" or a bit nicer interface.
Signed-off-by: Stefan Reiter
---
qm-pci-passthrough.adoc | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
index c1bca7c..abb9075 100644
--- a/qm-pci-passthrough.adoc
+++ b/qm-pci-passthrough.adoc
@@ -149,7
This patch enables the backup checkbox by default for newly created
LXC mount points, aligning it with the behaviour when adding disks to
VMs. There new disks are automatically part of backups. If it is not
wanted it needs to be actively disabled in the advanced section.
Hopefully this will help t
hi,
tested and works as expected, although one thing i'd change is the
variable name 'isBackedUp'. it sounds a bit like there's already a
backup present for the mp.
maybe something like 'enableBackup' or similar?
On Wed, Nov 27, 2019 at 11:49:38AM +0100, Aaron Lauterer wrote:
> This patch enable
The size of an unused volume is not visible to the user and trying to resize
an unused volume runs into a 'parameter verification failed' anyways.
Signed-off-by: Fabian Ebner
---
www/manager6/lxc/Resources.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/www/manager6/lxc/
since 'pvesm export' and 'pvesm import' are connected via a pipe and
SSH, a fatal error in the former can lead to no valid header being
written to the pipe. handle this more gracefully by printing an easier
to understand error message, instead of uninitialized warnings with no
context.
Signed-off-
Signed-off-by: Fabian Grünbichler
---
PVE/Storage/Plugin.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
index 963c391..d0f1df6 100644
--- a/PVE/Storage/Plugin.pm
+++ b/PVE/Storage/Plugin.pm
@@ -1116,7 +1116,7 @@ sub read_common
good to go
Tested-by: Oguz Bektas
On Wed, Nov 27, 2019 at 01:01:48PM +0100, Fabian Ebner wrote:
> The size of an unused volume is not visible to the user and trying to resize
> an unused volume runs into a 'parameter verification failed' anyways.
>
> Signed-off-by: Fabian Ebner
> ---
> www/ma
On 11/27/19 1:48 PM, Fabian Grünbichler wrote:
> since 'pvesm export' and 'pvesm import' are connected via a pipe and
> SSH, a fatal error in the former can lead to no valid header being
> written to the pipe. handle this more gracefully by printing an easier
> to understand error message, instead
On 11/27/19 1:48 PM, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler
> ---
> PVE/Storage/Plugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
> index 963c391..d0f1df6 100644
> --- a/PVE/Storage/Plugin.pm
>
From: Stefan Reiter
Signed-off-by: Stefan Reiter
Signed-off-by: Oguz Bektas
---
www/manager6/form/DiskStorageSelector.js | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/www/manager6/form/DiskStorageSelector.js
b/www/manager6/form/DiskStorageSelector.js
index 4
On 11/27/19 12:13 PM, Oguz Bektas wrote:
hi,
tested and works as expected, although one thing i'd change is the
variable name 'isBackedUp'. it sounds a bit like there's already a
backup present for the mp.
maybe something like 'enableBackup' or similar?
What about 'isBackupIncluded'? 'enab
otherwise, an api error leads to an empty UserView, and the user
wonders why no users show up
Signed-off-by: Dominik Csapak
---
www/manager6/dc/UserView.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/dc/UserView.js b/www/manager6/dc/UserView.js
index 8918fb2b..922d072b 100
On 11/27/19 4:05 PM, Aaron Lauterer wrote:
>
>
> On 11/27/19 12:13 PM, Oguz Bektas wrote:
>> hi,
>>
>> tested and works as expected, although one thing i'd change is the
>> variable name 'isBackedUp'. it sounds a bit like there's already a
>> backup present for the mp.
>>
>> maybe something like
On 11/27/19 4:27 PM, Dominik Csapak wrote:
> otherwise, an api error leads to an empty UserView, and the user
> wonders why no users show up
>
> Signed-off-by: Dominik Csapak
> ---
> www/manager6/dc/UserView.js | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/www/manager6/dc/UserView.
On 11/26/19 1:10 PM, Christian Ebner wrote:
> Example:
> pvesh get /nodes/{node}/qemu/{vmid}/rrddata --timeframe day
>
> If the sorting key is not defined in the dataset, e.g. when a VM was not
> running
> for some time within the given timeframe, this resulted in several ugly
> warnings.
>
currently only the first vdev of a ZFS rpool gets created with the stable
/dev/by-id paths, all later vdevs (in a RAID0 or RAID10 setup) are left as
sdX.
By iterating over all disks in the pool and replacing their occurence with
their by-id path we get consistent and recommended names for all vdev
by wiping the partition table after the initial sanity checks regarding
minimal size and blocksize of the device, no data is destroyed for an
install that would fail in any case.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/pr
in preparation for 4kn installer support add the logical_blocksize to each
disk found.
Signed-off-by: Stoiko Ivanov
---
proxinstall | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/proxinstall b/proxinstall
index 1a5acc5..fec9772 100755
--- a/pr
This patchset adds support for installing on 4kn disks.
v1->v2:
* Dominik suggested to do it correctly - so i tried, which resulted in a
rather different structure of the patch :)
* Instead of checking the logical blocksize before partitioning the info now
gets collected into the hd list, whic
Installation on disks with 4k logical blocksize (4kn) failed, because the
bios_boot (a.k.a. gdisk partitiontype EF02, place for grub in legacy BIOS
boot mode) partition is created using start and end sectors (and sector 2047
is not at 1M, where the ESP starts)
This patch addresses the issue by not
Signed-off-by: Stoiko Ivanov
---
proxinstall | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/proxinstall b/proxinstall
index fec9772..d81d71d 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1294,8 +1294,12 @@ sub extract_data {
partition_bo
/sys/block/$dev/size is also given in 512b sectors even for 4kn disks.
Since it surprised me - mention it explicitly in the comment
Signed-off-by: Stoiko Ivanov
---
proxinstall | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxinstall b/proxinstall
index 5d02b34..1a5acc5 1
in some languages (e.g. German) the default (100) is too short for some labels,
resulting in cut-off text. We often use 120 in such cases, so we should
do here as well
Signed-off-by: Dominik Csapak
---
www/manager6/dc/OptionView.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6
On 11/27/19 4:50 PM, Thomas Lamprecht wrote:
On 11/27/19 4:05 PM, Aaron Lauterer wrote:
On 11/27/19 12:13 PM, Oguz Bektas wrote:
hi,
tested and works as expected, although one thing i'd change is the
variable name 'isBackedUp'. it sounds a bit like there's already a
backup present for the
On 11/27/19 5:31 PM, Dominik Csapak wrote:
> in some languages (e.g. German) the default (100) is too short for some
> labels,
> resulting in cut-off text. We often use 120 in such cases, so we should
> do here as well
>
> Signed-off-by: Dominik Csapak
> ---
> www/manager6/dc/OptionView.js | 1
On 11/27/19 5:06 PM, Stoiko Ivanov wrote:
> This patchset adds support for installing on 4kn disks.
>
> v1->v2:
> * Dominik suggested to do it correctly - so i tried, which resulted in a
> rather different structure of the patch :)
> * Instead of checking the logical blocksize before partitionin
On Wed, Nov 27, 2019 at 07:19:02PM +0100, Thomas Lamprecht wrote:
> On 11/27/19 5:06 PM, Stoiko Ivanov wrote:
> > This patchset adds support for installing on 4kn disks.
> >
> > v1->v2:
> > * Dominik suggested to do it correctly - so i tried, which resulted in a
> > rather different structure of
Signed-off-by: Thomas Lamprecht
---
www/manager6/dc/OptionView.js | 3 +++
1 file changed, 3 insertions(+)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index d98e7351..d8eaf848 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -23,6 +
Signed-off-by: Thomas Lamprecht
---
PVE/VZDump/QemuServer.pm | 4
1 file changed, 4 insertions(+)
diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index 1826edb..3d9c61a 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -417,9 +417,12 @@ sub archive {
37 matches
Mail list logo
