[pve-devel] [PATCH container] fix bindmounting with staged mount points

2019-11-26 Thread Wolfgang Bumiller
We still passed the target mount path to bindmount() causing bindmount_verify() to fail. Fix this by assuming '/' as the in-container target mount path when staging, as we mount onto the $rootdir instead. Signed-off-by: Wolfgang Bumiller --- src/PVE/LXC.pm | 6 +- 1 file changed, 5 insertion

[pve-devel] applied: [PATCH container] fix bindmounting with staged mount points

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 9:03 AM, Wolfgang Bumiller wrote: > We still passed the target mount path to bindmount() causing > bindmount_verify() to fail. Fix this by assuming '/' as the > in-container target mount path when staging, as we mount > onto the $rootdir instead. > > Signed-off-by: Wolfgang Bumiller >

[pve-devel] [PATCH v2 pve-network 00/15] sdn: split vnets/zones/controllers plugins + improvments

2019-11-26 Thread Alexandre Derumier
Split code in different plugins (vnets/zones/controllers) for better maintenance and readability Changelog V2: lot of cleanup, permissions, some plugins rework (sorry that's a lot of patches) Alexandre Derumier (15): split transport/controllers/vnet to separate plugins api2 : split vnets/zo

[pve-devel] [PATCH v2 pve-network 03/15] api2: sdn: add reload config

2019-11-26 Thread Alexandre Derumier
fixme: current using pvesh Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 65 + PVE/API2/Network/SDN/Controllers.pm | 24 --- PVE/API2/Network/SDN/Vnets.pm | 24 --- PVE/API2/Network/SDN/Zones.pm | 24 ---

[pve-devel] [PATCH v2 pve-network 02/15] api2 : split vnets/zones/controllers

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/Makefile | 1 - PVE/API2/Network/SDN.pm | 310 +++- PVE/API2/Network/SDN/Controllers.pm | 288 ++ PVE/API2/Network/SDN/Makefile | 4 +- PVE/API2/N

[pve-devel] [PATCH v2 pve-network 04/15] update documentation.txt

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- test/documentation.txt | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/test/documentation.txt b/test/documentation.txt index 3f70987..8b78d46 100644 --- a/test/documentation.txt +++ b/test/documentation.txt @@ -2,3

[pve-devel] [PATCH v2 pve-network 07/15] remove vxlan|vlan allowed zone option

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Zones/EvpnPlugin.pm | 25 --- PVE/Network/SDN/Zones/FaucetPlugin.pm | 1 - PVE/Network/SDN/Zones/QinQPlugin.pm | 2 -- PVE/Network/SDN/Zones/VlanPlugin.pm | 27 - PVE/Network/SDN/Zones/VxlanP

[pve-devel] [PATCH v2 pve-cluster 0/1] sdn: split vnets/zones/controllers plugins

2019-11-26 Thread Alexandre Derumier
Following the pve-network patch series v2 Alexandre Derumier (1): add sdn vnets/zones/controllers.cfg data/PVE/Cluster.pm | 9 +++-- data/src/status.c | 8 ++-- 2 files changed, 13 insertions(+), 4 deletions(-) -- 2.20.1 ___ pve-devel ma

[pve-devel] [PATCH v2 pve-network 13/15] evpn zone plugin : remove vrf option

2019-11-26 Thread Alexandre Derumier
instead, use zone name as vrf Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers.pm| 2 +- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 4 +--- PVE/Network/SDN/Zones/EvpnPlugin.pm | 19 +++ test/documentation.txt| 2 +- 4 fil

[pve-devel] [PATCH v2 pve-network 09/15] rename frrevpn controller plugin to evpn plugin

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Controllers.pm | 2 +- PVE/Network/SDN/Controllers.pm| 4 +- .../{FrrEvpnPlugin.pm => EvpnPlugin.pm} | 4 +- PVE/Network/SDN/Controllers/Makefile | 2 +- PVE/Network/SDN/Zones/EvpnPlugin.pm

[pve-devel] [PATCH v2 pve-network 05/15] rename transportzone option to zone

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Zones/Content.pm | 4 ++-- PVE/API2/Network/SDN/Zones/Status.pm | 4 ++-- PVE/Network/SDN/Controllers.pm| 2 +- PVE/Network/SDN/Zones.pm | 14 +++--- PVE/Network/SDN/Zones/EvpnPlugin.pm | 2 +- PVE/Netw

[pve-devel] [PATCH v2 pve-network 01/15] split transport/controllers/vnet to separate plugins

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Network/SDN.pm| 297 +- PVE/Network/SDN/Controllers.pm| 158 ++ .../FaucetPlugin.pm} | 14 +- .../FrrEvpnPlugin.pm} | 21 +- PVE/Network

[pve-devel] [PATCH v2 pve-network 08/15] add nodes option to zones

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Zones.pm | 4 PVE/Network/SDN/Zones.pm | 8 PVE/Network/SDN/Zones/EvpnPlugin.pm | 1 + PVE/Network/SDN/Zones/FaucetPlugin.pm | 1 + PVE/Network/SDN/Zones/Plugin.pm | 29 ++

[pve-devel] [PATCH v2 pve-network 10/15] fix zones on_update_hook

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Zones.pm | 22 +- PVE/Network/SDN/Zones/EvpnPlugin.pm | 63 ++- PVE/Network/SDN/Zones/FaucetPlugin.pm | 6 --- PVE/Network/SDN/Zones/Plugin.pm | 2 +- 4 files changed, 37 insertions(+), 56

[pve-devel] [PATCH v2 pve-cluster 1/1] add sdn vnets/zones/controllers.cfg

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- data/PVE/Cluster.pm | 9 +++-- data/src/status.c | 8 ++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 2057162..c1d8b09 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@

[pve-devel] [PATCH v2 pve-network 15/15] controller: evpn: use frr-reload.py for reloading frr

2019-11-26 Thread Alexandre Derumier
vtysh is not enough to cleanly reload configuration This require frr-pythontools package Also add default global values or frr-reload will try to remove them each time Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/EvpnPlugin.pm | 22 ++ 1 file changed, 18

[pve-devel] [PATCH pve-access-control 1/1] add SDN.Allocate && SDN.Audit privileges

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/AccessControl.pm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm index ad97a42..4e9deea 100644 --- a/PVE/AccessControl.pm +++ b/PVE/AccessControl.pm @@ -683,6 +683,16 @@ my $privgroups = {

[pve-devel] [PATCH v2 pve-network 14/15] cleanup old transport/router/sdn_cfg references

2019-11-26 Thread Alexandre Derumier
use zone/controller... Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Controllers.pm | 24 ++--- PVE/API2/Network/SDN/Zones/Content.pm | 6 +- PVE/API2/Network/SDN/Zones/Status.pm| 6 +- PVE/Network/SDN.pm | 4 +- PVE/Network/SDN/

[pve-devel] [PATCH v2 pve-network 12/15] limit vnet/zones/controller to 10 characters

2019-11-26 Thread Alexandre Derumier
linux have 16 characters limit for interfaces, but we can prepend "vxlan", "vrf",... when we generate interfaces Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Controllers/Plugin.pm | 5 +++-- PVE/Network/SDN/VnetPlugin.pm | 5 +++-- PVE/Network/SDN/Zones/Plugin.pm | 7 -

[pve-devel] [PATCH v2 pve-network 11/15] add permissions

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN.pm | 8 +++--- PVE/API2/Network/SDN/Controllers.pm | 36 +-- PVE/API2/Network/SDN/Vnets.pm | 36 +-- PVE/API2/Network/SDN/Zones.pm | 36 +

[pve-devel] [PATCH v2 pve-network 06/15] improve status error description

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network/SDN/Zones/Content.pm | 6 ++ PVE/Network/SDN/Zones.pm | 16 ++-- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Network/SDN/Zones/Content.pm b/PVE/API2/Network/SDN/Zones/Content.pm inde

[pve-devel] [PATCH v2 pve-manager 3/4] api2 : nodes : use zones api status

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Nodes.pm | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index ddeafbef..f0d062d5 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -54,7 +54,7 @@ use Socket; my $have_sdn;

[pve-devel] [PATCH v2 pve-manager 1/4] pvestatd: fix require PVE::Network::SDN

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Service/pvestatd.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index b789b819..3f539b21 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/pvestatd.pm @@ -35,7 +35,7 @@ use bas

[pve-devel] [PATCH v2 pve-manager 2/4] api2 : reload : use zones/controllers sdn plugins

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Network.pm | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index fa605ba7..5e5cb5fd 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -18,7 +18,8 @

[pve-devel] [PATCH v2 pve-manager 0/4] sdn: split vnets/zones/controllers plugins + gui

2019-11-26 Thread Alexandre Derumier
Following the pve-network patch series Changelog v2: - rebase on last master git - add sdn gui Alexandre Derumier (4): pvestatd: fix require PVE::Network::SDN api2 : reload : use zones/controllers sdn plugins api2 : nodes : use zones api status add sdn gui PVE/API2/Network.pm

[pve-devel] [PATCH v2 pve-manager 4/4] add sdn gui

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- www/manager6/Makefile | 17 +++ www/manager6/Makefile.rej | 9 ++ www/manager6/StateProvider.js | 4 +- www/manager6/Utils.js | 70 + www/manager6/Workspace.js

Re: [pve-devel] applied: [PATCH frr] use 7.2 tag for submodule

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 8:40 AM, Alexandre DERUMIER wrote: >>> There's also a stable 7.2 branch, with a few fixes since 7.2 tag[0], >>> or is this also not yet working? > > No, still broken :/ > OK, I rolled out the current "stable/7.1" as update, the version number is a bit extra to ensure it sort newer

[pve-devel] [PATCH manager v2 1/1] renew pve-ssl.pem when it nearly expires

2019-11-26 Thread Dominik Csapak
but only if the cert is issued by the ca in /etc/pve/pve-root-ca.pem (by checking the issuer and openssl verify) this way we can reduce the lifetime of the certs without having to worry that they ran out Signed-off-by: Dominik Csapak --- changes from v1: * only make checks if the cert expires so

[pve-devel] [PATCH cluster v2 1/1] change certificate lifetime to two years

2019-11-26 Thread Dominik Csapak
instead of 10 years, to avoid issues with browsers/os that reject certificates which have a longer lifetime (e.g. macOs Catalina only accepts max 825 days if issued after july 2019) also limit the lifetime by the expiry date of the ca, since a certifiacte cannot be valid longer than its ca Signed

[pve-devel] [PATCH manager/cluster v2] improve handling of issued certificates

2019-11-26 Thread Dominik Csapak
this series enabled auto-renewing of our self issued certificates by checking the expiry time daily with 'pveupdate' and renewing it if it expires in less than 2 weeks also reduce the initial lifetime of the certificates to two years this fixes an issue where some os/browsers (macOs Catalina) wou

[pve-devel] applied: [PATCH qemu-server] fix #2478: record python3-minimal as build dependency

2019-11-26 Thread Thomas Lamprecht
Suggested-by: Fabian Grünbichler Signed-off-by: Thomas Lamprecht --- debian/control | 1 + 1 file changed, 1 insertion(+) diff --git a/debian/control b/debian/control index a754536..99841ab 100644 --- a/debian/control +++ b/debian/control @@ -20,6 +20,7 @@ Build-Depends: debhelper (>= 11~),

[pve-devel] applied: [PATCH manager] api: network reload: more granular OVS change check

2019-11-26 Thread Thomas Lamprecht
Just because OVS is installed it doesn't mean that OVS interface (changes) are configured - so check for that. Signed-off-by: Thomas Lamprecht --- PVE/API2/Network.pm | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.p

[pve-devel] applied: [PATCH manager 1/1] gui: node network: enable apply config button

2019-11-26 Thread Thomas Lamprecht
On 10/29/19 12:08 PM, Dominik Csapak wrote: > Signed-off-by: Dominik Csapak > --- > www/manager6/node/Config.js | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/www/manager6/node/Config.js b/www/manager6/node/Config.js > index 054ced64..91a999e1 100644 > --- a/www/manager6/node/Config.js

Re: [pve-devel] applied: [PATCH manager] api: network reload: more granular OVS change check

2019-11-26 Thread Alexandre DERUMIER
Damn, you are too fast, I'll rebase my pve-manager patch for sdn ;) - Mail original - De: "Thomas Lamprecht" À: "pve-devel" Envoyé: Mardi 26 Novembre 2019 11:45:04 Objet: [pve-devel] applied: [PATCH manager] api: network reload: more granular OVS change check Just because OVS is instal

[pve-devel] applied: [PATCH widget-toolkit 1/1] NetworkView: add apply config button

2019-11-26 Thread Thomas Lamprecht
On 10/29/19 12:08 PM, Dominik Csapak wrote: > when the host has ifupdown2 installed, we can hot apply the config > add a button to do this > > if the user does not meet the requirements, the api call > will show why and throw an error (without changing anything) > > the button has to be enabled v

Re: [pve-devel] applied: [PATCH manager] api: network reload: more granular OVS change check

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 12:01 PM, Alexandre DERUMIER wrote: > Damn, you are too fast, I'll rebase my pve-manager patch for sdn ;) > sorry, didn't saw that your patch also touched this ^^ But the changes should work for you too, or? ___ pve-devel mailing list pve-d

Re: [pve-devel] applied: [PATCH manager] api: network reload: more granular OVS change check

2019-11-26 Thread Alexandre DERUMIER
>>But the changes should work for you too, or? yes, no problem. (BTW, great to see finally ifupdown2/local network reload in gui :) - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Envoyé: Mardi 26 Novembre 2019 12:16:53 Objet: Re: [pve-devel] applied: [PATCH man

[pve-devel] applied-series: [PATCH v2 pve-network 00/15] sdn: split vnets/zones/controllers plugins + improvments

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 10:00 AM, Alexandre Derumier wrote: > Split code in different plugins (vnets/zones/controllers) for better > maintenance > and readability > > Changelog V2: > lot of cleanup, permissions, some plugins rework > (sorry that's a lot of patches) > applied series, thanks! > > Alexandr

[pve-devel] [PATCH container] Remove an unused volume from the config if it is pending to be re-added

2019-11-26 Thread Fabian Ebner
This makes the behavior more similar to what we do for VM configs. If we have a pending change re-adding an unused volume as a mount point, then the unused volume will not show up anymore. And if we revert such a change, the volume will re-appear as an unused volume. Like this a user with a running

[pve-devel] [PATCH v2 common] cli-formatter: avoid warning when trying to sort on undefined key

2019-11-26 Thread Christian Ebner
Example: pvesh get /nodes/{node}/qemu/{vmid}/rrddata --timeframe day If the sorting key is not defined in the dataset, e.g. when a VM was not running for some time within the given timeframe, this resulted in several ugly warnings. Signed-off-by: Christian Ebner --- v2: Oops, v1 is nonsens

[pve-devel] applied: [PATCH cluster v2 1/1] change certificate lifetime to two years

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 11:01 AM, Dominik Csapak wrote: > instead of 10 years, to avoid issues with browsers/os that reject > certificates which have a longer lifetime > (e.g. macOs Catalina only accepts max 825 days if issued after july 2019) > > also limit the lifetime by the expiry date of the ca, since >

Re: [pve-devel] [PATCH common] cli-formatter: avoid warning when trying to sort on undefined key

2019-11-26 Thread Christian Ebner
Please do not apply, this breaks sorting! > On November 21, 2019 3:21 PM Christian Ebner wrote: > > > Example: > pvesh get /nodes/{node}/qemu/{vmid}/rrddata --timeframe day > > If the sorting key is not defined in the dataset, e.g. when a VM was not > running > for some time within the g

[pve-devel] applied: [PATCH manager v2 1/1] renew pve-ssl.pem when it nearly expires

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 11:01 AM, Dominik Csapak wrote: > but only if the cert is issued by the ca in /etc/pve/pve-root-ca.pem > (by checking the issuer and openssl verify) > > this way we can reduce the lifetime of the certs without having > to worry that they ran out > > Signed-off-by: Dominik Csapak > --

[pve-devel] Same migration IP on multiple devices

2019-11-26 Thread Harald Leithner
Hi, one of my 3 nodes clusters has a full mesh. While trying to migrate a VM I get the error message "could not get migration ip: multiple IP address configured for " This only happens when the migration IP is configured on more then one device. This is the suggested configuration for a full mes

[pve-devel] [PATCH cluster] mtunnel: allow multiple IPs if the are the same

2019-11-26 Thread Thomas Lamprecht
To allow routed full-mesh, where the same IP is used on multiple adapters. For the migration IP this is OK, as we just want a single unique IP, if that one is configured more than once does not bothers us here. Signed-off-by: Thomas Lamprecht --- data/PVE/CLI/pvecm.pm | 4 ++-- 1 file changed, 2

Re: [pve-devel] Same migration IP on multiple devices

2019-11-26 Thread Thomas Lamprecht
Hi, On 11/26/19 1:39 PM, Harald Leithner wrote: > one of my 3 nodes clusters has a full mesh. While trying to migrate a VM > I get the error message "could not get migration ip: multiple IP address > configured for " > > This only happens when the migration IP is configured on more then one > dev

[pve-devel] applied: [PATCH cluster] mtunnel: allow multiple IPs if the are the same

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 1:54 PM, Thomas Lamprecht wrote: > To allow routed full-mesh, where the same IP is used on multiple > adapters. For the migration IP this is OK, as we just want a single > unique IP, if that one is configured more than once does not bothers > us here. > > Signed-off-by: Thomas Lamprech

Re: [pve-devel] [PATCH v2 pve-cluster 1/1] add sdn vnets/zones/controllers.cfg

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 10:00 AM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > data/PVE/Cluster.pm | 9 +++-- > data/src/status.c | 8 ++-- > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm > index 2057162..c1d8b

Re: [pve-devel] [PATCH v2 pve-manager 3/4] api2 : nodes : use zones api status

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 10:01 AM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Nodes.pm | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > index ddeafbef..f0d062d5 100644 > --- a/PVE/API2/Nodes.pm > +++ b/

[pve-devel] applied: [PATCH storage] fix #2309: allow LVM Volume Group names starting with a digit

2019-11-26 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/Storage/Plugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm index a573959..283eafc 100644 --- a/PVE/Storage/Plugin.pm +++ b/PVE/Storage/Plugin.pm @@ -145,7 +145,7 @@ PVE::JSONSchema::re

Re: [pve-devel] [PATCH v2 pve-cluster 1/1] add sdn vnets/zones/controllers.cfg

2019-11-26 Thread Alexandre DERUMIER
>>those paths would also need the sdn/ folder prefix? oh yes, you're right, sorry. I'll send v3 - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier" Envoyé: Mardi 26 Novembre 2019 14:06:21 Objet: Re: [pve-devel] [PATCH v2 pve-cluster 1/1] add sdn vnets/zones/controller

[pve-devel] [PATCH v3 pve-cluster 0/1] sdn: split vnets/zones/controllers plugins

2019-11-26 Thread Alexandre Derumier
Following the pve-network patch series v2 changelogv3: fix paths in status.c Alexandre Derumier (1): add sdn vnets/zones/controllers.cfg data/PVE/Cluster.pm | 9 +++-- data/src/status.c | 8 ++-- 2 files changed, 13 insertions(+), 4 deletions(-) -- 2.20.1 ___

[pve-devel] [PATCH v3 pve-cluster 1/1] add sdn vnets/zones/controllers.cfg

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- data/PVE/Cluster.pm | 9 +++-- data/src/status.c | 8 ++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/data/PVE/Cluster.pm b/data/PVE/Cluster.pm index 2057162..c1d8b09 100644 --- a/data/PVE/Cluster.pm +++ b/data/PVE/Cluster.pm @@

[pve-devel] applied: [PATCH v3 pve-cluster 1/1] add sdn vnets/zones/controllers.cfg

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 2:42 PM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > data/PVE/Cluster.pm | 9 +++-- > data/src/status.c | 8 ++-- > 2 files changed, 13 insertions(+), 4 deletions(-) > applied, thanks! ___ pve-devel mai

[pve-devel] [PATCH v3 pve-manager 0/4] sdn: split vnets/zones/controllers plugins + gui

2019-11-26 Thread Alexandre Derumier
Following the pve-network patch series Changelog v3: - add missing have_sdn in api node - rebase reload on last master Changelog v2: - rebase on last master git - add sdn gui Alexandre Derumier (4): pvestatd: fix require PVE::Network::SDN api2 : reload : use zones/controllers sdn plugins

[pve-devel] [PATCH v3 pve-manager 3/4] api2 : nodes : use zones api status

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/API2/Nodes.pm | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index ddeafbef..93caf66f 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -54,7 +54,7 @@ use Socket; my $have_sdn;

[pve-devel] [PATCH v3 pve-manager 2/4] api2 : reload : use zones/controllers sdn plugins

2019-11-26 Thread Alexandre Derumier
--- PVE/API2/Network.pm | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/PVE/API2/Network.pm b/PVE/API2/Network.pm index 60178c86..2d201c0e 100644 --- a/PVE/API2/Network.pm +++ b/PVE/API2/Network.pm @@ -18,7 +18,8 @@ use base qw(PVE::RESTHandler); m

[pve-devel] [PATCH v3 pve-manager 4/4] add sdn gui

2019-11-26 Thread Alexandre Derumier
--- www/manager6/Makefile | 17 +++ www/manager6/Makefile.rej | 9 ++ www/manager6/StateProvider.js | 4 +- www/manager6/Utils.js | 70 + www/manager6/Workspace.js | 1 + www/manager6/dc/Config

[pve-devel] [PATCH v3 pve-manager 1/4] pvestatd: fix require PVE::Network::SDN

2019-11-26 Thread Alexandre Derumier
Signed-off-by: Alexandre Derumier --- PVE/Service/pvestatd.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index b789b819..3f539b21 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/pvestatd.pm @@ -35,7 +35,7 @@ use bas

Re: [pve-devel] Same migration IP on multiple devices

2019-11-26 Thread Harald Leithner
Hi, good to know and thx for the fix. I think the same is true for creating a ceph mon from the gui. You get an error message if you create a ceph mon complaining about multiple ips. This can be overridden in the console with --mon-address but maybe should be fixed too. also your fix will not wo

[pve-devel] [PATCH installer 2/3] linewrap bootdevinfo generation

2019-11-26 Thread Stoiko Ivanov
Signed-off-by: Stoiko Ivanov --- proxinstall | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/proxinstall b/proxinstall index 1a5acc5..a0ba91f 100755 --- a/proxinstall +++ b/proxinstall @@ -1278,8 +1278,12 @@ sub extract_data { partition_bo

[pve-devel] [PATCH installer 1/3] expand comment on /sys/block/$dev/size

2019-11-26 Thread Stoiko Ivanov
/sys/block/$dev/size is also given in 512b sectors even for 4kn disks. Since it surprised me - mention it explicitly in the comment Signed-off-by: Stoiko Ivanov --- proxinstall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxinstall b/proxinstall index 5d02b34..1a5acc5 1

[pve-devel] [PATCH installer 0/3] add 4kn support

2019-11-26 Thread Stoiko Ivanov
This patchset adds support for installing on 4kn disks. The catchy part for me was the neccessary parameter -s1 for mkfs.vfat (the installer ran through, but ovmf (and I guess many UEFI implementations out there) did not boot from the esp. Points I'm not too sure about: * should we still create a

[pve-devel] [PATCH installer 3/3] fix #1211: allow install on 4kn disks

2019-11-26 Thread Stoiko Ivanov
Installation on disks with 4k logical blocksize (4kn) failed, because the bios_boot (a.k.a. gdisk partitiontype EF02, place for grub in legacy BIOS boot mode) partition is created using start and end sectors (and sector 2047 is not at 1M, where the ESP starts) This patch addresses the issue by not

Re: [pve-devel] Same migration IP on multiple devices

2019-11-26 Thread Thomas Lamprecht
Hi, On 11/26/19 3:22 PM, Harald Leithner wrote: > Hi, > > good to know and thx for the fix. I think the same is true for creating > a ceph mon from the gui. > > You get an error message if you create a ceph mon complaining about > multiple ips. This can be overridden in the console with --mon-ad

[pve-devel] applied: [PATCH manager] api mon: allow full-mesh routed setup for monitor IP

2019-11-26 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- PVE/API2/Ceph/MON.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Ceph/MON.pm b/PVE/API2/Ceph/MON.pm index 57f88878..0432ca67 100644 --- a/PVE/API2/Ceph/MON.pm +++ b/PVE/API2/Ceph/MON.pm @@ -42,7 +42,7 @@ my $find_mon_ip = sub {

Re: [pve-devel] [PATCH container] Remove an unused volume from the config if it is pending to be re-added

2019-11-26 Thread Oguz Bektas
hi, found an issue here: 1 - create a new mp on running container 2 - mp gets added as pending, but disk is not created yet 3 - revert the pending mp 4 - this adds an unused disk, which doesn't exist and can't be removed via GUI when i try to revert a new mp, 'guests:1' this is what $mp is: $VA

Re: [pve-devel] [PATCH installer 3/3] fix #1211: allow install on 4kn disks

2019-11-26 Thread Dominik Csapak
just a high level comment, since i did not found anything in the commit: i think we should warn/notify the user if he boots in bios mode and installs/tries to install on 4kn disks, since the user will not be able to boot in that case (since we do not install a bootloader?) i'd be very confused i

[pve-devel] [PATCH manager] lxc: disable remove button for pending resource changes

2019-11-26 Thread Oguz Bektas
for a pending change, it's 'revert's job to do this. pressing remove doesn't do anything and it might be confusing for users. Signed-off-by: Oguz Bektas --- www/manager6/lxc/Resources.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/manager6/lxc/Resources.js b/www/manag

Re: [pve-devel] [PATCH installer 3/3] fix #1211: allow install on 4kn disks

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 4:25 PM, Dominik Csapak wrote: > just a high level comment, since i did not found anything in the commit: > > i think we should warn/notify the user if he boots in bios mode > and installs/tries to install on 4kn disks, since the user will > not be able to boot in that case (since we d

[pve-devel] applied: [PATCH pve-access-control 1/1] add SDN.Allocate && SDN.Audit privileges

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 10:01 AM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/AccessControl.pm | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/PVE/AccessControl.pm b/PVE/AccessControl.pm > index ad97a42..4e9deea 100644 > --- a/PVE/AccessControl.pm > +++ b/P

[pve-devel] applied: [PATCH manager] lxc: disable remove button for pending resource changes

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 4:37 PM, Oguz Bektas wrote: > for a pending change, it's 'revert's job to do this. pressing remove > doesn't do anything and it might be confusing for users. > > Signed-off-by: Oguz Bektas > --- > www/manager6/lxc/Resources.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

[pve-devel] [PATCH qemu-server] skip efidisk0 in hotplug

2019-11-26 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 5f248a3..75e4f67 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4902,6 +4902,7 @@ sub vmconfig_hotplug_pending { vmconfig_up

[pve-devel] applied: [PATCH qemu-server] skip efidisk0 in hotplug

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 5:07 PM, Oguz Bektas wrote: > Signed-off-by: Oguz Bektas > --- > PVE/QemuServer.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index 5f248a3..75e4f67 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -4902,6 +4902,7 @

Re: [pve-devel] [PATCH v3 pve-manager 3/4] api2 : nodes : use zones api status

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 3:20 PM, Alexandre Derumier wrote: > Signed-off-by: Alexandre Derumier > --- > PVE/API2/Nodes.pm | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm > index ddeafbef..93caf66f 100644 > --- a/PVE/API2/Nodes.pm > +++ b/

Re: [pve-devel] [PATCH v3 pve-manager 4/4] add sdn gui

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 3:20 PM, Alexandre Derumier wrote: > --- > www/manager6/Makefile | 17 +++ > www/manager6/Makefile.rej | 9 ++ > www/manager6/StateProvider.js | 4 +- > www/manager6/Utils.js | 70 + > www/manager6/Wo

Re: [pve-devel] [PATCH v3 pve-manager 0/4] sdn: split vnets/zones/controllers plugins + gui

2019-11-26 Thread Thomas Lamprecht
On 11/26/19 3:20 PM, Alexandre Derumier wrote: > Following the pve-network patch series > > Changelog v3: > - add missing have_sdn in api node > - rebase reload on last master > > Changelog v2: > - rebase on last master git > - add sdn gui > > Alexandre Derumier (4): > pvestatd: fix requir

[pve-devel] [PATCH qemu-server 1/3] hotplug_pending: remove redundant write/load config calls

2019-11-26 Thread Oguz Bektas
instead of writing the config after every change, we can do it once for all the changes in the end to avoid redundant i/o. we also don't need to load_config after writing fastplug changes. Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 9 ++--- 1 file changed, 2 insertions(+), 7 deletio

[pve-devel] [PATCH qemu-server 3/3] add error handling to vmconfig_apply_pending

2019-11-26 Thread Oguz Bektas
Signed-off-by: Oguz Bektas --- PVE/API2/Qemu.pm | 6 +++--- PVE/QemuServer.pm | 46 ++ 2 files changed, 33 insertions(+), 19 deletions(-) diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm index 1811795..f291f52 100644 --- a/PVE/API2/Qemu.pm +++ b/PVE/

[pve-devel] [PATCH qemu-server 2/3] apply_pending: remove redundant write/load config calls

2019-11-26 Thread Oguz Bektas
replace redundant write/load config calls with a single write_config at the end to avoid unnecessary i/o Signed-off-by: Oguz Bektas --- PVE/QemuServer.pm | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 9749917..7d2959a 1