On 11/25/19 8:02 AM, Fabian Grünbichler wrote:
>>> +
>>> + while (line != NULL) {
>>> + next_line = memchr(line, '\n',
>>> remaining);
>>> + if (next_line != NULL) {
>>> +
On November 22, 2019 1:35 pm, Oguz Bektas wrote:
> hi,
>
> will this get applied?
applied this patch, with the following additional check:
commit a85c6be13e40230ae9ca201fcf92cfc381bdd26a
Author: Fabian Grünbichler
AuthorDate: Mon Nov 25 10:02:46 2019 +0100
Commit: Fabian Grünbichler
Co
On 10/24/19 1:53 PM, Oguz Bektas wrote:
> or any other variant of the word 'pending'.
>
> note that we can actually allow this snapshot after PVE 7.0, since
> pending section and snapshots will be properly namespaced.
> ([pve:pending] and [snap:$snapname] or similar).
>
> Signed-off-by: Oguz Bekt
On 10/24/19 1:53 PM, Oguz Bektas wrote:
> to make the pct/qemu config formats more similar, we can namespace the
> pending section using the 'pve:' prefix like in pct parser.
>
> the new format is optional in the parser, but default in the writer.
>
> with PVE 7.0, we can make it default in parse
if we don't know which format the source volume/file has, let qemu-img
decide.
Signed-off-by: Fabian Grünbichler
---
also checked EFI disk creation, auto-detection works correctly there.
PVE/QemuServer.pm | 7 ---
test/run_qemu_img_convert_tests.pl | 4 ++--
2 files changed
On 11/25/19 10:49 AM, Fabian Grünbichler wrote:
> if we don't know which format the source volume/file has, let qemu-img
> decide.
>
> Signed-off-by: Fabian Grünbichler
> ---
> also checked EFI disk creation, auto-detection works correctly there.
>
> PVE/QemuServer.pm | 7 -
in fields with 'multiSelect: true', we get an array as value instead
of a string, but a check of !![] results in true (since an array
is an object), so we have to explicitely check for arraylength
in 'setValue' (for correctly showing the trigger) and in the
load handler (to not set an empty field w
on multiSelect we have to check the values that is in the values
array, but we get the 'displaystring' in the validator so we
have to get the 'real' value (aka the underlying array of values)
before checking if they are in the store
Signed-off-by: Dominik Csapak
---
form/ComboGrid.js | 6 +-
On November 25, 2019 10:53 am, Thomas Lamprecht wrote:
> On 11/25/19 10:49 AM, Fabian Grünbichler wrote:
>> if we don't know which format the source volume/file has, let qemu-img
>> decide.
>>
>> Signed-off-by: Fabian Grünbichler
>> ---
>> also checked EFI disk creation, auto-detection works corr
On 11/20/19 3:45 PM, Stefan Reiter wrote:
Signed-off-by: Stefan Reiter
---
I tested 4.1.0 seperately to 4.1.1 for a while, so I left the patches in the
order I did them (i.e. 4.1 rebase first, then rebase that to 4.1.1). Patches 1-3
could technically be squashed together into a single 4.1.1 reb
On November 22, 2019 7:37 pm, Thomas Lamprecht wrote:
> Do not check for cycles or for self-validation if not in a build
> environment.
>
> The slight drawback is that we also avoid this cycle checks when we
> do (development) testing through the API and don't remeber to set the
> PROXMOX_FORCE_SC
With our QEMU 4.1.1 package we can pass a additional internal version
to QEMU's machine, it will be split out there and ignored, but
returned on a QMP 'query-machines' call.
This allows us to use it for reducing the granularity with which we
can roll-out HW layout changes/additions for VMs. Until
On 11/25/19 11:05 AM, Fabian Grünbichler wrote:
> On November 25, 2019 10:53 am, Thomas Lamprecht wrote:
>> On 11/25/19 10:49 AM, Fabian Grünbichler wrote:
>>> if we don't know which format the source volume/file has, let qemu-img
>>> decide.
>>>
>>> Signed-off-by: Fabian Grünbichler
>>> ---
>>> a
On 11/25/19 11:21 AM, Fabian Grünbichler wrote:
> On November 22, 2019 7:37 pm, Thomas Lamprecht wrote:
>> Do not check for cycles or for self-validation if not in a build
>> environment.
>>
>> The slight drawback is that we also avoid this cycle checks when we
>> do (development) testing through t
On 11/20/19 8:10 PM, Thomas Lamprecht wrote:
On 10/31/19 1:36 PM, Dominik Csapak wrote:
this series lets users add tags to guest configs
these do not have any concrete meaning but are intended to be used
by management software such as config management systems
this is the basic implementation o
On 11/25/19 11:33 AM, Dominik Csapak wrote:
> On 11/20/19 8:10 PM, Thomas Lamprecht wrote:
>> applied qemu-server and container, for the Webinterface part I'd like
>> to see some changes/features..
>>
>> * tag reordering (or show/save them sorted)
>
> they already are shown in the order they are p
On 11/20/19 3:45 PM, Stefan Reiter wrote:
> Signed-off-by: Stefan Reiter
> ---
>
> I tested 4.1.0 seperately to 4.1.1 for a while, so I left the patches in the
> order I did them (i.e. 4.1 rebase first, then rebase that to 4.1.1). Patches
> 1-3
> could technically be squashed together into a sin
+eval {
+# get CA and check issuer
+my $capath = "/etc/pve/pve-root-ca.pem";
+my $cainfo = PVE::Certificate::get_certificate_info($capath);
+if ($cainfo->{subject} !~ m|/CN=Proxmox Virtual Environment/.*/O=PVE
Cluster Manager CA|) {
+ die "Root CA is not issued by Proxmox
if we don't know which format the source volume/file has, let qemu-img
decide.
Signed-off-by: Fabian Grünbichler
---
Notes:
v1->v2:
drop definedness check, since $src_format can only either be undef or
true/non-empty
CC Dominik, since he did the recent refactoring of qemu_img_conve
Approach is correct IMO, probably the easiest way, and I agree that it
seems unlikely that QEMU's patch version will be important in the future.
Some stuff inline.
On 11/25/19 11:27 AM, Thomas Lamprecht wrote:
With our QEMU 4.1.1 package we can pass a additional internal version
to QEMU's mach
See: https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg03201.html
Signed-off-by: Stefan Reiter
---
...ule-virtio_notify_config-to-run-on-m.patch | 76 +++
debian/patches/series | 1 +
2 files changed, 77 insertions(+)
create mode 100644
debian
On 11/21/19 4:46 PM, Fabian Grünbichler wrote:
On November 4, 2019 11:23 am, Fabian Ebner wrote:
On 10/31/19 10:19 AM, Thomas Lamprecht wrote:
On 10/30/19 10:54 AM, Fabian Ebner wrote:
Doing an online migration with --targetstorage and two unused disks with the
same name on different storages
On November 25, 2019 12:40 pm, Fabian Ebner wrote:
> On 11/21/19 4:46 PM, Fabian Grünbichler wrote:
>> On November 4, 2019 11:23 am, Fabian Ebner wrote:
>>> On 10/31/19 10:19 AM, Thomas Lamprecht wrote:
On 10/30/19 10:54 AM, Fabian Ebner wrote:
> Doing an online migration with --targetstor
On 11/25/19 12:33 PM, Stefan Reiter wrote:
> Approach is correct IMO, probably the easiest way, and I agree that it seems
> unlikely that QEMU's patch version will be important in the future.
>
> Some stuff inline.
>
> On 11/25/19 11:27 AM, Thomas Lamprecht wrote:
>> With our QEMU 4.1.1 package
On 11/25/19 1:22 PM, Thomas Lamprecht wrote:
On 11/25/19 12:33 PM, Stefan Reiter wrote:
Approach is correct IMO, probably the easiest way, and I agree that it seems
unlikely that QEMU's patch version will be important in the future.
Some stuff inline.
On 11/25/19 11:27 AM, Thomas Lamprecht wr
On 11/25/19 12:03 PM, Fabian Grünbichler wrote:
> if we don't know which format the source volume/file has, let qemu-img
> decide.
>
While qemu-img's format probing through bdrv_probe_all is a bit wonky on
its own, it's better to just assume raw, so applied.
> Signed-off-by: Fabian Grünbichler
On 11/25/19 12:38 PM, Stefan Reiter wrote:
> See: https://lists.nongnu.org/archive/html/qemu-devel/2019-09/msg03201.html
>
> Signed-off-by: Stefan Reiter
> ---
> ...ule-virtio_notify_config-to-run-on-m.patch | 76 +++
> debian/patches/series | 1 +
> 2 fi
Signed-off-by: Thomas Lamprecht
---
debian/control | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/control b/debian/control
index a7a3400..513d2ee 100644
--- a/debian/control
+++ b/debian/control
@@ -38,5 +38,6 @@ Depends: cstream,
cifs-utils,
pve-cluster (>= 5.0-32
general overhaul of the documentation, improving phrasing, move open
source info
Signed-off-by: Aaron Lauterer
---
v1 -> v2:
feedback from thomas[0]:
* moved open source hint to mailing list for devs
* added suggestions
* regarding spaces around dashes (--): our current technical writing
styl
This is the first patch series aimed to overhaul our documentation. The
main goal is to make it easier to understand and more consistent.
Therefore the phrasing is changed in a lot of places, sometimes the
ordering of content as well. I tried to align the source to the 80
characters per line wherev
general overhauling, improve phrasing
Signed-off-by: Aaron Lauterer
---
howto-improve-pve-docs.adoc | 38 +
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/howto-improve-pve-docs.adoc b/howto-improve-pve-docs.adoc
index c0d277e..d96bb03 100644
improve phrasing
Signed-off-by: Aaron Lauterer
---
v1 -> v2:
applied suggestion from oguz [0]
[0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038952.html
translation.adoc | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/
improve phrasing
Signed-off-by: Aaron Lauterer
---
v1 -> v2:
applied suggestions from oguz [0]
[0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038966.html
sysadmin.adoc | 38 ++
1 file changed, 14 insertions(+), 24 deletions(-)
diff --git a/
improve phrasing, align headlines, rearrange requirement lists
Signed-off-by: Aaron Lauterer
---
v1 -> v2:
applied (some) suggestions from oguz [0], IO performance is based on the
whole system, not just disks
[0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038953.html
pve-system
improve phrasing, align style of CLI commands
Signed-off-by: Aaron Lauterer
---
v1 -> v2:
applied suggestions from oguz [0]
[0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038965.html
system-software-updates.adoc | 25 ++---
1 file changed, 10 insertions(+),
Signed-off-by: Aaron Lauterer
---
getting-help.adoc| 9 -
howto-improve-pve-docs.adoc | 4 ++--
pve-installation.adoc| 14 +++---
pve-package-repos.adoc | 11 +--
pve-system-requirements.adoc | 4 ++--
sysadmin.adoc| 2 +-
6 f
improve phrasing, align style of CLI commands
Signed-off-by: Aaron Lauterer
---
v1 -> v2:
applied suggestions from oguz [0]
[0] https://pve.proxmox.com/pipermail/pve-devel/2019-September/038964.html
pve-installation.adoc | 264 --
1 file changed, 127 in
improve phrasing, align style of CLI commands, OSX is now macOS, Rufus
with dd mode is preferred to etcher, removed mention of os forensics.
Signed-off-by: Aaron Lauterer
---
pve-usbstick.adoc | 109 +++---
1 file changed, 54 insertions(+), 55 deletions(-)
improve phrasing, align style of CLI commands
Signed-off-by: Aaron Lauterer
---
pve-package-repos.adoc | 143 +
1 file changed, 74 insertions(+), 69 deletions(-)
diff --git a/pve-package-repos.adoc b/pve-package-repos.adoc
index 078de95..e11f8ec 100644
--
With our QEMU 4.1.1 package we can pass a additional internal version
to QEMU's machine, it will be split out there and ignored, but
returned on a QMP 'query-machines' call.
This allows us to use it for increasing the granularity with which we
can roll-out HW layout changes/additions for VMs. Unti
On 11/25/19 4:13 PM, Thomas Lamprecht wrote:
With our QEMU 4.1.1 package we can pass a additional internal version
to QEMU's machine, it will be split out there and ignored, but
returned on a QMP 'query-machines' call.
This allows us to use it for increasing the granularity with which we
can rol
On 11/25/19 4:36 PM, Stefan Reiter wrote:
> On 11/25/19 4:13 PM, Thomas Lamprecht wrote:
>> With our QEMU 4.1.1 package we can pass a additional internal version
>> to QEMU's machine, it will be split out there and ignored, but
>> returned on a QMP 'query-machines' call.
>>
>> This allows us to use
The currently packaged version still used frr 6.0 :/
Signed-off-by: Alexandre Derumier
---
Makefile | 2 +-
debian/changelog | 6 ++
frr | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 3359748..77ce228 100644
--- a/Makefil
On 11/25/19 6:02 PM, Alexandre Derumier wrote:
> The currently packaged version still used frr 6.0 :/
>
argh, well, doh! Let's act like this never happened :)
applied, thanks!
> Signed-off-by: Alexandre Derumier
> ---
> Makefile | 2 +-
> debian/changelog | 6 ++
> frr
On 11/25/19 11:04 AM, Dominik Csapak wrote:
> on multiSelect we have to check the values that is in the values
> array, but we get the 'displaystring' in the validator so we
> have to get the 'real' value (aka the underlying array of values)
> before checking if they are in the store
>
> Signed-of
On 11/25/19 11:04 AM, Dominik Csapak wrote:
> in fields with 'multiSelect: true', we get an array as value instead
> of a string, but a check of !![] results in true (since an array
> is an object), so we have to explicitely check for arraylength
> in 'setValue' (for correctly showing the trigger)
This adds handling for a new shutdown policy, namely "migrate".
If that is set then the LRM doesn't queues stop jobs, but transitions
to a new mode, namely 'maintenance'.
The LRM modes now get passed from the CRM in the NodeStatus update
method, this allows to detect such a mode and make node-stat
We simply remember the node we where on, if moved for maintenance.
This record gets dropped once we move to _any_ other node, be it:
* our previous node, as it came back from maintenance
* another node due to manual migration, group priority changes or
fencing
The first point is handled explicit
To avoid early disconnect during shutdown ensure we order After them,
for shutdown the ordering is reversed and so we're stopped before
those two - this allows to checkout the node stats and do SSH stuff
if something fails.
Signed-off-by: Thomas Lamprecht
---
debian/pve-ha-lrm.service | 2 ++
1
Signed-off-by: Thomas Lamprecht
---
www/manager6/dc/OptionView.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index 3974e59e..28f2d315 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -119,6 +11
Signed-off-by: Thomas Lamprecht
---
Mostly just line-wrapping, as:
# git show --word-diff=color --word-diff-regex=.
tells you. Sorry, to lazy to split that up :)
data/PVE/DataCenterConfig.pm | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/data/PVE/DataCen
Hi Thomas,
I have done test with 7.2, and it seem that it's again broken with evpn
I have opened an issue https://github.com/FRRouting/frr/issues/5431
I wonder if it couldn't be better to use stable/xx branch, instead tag release ?
This is the Thirth time I'm seen broken tag release, and it's a
Hi Alexandre,
On 11/26/19 8:08 AM, Alexandre DERUMIER wrote:
> Hi Thomas,
>
> I have done test with 7.2, and it seem that it's again broken with evpn
> I have opened an issue https://github.com/FRRouting/frr/issues/5431
>
>
> I wonder if it couldn't be better to use stable/xx branch, instead ta
>>As long as we have the features available we need?
Yes, the 7.1 have all needed features.
>>Hmm, but not that you're the only one testing newest tags,
>>and once we switch the stable branch will be less stable too :D
I'm hoping for a 7.1.x tag soon, the minor tag are done from the stable bra
54 matches
Mail list logo
