The data passed to this closure was never free'd, depending on the
count of VM/CTs one could get >1 MB of RSS (!) memory leaked per
statd status cycle update run...
We could also use Scalar::Util's weaken, to weak a copy of this
variable, but as a simple undef works lets do that with a comment..
On 11/19/19 9:14 AM, Thomas Lamprecht wrote:
> The data passed to this closure was never free'd, depending on the
> count of VM/CTs one could get >1 MB of RSS (!) memory leaked per
> statd status cycle update run...
>
> We could also use Scalar::Util's weaken, to weak a copy of this
> variable, bu
When 'content_types' included both 'images' and 'rootdir', a single volume
could appear twice in the volume list. This also fixes the same kind of
duplication in 'pvesm list'.
Signed-off-by: Fabian Ebner
---
PVE/Storage/Plugin.pm | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
dif
PVE::Cluster::Setup::join already calls assert_joinable, we only need the
explicit call in pvecm if we fall back to SSH.
Signed-off-by: Stefan Reiter
---
data/PVE/CLI/pvecm.pm | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/data/PVE/CLI/pvecm.pm b/data/PVE/CLI/
...and change $silent to $noerr for consistency.
Commit 3df092f9 (fix #1380: pvecm status: add general cluster
information) broke "pvecm status" on non-cluster nodes (well, it made
the error look worse, ofc it didn't "work" before either) because it
tries to access a totem that cannot exist withou
Not only did it display two prompts with identical meaning, the second
was indented to the end of the first in my terminal for some reason.
Signed-off-by: Stefan Reiter
---
Series is already based on Fabian's refactoring (i.e. latest master).
v2:
* Move variable definitons with assert_joinable
On November 4, 2019 2:57 pm, Stefan Reiter wrote:
> Also merge the 'mkdir's from QemuServer and QemuConfig to reduce
> duplication (both modules depend on Helpers anyway).
>
> nodename() is still called in multiple places, but since it's cached by
> INotify it doesn't really matter.
>
> Signed-of
On November 4, 2019 2:57 pm, Stefan Reiter wrote:
> parse_cmdline is required for upcoming changes related to custom CPU
> types and live migration, and this way we can re-use existing code.
>
> Provides the necessary infrastructure to parse QEMU /proc/.../cmdline.
> Changing the single user (chec
On November 4, 2019 2:57 pm, Stefan Reiter wrote:
> This series refactors QemuServer and creates three new packages:
> * 'PVE::QemuServer::Helpers' for general purpose helpers
> * 'PVE::QemuServer::Monitor' for higher-level QMP functions
> * 'PVE::QemuServer::Machine' for QEMU machine-type related
On November 4, 2019 2:57 pm, Stefan Reiter wrote:
> vm_exists_on_node in PVE::QemuConfig checks if a config file for a vmid
> exists
>
> vm_running_locally in PVE::QemuServer::Helpers checks if a VM is running
> on the local machine by probing its pidfile and checking /proc/.../cmdline
>
> check_
On November 4, 2019 2:57 pm, Stefan Reiter wrote:
> QMP and monitor helpers are moved from QemuServer.pm.
>
> By using only vm_running_locally instead of check_running, a cyclic
> dependency to QemuConfig is avoided. This also means that the $nocheck
> parameter serves no more purpose, and has thu
one probably leftover wrong use, see inline
On November 4, 2019 2:57 pm, Stefan Reiter wrote:
> ...PVE::QemuServer::Machine.
>
> qemu_machine_feature_enabled is exported since it has a *lot* of users
> in PVE::QemuServer and a long enough name as it is.
>
> Signed-off-by: Stefan Reiter
> ---
>
While we may not want to copy the cloudinit disk/drive, we still need
to create+allocate the volume, else the next start complains about a
missing CI drive..
fixes commit 7d6c99f0a0026ce07fa0eb858db7b6b7756ae021.
Signed-off-by: Thomas Lamprecht
---
PVE/API2/Qemu.pm | 4 ++--
PVE/QemuServer.pm
Signed-off-by: Wolfgang Bumiller
---
Changes to v2: use move_mount() instead of fsopen()
src/PVE/LXC/Tools.pm | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/PVE/LXC/Tools.pm b/src/PVE/LXC/Tools.pm
index bebd7d8..ce37cee 100644
--- a/src/PVE/LXC/Tools.pm
+++ b/src/PVE
Signed-off-by: Wolfgang Bumiller
---
New in v3
src/PVE/LXC.pm | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 61f9bae..866b456 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1262,13 +1262,21 @@ sub run_with_loo
Signed-off-by: Wolfgang Bumiller
---
No changes to v2.
src/PVE/LXC.pm | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 3ad807d..70a3b0a 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -11,7 +11,7 @@ use Fi
Changes to v2:
* Factor `walk_tree_nofollow` to be usable with fds as starting point.
* Create destination directory entries (this was completely missing in
the staged code path api).
* Test for new kernel api with `move_mount` instead of `fsopen` since
we don't actually use `fsopen` currently.
Signed-off-by: Wolfgang Bumiller
---
No changes to v2.
src/PVE/LXC.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 2a79327..3ad807d 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1044,6 +1044,19 @@ my $enter_namespace = sub {
This takes care of creating the directories on the fly
before issuing the move_mount() syscall.
Signed-off-by: Wolfgang Bumiller
---
New in v3:
To make sure both users of this also create the destination directories.
src/PVE/LXC.pm | 19 +++
1 file changed, 19 insertions(+)
dif
Signed-off-by: Wolfgang Bumiller
---
New in v3
src/PVE/LXC.pm | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index a7a9817..e055c26 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -10,7 +10,7 @@ use Socket;
use
Getting a pid and acting on it is always a race, so add
safer helpers for this.
Signed-off-by: Wolfgang Bumiller
---
No changes to v2.
src/PVE/LXC.pm | 38 ++
1 file changed, 38 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index d747039..e5b765
Staging a mount point requires the new kernel mount API and
will mount the volume at a fixed path, then use open_tree()
to "pick it up" into a file descriptor.
For most of our volumes we wouldn't need the temp directory,
but some things cannot be handled with _only_ the new API
(like single-step r
Signed-off-by: Wolfgang Bumiller
---
No changes to v2.
src/PVE/LXC.pm | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index e5b765a..2a79327 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1029,12 +1029,18 @@ sub update_ipc
This way we operate on defined paths in the monitor
namespace (/run/pve/mountpoint/{rootfs,mp0,mp1,...}) while
performing the mount, and can use `move_mount()` without
passing the MOVE_MOUNT_T_SYMLINKS flag when putting the
hierarchy in place.
Signed-off-by: Wolfgang Bumiller
---
Changes to v2: u
for reuse in hotplug code
Signed-off-by: Wolfgang Bumiller
---
Changes to v2:
rename vmconfig_apply_pending_mountpoint to just apply_pending_mountpoint
src/PVE/LXC/Config.pm | 65 ++-
1 file changed, 39 insertions(+), 26 deletions(-)
diff --git a/src/P
Signed-off-by: Wolfgang Bumiller
---
Changes to v2:
use mountpoint_insert_staged() helper
src/PVE/LXC.pm| 38 ++
src/PVE/LXC/Config.pm | 31 ++-
2 files changed, 68 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC.pm
On 11/19/19 10:30 AM, Fabian Grünbichler wrote:
>> +
>> # BEGIN implemented abstract methods from PVE::AbstractConfig
> IMHO, vm_exists_on_node is a prime candidate for being put into
> AbstractConfig - it's not qemu-specific at all, we probably want to do a
> similar split for pve-container as
On 11/19/19 10:59 AM, Thomas Lamprecht wrote:
On 11/19/19 10:30 AM, Fabian Grünbichler wrote:
+
# BEGIN implemented abstract methods from PVE::AbstractConfig
IMHO, vm_exists_on_node is a prime candidate for being put into
AbstractConfig - it's not qemu-specific at all, we probably want to do
On 11/19/19 11:54 AM, Stefan Reiter wrote:
> On 11/19/19 10:59 AM, Thomas Lamprecht wrote:
>> On 11/19/19 10:30 AM, Fabian Grünbichler wrote:
+
# BEGIN implemented abstract methods from PVE::AbstractConfig
>>> IMHO, vm_exists_on_node is a prime candidate for being put into
>>> AbstractC
The bugfix for #2317 introduced a kind of odd api behavior, where each volume
was returned twice from our api if a storage has both 'rootdir' & 'images'
content
types enabled. To give the content type of the volume an actual meaning, it is
now inferred form the associated guest (qemu/lxc) and we n
vm_exists_on_node in PVE::QemuConfig checks if a config file for a vmid
exists
vm_running_locally in PVE::QemuServer::Helpers checks if a VM is running
on the local machine by probing its pidfile and checking /proc/.../cmdline
check_running is left in QemuServer for compatibility, but changed to
Signed-off-by: Stefan Reiter
---
Requires a depends on qemu-server.
PVE/Service/pvestatd.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm
index 7243702f..92d94809 100755
--- a/PVE/Service/pvestatd.pm
+++ b/PVE/Service/pve
parse_cmdline is required for upcoming changes related to custom CPU
types and live migration, and this way we can re-use existing code.
Provides the necessary infrastructure to parse QEMU /proc/.../cmdline.
Changing the single user (check_running) is trivial too.
Signed-off-by: Stefan Reiter
--
Also change to mon_cmd helper, avoid calling qmp_cmd directly.
Signed-off-by: Stefan Reiter
---
Requires a depends on qemu-server.
src/PVE/HA/Resources/PVEVM.pm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/PVE/HA/Resources/PVEVM.pm b/src/PVE/HA/Resources/PVEVM.pm
Also remove unused $confdir variable in QemuConfig, but leave it and
$lock_dir there, since those paths should only be used with
cfs_config_path anyway.
nodename() is still called in multiple places, but since it's cached by
INotify it doesn't really matter.
Signed-off-by: Stefan Reiter
---
PVE
This series refactors QemuServer and creates three new packages:
* 'PVE::QemuServer::Helpers' for general purpose helpers
* 'PVE::QemuServer::Monitor' for higher-level QMP functions
* 'PVE::QemuServer::Machine' for QEMU machine-type related helpers
This refactoring came along because qemu_machine_
...PVE::QemuServer::Machine.
qemu_machine_feature_enabled is exported since it has a *lot* of users
in PVE::QemuServer and a long enough name as it is.
Signed-off-by: Stefan Reiter
---
I left the code exporting qemu_machine_feature_enabled from v2 and only remove
it in the next patch, just to m
...into:
* PVE::QemuServer::Helpers::min_version: check a major.minor version
string with a given major/minor version (this is equivalent to calling
the old qemu_machine_feature_enabled with only $kvmver)
* PVE::QemuServer::Machine::extract_version: get major.minor version
string from arbitr
QMP and monitor helpers are moved from QemuServer.pm.
By using only vm_running_locally instead of check_running, a cyclic
dependency to QemuConfig is avoided. This also means that the $nocheck
parameter serves no more purpose, and has thus been removed along with
vm_mon_cmd_nocheck.
Care has been
On 11/19/19 12:23 PM, Stefan Reiter wrote:
> * fix and improve parse_cmdline (differentiate parameter '--foo' and '--foo
> 1',
> no ordering for now, I don't know if that ever makes in difference in QEMU?)
QEMU's command line is highly order-dependent of arguments, thus I
explicitly do *not* so
Add a simple ExecStartPre command which reads the local node config,
and if a delay is set the helper sleeps that long then exists.
The systemd-unit approach was chosen as this ensures that we really
only delay when doing the startall on node boot. The pve-guests
service does not allows manual sto
Add a simple ExecStartPre command which reads the local node config,
and if a delay is set the helper sleeps that long then exists.
The systemd-unit approach was chosen as this ensures that we really
only delay when doing the startall on node boot. The pve-guests
service does not allows manual sto
On 11/19/19 12:34 PM, Thomas Lamprecht wrote:
On 11/19/19 12:23 PM, Stefan Reiter wrote:
* fix and improve parse_cmdline (differentiate parameter '--foo' and '--foo 1',
no ordering for now, I don't know if that ever makes in difference in QEMU?)
QEMU's command line is highly order-dependent
On 5/21/19 1:16 PM, Dominic Jäger wrote:
> When creating a backup the log part can make the mail too big to be
> transferred. To ensure delivery, two measures are taken:
> 1. Always omit the status lines
> 2. Omit the whole log part if a mail becomes (too) big
>
> Additionally, add a check for mis
This adds an extra field to the AgentFeatureSelector that reflects the
change in qemu-server.
Changes since previous version:
* Use map rather than if/else if/else for type display string.
* Use Proxmox.Utils.unknownText for unknown type (should not occur with
regular use).
* Keep existing
i'm omitting the widget-toolkit patch since that one is already applied.
pve-container:
v1->v2:
* removed helpers for reboot triggers, because reboot triggers are not needed
- we just do vm_stop and vm_start
* also apply pending changes in prestart hook
- check for pending section
also use the opportunity to refactor the shutdown button code into the
menu.
Signed-off-by: Oguz Bektas
---
no changes.
www/manager6/lxc/Config.js | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/www/manager6/lxc/Config.js b/www/manager6
Signed-off-by: Oguz Bektas
---
src/PVE/API2/LXC/Status.pm | 52 ++
1 file changed, 52 insertions(+)
diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm
index 166c731..41f1f4f 100644
--- a/src/PVE/API2/LXC/Status.pm
+++ b/src/PVE/API2/LXC/Statu
this allows pending changes to be applied when a reboot is issued inside
the container.
Signed-off-by: Oguz Bektas
---
src/lxc-pve-prestart-hook | 9 +
1 file changed, 9 insertions(+)
diff --git a/src/lxc-pve-prestart-hook b/src/lxc-pve-prestart-hook
index c0965ab..516217f 100755
--- a/
Signed-off-by: Oguz Bektas
---
src/PVE/CLI/pct.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 3a32de4..98e2c6e 100755
--- a/src/PVE/CLI/pct.pm
+++ b/src/PVE/CLI/pct.pm
@@ -836,7 +836,8 @@ our $cmddef = {
resume => [ 'PVE
Signed-off-by: Oguz Bektas
---
src/PVE/LXC.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 61f9bae..c400f21 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2009,6 +2009,19 @@ sub vm_stop {
die "container did not stop\n";
}
+
with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
session to enable more displays on the fly in linux guests.
Adding the `max_outputs` parameter to the qxl device manually restores
the functionality.
Signed-off-by: Aaron Lauterer
---
PVE/QemuServer.pm| 10 +++
On 11/19/19 4:01 PM, Aaron Lauterer wrote:
> with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
> session to enable more displays on the fly in linux guests.
>
> Adding the `max_outputs` parameter to the qxl device manually restores
> the functionality.
>
> Signed-off-by: Aaron
On 11/19/19 4:13 PM, Thomas Lamprecht wrote:
On 11/19/19 4:01 PM, Aaron Lauterer wrote:
with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
session to enable more displays on the fly in linux guests.
Adding the `max_outputs` parameter to the qxl device manually restores
the
with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
session to enable more displays on the fly in linux guests.
Adding the `max_outputs` parameter to the qxl device manually restores
the functionality.
Signed-off-by: Aaron Lauterer
---
v1 -> v2: change `my $max_outputs` from un
On November 19, 2019 3:53 pm, Oguz Bektas wrote:
> this allows pending changes to be applied when a reboot is issued inside
> the container.
>
> Signed-off-by: Oguz Bektas
> ---
> src/lxc-pve-prestart-hook | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/lxc-pve-prestart-ho
hi,
this breaks mounting with mountopts. (hotplug and normal mount)
reproduce:
- install new kernel
- make a CT
- run it
- try to hotplug a mp with any mountoption (ro, noatime, nosuid, noexec,
nodev)
- mount will fail with exit code 32
- shutdown CT
- boot CT
- mp will be created, it will fail t
On 11/19/19 4:18 PM, Aaron Lauterer wrote:
> with pve-qemu-4.0.1-3 or higher it was not possible in a spice remote
> session to enable more displays on the fly in linux guests.
>
> Adding the `max_outputs` parameter to the qxl device manually restores
> the functionality.
>
> Signed-off-by: Aaron
On Tue, Nov 19, 2019 at 04:56:55PM +0100, Oguz Bektas wrote:
> hi,
>
> this breaks mounting with mountopts. (hotplug and normal mount)
testing with the older kernel now. hotplugging isn't supported because
of the old version, but we can actually mount mps with mountoptions with
the older kernel.
Signed-off-by: Oguz Bektas
---
src/PVE/LXC.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 61f9bae..c400f21 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -2009,6 +2009,19 @@ sub vm_stop {
die "container did not stop\n";
}
+
Signed-off-by: Oguz Bektas
---
src/PVE/API2/LXC/Status.pm | 52 ++
1 file changed, 52 insertions(+)
diff --git a/src/PVE/API2/LXC/Status.pm b/src/PVE/API2/LXC/Status.pm
index 166c731..41f1f4f 100644
--- a/src/PVE/API2/LXC/Status.pm
+++ b/src/PVE/API2/LXC/Statu
this allows pending changes to be applied when a reboot is issued inside
the container.
Signed-off-by: Oguz Bektas
---
src/lxc-pve-prestart-hook | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/lxc-pve-prestart-hook b/src/lxc-pve-prestart-hook
index c0965ab..b44b69
Signed-off-by: Oguz Bektas
---
src/PVE/CLI/pct.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm
index 3a32de4..98e2c6e 100755
--- a/src/PVE/CLI/pct.pm
+++ b/src/PVE/CLI/pct.pm
@@ -836,7 +836,8 @@ our $cmddef = {
resume => [ 'PVE
also use the opportunity to refactor the shutdown button code into the
menu.
Signed-off-by: Oguz Bektas
---
v2->v3:
no changes.
www/manager6/lxc/Config.js | 35 +--
1 file changed, 21 insertions(+), 14 deletions(-)
diff --git a/www/manager6/lxc/Config.js b/www/
i'm omitting the widget-toolkit patch since that one is already applied.
pve-container:
v2->v3:
* use vmconfig_apply_pending() in prestart hook instead of calling
update_pct_config and update_lxc_config
Oguz Bektas (4):
add vm_reboot sub to later use in api
add vm_reboot api call
add 'pct
On Tue, Nov 19, 2019 at 04:56:55PM +0100, Oguz Bektas wrote:
> hi,
>
> this breaks mounting with mountopts. (hotplug and normal mount)
>
> reproduce:
> - install new kernel
> - make a CT
> - run it
> - try to hotplug a mp with any mountoption (ro, noatime, nosuid, noexec,
> nodev)
I was a bit co
Staging a mount point requires the new kernel mount API and
will mount the volume at a fixed path, then use open_tree()
to "pick it up" into a file descriptor.
For most of our volumes we wouldn't need the temp directory,
but some things cannot be handled with _only_ the new API
(like single-step r
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC.pm | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 2a79327..3ad807d 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1044,6 +1044,19 @@ my $enter_namespace = sub {
close $fd;
};
+
Changes to v3:
* Change mount point staging directory from /run/pve/mountpoints to
/var/lib/lxc/.pve-staged-mounts due to allowed mount paths being
restricted by the lxc-start apparmor profile.
(Only affects path 8, the remaining patches are unchanged)
Changes to v2:
* Factor `walk_tree_nofo
Getting a pid and acting on it is always a race, so add
safer helpers for this.
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC.pm | 38 ++
1 file changed, 38 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index d747039..e5b765a 100644
--- a/src/
Signed-off-by: Wolfgang Bumiller
---
Changes to v3:
Changed the staging path from /run/pve/mountpoints to
/var/lib/lxc/.pve-staged-mounts due to the lxc-start apparmor profile.
src/PVE/LXC.pm | 30 +-
1 file changed, 29 insertions(+), 1 deletion(-)
diff --git a/s
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC/Tools.pm | 18 ++
1 file changed, 18 insertions(+)
diff --git a/src/PVE/LXC/Tools.pm b/src/PVE/LXC/Tools.pm
index bebd7d8..ce37cee 100644
--- a/src/PVE/LXC/Tools.pm
+++ b/src/PVE/LXC/Tools.pm
@@ -2,6 +2,8 @@
package PVE::LXC::To
This takes care of creating the directories on the fly
before issuing the move_mount() syscall.
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC.pm | 19 +++
1 file changed, 19 insertions(+)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 77679fa..d747039 100644
--- a/src/PVE
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC.pm | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index e5b765a..2a79327 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1029,12 +1029,18 @@ sub update_ipconfig {
}
+my
This way we operate on defined paths in the monitor
namespace (/run/pve/mountpoint/{rootfs,mp0,mp1,...}) while
performing the mount, and can use `move_mount()` without
passing the MOVE_MOUNT_T_SYMLINKS flag when putting the
hierarchy in place.
Signed-off-by: Wolfgang Bumiller
---
src/lxc-pve-pre
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC.pm | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 431f6cd..d27140f 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -10,7 +10,7 @@ use Socket;
use File::Path;
for reuse in hotplug code
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC/Config.pm | 65 ++-
1 file changed, 39 insertions(+), 26 deletions(-)
diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 6203c42..573eaff 100644
--- a/src/PVE/LXC/Con
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC.pm | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 61f9bae..866b456 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1262,13 +1262,21 @@ sub run_with_loopdev {
sub
Signed-off-by: Wolfgang Bumiller
---
src/PVE/LXC.pm| 38 ++
src/PVE/LXC/Config.pm | 31 ++-
2 files changed, 68 insertions(+), 1 deletion(-)
diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 26c03f7..431f6cd 100644
--- a/sr
On 11/19/19 10:13 AM, Fabian Ebner wrote:
When 'content_types' included both 'images' and 'rootdir', a single volume
could appear twice in the volume list. This also fixes the same kind of
duplication in 'pvesm list'.
Signed-off-by: Fabian Ebner
---
PVE/Storage/Plugin.pm | 8 ++--
1 file
80 matches
Mail list logo
