[pve-devel] [PATCH v2 docs] Add description for mountpoint property

2019-11-07 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- pve-storage-zfspool.adoc | 5 + 1 file changed, 5 insertions(+) diff --git a/pve-storage-zfspool.adoc b/pve-storage-zfspool.adoc index f53a598..cf7cc3f 100644 --- a/pve-storage-zfspool.adoc +++ b/pve-storage-zfspool.adoc @@ -32,6 +32,11 @@ sparse:: Use ZFS th

[pve-devel] [PATCH v2 storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Ebner
A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first time, the current mount point is determined and written to the storage config. Signed-off-by: Fabian Ebner --- Changes from v1: * expanded eval around the zfs_request * check if the returned

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Grünbichler
On November 6, 2019 1:46 pm, Fabian Ebner wrote: > A new mountpoint property is added to the schema for ZFSPool storages. > When needed for the first time, the current mount point is determined and > written to the storage config. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage/ZFSPoolPlugin

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Ebner
On 11/7/19 9:34 AM, Fabian Grünbichler wrote: On November 6, 2019 1:46 pm, Fabian Ebner wrote: A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first time, the current mount point is determined and written to the storage config. Signed-off-by: Fabian Eb

Re: [pve-devel] [PATCH v2 docs] Add section for ZFS Special Device

2019-11-07 Thread Fabian Ebner
Thanks for the suggestions, I'll do a v3. On 11/6/19 8:40 PM, Thomas Lamprecht wrote: On 11/6/19 10:46 AM, Fabian Ebner wrote: Signed-off-by: Fabian Ebner --- Changes from v1: * Reworded the part that describes when a special device is useful * Moved that part to the top, so people

[pve-devel] [PATCH v3 docs] Add section for ZFS Special Device

2019-11-07 Thread Fabian Ebner
Signed-off-by: Fabian Ebner --- Changes from v2: * Better example of when a special device is useful * Don't mention special_small_blocks property in the first section, so it is explained right when we use it for the first time * Explain possible values for size right away *

[pve-devel] applied: [PATCH] fix #2456 setting bind-mount through API/CLI is broken

2019-11-07 Thread Thomas Lamprecht
On 11/7/19 7:51 AM, Wolfgang Link wrote: > Content-type check is only valid for mp from type 'volume'. > The Content-type check is correct for rootfs and mount points. > --- > src/PVE/LXC/Config.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/LXC/Config.pm b/sr

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Ebner
On 11/7/19 9:34 AM, Fabian Grünbichler wrote: On November 6, 2019 1:46 pm, Fabian Ebner wrote: A new mountpoint property is added to the schema for ZFSPool storages. When needed for the first time, the current mount point is determined and written to the storage config. Signed-off-by: Fabian Eb

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-07 Thread Fabian Grünbichler
On November 7, 2019 12:52 pm, Fabian Ebner wrote: > On 11/7/19 9:34 AM, Fabian Grünbichler wrote: >> On November 6, 2019 1:46 pm, Fabian Ebner wrote: >>> A new mountpoint property is added to the schema for ZFSPool storages. >>> When needed for the first time, the current mount point is determined

[pve-devel] [PATCH qemu-server] restore_tar_archive: Add skiplock to destroy_vm

2019-11-07 Thread Dominic Jäger
When calling qmrestore a config file is created and locked with a lock property. The following destroy_vm has been impossible as skiplock has not been set. Signed-off-by: Dominic Jäger --- PVE/QemuServer.pm | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/PVE/QemuServ

Re: [pve-devel] applied: [PATCH pve-access-control] ldap auth: add sslversion option

2019-11-07 Thread Alexandre DERUMIER
>>Would it make sense to switch to that as default? To you know how >>good its supported? For now, keep tls 1.2. tls 1.3 is really new and far to be implemented everywhere. (I don't think it's implemented in AD 2019) - Mail original - De: "Thomas Lamprecht" À: "pve-devel" , "aderumier"

[pve-devel] [PATCH docs] Fix: pveceph: broken ref anchor pveceph_mgr_create

2019-11-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pveceph.adoc b/pveceph.adoc index ef257ac..99c610a 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -286,7 +286,7 @@ monitor the cluster. Since the Ceph luminous release at least one

[pve-devel] applied: [PATCH docs] Fix: pveceph: broken ref anchor pveceph_mgr_create

2019-11-07 Thread Thomas Lamprecht
On 11/7/19 1:35 PM, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > pveceph.adoc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.proxmox.com/cgi

[pve-devel] [PATCH docs] Fix: pveceph: spelling in section Trim/Discard

2019-11-07 Thread Alwin Antreich
Signed-off-by: Alwin Antreich --- pveceph.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pveceph.adoc b/pveceph.adoc index 99c610a..122f063 100644 --- a/pveceph.adoc +++ b/pveceph.adoc @@ -762,9 +762,9 @@ Trim/Discard It is a good measure to run 'fst

[pve-devel] applied: [PATCH docs] Fix: pveceph: spelling in section Trim/Discard

2019-11-07 Thread Thomas Lamprecht
On 11/7/19 1:42 PM, Alwin Antreich wrote: > Signed-off-by: Alwin Antreich > --- > pveceph.adoc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/pveceph.adoc b/pveceph.adoc > index 99c610a..122f063 100644 > --- a/pveceph.adoc > +++ b/pveceph.adoc > @@ -762,9 +762,9 @

[pve-devel] applied: [PATCH manager 2/2] status/graphite: refactor write_graphite to send all at once

2019-11-07 Thread Thomas Lamprecht
Instead of doing multiple sends, for each status metric line one, assemble it all in a string and send it out in a single go. Per VM/CT/Node we had >10 lines to send, so this is quite the reduction. But, also note that thanks to Nagler's delay algorithm this may not had a big effect for TCP, as it

[pve-devel] applied: [PATCH manager 1/2] status/graphite: just use setsockopt to set timeouts

2019-11-07 Thread Thomas Lamprecht
after rethinking this it felt weird, sockets already can to this themself, so I checked out the IO::Socket::Timeout module, and yeah, it's just a OOP wrapper for this, hiding the "scary" struct pack. So instead of adding that as dependency lets do it ourself. Signed-off-by: Thomas Lamprecht Cc:

Re: [pve-devel] [PATCH v3 kernel-meta] fix #2403: exclude initrd entries from /proc/cmdline

2019-11-07 Thread Thomas Lamprecht
On 10/16/19 1:17 PM, Oguz Bektas wrote: > if we fallback to /proc/cmdline, it can include the booted initrd. > > to avoid loader entries with initrd 'options' lines, we have to parse > them out. > > Signed-off-by: Oguz Bektas > --- > > v2->v3: > * match forward slashes > * match underscore > *

[pve-devel] [PATCH kernel-meta] efiboot/autorm functions: ignore running kernel if it was removed

2019-11-07 Thread Thomas Lamprecht
In the case were someone removes the current kernel we do not can "keep" it anymore. While this was obviously no issue for the autoremoval logic, it is an issue for the pve-efiboot-tool refresh command, which reuses this helper to see which kernels it needs to keep on the ESP. Without this a runni

Re: [pve-devel] [PATCH manager 1/4] ceph: add perf data cache helpers

2019-11-07 Thread Thomas Lamprecht
On 11/7/19 8:49 AM, Dominik Csapak wrote: >>> yes librados and ceph config is available, but that does not mean the >>> cluster is designed so that all nodes can reach the monitor nodes... >>> e.g.: >>> >>> 5 nodes with node0-node2 ceph nodes, node3 a 'compute' node, and >>> node4 is a node in the