Re: [pve-devel] [PATCH manager 1/4] ceph: add perf data cache helpers

2019-11-06 Thread Dominik Csapak
On 11/6/19 3:49 PM, Thomas Lamprecht wrote: On 11/6/19 8:36 AM, Dominik Csapak wrote: On 11/5/19 6:33 PM, Thomas Lamprecht wrote: On 11/5/19 1:51 PM, Dominik Csapak wrote: +my $entry = { +time => $time, +ops_r => $pgmap->{read_op_per_sec}, +ops_w => $pgmap->{write_op_per_sec},

Re: [pve-devel] [PATCH manager 1/4] ceph: add perf data cache helpers

2019-11-06 Thread Thomas Lamprecht
On 11/6/19 4:10 PM, Dominik Csapak wrote: > On 11/6/19 3:49 PM, Thomas Lamprecht wrote: >> On 11/6/19 8:36 AM, Dominik Csapak wrote: >>> On 11/5/19 6:33 PM, Thomas Lamprecht wrote: On 11/5/19 1:51 PM, Dominik Csapak wrote: > + > +    my $data = encode_json($perf_cache); > +    PVE:

[pve-devel] applied: [PATCH container] fix #2453: actually write random MAC addresses in config

2019-11-06 Thread Thomas Lamprecht
On 11/6/19 3:58 PM, Oguz Bektas wrote: > apparently this was a regression introduced with the pending changes series. > when creating/changing the network interface of a container, we need to use > $print_lxc_network in order to have the correct property string in the config > file. > > Signed-off

[pve-devel] applied-series: [PATCH docs v2 00/10] pveceph: update doc

2019-11-06 Thread Thomas Lamprecht
On 11/6/19 3:09 PM, Alwin Antreich wrote: > In patch 10 I have added an attribute to asciidoc-pve.conf to replace > Ceph's codename. I hope this is the right location for this. applied series, but dropped all screenshots. They were not made with our selenium/remote driver based end-to-end+screensh

[pve-devel] applied: [PATCH manager] ui: fix backup "Run now" with specific node selected

2019-11-06 Thread Thomas Lamprecht
On 11/4/19 3:51 PM, Stefan Reiter wrote: > Previous behaviour was bugged and displayed "Node is offline" for all > non-selected nodes (only 1 can be selected at a time). > > Also fix progress window to show correct number of nodes in backup job. > > Signed-off-by: Stefan Reiter > --- > > I cann

[pve-devel] applied: [PATCH pve-access-control] ldap auth: add sslversion option

2019-11-06 Thread Thomas Lamprecht
On 11/4/19 10:18 AM, Alexandre Derumier wrote: > default to tls1.2 > While https://metacpan.org/pod/distribution/perl-ldap/lib/Net/LDAP.pod#sslversion ony lists ['sslv2' | 'sslv3' | 'sslv23' | 'tlsv1' | 'tlsv1_1' | 'tlsv1_2'] it says that this is just passed to IO::Socket::SSL and https://metac

Re: [pve-devel] first 20 nodes cluster upgraded to proxmox6 :)

2019-11-06 Thread Thomas Lamprecht
Hi, On 11/6/19 10:08 AM, Alexandre DERUMIER wrote: > Hi, > > I have finished to upgraded my first 20 nodes cluster to proxmox6. > > So far, it's stable, no corosync bug. qemu is working fine too. > great to hear! > > I just have ldaps auth not working, I have send a patch to the mailing this

Re: [pve-devel] [PATCH v2 docs] Add section for ZFS Special Device

2019-11-06 Thread Thomas Lamprecht
On 11/6/19 10:46 AM, Fabian Ebner wrote: > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * Reworded the part that describes when a special device is useful > * Moved that part to the top, so people know right away whether it's > interesting for them > * Add note about

[pve-devel] applied-series: [PATCH lxc 1/2] postinst: ignore lxc.service reload errors

2019-11-06 Thread Thomas Lamprecht
On 11/6/19 11:08 AM, Fabian Grünbichler wrote: > otherwise this could fail posinst execution (and thus package > installation!) on systems coming from plain Debian, or where lxc.service > is masked. > > Signed-off-by: Fabian Grünbichler > --- > applied both patches, thanks! __

[pve-devel] applied: [PATCH v2 docs] qm: spice foldersharing: Add experimental warning

2019-11-06 Thread Thomas Lamprecht
On 11/6/19 4:02 PM, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > > v1 -> v2: added Currently > qm.adoc | 2 ++ > 1 file changed, 2 insertions(+) > applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com https://pve.pro

Re: [pve-devel] [PATCH storage] fix #2085: Handle non-default mount point in path() by introducing new mountpoint property

2019-11-06 Thread Thomas Lamprecht
On 11/6/19 1:46 PM, Fabian Ebner wrote: > A new mountpoint property is added to the schema for ZFSPool storages. > When needed for the first time, the current mount point is determined and > written to the storage config. > > Signed-off-by: Fabian Ebner > --- > PVE/Storage/ZFSPoolPlugin.pm | 25

Re: [pve-devel] [PATCH manager] add graphite tcp support

2019-11-06 Thread Thomas Lamprecht
On 11/5/19 10:34 PM, Martin Verges wrote: > This change allows sending statistics to graphite over TCP. > > So far only UDP is possible, which is not available in some environments, > like behind a loadbalancer. > > Configuration example: > ~ $ cat /etc/pve/status.cfg > > graphite: > server

Re: [pve-devel] [PATCH manager] add graphite tcp support

2019-11-06 Thread Thomas Lamprecht
On 11/5/19 10:34 PM, Martin Verges wrote: > This change allows sending statistics to graphite over TCP. > > So far only UDP is possible, which is not available in some environments, > like behind a loadbalancer. > > Configuration example: > ~ $ cat /etc/pve/status.cfg > > graphite: > server

[pve-devel] [PATCH manager] status/graphite: catch socket send errors

2019-11-06 Thread Thomas Lamprecht
Signed-off-by: Thomas Lamprecht --- the catch: not really tested ^^ PVE/Status/Graphite.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Status/Graphite.pm b/PVE/Status/Graphite.pm index f43a49a7..b948526c 100644 --- a/PVE/Status/Graphite.pm +++ b/PVE/Status/Graphite.p

[pve-devel] applied-series: [PATCH manager 1/5] gui: qemu/HardwareView: use builtin reload function

2019-11-06 Thread Thomas Lamprecht
On 10/31/19 9:33 AM, Dominik Csapak wrote: > ObjectGrid (an ancestor of PendingObjectGrid) does already have > a 'reload' function which does exactly the same, so get rid > of the local one here > > Signed-off-by: Dominik Csapak > --- > www/manager6/qemu/HardwareView.js | 36

[pve-devel] [PATCH] fix #2456 setting bind-mount through API/CLI is broken

2019-11-06 Thread Wolfgang Link
Content-type check is only valid for mp from type 'volume'. The Content-type check is correct for rootfs and mount points. --- src/PVE/LXC/Config.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 7e51b8d..39de691 100644 --- a

Re: [pve-devel] [PATCH manager] add graphite tcp support

2019-11-06 Thread Martin Verges
Hello, yes 1 second should be ok as well and it can be configured. Maybe if pvestatd has problems with blocking, an upper limit would be good as well to prevent misconfiguration. I agree that we don't read from that socket, therefore "$carbon_socket->read_timeout($timeout);" should not be require

Re: [pve-devel] [PATCH manager] add graphite tcp support

2019-11-06 Thread Thomas Lamprecht
Hi, On 11/7/19 8:08 AM, Martin Verges wrote: > I agree that we don't read from that socket, therefore > "$carbon_socket->read_timeout($timeout);" should not be required. However, > I don't know how perl works internally and therefore I think it won't hurt > to set read and write to prevent any blo

Re: [pve-devel] [PATCH manager 1/4] ceph: add perf data cache helpers

2019-11-06 Thread Dominik Csapak
i only partially quoted, since most is already clear yes librados and ceph config is available, but that does not mean the cluster is designed so that all nodes can reach the monitor nodes... e.g.: 5 nodes with node0-node2 ceph nodes, node3 a 'compute' node, and node4 is a node in the same clu

<    1   2